Re: [PATCH v4 4/6] ACPI / fan: Properly handle fine grain control

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2764 bytes --]

Hi Srinivas,

I love your patch! Yet something to improve:

[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on linus/master v5.17-rc3 next-20220211]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Srinivas-Pandruvada/ACPI-fan-Add-fine-grain-control/20220212-001118
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: i386-randconfig-a003 (https://download.01.org/0day-ci/archive/20220212/202202120622.lPBqcxi6-lkp(a)intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce (this is a W=1 build):
        # https://github.com/0day-ci/linux/commit/367e082b5f2d1c640b906682cffcb7195e722f26
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Srinivas-Pandruvada/ACPI-fan-Add-fine-grain-control/20220212-001118
        git checkout 367e082b5f2d1c640b906682cffcb7195e722f26
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   ld: drivers/acpi/fan_core.o: in function `fan_get_state_acpi4':
>> drivers/acpi/fan_core.c:126: undefined reference to `__udivdi3'


vim +126 drivers/acpi/fan_core.c

   108	
   109	static int fan_get_state_acpi4(struct acpi_device *device, unsigned long *state)
   110	{
   111		struct acpi_fan *fan = acpi_driver_data(device);
   112		struct acpi_fan_fst fst;
   113		int status, i;
   114	
   115		status = acpi_fan_get_fst(device, &fst);
   116		if (status)
   117			return status;
   118	
   119		if (fan->fif.fine_grain_ctrl) {
   120			/* This control should be same what we set using _FSL by spec */
   121			if (fst.control > 100) {
   122				dev_dbg(&device->dev, "Invalid control value returned\n");
   123				goto match_fps;
   124			}
   125	
 > 126			*state = fst.control / fan->fif.step_size;
   127			return 0;
   128		}
   129	
   130	match_fps:
   131		for (i = 0; i < fan->fps_count; i++) {
   132			if (fst.control == fan->fps[i].control)
   133				break;
   134		}
   135		if (i == fan->fps_count) {
   136			dev_dbg(&device->dev, "Invalid control value returned\n");
   137			return -EINVAL;
   138		}
   139	
   140		*state = i;
   141	
   142		return status;
   143	}
   144	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org