Re: [PATCH v4 2/2] efi_loader: Reset system after CapsuleUpdate on disk

[AKASHI Takahiro <takahiro.akashi@linaro.org>]

On Sun, Feb 13, 2022 at 11:17:37AM +0100, Heinrich Schuchardt wrote:
> On 2/13/22 10:01, Heinrich Schuchardt wrote:
> > On 2/3/22 10:23, Masami Hiramatsu wrote:
> > > Add a cold reset soon after processing capsule update on disk.
> > > This is required in UEFI specification 2.9 Section 8.5.5
> > > "Delivery of Capsules via file on Mass Storage device" as;
> > > 
> > >      In all cases that a capsule is identified for processing the
> > > system is
> > >      restarted after capsule processing is completed.
> > > 
> > > This also reports the result of each capsule update so that the user can
> > > notice that the capsule update has been succeeded or not from console
> > > log.
> > > 
> > > Signed-off-by: Masami Hiramatsu <masami.hiramatsu@linaro.org>
> > 
> > Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> 
> 
> Gitlab CI tests fail. Please, resubmit with the Python tests adjusted.
> Make sure that 'make tests' does not fail.
> 
> https://source.denx.de/u-boot/custodians/u-boot-efi/-/jobs/392345
> 
> FAILED
> test/py/tests/test_efi_capsule/test_capsule_firmware.py::TestEfiCapsuleFirmwareFit::test_efi_capsule_fw2
> FAILED
> test/py/tests/test_efi_capsule/test_capsule_firmware.py::TestEfiCapsuleFirmwareFit::test_efi_capsule_fw3
> FAILED
> test/py/tests/test_efi_capsule/test_capsule_firmware.py::TestEfiCapsuleFirmwareFit::test_efi_capsule_fw4

I should have mentioned this in my previous comment.

My capsule tests assume that the capsule update does *not* initiate
a reboot automatically and does "reboot" by "env print -e Capsule0000".

Furthermore, since the current sandbox_defconfig does not enable any
U-Boot environment storage, "dfu_alt_info," for instance, cannot
retain across the reboot (and so I didn't use CAPSULE_ON_DISK_EARLY).

I will help Masami fix the issue.

-Takahiro Akashi





> Best regards
> 
> Heinrich
> 
> 
> Best regards
> 
> Heinrich