From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94267C433EF for ; Mon, 14 Feb 2022 01:50:21 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 4AFC483B71; Mon, 14 Feb 2022 02:50:19 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="iYp80Vt/"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 637C783A5D; Mon, 14 Feb 2022 02:50:18 +0100 (CET) Received: from mail-pf1-x434.google.com (mail-pf1-x434.google.com [IPv6:2607:f8b0:4864:20::434]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4817D83B88 for ; Mon, 14 Feb 2022 02:50:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=takahiro.akashi@linaro.org Received: by mail-pf1-x434.google.com with SMTP id t36so15831545pfg.0 for ; Sun, 13 Feb 2022 17:50:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=ZDMrFMJZEXjScPtqyinS3tYw2J5OFnl9m+gfVpk2htQ=; b=iYp80Vt/mz/pz/ZsYzRWmIT1rNG+KK7wAZynAzrjYnYbcZ2ChpwmC81wiKCmZmKoIn nsVdG7NR0Sv2ixkw6GBu02XF44KP0bEsE78WAj2/N00scvde61Pd2kEWu9GXOSaUVz+U e0E7QV+aKil2n2xJblXtEqQUYWaAcg4XWvqRY6jgjTu9NyQ4DQS5C7Vr35gnyfLkVh3Y k02Qg3H9iXtK45zVE42q+D1dKtkqY6e71BOHehrgn9ldWOY0Jg7BVXoUi04fStErCjtf ziqvxypHYMflnd19F8Txobf8DbN7A39ldn7HqZT9aCf4so6lYHDD7moQjhHIAGT3yH6D uTLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=ZDMrFMJZEXjScPtqyinS3tYw2J5OFnl9m+gfVpk2htQ=; b=noiWPHQz7x39UKIy2773F7d3tAcuxc51FfxxmS6KnLxTbfn2NDkUIc5cAZZ3JZvIWH N59Rb8DEqBJprNgt4waAfKHFFhXGYc5gJen3WwSyLjGDcXnPziL4OkjDiM5THocRgwWB RM3iBWiJesjxAT9o1smk7GpeSAnWb5qhNS2pXI1xVN74oqdjygWtuI1IJt3Bf+JzNHeX ZxhUtR3Z7g4hyktHpviX2wrFLuOSNfWcnuwdO29+CAncUVu1k43FW6vmY4M0Lbn/j13m nj5Fxd1iWleiLtoS9jJ3UUAdBvbjjUztzHrRlCvtHxhAXWB5jow79/T+K86E6mV8wrsA MAHA== X-Gm-Message-State: AOAM5311Wix0UjVkrk0lwlQHeV4SGEkKLJOeYBitIivryH4a7MRqNYUM uQz8LYyNegGbkOU5YqY4qXsZng== X-Google-Smtp-Source: ABdhPJyN1QMVKtMBbxSlsRFmbpQVDKOLaKga1L1UGU0NlXdM08qsoJNSFlgMmg4zWG3dY8vr4vOTZg== X-Received: by 2002:a63:4743:: with SMTP id w3mr9945619pgk.207.1644803412403; Sun, 13 Feb 2022 17:50:12 -0800 (PST) Received: from laputa ([2400:4050:c3e1:100:c11:cd20:ca66:ba1d]) by smtp.gmail.com with ESMTPSA id e8sm17455453pfv.168.2022.02.13.17.50.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 13 Feb 2022 17:50:12 -0800 (PST) Date: Mon, 14 Feb 2022 10:50:08 +0900 From: AKASHI Takahiro To: Ilias Apalodimas Cc: xypron.glpk@gmx.de, u-boot@lists.denx.de Subject: Re: [PATCH 2/2] test/py: efi_secboot: adjust secure boot tests to code changes Message-ID: <20220214015008.GD39639@laputa> Mail-Followup-To: AKASHI Takahiro , Ilias Apalodimas , xypron.glpk@gmx.de, u-boot@lists.denx.de References: <20220211073750.733348-1-ilias.apalodimas@linaro.org> <20220211073750.733348-2-ilias.apalodimas@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220211073750.733348-2-ilias.apalodimas@linaro.org> X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean Ilias, On Fri, Feb 11, 2022 at 09:37:50AM +0200, Ilias Apalodimas wrote: > The previous patch is changing U-Boot's behavior wrt certificate based > binary authentication. Specifically an image who's digest of a > certificate is found in dbx is now rejected. Fix the test accordingly > and add another one testing signatures in reverse order > > Signed-off-by: Ilias Apalodimas > --- > changes since RFC: > - Added another test cases checking signature hashes in reverse order > test/py/tests/test_efi_secboot/test_signed.py | 30 +++++++++++++++++-- > 1 file changed, 28 insertions(+), 2 deletions(-) > > diff --git a/test/py/tests/test_efi_secboot/test_signed.py b/test/py/tests/test_efi_secboot/test_signed.py > index 0aee34479f55..cc9396a11d48 100644 > --- a/test/py/tests/test_efi_secboot/test_signed.py > +++ b/test/py/tests/test_efi_secboot/test_signed.py > @@ -186,7 +186,7 @@ class TestEfiSignedImage(object): > assert 'Hello, world!' in ''.join(output) > > with u_boot_console.log.section('Test Case 5c'): > - # Test Case 5c, not rejected if one of signatures (digest of > + # Test Case 5c, rejected if one of signatures (digest of > # certificate) is revoked > output = u_boot_console.run_command_list([ > 'fatload host 0:1 4000000 dbx_hash.auth', > @@ -195,7 +195,8 @@ class TestEfiSignedImage(object): > output = u_boot_console.run_command_list([ > 'efidebug boot next 1', > 'efidebug test bootmgr']) > - assert 'Hello, world!' in ''.join(output) > + assert '\'HELLO\' failed' in ''.join(output) > + assert 'efi_start_image() returned: 26' in ''.join(output) > > with u_boot_console.log.section('Test Case 5d'): > # Test Case 5d, rejected if both of signatures are revoked > @@ -209,6 +210,31 @@ class TestEfiSignedImage(object): > assert '\'HELLO\' failed' in ''.join(output) > assert 'efi_start_image() returned: 26' in ''.join(output) > > + # Try rejection in reverse order. "Reverse order" of what? > + u_boot_console.restart_uboot() I don't think we need 'restart' here. I added it in each test function (not test case), IIRC, because we didn't have file-based non-volatile variables at that time. > + with u_boot_console.log.section('Test Case 5e'): > + # Test Case 5e, authenticated even if only one of signatures > + # is verified. Same as before but reject dbx_hash1.auth only Please specify what test case "before" means. > + output = u_boot_console.run_command_list([ > + 'host bind 0 %s' % disk_img, > + 'fatload host 0:1 4000000 db.auth', > + 'setenv -e -nv -bs -rt -at -i 4000000:$filesize db', > + 'fatload host 0:1 4000000 KEK.auth', > + 'setenv -e -nv -bs -rt -at -i 4000000:$filesize KEK', > + 'fatload host 0:1 4000000 PK.auth', > + 'setenv -e -nv -bs -rt -at -i 4000000:$filesize PK', > + 'fatload host 0:1 4000000 db1.auth', > + 'setenv -e -nv -bs -rt -at -a -i 4000000:$filesize db', > + 'fatload host 0:1 4000000 dbx_hash1.auth', > + 'setenv -e -nv -bs -rt -at -i 4000000:$filesize dbx']) Now "db" has db.auth and db1.auth in this order and 'dbx" has dbx_hash1.auth. Is this what you intend to test? -Takahiro Akashi > + assert 'Failed to set EFI variable' not in ''.join(output) > + output = u_boot_console.run_command_list([ > + 'efidebug boot add -b 1 HELLO host 0:1 /helloworld.efi.signed_2sigs -s ""', > + 'efidebug boot next 1', > + 'efidebug test bootmgr']) > + assert '\'HELLO\' failed' in ''.join(output) > + assert 'efi_start_image() returned: 26' in ''.join(output) > + > def test_efi_signed_image_auth6(self, u_boot_console, efi_boot_env): > """ > Test Case 6 - using digest of signed image in database > -- > 2.32.0 >