From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
stable@vger.kernel.org,
"Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>,
"Cezary Rojewski" <cezary.rojewski@intel.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
"Sasha Levin" <sashal@kernel.org>
Subject: [PATCH 5.4 22/71] PM: hibernate: Remove register_nosave_region_late()
Date: Mon, 14 Feb 2022 10:25:50 +0100 [thread overview]
Message-ID: <20220214092452.761290303@linuxfoundation.org> (raw)
In-Reply-To: <20220214092452.020713240@linuxfoundation.org>
From: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
[ Upstream commit 33569ef3c754a82010f266b7b938a66a3ccf90a4 ]
It is an unused wrapper forcing kmalloc allocation for registering
nosave regions. Also, rename __register_nosave_region() to
register_nosave_region() now that there is no need for disambiguation.
Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Reviewed-by: Cezary Rojewski <cezary.rojewski@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
include/linux/suspend.h | 11 +----------
kernel/power/snapshot.c | 21 +++++++--------------
2 files changed, 8 insertions(+), 24 deletions(-)
diff --git a/include/linux/suspend.h b/include/linux/suspend.h
index cd97d2c8840cc..44dd49cb2ea05 100644
--- a/include/linux/suspend.h
+++ b/include/linux/suspend.h
@@ -428,15 +428,7 @@ struct platform_hibernation_ops {
#ifdef CONFIG_HIBERNATION
/* kernel/power/snapshot.c */
-extern void __register_nosave_region(unsigned long b, unsigned long e, int km);
-static inline void __init register_nosave_region(unsigned long b, unsigned long e)
-{
- __register_nosave_region(b, e, 0);
-}
-static inline void __init register_nosave_region_late(unsigned long b, unsigned long e)
-{
- __register_nosave_region(b, e, 1);
-}
+extern void register_nosave_region(unsigned long b, unsigned long e);
extern int swsusp_page_is_forbidden(struct page *);
extern void swsusp_set_page_free(struct page *);
extern void swsusp_unset_page_free(struct page *);
@@ -453,7 +445,6 @@ extern struct pbe *restore_pblist;
int pfn_is_nosave(unsigned long pfn);
#else /* CONFIG_HIBERNATION */
static inline void register_nosave_region(unsigned long b, unsigned long e) {}
-static inline void register_nosave_region_late(unsigned long b, unsigned long e) {}
static inline int swsusp_page_is_forbidden(struct page *p) { return 0; }
static inline void swsusp_set_page_free(struct page *p) {}
static inline void swsusp_unset_page_free(struct page *p) {}
diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c
index d65f2d5ab6942..46455aa7951ec 100644
--- a/kernel/power/snapshot.c
+++ b/kernel/power/snapshot.c
@@ -945,8 +945,7 @@ static void memory_bm_recycle(struct memory_bitmap *bm)
* Register a range of page frames the contents of which should not be saved
* during hibernation (to be used in the early initialization code).
*/
-void __init __register_nosave_region(unsigned long start_pfn,
- unsigned long end_pfn, int use_kmalloc)
+void __init register_nosave_region(unsigned long start_pfn, unsigned long end_pfn)
{
struct nosave_region *region;
@@ -962,18 +961,12 @@ void __init __register_nosave_region(unsigned long start_pfn,
goto Report;
}
}
- if (use_kmalloc) {
- /* During init, this shouldn't fail */
- region = kmalloc(sizeof(struct nosave_region), GFP_KERNEL);
- BUG_ON(!region);
- } else {
- /* This allocation cannot fail */
- region = memblock_alloc(sizeof(struct nosave_region),
- SMP_CACHE_BYTES);
- if (!region)
- panic("%s: Failed to allocate %zu bytes\n", __func__,
- sizeof(struct nosave_region));
- }
+ /* This allocation cannot fail */
+ region = memblock_alloc(sizeof(struct nosave_region),
+ SMP_CACHE_BYTES);
+ if (!region)
+ panic("%s: Failed to allocate %zu bytes\n", __func__,
+ sizeof(struct nosave_region));
region->start_pfn = start_pfn;
region->end_pfn = end_pfn;
list_add_tail(®ion->list, &nosave_regions);
--
2.34.1
next prev parent reply other threads:[~2022-02-14 9:41 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 9:25 [PATCH 5.4 00/71] 5.4.180-rc1 review Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 01/71] integrity: check the return value of audit_log_start() Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 02/71] ima: Remove ima_policy file before directory Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 03/71] ima: Allow template selection with ima_template[_fmt]= after ima_hash= Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 04/71] ima: Do not print policy rule with inactive LSM labels Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 05/71] mmc: sdhci-of-esdhc: Check for error num after setting mask Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 06/71] net: phy: marvell: Fix RGMII Tx/Rx delays setting in 88e1121-compatible PHYs Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 07/71] net: phy: marvell: Fix MDI-x polarity setting in 88e1118-compatible PHYs Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 08/71] NFS: Fix initialisation of nfs_client cl_flags field Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 09/71] NFSD: Clamp WRITE offsets Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 10/71] NFSD: Fix offset type in I/O trace points Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 11/71] nvme: Fix parsing of ANA log page Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 12/71] NFSv4 only print the label when its queried Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 13/71] nfs: nfs4clinet: check the return value of kstrdup() Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 14/71] NFSv4.1: Fix uninitialised variable in devicenotify Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 15/71] NFSv4 remove zero number of fs_locations entries error check Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 16/71] NFSv4 expose nfs_parse_server_name function Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 17/71] drm: panel-orientation-quirks: Add quirk for the 1Netbook OneXPlayer Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 18/71] net: sched: Clarify error message when qdisc kind is unknown Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 19/71] scsi: target: iscsi: Make sure the np under each tpg is unique Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 20/71] scsi: qedf: Fix refcount issue when LOGO is received during TMF Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 21/71] scsi: myrs: Fix crash in error case Greg Kroah-Hartman
2022-02-14 9:25 ` Greg Kroah-Hartman [this message]
2022-02-14 9:25 ` [PATCH 5.4 23/71] usb: dwc2: gadget: dont try to disable ep0 in dwc2_hsotg_suspend Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 24/71] net: stmmac: dwmac-sun8i: use return val of readl_poll_timeout() Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 25/71] KVM: nVMX: eVMCS: Filter out VM_EXIT_SAVE_VMX_PREEMPTION_TIMER Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 26/71] bpf: Add kconfig knob for disabling unpriv bpf by default Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 27/71] riscv: fix build with binutils 2.38 Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 28/71] ARM: dts: imx23-evk: Remove MX23_PAD_SSP1_DETECT from hog group Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 29/71] ARM: socfpga: fix missing RESET_CONTROLLER Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 30/71] nvme-tcp: fix bogus request completion when failing to send AER Greg Kroah-Hartman
2022-02-14 9:25 ` [PATCH 5.4 31/71] ACPI/IORT: Check node revision for PMCG resources Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 32/71] PM: s2idle: ACPI: Fix wakeup interrupts handling Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 33/71] net: bridge: fix stale eth hdr pointer in br_dev_xmit Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 34/71] perf probe: Fix ppc64 perf probe add events failed case Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 35/71] ARM: dts: meson: Fix the UART compatible strings Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 36/71] staging: fbtft: Fix error path in fbtft_driver_module_init() Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 37/71] ARM: dts: imx6qdl-udoo: Properly describe the SD card detect Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 38/71] usb: f_fs: Fix use-after-free for epfile Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 39/71] misc: fastrpc: avoid double fput() on failed usercopy Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 40/71] ixgbevf: Require large buffers for build_skb on 82599VF Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 41/71] bonding: pair enable_port with slave_arr_updates Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 42/71] ipmr,ip6mr: acquire RTNL before calling ip[6]mr_free_table() on failure path Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 43/71] nfp: flower: fix ida_idx not being released Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 44/71] net: do not keep the dst cache when uncloning an skb dst and its metadata Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 45/71] net: fix a memleak " Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 46/71] veth: fix races around rq->rx_notify_masked Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 47/71] net: mdio: aspeed: Add missing MODULE_DEVICE_TABLE Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 48/71] tipc: rate limit warning for received illegal binding update Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 49/71] net: amd-xgbe: disable interrupts during pci removal Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 50/71] vt_ioctl: fix array_index_nospec in vt_setactivate Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 51/71] vt_ioctl: add array_index_nospec to VT_ACTIVATE Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 52/71] n_tty: wake up poll(POLLRDNORM) on receiving data Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 53/71] eeprom: ee1004: limit i2c reads to I2C_SMBUS_BLOCK_MAX Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 54/71] net: usb: ax88179_178a: Fix out-of-bounds accesses in RX fixup Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 55/71] usb: ulpi: Move of_node_put to ulpi_dev_release Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 56/71] usb: ulpi: Call of_node_put correctly Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 57/71] usb: dwc3: gadget: Prevent core from processing stale TRBs Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 58/71] usb: gadget: udc: renesas_usb3: Fix host to USB_ROLE_NONE transition Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 59/71] USB: gadget: validate interface OS descriptor requests Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 60/71] usb: gadget: rndis: check size of RNDIS_MSG_SET command Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 61/71] usb: gadget: f_uac2: Define specific wTerminalType Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 62/71] USB: serial: ftdi_sio: add support for Brainboxes US-159/235/320 Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 63/71] USB: serial: option: add ZTE MF286D modem Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 64/71] USB: serial: ch341: add support for GW Instek USB2.0-Serial devices Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 65/71] USB: serial: cp210x: add NCR Retail IO box id Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 66/71] USB: serial: cp210x: add CPI Bulk Coin Recycler id Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 67/71] seccomp: Invalidate seccomp mode to catch death failures Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 68/71] hwmon: (dell-smm) Speed up setting of fan speed Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 69/71] scsi: lpfc: Remove NVMe support if kernel has NVME_FC disabled Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 70/71] perf: Fix list corruption in perf_cgroup_switch() Greg Kroah-Hartman
2022-02-14 9:26 ` [PATCH 5.4 71/71] ACPI: PM: s2idle: Cancel wakeup before dispatching EC GPE Greg Kroah-Hartman
2022-02-14 14:22 ` [PATCH 5.4 00/71] 5.4.180-rc1 review Jon Hunter
2022-02-14 20:12 ` Florian Fainelli
2022-02-14 21:29 ` Slade Watkins
2022-02-14 22:26 ` Shuah Khan
2022-02-15 1:51 ` Guenter Roeck
2022-02-15 9:15 ` Naresh Kamboju
2022-02-15 15:40 ` Sudip Mukherjee
2022-02-16 0:51 ` Samuel Zou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220214092452.761290303@linuxfoundation.org \
--to=gregkh@linuxfoundation.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=cezary.rojewski@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.