From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F748C433EF for ; Mon, 14 Feb 2022 14:27:45 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 1294260F1D; Mon, 14 Feb 2022 14:27:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id sTqejJoR1rGE; Mon, 14 Feb 2022 14:27:43 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp3.osuosl.org (Postfix) with ESMTPS id B715360ECE; Mon, 14 Feb 2022 14:27:42 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 732B9C0011; Mon, 14 Feb 2022 14:27:42 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0DA04C000B for ; Mon, 14 Feb 2022 14:27:41 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id E1CA560EEF for ; Mon, 14 Feb 2022 14:27:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 8SSVwfJWhqGo for ; Mon, 14 Feb 2022 14:27:39 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id 14FB660ECE for ; Mon, 14 Feb 2022 14:27:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644848858; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PclHVn4hFaIREct3Ix5qAB8FWulpbaBhmyWRoGDkv4M=; b=LZACA/dwd6gkIZF3BO3Bq0D66XQLAWfoi9Gsp3O0EicenkUEMGDfnfaVVqrpnQ/eOe1gHe Wy93h92nU31peY54Dnu3Cl2yolgGBPzkkag9FvSNHY8M1rdzbyRLXRPlIYqkCpM7JC+G63 o3sYNgGj5FkaBPdwCmsV1An514PAzSk= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-192-MZN57PhENvWL060oWh5kuA-1; Mon, 14 Feb 2022 09:27:35 -0500 X-MC-Unique: MZN57PhENvWL060oWh5kuA-1 Received: by mail-wr1-f70.google.com with SMTP id q21-20020adfab15000000b001e57c9a342aso3335340wrc.6 for ; Mon, 14 Feb 2022 06:27:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=PclHVn4hFaIREct3Ix5qAB8FWulpbaBhmyWRoGDkv4M=; b=5VVxLIo5wVysf5jFQR5eNbPIqC2kqubooGoLItq1gy6jaT7AeaDMY7uQ9H7RmOrpb+ t9oo4uf6tan7HYvEt2Ujg4cb38CCi+eKlr91n1D/mYRveLmP3AQy6V3aJmavE4Nv71K/ 68cLwxBKKyG6dmPjMKU2I9dJ3YMKBRbdQTcUjQq/RSaclbt6s67n3HWu9HN1DLkLf7Zr Cu/gToSVm4AVpuV+d0aQMzeW4GUlnhhAz6Q2+GFfzJ1eNzKI+GqF99pXwkS+XWZv1jCR D8cVJ90PqRwDVEri9OMO3nZDo7VrYP4SnFJf8AVwMNFeYC1kwYg25E9y57nngnGT4LWE hm8w== X-Gm-Message-State: AOAM532va/R3Sb1KM5QNgcAqzI52TLPFNjyMUsRbSu5lxmq/owCHUaWU Pe6fBfAdxntxcKuT14zqHfO5nGGZGrWH+Iz3CY8R76PBKM2Lk2IVf/IVpFgiekI5aBXmJLSt/4U QIxEI+sdI5T63+Q6ygmFSqp1ah72d8F/hRpgDIwiuGg== X-Received: by 2002:a05:6000:85:: with SMTP id m5mr11706320wrx.75.1644848854495; Mon, 14 Feb 2022 06:27:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJw7RUa44P2HY0Ef9H21Qu743c1fDXi9Y4u9KKARtPAKyb8tGnmZK8UZoQAqeDcYInaYml4J3w== X-Received: by 2002:a05:6000:85:: with SMTP id m5mr11706299wrx.75.1644848854175; Mon, 14 Feb 2022 06:27:34 -0800 (PST) Received: from redhat.com ([2.55.156.76]) by smtp.gmail.com with ESMTPSA id g5sm12014178wmk.38.2022.02.14.06.27.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Feb 2022 06:27:33 -0800 (PST) Date: Mon, 14 Feb 2022 09:27:30 -0500 From: "Michael S. Tsirkin" To: Zhu Lingshan Subject: Re: [PATCH V4 4/4] vDPA/ifcvf: implement shared IRQ feature Message-ID: <20220214092558-mutt-send-email-mst@kernel.org> References: <20220203072735.189716-1-lingshan.zhu@intel.com> <20220203072735.189716-5-lingshan.zhu@intel.com> <449aa3a3-06c8-1236-241e-42ea5b7d8877@linux.intel.com> MIME-Version: 1.0 In-Reply-To: <449aa3a3-06c8-1236-241e-42ea5b7d8877@linux.intel.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: netdev@vger.kernel.org, Zhu Lingshan , virtualization@lists.linux-foundation.org X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gTW9uLCBGZWIgMTQsIDIwMjIgYXQgMDY6MDE6NTZQTSArMDgwMCwgWmh1IExpbmdzaGFuIHdy b3RlOgo+IAo+IAo+IE9uIDIvMTQvMjAyMiAzOjE5IFBNLCBKYXNvbiBXYW5nIHdyb3RlOgo+ID4g Cj4gPiDlnKggMjAyMi8yLzMg5LiL5Y2IMzoyNywgWmh1IExpbmdzaGFuIOWGmemBkzoKPiA+ID4g T24gc29tZSBwbGF0Zm9ybXMvZGV2aWNlcywgdGhlcmUgbWF5IG5vdCBiZSBlbm91Z2ggTVNJIHZl Y3Rvcgo+ID4gPiBzbG90cyBhbGxvY2F0ZWQgZm9yIHZpcnRxdWV1ZXMgYW5kIGNvbmZpZyBjaGFu Z2VzLiBJbiBzdWNoIGEgY2FzZSwKPiA+ID4gdGhlIGludGVycnVwdCBzb3VyY2VzKHZpcnRxdWV1 ZXMsIGNvbmZpZyBjaGFuZ2VzKSBtdXN0IHNoYXJlCj4gPiA+IGFuIElSUS92ZWN0b3IsIHRvIGF2 b2lkIGluaXRpYWxpemF0aW9uIGZhaWx1cmVzLCBrZWVwCj4gPiA+IHRoZSBkZXZpY2UgZnVuY3Rp b25hbC4KPiA+ID4gCj4gPiA+IFRoaXMgY29tbWl0IGhhbmRsZXMgdGhyZWUgY2FzZXM6Cj4gPiA+ ICgxKSBudW1iZXIgb2YgdGhlIGFsbG9jYXRlZCB2ZWN0b3JzID09IHRoZSBudW1iZXIgb2Ygdmly dHF1ZXVlcyArIDEKPiA+ID4gKGNvbmZpZyBjaGFuZ2VzKSwgZXZlcnkgdmlydHF1ZXVlIGFuZCB0 aGUgY29uZmlnIGludGVycnVwdCBoYXMKPiA+ID4gYSBzZXBhcmF0ZWQgdmVjdG9yL0lSUSwgdGhl IGJlc3QgYW5kIHRoZSBtb3N0IGxpa2VseSBjYXNlLgo+ID4gPiAoMikgbnVtYmVyIG9mIHRoZSBh bGxvY2F0ZWQgdmVjdG9ycyBpcyBsZXNzIHRoYW4gdGhlIGJlc3QgY2FzZSwgYnV0Cj4gPiA+IGdy ZWF0ZXIgdGhhbiAxLiBJbiB0aGlzIGNhc2UsIGFsbCB2aXJ0cXVldWVzIHNoYXJlIGEgdmVjdG9y L0lSUSwKPiA+ID4gdGhlIGNvbmZpZyBpbnRlcnJ1cHQgaGFzIGEgc2VwYXJhdGVkIHZlY3Rvci9J UlEKPiA+ID4gKDMpIG9ubHkgb25lIHZlY3RvciBpcyBhbGxvY2F0ZWQsIGluIHRoaXMgY2FzZSwg dGhlIHZpcnRxdWV1ZXMgYW5kCj4gPiA+IHRoZSBjb25maWcgaW50ZXJydXB0IHNoYXJlIGEgdmVj dG9yL0lSUS4gVGhlIHdvcnN0IGFuZCBtb3N0Cj4gPiA+IHVubGlrZWx5IGNhc2UuCj4gPiA+IAo+ ID4gPiBPdGhlcndpc2UsIGl0IG5lZWRzIHRvIGZhaWwuCj4gPiA+IAo+ID4gPiBUaGlzIGNvbW1p dCBpbnRyb2R1Y2VzIHNvbWUgaGVscGVyIGZ1bmN0aW9uczoKPiA+ID4gaWZjdmZfc2V0X3ZxX3Zl Y3RvcigpIGFuZCBpZmN2Zl9zZXRfY29uZmlnX3ZlY3RvcigpIHNldHMgdmlydHF1ZXVlCj4gPiA+ IHZlY3RvciBhbmQgY29uZmlnIHZlY3RvciBpbiB0aGUgZGV2aWNlIGNvbmZpZyBzcGFjZSwgc28g dGhhdAo+ID4gPiB0aGUgZGV2aWNlIGNhbiBzZW5kIGludGVycnVwdCBETUEuCj4gPiA+IAo+ID4g PiBUaGlzIGNvbW1pdCBhZGRzIHNvbWUgZmllbGRzIGluIHN0cnVjdCBpZmN2Zl9odyBhbmQgcmUt cGxhY2VkCj4gPiA+IHRoZSBleGlzdGVkIGZpZWxkcyB0byBiZSBhbGlnbmVkIHdpdGggdGhlIGNh Y2hlbGluZS4KPiA+ID4gCj4gPiA+IFNpZ25lZC1vZmYtYnk6IFpodSBMaW5nc2hhbiA8bGluZ3No YW4uemh1QGludGVsLmNvbT4KPiA+ID4gLS0tCj4gPiA+IMKgIGRyaXZlcnMvdmRwYS9pZmN2Zi9p ZmN2Zl9iYXNlLmMgfMKgIDQ3ICsrKystLQo+ID4gPiDCoCBkcml2ZXJzL3ZkcGEvaWZjdmYvaWZj dmZfYmFzZS5oIHzCoCAyMyArKy0KPiA+ID4gwqAgZHJpdmVycy92ZHBhL2lmY3ZmL2lmY3ZmX21h aW4uYyB8IDI0MyArKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLQo+ID4gPiDCoCAzIGZp bGVzIGNoYW5nZWQsIDI1NiBpbnNlcnRpb25zKCspLCA1NyBkZWxldGlvbnMoLSkKPiA+ID4gCj4g PiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3ZkcGEvaWZjdmYvaWZjdmZfYmFzZS5jCj4gPiA+IGIv ZHJpdmVycy92ZHBhL2lmY3ZmL2lmY3ZmX2Jhc2UuYwo+ID4gPiBpbmRleCAzOTc2OTJhZTY3MWMu LjE4ZGNiNjNhYjFlMyAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy92ZHBhL2lmY3ZmL2lmY3Zm X2Jhc2UuYwo+ID4gPiArKysgYi9kcml2ZXJzL3ZkcGEvaWZjdmYvaWZjdmZfYmFzZS5jCj4gPiA+ IEBAIC0xNSw2ICsxNSwzNiBAQCBzdHJ1Y3QgaWZjdmZfYWRhcHRlciAqdmZfdG9fYWRhcHRlcihz dHJ1Y3QKPiA+ID4gaWZjdmZfaHcgKmh3KQo+ID4gPiDCoMKgwqDCoMKgIHJldHVybiBjb250YWlu ZXJfb2YoaHcsIHN0cnVjdCBpZmN2Zl9hZGFwdGVyLCB2Zik7Cj4gPiA+IMKgIH0KPiA+ID4gwqAg K2ludCBpZmN2Zl9zZXRfdnFfdmVjdG9yKHN0cnVjdCBpZmN2Zl9odyAqaHcsIHUxNiBxaWQsIGlu dCB2ZWN0b3IpCj4gPiA+ICt7Cj4gPiA+ICvCoMKgwqAgc3RydWN0IHZpcnRpb19wY2lfY29tbW9u X2NmZyBfX2lvbWVtICpjZmcgPSBody0+Y29tbW9uX2NmZzsKPiA+ID4gK8KgwqDCoCBzdHJ1Y3Qg aWZjdmZfYWRhcHRlciAqaWZjdmYgPSB2Zl90b19hZGFwdGVyKGh3KTsKPiA+ID4gKwo+ID4gPiAr wqDCoMKgIGlmY19pb3dyaXRlMTYocWlkLCAmY2ZnLT5xdWV1ZV9zZWxlY3QpOwo+ID4gPiArwqDC oMKgIGlmY19pb3dyaXRlMTYodmVjdG9yLCAmY2ZnLT5xdWV1ZV9tc2l4X3ZlY3Rvcik7Cj4gPiA+ ICvCoMKgwqAgaWYgKGlmY19pb3JlYWQxNigmY2ZnLT5xdWV1ZV9tc2l4X3ZlY3RvcikgPT0KPiA+ ID4gVklSVElPX01TSV9OT19WRUNUT1IpIHsKPiA+ID4gK8KgwqDCoMKgwqDCoMKgIElGQ1ZGX0VS UihpZmN2Zi0+cGRldiwgIk5vIG1zaXggdmVjdG9yIGZvciBxdWV1ZSAldVxuIiwgcWlkKTsKPiA+ ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgcmV0dXJuIC1FSU5WQUw7Cj4gPiA+ICvCoMKgwqAg fQo+ID4gCj4gPiAKPiA+IExldCdzIGxlYXZlIHRoaXMgY2hlY2sgZm9yIHRoZSBjYWxsZXIsIEUu ZyBjYW4gY2FsbGVyIHRyeSB0byBhc3NpZ24KPiA+IE5PX1ZFQ1RPUiBkdXJpbmcgdW5pLW5pdD8K PiBpZmN2ZiBkcml2ZXIgc2V0cyBOT19WRUNUT1Igd2hlbiBjYWxsIGh3X2Rpc2FibGUoKS4gSSBh bSBub3Qgc3VyZSB3aGV0aGVyIEkKPiBnZXQgaXQsCj4gWWVzIHdlIGNhbiBsZXQgdGhlIGNhbGxl ciBjaGVjayBhIHZxIHZlY3RvciwgaG93ZXZlciB0aGlzIG1heSBjYXVzZSBtb3JlCj4gdGhhbiB0 aHJlZSBsZXZlbHMgYnJhY2tldHMsIG1heSBsb29rcyB1Z2x5Lgo+ID4gCj4gPiAKPiA+ID4gKwo+ ID4gPiArwqDCoMKgIHJldHVybiAwOwo+ID4gPiArfQo+ID4gPiArCj4gPiA+ICtpbnQgaWZjdmZf c2V0X2NvbmZpZ192ZWN0b3Ioc3RydWN0IGlmY3ZmX2h3ICpodywgaW50IHZlY3RvcikKPiA+ID4g K3sKPiA+ID4gK8KgwqDCoCBzdHJ1Y3QgdmlydGlvX3BjaV9jb21tb25fY2ZnIF9faW9tZW0gKmNm ZyA9IGh3LT5jb21tb25fY2ZnOwo+ID4gPiArwqDCoMKgIHN0cnVjdCBpZmN2Zl9hZGFwdGVyICpp ZmN2ZiA9IHZmX3RvX2FkYXB0ZXIoaHcpOwo+ID4gPiArCj4gPiA+ICvCoMKgwqAgY2ZnID0gaHct PmNvbW1vbl9jZmc7Cj4gPiA+ICvCoMKgwqAgaWZjX2lvd3JpdGUxNih2ZWN0b3IswqAgJmNmZy0+ bXNpeF9jb25maWcpOwo+ID4gPiArwqDCoMKgIGlmIChpZmNfaW9yZWFkMTYoJmNmZy0+bXNpeF9j b25maWcpID09IFZJUlRJT19NU0lfTk9fVkVDVE9SKSB7Cj4gPiA+ICvCoMKgwqDCoMKgwqDCoCBJ RkNWRl9FUlIoaWZjdmYtPnBkZXYsICJObyBtc2l4IHZlY3RvciBmb3IgZGV2aWNlIGNvbmZpZ1xu Iik7Cj4gPiA+ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4gLUVJTlZBTDsKPiA+ID4gK8KgwqDCoCB9 Cj4gPiAKPiA+IAo+ID4gU2ltaWxhciBxdWVzdGlvbiBhcyBhYm92ZS4KPiA+IAo+ID4gCj4gPiA+ ICsKPiA+ID4gK8KgwqDCoCByZXR1cm4gMDsKPiA+ID4gK30KPiA+ID4gKwo+ID4gPiDCoCBzdGF0 aWMgdm9pZCBfX2lvbWVtICpnZXRfY2FwX2FkZHIoc3RydWN0IGlmY3ZmX2h3ICpodywKPiA+ID4g wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgc3RydWN0IHZpcnRpb19wY2lf Y2FwICpjYXApCj4gPiA+IMKgIHsKPiA+ID4gQEAgLTE0MCw2ICsxNzAsOCBAQCBpbnQgaWZjdmZf aW5pdF9odyhzdHJ1Y3QgaWZjdmZfaHcgKmh3LCBzdHJ1Y3QKPiA+ID4gcGNpX2RldiAqcGRldikK PiA+ID4gwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBody0+Y29tbW9uX2NmZywgaHctPm5vdGlmeV9i YXNlLCBody0+aXNyLAo+ID4gPiDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGh3LT5kZXZfY2ZnLCBo dy0+bm90aWZ5X29mZl9tdWx0aXBsaWVyKTsKPiA+ID4gwqAgK8KgwqDCoCBody0+dnFzX3NoYXJl ZF9pcnEgPSAtRUlOVkFMOwo+ID4gPiArCj4gPiA+IMKgwqDCoMKgwqAgcmV0dXJuIDA7Cj4gPiA+ IMKgIH0KPiA+ID4gwqAgQEAgLTMyMSwxMiArMzUzLDYgQEAgc3RhdGljIGludCBpZmN2Zl9od19l bmFibGUoc3RydWN0IGlmY3ZmX2h3ICpodykKPiA+ID4gwqAgwqDCoMKgwqDCoCBpZmN2ZiA9IHZm X3RvX2FkYXB0ZXIoaHcpOwo+ID4gPiDCoMKgwqDCoMKgIGNmZyA9IGh3LT5jb21tb25fY2ZnOwo+ ID4gPiAtwqDCoMKgIGlmY19pb3dyaXRlMTYoSUZDVkZfTVNJX0NPTkZJR19PRkYsICZjZmctPm1z aXhfY29uZmlnKTsKPiA+ID4gLQo+ID4gPiAtwqDCoMKgIGlmIChpZmNfaW9yZWFkMTYoJmNmZy0+ bXNpeF9jb25maWcpID09IFZJUlRJT19NU0lfTk9fVkVDVE9SKSB7Cj4gPiA+IC3CoMKgwqDCoMKg wqDCoCBJRkNWRl9FUlIoaWZjdmYtPnBkZXYsICJObyBtc2l4IHZlY3RvciBmb3IgZGV2aWNlIGNv bmZpZ1xuIik7Cj4gPiA+IC3CoMKgwqDCoMKgwqDCoCByZXR1cm4gLUVJTlZBTDsKPiA+ID4gLcKg wqDCoCB9Cj4gPiA+IMKgIMKgwqDCoMKgwqAgZm9yIChpID0gMDsgaSA8IGh3LT5ucl92cmluZzsg aSsrKSB7Cj4gPiA+IMKgwqDCoMKgwqDCoMKgwqDCoCBpZiAoIWh3LT52cmluZ1tpXS5yZWFkeSkK PiA+ID4gQEAgLTM0MCwxNSArMzY2LDYgQEAgc3RhdGljIGludCBpZmN2Zl9od19lbmFibGUoc3Ry dWN0IGlmY3ZmX2h3ICpodykKPiA+ID4gwqDCoMKgwqDCoMKgwqDCoMKgIGlmY19pb3dyaXRlNjRf dHdvcGFydChody0+dnJpbmdbaV0udXNlZCwgJmNmZy0+cXVldWVfdXNlZF9sbywKPiA+ID4gwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgJmNmZy0+cXVldWVfdXNl ZF9oaSk7Cj4gPiA+IMKgwqDCoMKgwqDCoMKgwqDCoCBpZmNfaW93cml0ZTE2KGh3LT52cmluZ1tp XS5zaXplLCAmY2ZnLT5xdWV1ZV9zaXplKTsKPiA+ID4gLcKgwqDCoMKgwqDCoMKgIGlmY19pb3dy aXRlMTYoaSArIElGQ1ZGX01TSV9RVUVVRV9PRkYsCj4gPiA+ICZjZmctPnF1ZXVlX21zaXhfdmVj dG9yKTsKPiA+ID4gLQo+ID4gPiAtwqDCoMKgwqDCoMKgwqAgaWYgKGlmY19pb3JlYWQxNigmY2Zn LT5xdWV1ZV9tc2l4X3ZlY3RvcikgPT0KPiA+ID4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgVklS VElPX01TSV9OT19WRUNUT1IpIHsKPiA+ID4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgSUZDVkZf RVJSKGlmY3ZmLT5wZGV2LAo+ID4gPiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oCAiTm8gbXNpeCB2ZWN0b3IgZm9yIHF1ZXVlICV1XG4iLCBpKTsKPiA+ID4gLcKgwqDCoMKgwqDC oMKgwqDCoMKgwqAgcmV0dXJuIC1FSU5WQUw7Cj4gPiA+IC3CoMKgwqDCoMKgwqDCoCB9Cj4gPiA+ IC0KPiA+ID4gwqDCoMKgwqDCoMKgwqDCoMKgIGlmY3ZmX3NldF92cV9zdGF0ZShodywgaSwgaHct PnZyaW5nW2ldLmxhc3RfYXZhaWxfaWR4KTsKPiA+ID4gwqDCoMKgwqDCoMKgwqDCoMKgIGlmY19p b3dyaXRlMTYoMSwgJmNmZy0+cXVldWVfZW5hYmxlKTsKPiA+ID4gwqDCoMKgwqDCoCB9Cj4gPiA+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL3ZkcGEvaWZjdmYvaWZjdmZfYmFzZS5oCj4gPiA+IGIvZHJp dmVycy92ZHBhL2lmY3ZmL2lmY3ZmX2Jhc2UuaAo+ID4gPiBpbmRleCA5NDliNGZiOWQ1NTQuLjlj ZmUwODhjODJlOSAxMDA2NDQKPiA+ID4gLS0tIGEvZHJpdmVycy92ZHBhL2lmY3ZmL2lmY3ZmX2Jh c2UuaAo+ID4gPiArKysgYi9kcml2ZXJzL3ZkcGEvaWZjdmYvaWZjdmZfYmFzZS5oCj4gPiA+IEBA IC0yNyw4ICsyNyw2IEBACj4gPiA+IMKgIMKgICNkZWZpbmUgSUZDVkZfUVVFVUVfQUxJR05NRU5U wqDCoMKgIFBBR0VfU0laRQo+ID4gPiDCoCAjZGVmaW5lIElGQ1ZGX1FVRVVFX01BWMKgwqDCoMKg wqDCoMKgIDMyNzY4Cj4gPiA+IC0jZGVmaW5lIElGQ1ZGX01TSV9DT05GSUdfT0ZGwqDCoMKgIDAK PiA+ID4gLSNkZWZpbmUgSUZDVkZfTVNJX1FVRVVFX09GRsKgwqDCoCAxCj4gPiA+IMKgICNkZWZp bmUgSUZDVkZfUENJX01BWF9SRVNPVVJDRcKgwqDCoCA2Cj4gPiA+IMKgIMKgICNkZWZpbmUgSUZD VkZfTE1fQ0ZHX1NJWkXCoMKgwqDCoMKgwqDCoCAweDQwCj4gPiA+IEBAIC00Miw2ICs0MCwxMyBA QAo+ID4gPiDCoCAjZGVmaW5lIGlmY3ZmX3ByaXZhdGVfdG9fdmYoYWRhcHRlcikgXAo+ID4gPiDC oMKgwqDCoMKgICgmKChzdHJ1Y3QgaWZjdmZfYWRhcHRlciAqKWFkYXB0ZXIpLT52ZikKPiA+ID4g wqAgKy8qIGFsbCB2cXMgYW5kIGNvbmZpZyBpbnRlcnJ1cHQgaGFzIGl0cyBvd24gdmVjdG9yICov Cj4gPiA+ICsjZGVmaW5lIE1TSVhfVkVDVE9SX1BFUl9WUV9BTkRfQ09ORklHwqDCoMKgwqDCoMKg wqAgMQo+ID4gPiArLyogYWxsIHZxcyBzaGFyZSBhIHZlY3RvciwgYW5kIGNvbmZpZyBpbnRlcnJ1 cHQgaGFzIGEgc2VwYXJhdGUKPiA+ID4gdmVjdG9yICovCj4gPiA+ICsjZGVmaW5lIE1TSVhfVkVD VE9SX1NIQVJFRF9WUV9BTkRfQ09ORklHwqDCoMKgIDIKPiA+ID4gKy8qIGFsbCB2cXMgYW5kIGNv bmZpZyBpbnRlcnJ1cHQgc2hhcmUgYSB2ZWN0b3IgKi8KPiA+ID4gKyNkZWZpbmUgTVNJWF9WRUNU T1JfREVWX1NIQVJFRMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgMwo+ID4gCj4gPiAKPiA+IEkgdGhp bmsgdGhlcmUncyBubyBtdWNoIHZhbHVlIHRvIGRpZmZlciAyIGZyb20gMyBjb25zaWRlciBjb25m aWcKPiA+IGludGVycnVwdCBzaG91bGQgYmUgcmFyZS4KPiBJTUhPIHdlIHN0aWxsIG5lZWQgMiBh bmQgMywgYmVjYXVzZSBNU0lYX1ZFQ1RPUl9TSEFSRURfVlFfQU5EX0NPTkZJRyBtZWFucwo+IHRo ZXJlIGFyZSBhdCBsZWFzdCAyIHZlY3RvcnMsCj4gdGhlIHZxcyBzaGFyZSBvbmUgdmVjdG9yLCBj b25maWcgY2hhbmdlIGhhcyBpdHMgb3duIHZlY3Rvci4KPiBNU0lYX1ZFQ1RPUl9ERVZfU0hBUkVE IG1lYW5zIHRocmVlIGFyZSBvbmx5IG9uZSB2ZWN0b3IsIGFsbCB2cXMgYW5kIGNvbmZpZwo+IGNo YW5nZXMgbmVlZCB0byBzaGFyZSB0aGlzIHZlY3Rvci4KPiA+IAo+ID4gCj4gPiAKPiA+ID4gKwo+ ID4gPiDCoCBzdGF0aWMgaW5saW5lIHU4IGlmY19pb3JlYWQ4KHU4IF9faW9tZW0gKmFkZHIpCj4g PiA+IMKgIHsKPiA+ID4gwqDCoMKgwqDCoCByZXR1cm4gaW9yZWFkOChhZGRyKTsKPiA+ID4gQEAg LTk3LDI1ICsxMDIsMjcgQEAgc3RydWN0IGlmY3ZmX2h3IHsKPiA+ID4gwqDCoMKgwqDCoCB1OCBf X2lvbWVtICppc3I7Cj4gPiA+IMKgwqDCoMKgwqAgLyogTGl2ZSBtaWdyYXRpb24gKi8KPiA+ID4g wqDCoMKgwqDCoCB1OCBfX2lvbWVtICpsbV9jZmc7Cj4gPiA+IC3CoMKgwqAgdTE2IG5yX3ZyaW5n Owo+ID4gCj4gPiAKPiA+IEFueSByZWFzb24gZm9yIG1vdmluZyBudl92cmluZywgY29uZmlnX3Np emUsIGFuZCBvdGhlciBzdHVmZnM/Cj4gZm9yIGNhY2hlbGluZSBhbGlnbm1lbnQuCgptYXliZSBh IHNlcGFyYXRlIHBhdGNoIHRoZW4uCgo+ID4gCj4gPiAKPiA+IAo+ID4gPiDCoMKgwqDCoMKgIC8q IE5vdGlmaWNhdGlvbiBiYXIgbnVtYmVyICovCj4gPiA+IMKgwqDCoMKgwqAgdTggbm90aWZ5X2Jh cjsKPiA+ID4gK8KgwqDCoCB1OCBtc2l4X3ZlY3Rvcl9zdGF0dXM7Cj4gPiA+ICvCoMKgwqAgLyog dmlydGlvLW5ldCBvciB2aXJ0aW8tYmxrIGRldmljZSBjb25maWcgc2l6ZSAqLwo+ID4gPiArwqDC oMKgIHUzMiBjb25maWdfc2l6ZTsKPiA+ID4gwqDCoMKgwqDCoCAvKiBOb3RpZmljYWl0b24gYmFy IGFkZHJlc3MgKi8KPiA+ID4gwqDCoMKgwqDCoCB2b2lkIF9faW9tZW0gKm5vdGlmeV9iYXNlOwo+ ID4gPiDCoMKgwqDCoMKgIHBoeXNfYWRkcl90IG5vdGlmeV9iYXNlX3BhOwo+ID4gPiDCoMKgwqDC oMKgIHUzMiBub3RpZnlfb2ZmX211bHRpcGxpZXI7Cj4gPiA+ICvCoMKgwqAgdTMyIGRldl90eXBl Owo+ID4gPiDCoMKgwqDCoMKgIHU2NCByZXFfZmVhdHVyZXM7Cj4gPiA+IMKgwqDCoMKgwqAgdTY0 IGh3X2ZlYXR1cmVzOwo+ID4gPiAtwqDCoMKgIHUzMiBkZXZfdHlwZTsKPiA+ID4gwqDCoMKgwqDC oCBzdHJ1Y3QgdmlydGlvX3BjaV9jb21tb25fY2ZnIF9faW9tZW0gKmNvbW1vbl9jZmc7Cj4gPiA+ IMKgwqDCoMKgwqAgdm9pZCBfX2lvbWVtICpkZXZfY2ZnOwo+ID4gPiDCoMKgwqDCoMKgIHN0cnVj dCB2cmluZ19pbmZvIHZyaW5nW0lGQ1ZGX01BWF9RVUVVRVNdOwo+ID4gPiDCoMKgwqDCoMKgIHZv aWQgX19pb21lbSAqIGNvbnN0ICpiYXNlOwo+ID4gPiDCoMKgwqDCoMKgIGNoYXIgY29uZmlnX21z aXhfbmFtZVsyNTZdOwo+ID4gPiDCoMKgwqDCoMKgIHN0cnVjdCB2ZHBhX2NhbGxiYWNrIGNvbmZp Z19jYjsKPiA+ID4gLcKgwqDCoCB1bnNpZ25lZCBpbnQgY29uZmlnX2lycTsKPiA+ID4gLcKgwqDC oCAvKiB2aXJ0aW8tbmV0IG9yIHZpcnRpby1ibGsgZGV2aWNlIGNvbmZpZyBzaXplICovCj4gPiA+ IC3CoMKgwqAgdTMyIGNvbmZpZ19zaXplOwo+ID4gPiArwqDCoMKgIGludCBjb25maWdfaXJxOwo+ ID4gPiArwqDCoMKgIGludCB2cXNfc2hhcmVkX2lycTsKPiA+ID4gK8KgwqDCoCB1MTYgbnJfdnJp bmc7Cj4gPiA+IMKgIH07Cj4gPiA+IMKgIMKgIHN0cnVjdCBpZmN2Zl9hZGFwdGVyIHsKPiA+ID4g QEAgLTE2MCw0ICsxNjcsNiBAQCBpbnQgaWZjdmZfc2V0X3ZxX3N0YXRlKHN0cnVjdCBpZmN2Zl9o dyAqaHcsIHUxNgo+ID4gPiBxaWQsIHUxNiBudW0pOwo+ID4gPiDCoCBzdHJ1Y3QgaWZjdmZfYWRh cHRlciAqdmZfdG9fYWRhcHRlcihzdHJ1Y3QgaWZjdmZfaHcgKmh3KTsKPiA+ID4gwqAgaW50IGlm Y3ZmX3Byb2JlZF92aXJ0aW9fbmV0KHN0cnVjdCBpZmN2Zl9odyAqaHcpOwo+ID4gPiDCoCB1MzIg aWZjdmZfZ2V0X2NvbmZpZ19zaXplKHN0cnVjdCBpZmN2Zl9odyAqaHcpOwo+ID4gPiAraW50IGlm Y3ZmX3NldF92cV92ZWN0b3Ioc3RydWN0IGlmY3ZmX2h3ICpodywgdTE2IHFpZCwgaW50IHZlY3Rv cik7Cj4gPiA+ICtpbnQgaWZjdmZfc2V0X2NvbmZpZ192ZWN0b3Ioc3RydWN0IGlmY3ZmX2h3ICpo dywgaW50IHZlY3Rvcik7Cj4gPiA+IMKgICNlbmRpZiAvKiBfSUZDVkZfSF8gKi8KPiA+ID4gZGlm ZiAtLWdpdCBhL2RyaXZlcnMvdmRwYS9pZmN2Zi9pZmN2Zl9tYWluLmMKPiA+ID4gYi9kcml2ZXJz L3ZkcGEvaWZjdmYvaWZjdmZfbWFpbi5jCj4gPiA+IGluZGV4IDQ0Yzg5YWIwYjZkYS4uY2E0MTQz OTlmMDQwIDEwMDY0NAo+ID4gPiAtLS0gYS9kcml2ZXJzL3ZkcGEvaWZjdmYvaWZjdmZfbWFpbi5j Cj4gPiA+ICsrKyBiL2RyaXZlcnMvdmRwYS9pZmN2Zi9pZmN2Zl9tYWluLmMKPiA+ID4gQEAgLTE3 LDYgKzE3LDcgQEAKPiA+ID4gwqAgI2RlZmluZSBEUklWRVJfQVVUSE9SwqDCoCAiSW50ZWwgQ29y cG9yYXRpb24iCj4gPiA+IMKgICNkZWZpbmUgSUZDVkZfRFJJVkVSX05BTUXCoMKgwqDCoMKgwqAg ImlmY3ZmIgo+ID4gPiDCoCArLyogaGFuZGxlcyBjb25maWcgaW50ZXJydXB0ICovCj4gPiAKPiA+ IAo+ID4gVGhpcyBzZWVtcyB1bnJlbGF0ZWQgdG8gdGhlIHNoYXJlZCBJUlEgbG9naWMgYW5kIGl0 IGxvb2tzIHVzZWxlc3Mgc2luY2UKPiA+IGl0J3MgZWFzaWx5IHRvIGRlZHVjZSBpdCBmcm9tIHRo ZSBmdW5jdGlvbiBuYW1lIGJlbG93Lgo+IE9LLCBkbyB5b3UgbWVhbiB0aGUgY29tbWVudHM/IEkg Y2FuIHJlbW92ZSB0aGVzZSBjb21tZW50cy4KPiA+IAo+ID4gCj4gPiA+IMKgIHN0YXRpYyBpcnFy ZXR1cm5fdCBpZmN2Zl9jb25maWdfY2hhbmdlZChpbnQgaXJxLCB2b2lkICphcmcpCj4gPiA+IMKg IHsKPiA+ID4gwqDCoMKgwqDCoCBzdHJ1Y3QgaWZjdmZfaHcgKnZmID0gYXJnOwo+ID4gPiBAQCAt MjcsNiArMjgsNyBAQCBzdGF0aWMgaXJxcmV0dXJuX3QgaWZjdmZfY29uZmlnX2NoYW5nZWQoaW50 IGlycSwKPiA+ID4gdm9pZCAqYXJnKQo+ID4gPiDCoMKgwqDCoMKgIHJldHVybiBJUlFfSEFORExF RDsKPiA+ID4gwqAgfQo+ID4gPiDCoCArLyogaGFuZGxlcyB2cXMgaW50ZXJydXB0ICovCj4gPiAK PiA+IAo+ID4gU28gZGlkIHRoaXMuCj4gPiAKPiA+IAo+ID4gPiDCoCBzdGF0aWMgaXJxcmV0dXJu X3QgaWZjdmZfaW50cl9oYW5kbGVyKGludCBpcnEsIHZvaWQgKmFyZykKPiA+ID4gwqAgewo+ID4g PiDCoMKgwqDCoMKgIHN0cnVjdCB2cmluZ19pbmZvICp2cmluZyA9IGFyZzsKPiA+ID4gQEAgLTM3 LDI0ICszOSw3OCBAQCBzdGF0aWMgaXJxcmV0dXJuX3QgaWZjdmZfaW50cl9oYW5kbGVyKGludCBp cnEsCj4gPiA+IHZvaWQgKmFyZykKPiA+ID4gwqDCoMKgwqDCoCByZXR1cm4gSVJRX0hBTkRMRUQ7 Cj4gPiA+IMKgIH0KPiA+ID4gwqAgKy8qIGhhbmRscyB2cXMgc2hhcmVkIGludGVycnVwdCAqLwo+ ID4gPiArc3RhdGljIGlycXJldHVybl90IGlmY3ZmX3ZxX3NoYXJlZF9pbnRyX2hhbmRsZXIoaW50 IGlycSwgdm9pZCAqYXJnKQo+ID4gPiArewo+ID4gPiArwqDCoMKgIHN0cnVjdCBpZmN2Zl9odyAq dmYgPSBhcmc7Cj4gPiA+ICvCoMKgwqAgc3RydWN0IHZyaW5nX2luZm8gKnZyaW5nOwo+ID4gPiAr wqDCoMKgIGludCBpOwo+ID4gPiArCj4gPiA+ICvCoMKgwqAgZm9yIChpID0gMDsgaSA8IHZmLT5u cl92cmluZzsgaSsrKSB7Cj4gPiA+ICvCoMKgwqDCoMKgwqDCoCB2cmluZyA9ICZ2Zi0+dnJpbmdb aV07Cj4gPiA+ICvCoMKgwqDCoMKgwqDCoCBpZiAodnJpbmctPmNiLmNhbGxiYWNrKQo+ID4gPiAr IHZmLT52cmluZy0+Y2IuY2FsbGJhY2sodnJpbmctPmNiLnByaXZhdGUpOwo+ID4gPiArwqDCoMKg IH0KPiA+ID4gKwo+ID4gPiArwqDCoMKgIHJldHVybiBJUlFfSEFORExFRDsKPiA+ID4gK30KPiA+ ID4gKwo+ID4gPiArLyogaGFuZGxlcyBhIHNoYXJlZCBpbnRlcnJ1cHQgZm9yIHZxcyBhbmQgY29u ZmlnICovCj4gPiA+ICtzdGF0aWMgaXJxcmV0dXJuX3QgaWZjdmZfZGV2X3NoYXJlZF9pbnRyX2hh bmRsZXIoaW50IGlycSwgdm9pZCAqYXJnKQo+ID4gPiArewo+ID4gPiArwqDCoMKgIHN0cnVjdCBp ZmN2Zl9odyAqdmYgPSBhcmc7Cj4gPiA+ICvCoMKgwqAgdTggaXNyOwo+ID4gPiArCj4gPiA+ICvC oMKgwqAgaXNyID0gaWZjX2lvcmVhZDgodmYtPmlzcik7Cj4gPiAKPiA+IAo+ID4gV2UgbmVlZCB0 byBleGFjdGx5IHdoYXQgdnBfaW50ZXJydXB0IGRvIGhlcmUuIENoZWNraW5nIGFnYWluc3QgdmYt Pmlzcgo+ID4gZmlyc3QgYW5kIHJldHVybiBJUlFfTk9ORSBpZiBpdCBpcyBub3Qgc2V0Lgo+ID4g Cj4gPiBBbHdheXMgcmV0dXJuIElSUV9IQU5ETEVEIHdpbGwgYnJlYWsgdGhlIGRldmljZSB3aG8g c2hhcmVzIGFuIGlycSB3aXRoCj4gPiBJRkNWRi4KPiBhcyB3ZSBkaXNjdXNzZWQgaW4gYW5vdGhl ciB0aHJlYWQoc3BlYyBpbmNvbnNpc3RlbmN5IGFib3V0IElTUiksIElTUiBtYXkKPiBvbmx5IHdv cmtzIGZvciBJTlR4IGZvciBub3csCj4gYnV0IFZGcyBkb24ndCBoYXZlIElOVHgsIGFuZCBhIFZG IG1heSBub3Qgc2hhcmUgaXRzIHZlY3RvcnMgd2l0aCBvdGhlcgo+IGRldmljZXMsIHNvIEkgZ3Vl c3MgaXQgY2FuIHdvcmsKPiBhbmQgbWF5IGJlIG91ciBiZXN0IHRyeSBmb3Igbm93Lgo+ID4gCj4g PiAKPiA+ID4gK8KgwqDCoCBpZiAoaXNyICYgVklSVElPX1BDSV9JU1JfQ09ORklHKQo+ID4gPiAr wqDCoMKgwqDCoMKgwqAgaWZjdmZfY29uZmlnX2NoYW5nZWQoaXJxLCBhcmcpOwo+ID4gPiArCj4g PiA+ICvCoMKgwqAgcmV0dXJuIGlmY3ZmX3ZxX3NoYXJlZF9pbnRyX2hhbmRsZXIoaXJxLCBhcmcp Owo+ID4gPiArfQo+ID4gPiArCj4gPiA+IMKgIHN0YXRpYyB2b2lkIGlmY3ZmX2ZyZWVfaXJxX3Zl Y3RvcnModm9pZCAqZGF0YSkKPiA+ID4gwqAgewo+ID4gPiDCoMKgwqDCoMKgIHBjaV9mcmVlX2ly cV92ZWN0b3JzKGRhdGEpOwo+ID4gPiDCoCB9Cj4gPiA+IMKgIC1zdGF0aWMgdm9pZCBpZmN2Zl9m cmVlX2lycShzdHJ1Y3QgaWZjdmZfYWRhcHRlciAqYWRhcHRlciwgaW50IHF1ZXVlcykKPiA+ID4g K3N0YXRpYyB2b2lkIGlmY3ZmX2ZyZWVfdnFfaXJxKHN0cnVjdCBpZmN2Zl9hZGFwdGVyICphZGFw dGVyLCBpbnQKPiA+ID4gcXVldWVzKQo+ID4gPiDCoCB7Cj4gPiA+IMKgwqDCoMKgwqAgc3RydWN0 IHBjaV9kZXYgKnBkZXYgPSBhZGFwdGVyLT5wZGV2Owo+ID4gPiDCoMKgwqDCoMKgIHN0cnVjdCBp ZmN2Zl9odyAqdmYgPSAmYWRhcHRlci0+dmY7Cj4gPiA+IMKgwqDCoMKgwqAgaW50IGk7Cj4gPiA+ IMKgICvCoMKgwqAgaWYgKHZmLT5tc2l4X3ZlY3Rvcl9zdGF0dXMgPT0gTVNJWF9WRUNUT1JfUEVS X1ZRX0FORF9DT05GSUcpIHsKPiA+ID4gK8KgwqDCoMKgwqDCoMKgIGZvciAoaSA9IDA7IGkgPCBx dWV1ZXM7IGkrKykgewo+ID4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBkZXZtX2ZyZWVfaXJx KCZwZGV2LT5kZXYsIHZmLT52cmluZ1tpXS5pcnEsICZ2Zi0+dnJpbmdbaV0pOwo+ID4gPiArwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCB2Zi0+dnJpbmdbaV0uaXJxID0gLUVJTlZBTDsKPiA+ID4gK8Kg wqDCoMKgwqDCoMKgIH0KPiA+ID4gK8KgwqDCoCB9IGVsc2Ugewo+ID4gPiArwqDCoMKgwqDCoMKg wqAgZGV2bV9mcmVlX2lycSgmcGRldi0+ZGV2LCB2Zi0+dnFzX3NoYXJlZF9pcnEsIHZmKTsKPiA+ ID4gK8KgwqDCoMKgwqDCoMKgIHZmLT52cXNfc2hhcmVkX2lycSA9IC1FSU5WQUw7Cj4gPiA+ICvC oMKgwqAgfQo+ID4gPiArfQo+ID4gPiDCoCAtwqDCoMKgIGZvciAoaSA9IDA7IGkgPCBxdWV1ZXM7 IGkrKykgewo+ID4gPiAtwqDCoMKgwqDCoMKgwqAgZGV2bV9mcmVlX2lycSgmcGRldi0+ZGV2LCB2 Zi0+dnJpbmdbaV0uaXJxLCAmdmYtPnZyaW5nW2ldKTsKPiA+ID4gLcKgwqDCoMKgwqDCoMKgIHZm LT52cmluZ1tpXS5pcnEgPSAtRUlOVkFMOwo+ID4gPiArc3RhdGljIHZvaWQgaWZjdmZfZnJlZV9j b25maWdfaXJxKHN0cnVjdCBpZmN2Zl9hZGFwdGVyICphZGFwdGVyKQo+ID4gPiArewo+ID4gPiAr wqDCoMKgIHN0cnVjdCBwY2lfZGV2ICpwZGV2ID0gYWRhcHRlci0+cGRldjsKPiA+ID4gK8KgwqDC oCBzdHJ1Y3QgaWZjdmZfaHcgKnZmID0gJmFkYXB0ZXItPnZmOwo+ID4gPiArCj4gPiA+ICvCoMKg wqAgLyogSWYgdGhlIGlycSBpcyBzaGFyZWQgYnkgYWxsIHZxcyBhbmQgdGhlIGNvbmZpZyBpbnRl cnJ1cHQsCj4gPiA+ICvCoMKgwqDCoCAqIGl0IGlzIGFscmVhZHkgZnJlZWQgaW4gaWZjdmZfZnJl ZV92cV9pcnEsIHNvIGhlcmUgb25seQo+ID4gPiArwqDCoMKgwqAgKiBuZWVkIHRvIGZyZWUgY29u ZmlnIGlycSB3aGVuIG1zaXhfdmVjdG9yX3N0YXR1cyAhPQo+ID4gPiBNU0lYX1ZFQ1RPUl9ERVZf U0hBUkVECj4gPiA+ICvCoMKgwqDCoCAqLwo+ID4gPiArwqDCoMKgIGlmICh2Zi0+bXNpeF92ZWN0 b3Jfc3RhdHVzICE9IE1TSVhfVkVDVE9SX0RFVl9TSEFSRUQpIHsKPiA+ID4gK8KgwqDCoMKgwqDC oMKgIGRldm1fZnJlZV9pcnEoJnBkZXYtPmRldiwgdmYtPmNvbmZpZ19pcnEsIHZmKTsKPiA+ID4g K8KgwqDCoMKgwqDCoMKgIHZmLT5jb25maWdfaXJxID0gLUVJTlZBTDsKPiA+ID4gwqDCoMKgwqDC oCB9Cj4gPiA+ICt9Cj4gPiA+ICsKPiA+ID4gK3N0YXRpYyB2b2lkIGlmY3ZmX2ZyZWVfaXJxKHN0 cnVjdCBpZmN2Zl9hZGFwdGVyICphZGFwdGVyLCBpbnQgcXVldWVzKQo+ID4gPiArewo+ID4gPiAr wqDCoMKgIHN0cnVjdCBwY2lfZGV2ICpwZGV2ID0gYWRhcHRlci0+cGRldjsKPiA+ID4gwqAgLcKg wqDCoCBkZXZtX2ZyZWVfaXJxKCZwZGV2LT5kZXYsIHZmLT5jb25maWdfaXJxLCB2Zik7Cj4gPiA+ ICvCoMKgwqAgaWZjdmZfZnJlZV92cV9pcnEoYWRhcHRlciwgcXVldWVzKTsKPiA+ID4gK8KgwqDC oCBpZmN2Zl9mcmVlX2NvbmZpZ19pcnEoYWRhcHRlcik7Cj4gPiA+IMKgwqDCoMKgwqAgaWZjdmZf ZnJlZV9pcnFfdmVjdG9ycyhwZGV2KTsKPiA+ID4gwqAgfQo+ID4gPiDCoCBAQCAtODYsNTggKzE0 MiwxNzIgQEAgc3RhdGljIGludCBpZmN2Zl9hbGxvY192ZWN0b3JzKHN0cnVjdAo+ID4gPiBpZmN2 Zl9hZGFwdGVyICphZGFwdGVyKQo+ID4gPiDCoMKgwqDCoMKgIHJldHVybiByZXQ7Cj4gPiA+IMKg IH0KPiA+ID4gwqAgLXN0YXRpYyBpbnQgaWZjdmZfcmVxdWVzdF9pcnEoc3RydWN0IGlmY3ZmX2Fk YXB0ZXIgKmFkYXB0ZXIpCj4gPiA+ICtzdGF0aWMgaW50IGlmY3ZmX3JlcXVlc3RfcGVyX3ZxX2ly cShzdHJ1Y3QgaWZjdmZfYWRhcHRlciAqYWRhcHRlcikKPiA+ID4gwqAgewo+ID4gPiDCoMKgwqDC oMKgIHN0cnVjdCBwY2lfZGV2ICpwZGV2ID0gYWRhcHRlci0+cGRldjsKPiA+ID4gwqDCoMKgwqDC oCBzdHJ1Y3QgaWZjdmZfaHcgKnZmID0gJmFkYXB0ZXItPnZmOwo+ID4gPiAtwqDCoMKgIGludCB2 ZWN0b3IsIG52ZWN0b3JzLCBpLCByZXQsIGlycTsKPiA+ID4gLcKgwqDCoCB1MTYgbWF4X2ludHI7 Cj4gPiA+ICvCoMKgwqAgaW50IGksIHZlY3RvciwgcmV0LCBpcnE7Cj4gPiA+IMKgIC3CoMKgwqAg bnZlY3RvcnMgPSBpZmN2Zl9hbGxvY192ZWN0b3JzKGFkYXB0ZXIpOwo+ID4gPiAtwqDCoMKgIGlm ICghKG52ZWN0b3JzID4gMCkpCj4gPiA+IC3CoMKgwqDCoMKgwqDCoCByZXR1cm4gbnZlY3RvcnM7 Cj4gPiA+ICvCoMKgwqAgZm9yIChpID0gMDsgaSA8IHZmLT5ucl92cmluZzsgaSsrKSB7Cj4gPiA+ ICvCoMKgwqDCoMKgwqDCoCBzbnByaW50Zih2Zi0+dnJpbmdbaV0ubXNpeF9uYW1lLCAyNTYsICJp ZmN2Zlslc10tJWRcbiIsCj4gPiA+IHBjaV9uYW1lKHBkZXYpLCBpKTsKPiA+ID4gK8KgwqDCoMKg wqDCoMKgIHZlY3RvciA9IGk7Cj4gPiA+ICvCoMKgwqDCoMKgwqDCoCBpcnEgPSBwY2lfaXJxX3Zl Y3RvcihwZGV2LCB2ZWN0b3IpOwo+ID4gPiArwqDCoMKgwqDCoMKgwqAgcmV0ID0gZGV2bV9yZXF1 ZXN0X2lycSgmcGRldi0+ZGV2LCBpcnEsCj4gPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoCBpZmN2Zl9pbnRyX2hhbmRsZXIsIDAsCj4gPiA+ICvCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB2Zi0+dnJpbmdbaV0ubXNpeF9u YW1lLAo+ID4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg JnZmLT52cmluZ1tpXSk7Cj4gPiA+ICvCoMKgwqDCoMKgwqDCoCBpZiAocmV0KSB7Cj4gPiA+ICvC oMKgwqDCoMKgwqDCoMKgwqDCoMKgIElGQ1ZGX0VSUihwZGV2LCAiRmFpbGVkIHRvIHJlcXVlc3Qg aXJxIGZvciB2cSAlZFxuIiwgaSk7Cj4gPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlmY3Zm X2ZyZWVfdnFfaXJxKGFkYXB0ZXIsIGkpOwo+ID4gPiArwqDCoMKgwqDCoMKgwqAgfSBlbHNlIHsK PiA+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdmYtPnZyaW5nW2ldLmlycSA9IGlycTsKPiA+ ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaWZjdmZfc2V0X3ZxX3ZlY3Rvcih2ZiwgaSwgdmVj dG9yKTsKPiA+ID4gK8KgwqDCoMKgwqDCoMKgIH0KPiA+ID4gK8KgwqDCoCB9Cj4gPiA+IMKgIC3C oMKgwqAgbWF4X2ludHIgPSB2Zi0+bnJfdnJpbmcgKyAxOwo+ID4gPiArwqDCoMKgIHZmLT52cXNf c2hhcmVkX2lycSA9IC1FSU5WQUw7Cj4gPiA+ICsKPiA+ID4gK8KgwqDCoCByZXR1cm4gMDsKPiA+ ID4gK30KPiA+ID4gKwo+ID4gPiArc3RhdGljIGludCBpZmN2Zl9yZXF1ZXN0X3NoYXJlZF92cV9p cnEoc3RydWN0IGlmY3ZmX2FkYXB0ZXIgKmFkYXB0ZXIpCj4gPiA+ICt7Cj4gPiA+ICvCoMKgwqAg c3RydWN0IHBjaV9kZXYgKnBkZXYgPSBhZGFwdGVyLT5wZGV2Owo+ID4gPiArwqDCoMKgIHN0cnVj dCBpZmN2Zl9odyAqdmYgPSAmYWRhcHRlci0+dmY7Cj4gPiA+ICvCoMKgwqAgaW50IGksIHZlY3Rv ciwgcmV0LCBpcnE7Cj4gPiA+ICsKPiA+ID4gK8KgwqDCoCB2ZWN0b3IgPSAwOwo+ID4gPiArwqDC oMKgIC8qIHJldXNlIG1zaXhfbmFtZVsyNTZdIHNwYWNlIG9mIHZyaW5nMCB0byBzdG9yZSBzaGFy ZWQgdnFzCj4gPiA+IGludGVycnVwdCBuYW1lICovCj4gPiAKPiA+IAo+ID4gSSB0aGluayB3ZSBj YW4gcmVtb3ZlIHRoaXMgY29tbWVudCBzaW5jZSB0aGUgY29kZSBpcyBzdHJhaWdodGZvcndhcmQu Cj4gc3VyZQo+ID4gCj4gPiAKPiA+ID4gKyBzbnByaW50Zih2Zi0+dnJpbmdbMF0ubXNpeF9uYW1l LCAyNTYsCj4gPiA+ICJpZmN2Zlslc10tdnFzLXNoYXJlZC1pcnFcbiIsIHBjaV9uYW1lKHBkZXYp KTsKPiA+ID4gK8KgwqDCoCBpcnEgPSBwY2lfaXJxX3ZlY3RvcihwZGV2LCB2ZWN0b3IpOwo+ID4g PiArwqDCoMKgIHJldCA9IGRldm1fcmVxdWVzdF9pcnEoJnBkZXYtPmRldiwgaXJxLAo+ID4gPiAr wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGlmY3ZmX3ZxX3NoYXJlZF9pbnRy X2hhbmRsZXIsIDAsCj4gPiA+ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAg dmYtPnZyaW5nWzBdLm1zaXhfbmFtZSwgdmYpOwo+ID4gPiArwqDCoMKgIGlmIChyZXQpIHsKPiA+ ID4gK8KgwqDCoMKgwqDCoMKgIElGQ1ZGX0VSUihwZGV2LCAiRmFpbGVkIHRvIHJlcXVlc3Qgc2hh cmVkIGlycSBmb3IgdmZcbiIpOwo+ID4gPiArCj4gPiA+ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4g cmV0Owo+ID4gPiArwqDCoMKgIH0KPiA+ID4gKwo+ID4gPiArwqDCoMKgIHZmLT52cXNfc2hhcmVk X2lycSA9IGlycTsKPiA+ID4gK8KgwqDCoCBmb3IgKGkgPSAwOyBpIDwgdmYtPm5yX3ZyaW5nOyBp KyspIHsKPiA+ID4gK8KgwqDCoMKgwqDCoMKgIHZmLT52cmluZ1tpXS5pcnEgPSAtRUlOVkFMOwo+ ID4gPiArwqDCoMKgwqDCoMKgwqAgaWZjdmZfc2V0X3ZxX3ZlY3Rvcih2ZiwgaSwgdmVjdG9yKTsK PiA+ID4gK8KgwqDCoCB9Cj4gPiA+ICsKPiA+ID4gK8KgwqDCoCByZXR1cm4gMDsKPiA+ID4gKwo+ ID4gPiArfQo+ID4gPiArCj4gPiA+ICtzdGF0aWMgaW50IGlmY3ZmX3JlcXVlc3RfZGV2X3NoYXJl ZF9pcnEoc3RydWN0IGlmY3ZmX2FkYXB0ZXIgKmFkYXB0ZXIpCj4gPiA+ICt7Cj4gPiA+ICvCoMKg wqAgc3RydWN0IHBjaV9kZXYgKnBkZXYgPSBhZGFwdGVyLT5wZGV2Owo+ID4gPiArwqDCoMKgIHN0 cnVjdCBpZmN2Zl9odyAqdmYgPSAmYWRhcHRlci0+dmY7Cj4gPiA+ICvCoMKgwqAgaW50IGksIHZl Y3RvciwgcmV0LCBpcnE7Cj4gPiA+ICsKPiA+ID4gK8KgwqDCoCB2ZWN0b3IgPSAwOwo+ID4gPiAr wqDCoMKgIC8qIHJldXNlIG1zaXhfbmFtZVsyNTZdIHNwYWNlIG9mIHZyaW5nMCB0byBzdG9yZSBz aGFyZWQgZGV2aWNlCj4gPiA+IGludGVycnVwdCBuYW1lICovCj4gPiA+ICvCoMKgwqAgc25wcmlu dGYodmYtPnZyaW5nWzBdLm1zaXhfbmFtZSwgMjU2LAo+ID4gPiAiaWZjdmZbJXNdLWRldi1zaGFy ZWQtaXJxXG4iLCBwY2lfbmFtZShwZGV2KSk7Cj4gPiA+ICvCoMKgwqAgaXJxID0gcGNpX2lycV92 ZWN0b3IocGRldiwgdmVjdG9yKTsKPiA+ID4gK8KgwqDCoCByZXQgPSBkZXZtX3JlcXVlc3RfaXJx KCZwZGV2LT5kZXYsIGlycSwKPiA+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoCBpZmN2Zl9kZXZfc2hhcmVkX2ludHJfaGFuZGxlciwgMCwKPiA+ID4gK8KgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCB2Zi0+dnJpbmdbMF0ubXNpeF9uYW1lLCB2Zik7Cj4g PiA+ICvCoMKgwqAgaWYgKHJldCkgewo+ID4gPiArwqDCoMKgwqDCoMKgwqAgSUZDVkZfRVJSKHBk ZXYsICJGYWlsZWQgdG8gcmVxdWVzdCBzaGFyZWQgaXJxIGZvciB2ZlxuIik7Cj4gPiA+IMKgIC3C oMKgwqAgcmV0ID0gcGNpX2FsbG9jX2lycV92ZWN0b3JzKHBkZXYsIG1heF9pbnRyLAo+ID4gPiAt wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgbWF4X2ludHIsIFBDSV9JUlFf TVNJWCk7Cj4gPiA+IC3CoMKgwqAgaWYgKHJldCA8IDApIHsKPiA+ID4gLcKgwqDCoMKgwqDCoMKg IElGQ1ZGX0VSUihwZGV2LCAiRmFpbGVkIHRvIGFsbG9jIElSUSB2ZWN0b3JzXG4iKTsKPiA+ID4g wqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiByZXQ7Cj4gPiA+IMKgwqDCoMKgwqAgfQo+ID4gPiDC oCArwqDCoMKgIHZmLT52cXNfc2hhcmVkX2lycSA9IGlycTsKPiA+ID4gK8KgwqDCoCBmb3IgKGkg PSAwOyBpIDwgdmYtPm5yX3ZyaW5nOyBpKyspIHsKPiA+ID4gK8KgwqDCoMKgwqDCoMKgIHZmLT52 cmluZ1tpXS5pcnEgPSAtRUlOVkFMOwo+ID4gPiArwqDCoMKgwqDCoMKgwqAgaWZjdmZfc2V0X3Zx X3ZlY3Rvcih2ZiwgaSwgdmVjdG9yKTsKPiA+ID4gK8KgwqDCoCB9Cj4gPiA+ICsKPiA+ID4gK8Kg wqDCoCB2Zi0+Y29uZmlnX2lycSA9IGlycTsKPiA+ID4gK8KgwqDCoCBpZmN2Zl9zZXRfY29uZmln X3ZlY3Rvcih2ZiwgdmVjdG9yKTsKPiA+ID4gKwo+ID4gPiArwqDCoMKgIHJldHVybiAwOwo+ID4g PiArCj4gPiA+ICt9Cj4gPiA+ICsKPiA+ID4gK3N0YXRpYyBpbnQgaWZjdmZfcmVxdWVzdF92cV9p cnEoc3RydWN0IGlmY3ZmX2FkYXB0ZXIgKmFkYXB0ZXIpCj4gPiA+ICt7Cj4gPiA+ICvCoMKgwqAg c3RydWN0IGlmY3ZmX2h3ICp2ZiA9ICZhZGFwdGVyLT52ZjsKPiA+ID4gK8KgwqDCoCBpbnQgcmV0 Owo+ID4gPiArCj4gPiA+ICvCoMKgwqAgaWYgKHZmLT5tc2l4X3ZlY3Rvcl9zdGF0dXMgPT0gTVNJ WF9WRUNUT1JfUEVSX1ZRX0FORF9DT05GSUcpCj4gPiA+ICvCoMKgwqDCoMKgwqDCoCByZXQgPSBp ZmN2Zl9yZXF1ZXN0X3Blcl92cV9pcnEoYWRhcHRlcik7Cj4gPiA+ICvCoMKgwqAgZWxzZQo+ID4g PiArwqDCoMKgwqDCoMKgwqAgcmV0ID0gaWZjdmZfcmVxdWVzdF9zaGFyZWRfdnFfaXJxKGFkYXB0 ZXIpOwo+ID4gPiArCj4gPiA+ICvCoMKgwqAgcmV0dXJuIHJldDsKPiA+ID4gK30KPiA+ID4gKwo+ ID4gPiArc3RhdGljIGludCBpZmN2Zl9yZXF1ZXN0X2NvbmZpZ19pcnEoc3RydWN0IGlmY3ZmX2Fk YXB0ZXIgKmFkYXB0ZXIpCj4gPiA+ICt7Cj4gPiA+ICvCoMKgwqAgc3RydWN0IHBjaV9kZXYgKnBk ZXYgPSBhZGFwdGVyLT5wZGV2Owo+ID4gPiArwqDCoMKgIHN0cnVjdCBpZmN2Zl9odyAqdmYgPSAm YWRhcHRlci0+dmY7Cj4gPiA+ICvCoMKgwqAgaW50IGNvbmZpZ192ZWN0b3IsIHJldDsKPiA+ID4g Kwo+ID4gPiArwqDCoMKgIGlmICh2Zi0+bXNpeF92ZWN0b3Jfc3RhdHVzID09IE1TSVhfVkVDVE9S X0RFVl9TSEFSRUQpCj4gPiA+ICvCoMKgwqDCoMKgwqDCoCByZXR1cm4gMDsKPiA+ID4gKwo+ID4g PiArwqDCoMKgIGlmICh2Zi0+bXNpeF92ZWN0b3Jfc3RhdHVzID09IE1TSVhfVkVDVE9SX1BFUl9W UV9BTkRfQ09ORklHKQo+ID4gPiArwqDCoMKgwqDCoMKgwqAgLyogdmVjdG9yIDAgfiB2Zi0+bnJf dnJpbmcgZm9yIHZxcywgbnVtIHZmLT5ucl92cmluZyB2ZWN0b3IKPiA+ID4gZm9yIGNvbmZpZyBp bnRlcnJ1cHQgKi8KPiA+ID4gK8KgwqDCoMKgwqDCoMKgIGNvbmZpZ192ZWN0b3IgPSB2Zi0+bnJf dnJpbmc7Cj4gPiA+ICsKPiA+ID4gK8KgwqDCoCBpZiAodmYtPm1zaXhfdmVjdG9yX3N0YXR1cyA9 PSBNU0lYX1ZFQ1RPUl9TSEFSRURfVlFfQU5EX0NPTkZJRykKPiA+ID4gK8KgwqDCoMKgwqDCoMKg IC8qIHZlY3RvciAwIGZvciB2cXMgYW5kIDEgZm9yIGNvbmZpZyBpbnRlcnJ1cHQgKi8KPiA+ID4g K8KgwqDCoMKgwqDCoMKgIGNvbmZpZ192ZWN0b3IgPSAxOwo+ID4gPiArCj4gPiA+IMKgwqDCoMKg wqAgc25wcmludGYodmYtPmNvbmZpZ19tc2l4X25hbWUsIDI1NiwgImlmY3ZmWyVzXS1jb25maWdc biIsCj4gPiA+IMKgwqDCoMKgwqDCoMKgwqDCoMKgIHBjaV9uYW1lKHBkZXYpKTsKPiA+ID4gLcKg wqDCoCB2ZWN0b3IgPSAwOwo+ID4gPiAtwqDCoMKgIHZmLT5jb25maWdfaXJxID0gcGNpX2lycV92 ZWN0b3IocGRldiwgdmVjdG9yKTsKPiA+ID4gK8KgwqDCoCB2Zi0+Y29uZmlnX2lycSA9IHBjaV9p cnFfdmVjdG9yKHBkZXYsIGNvbmZpZ192ZWN0b3IpOwo+ID4gPiDCoMKgwqDCoMKgIHJldCA9IGRl dm1fcmVxdWVzdF9pcnEoJnBkZXYtPmRldiwgdmYtPmNvbmZpZ19pcnEsCj4gPiA+IMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaWZjdmZfY29uZmlnX2NoYW5nZWQsIDAs Cj4gPiA+IMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdmYtPmNvbmZp Z19tc2l4X25hbWUsIHZmKTsKPiA+ID4gwqDCoMKgwqDCoCBpZiAocmV0KSB7Cj4gPiA+IMKgwqDC oMKgwqDCoMKgwqDCoCBJRkNWRl9FUlIocGRldiwgIkZhaWxlZCB0byByZXF1ZXN0IGNvbmZpZyBp cnFcbiIpOwo+ID4gPiArwqDCoMKgwqDCoMKgwqAgaWZjdmZfZnJlZV92cV9pcnEoYWRhcHRlciwg dmYtPm5yX3ZyaW5nKTsKPiA+ID4gwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiByZXQ7Cj4gPiA+ IMKgwqDCoMKgwqAgfQo+ID4gPiDCoCAtwqDCoMKgIGZvciAoaSA9IDA7IGkgPCB2Zi0+bnJfdnJp bmc7IGkrKykgewo+ID4gPiAtwqDCoMKgwqDCoMKgwqAgc25wcmludGYodmYtPnZyaW5nW2ldLm1z aXhfbmFtZSwgMjU2LCAiaWZjdmZbJXNdLSVkXG4iLAo+ID4gPiAtwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgIHBjaV9uYW1lKHBkZXYpLCBpKTsKPiA+ID4gLcKgwqDCoMKgwqDCoMKgIHZlY3RvciA9 IGkgKyBJRkNWRl9NU0lfUVVFVUVfT0ZGOwo+ID4gPiAtwqDCoMKgwqDCoMKgwqAgaXJxID0gcGNp X2lycV92ZWN0b3IocGRldiwgdmVjdG9yKTsKPiA+ID4gLcKgwqDCoMKgwqDCoMKgIHJldCA9IGRl dm1fcmVxdWVzdF9pcnEoJnBkZXYtPmRldiwgaXJxLAo+ID4gPiAtwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgaWZjdmZfaW50cl9oYW5kbGVyLCAwLAo+ID4gPiAt wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgdmYtPnZyaW5nW2ld Lm1zaXhfbmFtZSwKPiA+ID4gLcKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgICZ2Zi0+dnJpbmdbaV0pOwo+ID4gPiAtwqDCoMKgwqDCoMKgwqAgaWYgKHJldCkgewo+ ID4gPiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBJRkNWRl9FUlIocGRldiwKPiA+ID4gLcKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgIkZhaWxlZCB0byByZXF1ZXN0IGlycSBmb3Ig dnEgJWRcbiIsIGkpOwo+ID4gPiAtwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCBpZmN2Zl9mcmVlX2ly cShhZGFwdGVyLCBpKTsKPiA+ID4gK8KgwqDCoCBpZmN2Zl9zZXRfY29uZmlnX3ZlY3Rvcih2Ziwg Y29uZmlnX3ZlY3Rvcik7Cj4gPiA+IMKgIC3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgIHJldHVybiBy ZXQ7Cj4gPiA+IC3CoMKgwqDCoMKgwqDCoCB9Cj4gPiA+ICvCoMKgwqAgcmV0dXJuIDA7Cj4gPiA+ ICt9Cj4gPiA+ICsKPiA+ID4gK3N0YXRpYyBpbnQgaWZjdmZfcmVxdWVzdF9pcnEoc3RydWN0IGlm Y3ZmX2FkYXB0ZXIgKmFkYXB0ZXIpCj4gPiA+ICt7Cj4gPiAKPiA+IAo+ID4gQXMgcmVwbGllZCBh Ym92ZSwgSSB0aGluayBoYXZpbmcgdHdvIG1vZGVzIHNob3VsZCBiZSBzdWZmaWNpZW50IGFuZCB0 aGUKPiA+IGNvZGUgY291bGQgYmUgZ3JlYXRseSBzaW1wbGlmaWVkLgo+IERvIHlvdSBtZWFuIGlm IHdlIGRvbid0IGdldCBlbm91Z2ggdmVjdG9ycywganVzdCB1c2Ugb25seSBvbmUgdmVjdG9yIGZv ciB0aGUKPiB2cXMgYW5kIGNvbmZpZyBjaGFuZ2VzPyBJIGd1ZXNzIHRoaXMKPiBvbmx5IHdvcmtz IGlmIElTUiB3b3JrIGZvciBNU0lYIGFzIHdlIGV4cGVjdHMsIG9yIHdlIG1heSB3YXN0ZSBzb21l IHRpbWUgaW4KPiB0aGUgZGV2aWNlIGNvbmZpZyBzcGFjZS4KPiAKPiBUaGFua3MsCj4gWmh1IExp bmdzaGFuCj4gPiAKPiA+IFRoYW5rcwo+ID4gCj4gPiAKPiA+ID4gK8KgwqDCoCBzdHJ1Y3QgaWZj dmZfaHcgKnZmID0gJmFkYXB0ZXItPnZmOwo+ID4gPiArwqDCoMKgIGludCBudmVjdG9ycywgcmV0 LCBtYXhfaW50cjsKPiA+ID4gwqAgLcKgwqDCoMKgwqDCoMKgIHZmLT52cmluZ1tpXS5pcnEgPSBp cnE7Cj4gPiA+ICvCoMKgwqAgbnZlY3RvcnMgPSBpZmN2Zl9hbGxvY192ZWN0b3JzKGFkYXB0ZXIp Owo+ID4gPiArwqDCoMKgIGlmICghKG52ZWN0b3JzID4gMCkpCj4gPiA+ICvCoMKgwqDCoMKgwqDC oCByZXR1cm4gbnZlY3RvcnM7Cj4gPiA+ICsKPiA+ID4gK8KgwqDCoCB2Zi0+bXNpeF92ZWN0b3Jf c3RhdHVzID0gTVNJWF9WRUNUT1JfUEVSX1ZRX0FORF9DT05GSUc7Cj4gPiA+ICvCoMKgwqAgbWF4 X2ludHIgPSB2Zi0+bnJfdnJpbmcgKyAxOwo+ID4gPiArwqDCoMKgIGlmIChudmVjdG9ycyA8IG1h eF9pbnRyKQo+ID4gPiArwqDCoMKgwqDCoMKgwqAgdmYtPm1zaXhfdmVjdG9yX3N0YXR1cyA9IE1T SVhfVkVDVE9SX1NIQVJFRF9WUV9BTkRfQ09ORklHOwo+ID4gPiArCj4gPiA+ICvCoMKgwqAgaWYg KG52ZWN0b3JzID09IDEpIHsKPiA+ID4gK8KgwqDCoMKgwqDCoMKgIHZmLT5tc2l4X3ZlY3Rvcl9z dGF0dXMgPSBNU0lYX1ZFQ1RPUl9ERVZfU0hBUkVEOwo+ID4gPiArwqDCoMKgwqDCoMKgwqAgcmV0 ID0gaWZjdmZfcmVxdWVzdF9kZXZfc2hhcmVkX2lycShhZGFwdGVyKTsKPiA+ID4gKwo+ID4gPiAr wqDCoMKgwqDCoMKgwqAgcmV0dXJuIHJldDsKPiA+ID4gwqDCoMKgwqDCoCB9Cj4gPiA+IMKgICvC oMKgwqAgcmV0ID0gaWZjdmZfcmVxdWVzdF92cV9pcnEoYWRhcHRlcik7Cj4gPiA+ICvCoMKgwqAg aWYgKHJldCkKPiA+ID4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiByZXQ7Cj4gPiA+ICsKPiA+ID4g K8KgwqDCoCByZXQgPSBpZmN2Zl9yZXF1ZXN0X2NvbmZpZ19pcnEoYWRhcHRlcik7Cj4gPiA+ICsK PiA+ID4gK8KgwqDCoCBpZiAocmV0KQo+ID4gPiArwqDCoMKgwqDCoMKgwqAgcmV0dXJuIHJldDsK PiA+ID4gKwo+ID4gPiDCoMKgwqDCoMKgIHJldHVybiAwOwo+ID4gPiDCoCB9Cj4gPiA+IMKgIEBA IC00NDEsNyArNjExLDEwIEBAIHN0YXRpYyBpbnQgaWZjdmZfdmRwYV9nZXRfdnFfaXJxKHN0cnVj dAo+ID4gPiB2ZHBhX2RldmljZSAqdmRwYV9kZXYsCj4gPiA+IMKgIHsKPiA+ID4gwqDCoMKgwqDC oCBzdHJ1Y3QgaWZjdmZfaHcgKnZmID0gdmRwYV90b192Zih2ZHBhX2Rldik7Cj4gPiA+IMKgIC3C oMKgwqAgcmV0dXJuIHZmLT52cmluZ1txaWRdLmlycTsKPiA+ID4gK8KgwqDCoCBpZiAodmYtPnZx c19zaGFyZWRfaXJxIDwgMCkKPiA+ID4gK8KgwqDCoMKgwqDCoMKgIHJldHVybiB2Zi0+dnJpbmdb cWlkXS5pcnE7Cj4gPiA+ICvCoMKgwqAgZWxzZQo+ID4gPiArwqDCoMKgwqDCoMKgwqAgcmV0dXJu IC1FSU5WQUw7Cj4gPiA+IMKgIH0KPiA+ID4gwqAgwqAgc3RhdGljIHN0cnVjdCB2ZHBhX25vdGlm aWNhdGlvbl9hcmVhCj4gPiA+IGlmY3ZmX2dldF92cV9ub3RpZmljYXRpb24oc3RydWN0IHZkcGFf ZGV2aWNlICp2ZHBhX2RldiwKPiA+IAo+ID4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KPiA+IFZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdAo+ID4gVmly dHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcKPiA+IGh0dHBzOi8vbGlzdHMu bGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL3ZpcnR1YWxpemF0aW9uCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpWaXJ0dWFsaXphdGlv biBtYWlsaW5nIGxpc3QKVmlydHVhbGl6YXRpb25AbGlzdHMubGludXgtZm91bmRhdGlvbi5vcmcK aHR0cHM6Ly9saXN0cy5saW51eGZvdW5kYXRpb24ub3JnL21haWxtYW4vbGlzdGluZm8vdmlydHVh bGl6YXRpb24= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0110CC433EF for ; Mon, 14 Feb 2022 14:27:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345165AbiBNO1s (ORCPT ); Mon, 14 Feb 2022 09:27:48 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:34928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233881AbiBNO1r (ORCPT ); Mon, 14 Feb 2022 09:27:47 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 0258FDF39 for ; Mon, 14 Feb 2022 06:27:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644848857; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PclHVn4hFaIREct3Ix5qAB8FWulpbaBhmyWRoGDkv4M=; b=Zf7Rl5lsFwe/DUaNd8SEqWmy5MQtWYXRqHQeyDOS5JkXuK5UHsx82nT9lioH7AvZE7WyAq JJwJp7TLtBoyFODSgT5OTxcLx3YbPX7ke2nGErQjIdbR/Xu7eDu9H1N+Rv8ccfV4/hmmOa vCJC3JIhgsJqa93/3BIGq7S4naNP0gI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-192-T3jyUZIYMzqzh7AJFUYmNQ-1; Mon, 14 Feb 2022 09:27:35 -0500 X-MC-Unique: T3jyUZIYMzqzh7AJFUYmNQ-1 Received: by mail-wm1-f71.google.com with SMTP id p24-20020a05600c1d9800b0037be98d03a1so8991515wms.0 for ; Mon, 14 Feb 2022 06:27:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=PclHVn4hFaIREct3Ix5qAB8FWulpbaBhmyWRoGDkv4M=; b=TqGEgpABSfglpSeOCGkD1uy1UZsZgNFldUSMLwuq788xSm1Wyh1mWOcQ9snBth7IrI aZ10mIcNMVn8Qb90Qz6sedM6XoMp2oSJjxNKk1+mOsu8zZsYjgNk0Xpg2oJ610+I3Th9 QZkI9WvOyTI4D7qAczzGgD5dYYEDzDDjhEPXCeIKLBBEz/wVPIsmAZkwYCiHYbJxaMuJ sMuuIyl4c6FoOx6GJdIMymonhdBUGja6NaY1uIUL+fsVZqN4dnj2EvhB/NDrF4u0iorA XBWeFNe/roxLJ4rEe5Ym5mh53nSJ7XyG7+nI6kCK4ZQiZRHW3or2DQ7Gw7HTiitGydYZ lhKA== X-Gm-Message-State: AOAM530eOqiYCtxcNLJeBkPHAN7nSu9s4RVFN6t3F3JxByi55n2mJS6D WP3ne0KMB1GwLTE8CKqPCSNgfboRevjlEAywGVr7sUTBOYNCKPZkW5sOj1P4sUhwwRdnZuF93BG 8+LCfqmYzknP0goFq X-Received: by 2002:a05:6000:85:: with SMTP id m5mr11706319wrx.75.1644848854494; Mon, 14 Feb 2022 06:27:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJw7RUa44P2HY0Ef9H21Qu743c1fDXi9Y4u9KKARtPAKyb8tGnmZK8UZoQAqeDcYInaYml4J3w== X-Received: by 2002:a05:6000:85:: with SMTP id m5mr11706299wrx.75.1644848854175; Mon, 14 Feb 2022 06:27:34 -0800 (PST) Received: from redhat.com ([2.55.156.76]) by smtp.gmail.com with ESMTPSA id g5sm12014178wmk.38.2022.02.14.06.27.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Feb 2022 06:27:33 -0800 (PST) Date: Mon, 14 Feb 2022 09:27:30 -0500 From: "Michael S. Tsirkin" To: Zhu Lingshan Cc: Jason Wang , Zhu Lingshan , netdev@vger.kernel.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH V4 4/4] vDPA/ifcvf: implement shared IRQ feature Message-ID: <20220214092558-mutt-send-email-mst@kernel.org> References: <20220203072735.189716-1-lingshan.zhu@intel.com> <20220203072735.189716-5-lingshan.zhu@intel.com> <449aa3a3-06c8-1236-241e-42ea5b7d8877@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <449aa3a3-06c8-1236-241e-42ea5b7d8877@linux.intel.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, Feb 14, 2022 at 06:01:56PM +0800, Zhu Lingshan wrote: > > > On 2/14/2022 3:19 PM, Jason Wang wrote: > > > > 在 2022/2/3 下午3:27, Zhu Lingshan 写道: > > > On some platforms/devices, there may not be enough MSI vector > > > slots allocated for virtqueues and config changes. In such a case, > > > the interrupt sources(virtqueues, config changes) must share > > > an IRQ/vector, to avoid initialization failures, keep > > > the device functional. > > > > > > This commit handles three cases: > > > (1) number of the allocated vectors == the number of virtqueues + 1 > > > (config changes), every virtqueue and the config interrupt has > > > a separated vector/IRQ, the best and the most likely case. > > > (2) number of the allocated vectors is less than the best case, but > > > greater than 1. In this case, all virtqueues share a vector/IRQ, > > > the config interrupt has a separated vector/IRQ > > > (3) only one vector is allocated, in this case, the virtqueues and > > > the config interrupt share a vector/IRQ. The worst and most > > > unlikely case. > > > > > > Otherwise, it needs to fail. > > > > > > This commit introduces some helper functions: > > > ifcvf_set_vq_vector() and ifcvf_set_config_vector() sets virtqueue > > > vector and config vector in the device config space, so that > > > the device can send interrupt DMA. > > > > > > This commit adds some fields in struct ifcvf_hw and re-placed > > > the existed fields to be aligned with the cacheline. > > > > > > Signed-off-by: Zhu Lingshan > > > --- > > >   drivers/vdpa/ifcvf/ifcvf_base.c |  47 ++++-- > > >   drivers/vdpa/ifcvf/ifcvf_base.h |  23 ++- > > >   drivers/vdpa/ifcvf/ifcvf_main.c | 243 +++++++++++++++++++++++++++----- > > >   3 files changed, 256 insertions(+), 57 deletions(-) > > > > > > diff --git a/drivers/vdpa/ifcvf/ifcvf_base.c > > > b/drivers/vdpa/ifcvf/ifcvf_base.c > > > index 397692ae671c..18dcb63ab1e3 100644 > > > --- a/drivers/vdpa/ifcvf/ifcvf_base.c > > > +++ b/drivers/vdpa/ifcvf/ifcvf_base.c > > > @@ -15,6 +15,36 @@ struct ifcvf_adapter *vf_to_adapter(struct > > > ifcvf_hw *hw) > > >       return container_of(hw, struct ifcvf_adapter, vf); > > >   } > > >   +int ifcvf_set_vq_vector(struct ifcvf_hw *hw, u16 qid, int vector) > > > +{ > > > +    struct virtio_pci_common_cfg __iomem *cfg = hw->common_cfg; > > > +    struct ifcvf_adapter *ifcvf = vf_to_adapter(hw); > > > + > > > +    ifc_iowrite16(qid, &cfg->queue_select); > > > +    ifc_iowrite16(vector, &cfg->queue_msix_vector); > > > +    if (ifc_ioread16(&cfg->queue_msix_vector) == > > > VIRTIO_MSI_NO_VECTOR) { > > > +        IFCVF_ERR(ifcvf->pdev, "No msix vector for queue %u\n", qid); > > > +            return -EINVAL; > > > +    } > > > > > > Let's leave this check for the caller, E.g can caller try to assign > > NO_VECTOR during uni-nit? > ifcvf driver sets NO_VECTOR when call hw_disable(). I am not sure whether I > get it, > Yes we can let the caller check a vq vector, however this may cause more > than three levels brackets, may looks ugly. > > > > > > > + > > > +    return 0; > > > +} > > > + > > > +int ifcvf_set_config_vector(struct ifcvf_hw *hw, int vector) > > > +{ > > > +    struct virtio_pci_common_cfg __iomem *cfg = hw->common_cfg; > > > +    struct ifcvf_adapter *ifcvf = vf_to_adapter(hw); > > > + > > > +    cfg = hw->common_cfg; > > > +    ifc_iowrite16(vector,  &cfg->msix_config); > > > +    if (ifc_ioread16(&cfg->msix_config) == VIRTIO_MSI_NO_VECTOR) { > > > +        IFCVF_ERR(ifcvf->pdev, "No msix vector for device config\n"); > > > +        return -EINVAL; > > > +    } > > > > > > Similar question as above. > > > > > > > + > > > +    return 0; > > > +} > > > + > > >   static void __iomem *get_cap_addr(struct ifcvf_hw *hw, > > >                     struct virtio_pci_cap *cap) > > >   { > > > @@ -140,6 +170,8 @@ int ifcvf_init_hw(struct ifcvf_hw *hw, struct > > > pci_dev *pdev) > > >             hw->common_cfg, hw->notify_base, hw->isr, > > >             hw->dev_cfg, hw->notify_off_multiplier); > > >   +    hw->vqs_shared_irq = -EINVAL; > > > + > > >       return 0; > > >   } > > >   @@ -321,12 +353,6 @@ static int ifcvf_hw_enable(struct ifcvf_hw *hw) > > >         ifcvf = vf_to_adapter(hw); > > >       cfg = hw->common_cfg; > > > -    ifc_iowrite16(IFCVF_MSI_CONFIG_OFF, &cfg->msix_config); > > > - > > > -    if (ifc_ioread16(&cfg->msix_config) == VIRTIO_MSI_NO_VECTOR) { > > > -        IFCVF_ERR(ifcvf->pdev, "No msix vector for device config\n"); > > > -        return -EINVAL; > > > -    } > > >         for (i = 0; i < hw->nr_vring; i++) { > > >           if (!hw->vring[i].ready) > > > @@ -340,15 +366,6 @@ static int ifcvf_hw_enable(struct ifcvf_hw *hw) > > >           ifc_iowrite64_twopart(hw->vring[i].used, &cfg->queue_used_lo, > > >                        &cfg->queue_used_hi); > > >           ifc_iowrite16(hw->vring[i].size, &cfg->queue_size); > > > -        ifc_iowrite16(i + IFCVF_MSI_QUEUE_OFF, > > > &cfg->queue_msix_vector); > > > - > > > -        if (ifc_ioread16(&cfg->queue_msix_vector) == > > > -            VIRTIO_MSI_NO_VECTOR) { > > > -            IFCVF_ERR(ifcvf->pdev, > > > -                  "No msix vector for queue %u\n", i); > > > -            return -EINVAL; > > > -        } > > > - > > >           ifcvf_set_vq_state(hw, i, hw->vring[i].last_avail_idx); > > >           ifc_iowrite16(1, &cfg->queue_enable); > > >       } > > > diff --git a/drivers/vdpa/ifcvf/ifcvf_base.h > > > b/drivers/vdpa/ifcvf/ifcvf_base.h > > > index 949b4fb9d554..9cfe088c82e9 100644 > > > --- a/drivers/vdpa/ifcvf/ifcvf_base.h > > > +++ b/drivers/vdpa/ifcvf/ifcvf_base.h > > > @@ -27,8 +27,6 @@ > > >     #define IFCVF_QUEUE_ALIGNMENT    PAGE_SIZE > > >   #define IFCVF_QUEUE_MAX        32768 > > > -#define IFCVF_MSI_CONFIG_OFF    0 > > > -#define IFCVF_MSI_QUEUE_OFF    1 > > >   #define IFCVF_PCI_MAX_RESOURCE    6 > > >     #define IFCVF_LM_CFG_SIZE        0x40 > > > @@ -42,6 +40,13 @@ > > >   #define ifcvf_private_to_vf(adapter) \ > > >       (&((struct ifcvf_adapter *)adapter)->vf) > > >   +/* all vqs and config interrupt has its own vector */ > > > +#define MSIX_VECTOR_PER_VQ_AND_CONFIG        1 > > > +/* all vqs share a vector, and config interrupt has a separate > > > vector */ > > > +#define MSIX_VECTOR_SHARED_VQ_AND_CONFIG    2 > > > +/* all vqs and config interrupt share a vector */ > > > +#define MSIX_VECTOR_DEV_SHARED            3 > > > > > > I think there's no much value to differ 2 from 3 consider config > > interrupt should be rare. > IMHO we still need 2 and 3, because MSIX_VECTOR_SHARED_VQ_AND_CONFIG means > there are at least 2 vectors, > the vqs share one vector, config change has its own vector. > MSIX_VECTOR_DEV_SHARED means three are only one vector, all vqs and config > changes need to share this vector. > > > > > > > > > + > > >   static inline u8 ifc_ioread8(u8 __iomem *addr) > > >   { > > >       return ioread8(addr); > > > @@ -97,25 +102,27 @@ struct ifcvf_hw { > > >       u8 __iomem *isr; > > >       /* Live migration */ > > >       u8 __iomem *lm_cfg; > > > -    u16 nr_vring; > > > > > > Any reason for moving nv_vring, config_size, and other stuffs? > for cacheline alignment. maybe a separate patch then. > > > > > > > > >       /* Notification bar number */ > > >       u8 notify_bar; > > > +    u8 msix_vector_status; > > > +    /* virtio-net or virtio-blk device config size */ > > > +    u32 config_size; > > >       /* Notificaiton bar address */ > > >       void __iomem *notify_base; > > >       phys_addr_t notify_base_pa; > > >       u32 notify_off_multiplier; > > > +    u32 dev_type; > > >       u64 req_features; > > >       u64 hw_features; > > > -    u32 dev_type; > > >       struct virtio_pci_common_cfg __iomem *common_cfg; > > >       void __iomem *dev_cfg; > > >       struct vring_info vring[IFCVF_MAX_QUEUES]; > > >       void __iomem * const *base; > > >       char config_msix_name[256]; > > >       struct vdpa_callback config_cb; > > > -    unsigned int config_irq; > > > -    /* virtio-net or virtio-blk device config size */ > > > -    u32 config_size; > > > +    int config_irq; > > > +    int vqs_shared_irq; > > > +    u16 nr_vring; > > >   }; > > >     struct ifcvf_adapter { > > > @@ -160,4 +167,6 @@ int ifcvf_set_vq_state(struct ifcvf_hw *hw, u16 > > > qid, u16 num); > > >   struct ifcvf_adapter *vf_to_adapter(struct ifcvf_hw *hw); > > >   int ifcvf_probed_virtio_net(struct ifcvf_hw *hw); > > >   u32 ifcvf_get_config_size(struct ifcvf_hw *hw); > > > +int ifcvf_set_vq_vector(struct ifcvf_hw *hw, u16 qid, int vector); > > > +int ifcvf_set_config_vector(struct ifcvf_hw *hw, int vector); > > >   #endif /* _IFCVF_H_ */ > > > diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c > > > b/drivers/vdpa/ifcvf/ifcvf_main.c > > > index 44c89ab0b6da..ca414399f040 100644 > > > --- a/drivers/vdpa/ifcvf/ifcvf_main.c > > > +++ b/drivers/vdpa/ifcvf/ifcvf_main.c > > > @@ -17,6 +17,7 @@ > > >   #define DRIVER_AUTHOR   "Intel Corporation" > > >   #define IFCVF_DRIVER_NAME       "ifcvf" > > >   +/* handles config interrupt */ > > > > > > This seems unrelated to the shared IRQ logic and it looks useless since > > it's easily to deduce it from the function name below. > OK, do you mean the comments? I can remove these comments. > > > > > > >   static irqreturn_t ifcvf_config_changed(int irq, void *arg) > > >   { > > >       struct ifcvf_hw *vf = arg; > > > @@ -27,6 +28,7 @@ static irqreturn_t ifcvf_config_changed(int irq, > > > void *arg) > > >       return IRQ_HANDLED; > > >   } > > >   +/* handles vqs interrupt */ > > > > > > So did this. > > > > > > >   static irqreturn_t ifcvf_intr_handler(int irq, void *arg) > > >   { > > >       struct vring_info *vring = arg; > > > @@ -37,24 +39,78 @@ static irqreturn_t ifcvf_intr_handler(int irq, > > > void *arg) > > >       return IRQ_HANDLED; > > >   } > > >   +/* handls vqs shared interrupt */ > > > +static irqreturn_t ifcvf_vq_shared_intr_handler(int irq, void *arg) > > > +{ > > > +    struct ifcvf_hw *vf = arg; > > > +    struct vring_info *vring; > > > +    int i; > > > + > > > +    for (i = 0; i < vf->nr_vring; i++) { > > > +        vring = &vf->vring[i]; > > > +        if (vring->cb.callback) > > > + vf->vring->cb.callback(vring->cb.private); > > > +    } > > > + > > > +    return IRQ_HANDLED; > > > +} > > > + > > > +/* handles a shared interrupt for vqs and config */ > > > +static irqreturn_t ifcvf_dev_shared_intr_handler(int irq, void *arg) > > > +{ > > > +    struct ifcvf_hw *vf = arg; > > > +    u8 isr; > > > + > > > +    isr = ifc_ioread8(vf->isr); > > > > > > We need to exactly what vp_interrupt do here. Checking against vf->isr > > first and return IRQ_NONE if it is not set. > > > > Always return IRQ_HANDLED will break the device who shares an irq with > > IFCVF. > as we discussed in another thread(spec inconsistency about ISR), ISR may > only works for INTx for now, > but VFs don't have INTx, and a VF may not share its vectors with other > devices, so I guess it can work > and may be our best try for now. > > > > > > > +    if (isr & VIRTIO_PCI_ISR_CONFIG) > > > +        ifcvf_config_changed(irq, arg); > > > + > > > +    return ifcvf_vq_shared_intr_handler(irq, arg); > > > +} > > > + > > >   static void ifcvf_free_irq_vectors(void *data) > > >   { > > >       pci_free_irq_vectors(data); > > >   } > > >   -static void ifcvf_free_irq(struct ifcvf_adapter *adapter, int queues) > > > +static void ifcvf_free_vq_irq(struct ifcvf_adapter *adapter, int > > > queues) > > >   { > > >       struct pci_dev *pdev = adapter->pdev; > > >       struct ifcvf_hw *vf = &adapter->vf; > > >       int i; > > >   +    if (vf->msix_vector_status == MSIX_VECTOR_PER_VQ_AND_CONFIG) { > > > +        for (i = 0; i < queues; i++) { > > > +            devm_free_irq(&pdev->dev, vf->vring[i].irq, &vf->vring[i]); > > > +            vf->vring[i].irq = -EINVAL; > > > +        } > > > +    } else { > > > +        devm_free_irq(&pdev->dev, vf->vqs_shared_irq, vf); > > > +        vf->vqs_shared_irq = -EINVAL; > > > +    } > > > +} > > >   -    for (i = 0; i < queues; i++) { > > > -        devm_free_irq(&pdev->dev, vf->vring[i].irq, &vf->vring[i]); > > > -        vf->vring[i].irq = -EINVAL; > > > +static void ifcvf_free_config_irq(struct ifcvf_adapter *adapter) > > > +{ > > > +    struct pci_dev *pdev = adapter->pdev; > > > +    struct ifcvf_hw *vf = &adapter->vf; > > > + > > > +    /* If the irq is shared by all vqs and the config interrupt, > > > +     * it is already freed in ifcvf_free_vq_irq, so here only > > > +     * need to free config irq when msix_vector_status != > > > MSIX_VECTOR_DEV_SHARED > > > +     */ > > > +    if (vf->msix_vector_status != MSIX_VECTOR_DEV_SHARED) { > > > +        devm_free_irq(&pdev->dev, vf->config_irq, vf); > > > +        vf->config_irq = -EINVAL; > > >       } > > > +} > > > + > > > +static void ifcvf_free_irq(struct ifcvf_adapter *adapter, int queues) > > > +{ > > > +    struct pci_dev *pdev = adapter->pdev; > > >   -    devm_free_irq(&pdev->dev, vf->config_irq, vf); > > > +    ifcvf_free_vq_irq(adapter, queues); > > > +    ifcvf_free_config_irq(adapter); > > >       ifcvf_free_irq_vectors(pdev); > > >   } > > >   @@ -86,58 +142,172 @@ static int ifcvf_alloc_vectors(struct > > > ifcvf_adapter *adapter) > > >       return ret; > > >   } > > >   -static int ifcvf_request_irq(struct ifcvf_adapter *adapter) > > > +static int ifcvf_request_per_vq_irq(struct ifcvf_adapter *adapter) > > >   { > > >       struct pci_dev *pdev = adapter->pdev; > > >       struct ifcvf_hw *vf = &adapter->vf; > > > -    int vector, nvectors, i, ret, irq; > > > -    u16 max_intr; > > > +    int i, vector, ret, irq; > > >   -    nvectors = ifcvf_alloc_vectors(adapter); > > > -    if (!(nvectors > 0)) > > > -        return nvectors; > > > +    for (i = 0; i < vf->nr_vring; i++) { > > > +        snprintf(vf->vring[i].msix_name, 256, "ifcvf[%s]-%d\n", > > > pci_name(pdev), i); > > > +        vector = i; > > > +        irq = pci_irq_vector(pdev, vector); > > > +        ret = devm_request_irq(&pdev->dev, irq, > > > +                       ifcvf_intr_handler, 0, > > > +                       vf->vring[i].msix_name, > > > +                       &vf->vring[i]); > > > +        if (ret) { > > > +            IFCVF_ERR(pdev, "Failed to request irq for vq %d\n", i); > > > +            ifcvf_free_vq_irq(adapter, i); > > > +        } else { > > > +            vf->vring[i].irq = irq; > > > +            ifcvf_set_vq_vector(vf, i, vector); > > > +        } > > > +    } > > >   -    max_intr = vf->nr_vring + 1; > > > +    vf->vqs_shared_irq = -EINVAL; > > > + > > > +    return 0; > > > +} > > > + > > > +static int ifcvf_request_shared_vq_irq(struct ifcvf_adapter *adapter) > > > +{ > > > +    struct pci_dev *pdev = adapter->pdev; > > > +    struct ifcvf_hw *vf = &adapter->vf; > > > +    int i, vector, ret, irq; > > > + > > > +    vector = 0; > > > +    /* reuse msix_name[256] space of vring0 to store shared vqs > > > interrupt name */ > > > > > > I think we can remove this comment since the code is straightforward. > sure > > > > > > > + snprintf(vf->vring[0].msix_name, 256, > > > "ifcvf[%s]-vqs-shared-irq\n", pci_name(pdev)); > > > +    irq = pci_irq_vector(pdev, vector); > > > +    ret = devm_request_irq(&pdev->dev, irq, > > > +                   ifcvf_vq_shared_intr_handler, 0, > > > +                   vf->vring[0].msix_name, vf); > > > +    if (ret) { > > > +        IFCVF_ERR(pdev, "Failed to request shared irq for vf\n"); > > > + > > > +        return ret; > > > +    } > > > + > > > +    vf->vqs_shared_irq = irq; > > > +    for (i = 0; i < vf->nr_vring; i++) { > > > +        vf->vring[i].irq = -EINVAL; > > > +        ifcvf_set_vq_vector(vf, i, vector); > > > +    } > > > + > > > +    return 0; > > > + > > > +} > > > + > > > +static int ifcvf_request_dev_shared_irq(struct ifcvf_adapter *adapter) > > > +{ > > > +    struct pci_dev *pdev = adapter->pdev; > > > +    struct ifcvf_hw *vf = &adapter->vf; > > > +    int i, vector, ret, irq; > > > + > > > +    vector = 0; > > > +    /* reuse msix_name[256] space of vring0 to store shared device > > > interrupt name */ > > > +    snprintf(vf->vring[0].msix_name, 256, > > > "ifcvf[%s]-dev-shared-irq\n", pci_name(pdev)); > > > +    irq = pci_irq_vector(pdev, vector); > > > +    ret = devm_request_irq(&pdev->dev, irq, > > > +                   ifcvf_dev_shared_intr_handler, 0, > > > +                   vf->vring[0].msix_name, vf); > > > +    if (ret) { > > > +        IFCVF_ERR(pdev, "Failed to request shared irq for vf\n"); > > >   -    ret = pci_alloc_irq_vectors(pdev, max_intr, > > > -                    max_intr, PCI_IRQ_MSIX); > > > -    if (ret < 0) { > > > -        IFCVF_ERR(pdev, "Failed to alloc IRQ vectors\n"); > > >           return ret; > > >       } > > >   +    vf->vqs_shared_irq = irq; > > > +    for (i = 0; i < vf->nr_vring; i++) { > > > +        vf->vring[i].irq = -EINVAL; > > > +        ifcvf_set_vq_vector(vf, i, vector); > > > +    } > > > + > > > +    vf->config_irq = irq; > > > +    ifcvf_set_config_vector(vf, vector); > > > + > > > +    return 0; > > > + > > > +} > > > + > > > +static int ifcvf_request_vq_irq(struct ifcvf_adapter *adapter) > > > +{ > > > +    struct ifcvf_hw *vf = &adapter->vf; > > > +    int ret; > > > + > > > +    if (vf->msix_vector_status == MSIX_VECTOR_PER_VQ_AND_CONFIG) > > > +        ret = ifcvf_request_per_vq_irq(adapter); > > > +    else > > > +        ret = ifcvf_request_shared_vq_irq(adapter); > > > + > > > +    return ret; > > > +} > > > + > > > +static int ifcvf_request_config_irq(struct ifcvf_adapter *adapter) > > > +{ > > > +    struct pci_dev *pdev = adapter->pdev; > > > +    struct ifcvf_hw *vf = &adapter->vf; > > > +    int config_vector, ret; > > > + > > > +    if (vf->msix_vector_status == MSIX_VECTOR_DEV_SHARED) > > > +        return 0; > > > + > > > +    if (vf->msix_vector_status == MSIX_VECTOR_PER_VQ_AND_CONFIG) > > > +        /* vector 0 ~ vf->nr_vring for vqs, num vf->nr_vring vector > > > for config interrupt */ > > > +        config_vector = vf->nr_vring; > > > + > > > +    if (vf->msix_vector_status == MSIX_VECTOR_SHARED_VQ_AND_CONFIG) > > > +        /* vector 0 for vqs and 1 for config interrupt */ > > > +        config_vector = 1; > > > + > > >       snprintf(vf->config_msix_name, 256, "ifcvf[%s]-config\n", > > >            pci_name(pdev)); > > > -    vector = 0; > > > -    vf->config_irq = pci_irq_vector(pdev, vector); > > > +    vf->config_irq = pci_irq_vector(pdev, config_vector); > > >       ret = devm_request_irq(&pdev->dev, vf->config_irq, > > >                      ifcvf_config_changed, 0, > > >                      vf->config_msix_name, vf); > > >       if (ret) { > > >           IFCVF_ERR(pdev, "Failed to request config irq\n"); > > > +        ifcvf_free_vq_irq(adapter, vf->nr_vring); > > >           return ret; > > >       } > > >   -    for (i = 0; i < vf->nr_vring; i++) { > > > -        snprintf(vf->vring[i].msix_name, 256, "ifcvf[%s]-%d\n", > > > -             pci_name(pdev), i); > > > -        vector = i + IFCVF_MSI_QUEUE_OFF; > > > -        irq = pci_irq_vector(pdev, vector); > > > -        ret = devm_request_irq(&pdev->dev, irq, > > > -                       ifcvf_intr_handler, 0, > > > -                       vf->vring[i].msix_name, > > > -                       &vf->vring[i]); > > > -        if (ret) { > > > -            IFCVF_ERR(pdev, > > > -                  "Failed to request irq for vq %d\n", i); > > > -            ifcvf_free_irq(adapter, i); > > > +    ifcvf_set_config_vector(vf, config_vector); > > >   -            return ret; > > > -        } > > > +    return 0; > > > +} > > > + > > > +static int ifcvf_request_irq(struct ifcvf_adapter *adapter) > > > +{ > > > > > > As replied above, I think having two modes should be sufficient and the > > code could be greatly simplified. > Do you mean if we don't get enough vectors, just use only one vector for the > vqs and config changes? I guess this > only works if ISR work for MSIX as we expects, or we may waste some time in > the device config space. > > Thanks, > Zhu Lingshan > > > > Thanks > > > > > > > +    struct ifcvf_hw *vf = &adapter->vf; > > > +    int nvectors, ret, max_intr; > > >   -        vf->vring[i].irq = irq; > > > +    nvectors = ifcvf_alloc_vectors(adapter); > > > +    if (!(nvectors > 0)) > > > +        return nvectors; > > > + > > > +    vf->msix_vector_status = MSIX_VECTOR_PER_VQ_AND_CONFIG; > > > +    max_intr = vf->nr_vring + 1; > > > +    if (nvectors < max_intr) > > > +        vf->msix_vector_status = MSIX_VECTOR_SHARED_VQ_AND_CONFIG; > > > + > > > +    if (nvectors == 1) { > > > +        vf->msix_vector_status = MSIX_VECTOR_DEV_SHARED; > > > +        ret = ifcvf_request_dev_shared_irq(adapter); > > > + > > > +        return ret; > > >       } > > >   +    ret = ifcvf_request_vq_irq(adapter); > > > +    if (ret) > > > +        return ret; > > > + > > > +    ret = ifcvf_request_config_irq(adapter); > > > + > > > +    if (ret) > > > +        return ret; > > > + > > >       return 0; > > >   } > > >   @@ -441,7 +611,10 @@ static int ifcvf_vdpa_get_vq_irq(struct > > > vdpa_device *vdpa_dev, > > >   { > > >       struct ifcvf_hw *vf = vdpa_to_vf(vdpa_dev); > > >   -    return vf->vring[qid].irq; > > > +    if (vf->vqs_shared_irq < 0) > > > +        return vf->vring[qid].irq; > > > +    else > > > +        return -EINVAL; > > >   } > > >     static struct vdpa_notification_area > > > ifcvf_get_vq_notification(struct vdpa_device *vdpa_dev, > > > > _______________________________________________ > > Virtualization mailing list > > Virtualization@lists.linux-foundation.org > > https://lists.linuxfoundation.org/mailman/listinfo/virtualization