From: Stephen Hemminger <stephen@networkplumber.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: netdev@vger.kernel.org, Roopa Prabhu <roopa@nvidia.com>,
Nikolay Aleksandrov <nikolay@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH net-next] net: bridge: vlan: check for errors from __vlan_del in __vlan_flush
Date: Mon, 14 Feb 2022 15:52:05 -0800 [thread overview]
Message-ID: <20220214155205.22135ebb@hermes.local> (raw)
In-Reply-To: <20220214233646.1592855-1-vladimir.oltean@nxp.com>
On Tue, 15 Feb 2022 01:36:46 +0200
Vladimir Oltean <vladimir.oltean@nxp.com> wrote:
> + if (err) {
> + br_err(br,
> + "port %u(%s) failed to delete vlan %d: %pe\n",
> + (unsigned int) p->port_no, p->dev->name,
> + vlan->vid, ERR_PTR(err));
Don't understand this last argument here.
It takes an integer error number, then converts it to an error pointer
just so the error message can then decode with %pe? Why?
next prev parent reply other threads:[~2022-02-14 23:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 23:36 [PATCH net-next] net: bridge: vlan: check for errors from __vlan_del in __vlan_flush Vladimir Oltean
2022-02-14 23:52 ` Stephen Hemminger [this message]
2022-02-14 23:58 ` Vladimir Oltean
2022-02-15 14:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220214155205.22135ebb@hermes.local \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=roopa@nvidia.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.