From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B29FCC433EF for ; Tue, 15 Feb 2022 14:29:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 48B744034B; Tue, 15 Feb 2022 14:29:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QlJhNdORcSsJ; Tue, 15 Feb 2022 14:29:19 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp2.osuosl.org (Postfix) with ESMTPS id 793234016A; Tue, 15 Feb 2022 14:29:18 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 531A2C001A; Tue, 15 Feb 2022 14:29:18 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [IPv6:2605:bc80:3010::136]) by lists.linuxfoundation.org (Postfix) with ESMTP id 0F852C000B for ; Tue, 15 Feb 2022 14:29:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id D74ED60FBD for ; Tue, 15 Feb 2022 14:29:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp3.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EDGJC6eFKXOQ for ; Tue, 15 Feb 2022 14:29:15 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by smtp3.osuosl.org (Postfix) with ESMTPS id EAB8E60FB9 for ; Tue, 15 Feb 2022 14:29:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644935353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aJaT7tTiIAUHk5Poe1JvEf9JYY6BY3ufsdneAooVC6s=; b=idp4/ihNXRHm3LgEJhL1itN/vP3HhKH/FQF1Evvt+gBF1XxLV1bIXFxUGxK4mmCt6gwq99 obGSbhjjSUWiYSOuS58Xmx9GODnSWb3qskLPfjOfiuRIGyuW014nu/Zh4vX8DlHJXkV5gL swFG35oyL1Gi8knizf50qJjCr4wN6jA= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-360-2utEv0LCNpOfS2UCl2WCIA-1; Tue, 15 Feb 2022 09:29:12 -0500 X-MC-Unique: 2utEv0LCNpOfS2UCl2WCIA-1 Received: by mail-ed1-f69.google.com with SMTP id j10-20020a05640211ca00b004090fd8a936so7863875edw.23 for ; Tue, 15 Feb 2022 06:29:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=aJaT7tTiIAUHk5Poe1JvEf9JYY6BY3ufsdneAooVC6s=; b=OOzhONrp/k/k1uFOoPuNJymIKTKv/1Zr4zjChKMgRFE1eE/ItqvMh11nH0ul2c9kj4 SBp2FYlZCiXXCsmGJIuRQvsOKfWB1BTnuYA3CEu7x5KyJqm2JFZ3MyPUE+4UzLP4zxOS u8M3V5ulDsqYpbqbL0ajO9ypSZ17iyKR+qdC0LgSLDY1eObf6sKi2uyJe1GwsVkAGaAd lecA24gh/G8IKWB8x4id1cpXbGjknC45Gj2UErjw0ck3sRU0uFbcq9s6WP8DTiZMbBl5 uCpxZaUY3v5AQjovxmM851Wt48MVBArziErnSe3oqb9VHbrA+TzuFHNvaEyE3Tij7JvT U6ig== X-Gm-Message-State: AOAM531g+ZU27ggVzHPxw9IIS5iawCi/HlEFdMaXzWGb35dKAgZ5AIYK Z2M7GQup8b8Xmvq+UYMp1K/S3RZ3OuTpAr4EMkNCCrE4s/VnXgfVL5SL39275d4xQugoNpzrvz+ lGeHIJczMGUSjriReqUIY9FIoyXTw+28FAVMvbiCjag== X-Received: by 2002:a17:906:135a:: with SMTP id x26mr1315253ejb.325.1644935350716; Tue, 15 Feb 2022 06:29:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJwo2EJpQoaVBkF0I4043ub23NV8B2eqRsSc+WMFLJ+57JIiIcdevZMu6B65nzRu2rLTKRWHQQ== X-Received: by 2002:a17:906:135a:: with SMTP id x26mr1315228ejb.325.1644935350315; Tue, 15 Feb 2022 06:29:10 -0800 (PST) Received: from redhat.com ([2a03:c5c0:207e:b00c:b5b3:fd4c:a2cd:10e5]) by smtp.gmail.com with ESMTPSA id e15sm2991485edz.104.2022.02.15.06.29.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Feb 2022 06:29:08 -0800 (PST) Date: Tue, 15 Feb 2022 09:29:05 -0500 From: "Michael S. Tsirkin" To: Jason Wang Subject: Re: [PATCH V4 4/4] vDPA/ifcvf: implement shared IRQ feature Message-ID: <20220215092846-mutt-send-email-mst@kernel.org> References: <20220203072735.189716-1-lingshan.zhu@intel.com> <20220203072735.189716-5-lingshan.zhu@intel.com> <20220214091842-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 In-Reply-To: Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=mst@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: netdev , Zhu Lingshan , virtualization X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" T24gVHVlLCBGZWIgMTUsIDIwMjIgYXQgMTE6MzQ6MzFBTSArMDgwMCwgSmFzb24gV2FuZyB3cm90 ZToKPiBPbiBNb24sIEZlYiAxNCwgMjAyMiBhdCAxMDoyNSBQTSBNaWNoYWVsIFMuIFRzaXJraW4g PG1zdEByZWRoYXQuY29tPiB3cm90ZToKPiA+Cj4gPiBPbiBNb24sIEZlYiAxNCwgMjAyMiBhdCAw MzoxOToyNVBNICswODAwLCBKYXNvbiBXYW5nIHdyb3RlOgo+ID4gPgo+ID4gPiDlnKggMjAyMi8y LzMg5LiL5Y2IMzoyNywgWmh1IExpbmdzaGFuIOWGmemBkzoKPiA+ID4gPiBPbiBzb21lIHBsYXRm b3Jtcy9kZXZpY2VzLCB0aGVyZSBtYXkgbm90IGJlIGVub3VnaCBNU0kgdmVjdG9yCj4gPiA+ID4g c2xvdHMgYWxsb2NhdGVkIGZvciB2aXJ0cXVldWVzIGFuZCBjb25maWcgY2hhbmdlcy4gSW4gc3Vj aCBhIGNhc2UsCj4gPiA+ID4gdGhlIGludGVycnVwdCBzb3VyY2VzKHZpcnRxdWV1ZXMsIGNvbmZp ZyBjaGFuZ2VzKSBtdXN0IHNoYXJlCj4gPiA+ID4gYW4gSVJRL3ZlY3RvciwgdG8gYXZvaWQgaW5p dGlhbGl6YXRpb24gZmFpbHVyZXMsIGtlZXAKPiA+ID4gPiB0aGUgZGV2aWNlIGZ1bmN0aW9uYWwu Cj4gPiA+ID4KPiA+ID4gPiBUaGlzIGNvbW1pdCBoYW5kbGVzIHRocmVlIGNhc2VzOgo+ID4gPiA+ ICgxKSBudW1iZXIgb2YgdGhlIGFsbG9jYXRlZCB2ZWN0b3JzID09IHRoZSBudW1iZXIgb2Ygdmly dHF1ZXVlcyArIDEKPiA+ID4gPiAoY29uZmlnIGNoYW5nZXMpLCBldmVyeSB2aXJ0cXVldWUgYW5k IHRoZSBjb25maWcgaW50ZXJydXB0IGhhcwo+ID4gPiA+IGEgc2VwYXJhdGVkIHZlY3Rvci9JUlEs IHRoZSBiZXN0IGFuZCB0aGUgbW9zdCBsaWtlbHkgY2FzZS4KPiA+ID4gPiAoMikgbnVtYmVyIG9m IHRoZSBhbGxvY2F0ZWQgdmVjdG9ycyBpcyBsZXNzIHRoYW4gdGhlIGJlc3QgY2FzZSwgYnV0Cj4g PiA+ID4gZ3JlYXRlciB0aGFuIDEuIEluIHRoaXMgY2FzZSwgYWxsIHZpcnRxdWV1ZXMgc2hhcmUg YSB2ZWN0b3IvSVJRLAo+ID4gPiA+IHRoZSBjb25maWcgaW50ZXJydXB0IGhhcyBhIHNlcGFyYXRl ZCB2ZWN0b3IvSVJRCj4gPiA+ID4gKDMpIG9ubHkgb25lIHZlY3RvciBpcyBhbGxvY2F0ZWQsIGlu IHRoaXMgY2FzZSwgdGhlIHZpcnRxdWV1ZXMgYW5kCj4gPiA+ID4gdGhlIGNvbmZpZyBpbnRlcnJ1 cHQgc2hhcmUgYSB2ZWN0b3IvSVJRLiBUaGUgd29yc3QgYW5kIG1vc3QKPiA+ID4gPiB1bmxpa2Vs eSBjYXNlLgo+ID4gPiA+Cj4gPiA+ID4gT3RoZXJ3aXNlLCBpdCBuZWVkcyB0byBmYWlsLgo+ID4g PiA+Cj4gPiA+ID4gVGhpcyBjb21taXQgaW50cm9kdWNlcyBzb21lIGhlbHBlciBmdW5jdGlvbnM6 Cj4gPiA+ID4gaWZjdmZfc2V0X3ZxX3ZlY3RvcigpIGFuZCBpZmN2Zl9zZXRfY29uZmlnX3ZlY3Rv cigpIHNldHMgdmlydHF1ZXVlCj4gPiA+ID4gdmVjdG9yIGFuZCBjb25maWcgdmVjdG9yIGluIHRo ZSBkZXZpY2UgY29uZmlnIHNwYWNlLCBzbyB0aGF0Cj4gPiA+ID4gdGhlIGRldmljZSBjYW4gc2Vu ZCBpbnRlcnJ1cHQgRE1BLgo+ID4gPiA+Cj4gPiA+ID4gVGhpcyBjb21taXQgYWRkcyBzb21lIGZp ZWxkcyBpbiBzdHJ1Y3QgaWZjdmZfaHcgYW5kIHJlLXBsYWNlZAo+ID4gPiA+IHRoZSBleGlzdGVk IGZpZWxkcyB0byBiZSBhbGlnbmVkIHdpdGggdGhlIGNhY2hlbGluZS4KPiA+ID4gPgo+ID4gPiA+ IFNpZ25lZC1vZmYtYnk6IFpodSBMaW5nc2hhbiA8bGluZ3NoYW4uemh1QGludGVsLmNvbT4KPiA+ ID4gPiAtLS0KPiA+ID4gPiAgIGRyaXZlcnMvdmRwYS9pZmN2Zi9pZmN2Zl9iYXNlLmMgfCAgNDcg KysrKy0tCj4gPiA+ID4gICBkcml2ZXJzL3ZkcGEvaWZjdmYvaWZjdmZfYmFzZS5oIHwgIDIzICsr LQo+ID4gPiA+ICAgZHJpdmVycy92ZHBhL2lmY3ZmL2lmY3ZmX21haW4uYyB8IDI0MyArKysrKysr KysrKysrKysrKysrKysrKysrKystLS0tLQo+ID4gPiA+ICAgMyBmaWxlcyBjaGFuZ2VkLCAyNTYg aW5zZXJ0aW9ucygrKSwgNTcgZGVsZXRpb25zKC0pCj4gPiA+ID4KPiA+ID4gPiBkaWZmIC0tZ2l0 IGEvZHJpdmVycy92ZHBhL2lmY3ZmL2lmY3ZmX2Jhc2UuYyBiL2RyaXZlcnMvdmRwYS9pZmN2Zi9p ZmN2Zl9iYXNlLmMKPiA+ID4gPiBpbmRleCAzOTc2OTJhZTY3MWMuLjE4ZGNiNjNhYjFlMyAxMDA2 NDQKPiA+ID4gPiAtLS0gYS9kcml2ZXJzL3ZkcGEvaWZjdmYvaWZjdmZfYmFzZS5jCj4gPiA+ID4g KysrIGIvZHJpdmVycy92ZHBhL2lmY3ZmL2lmY3ZmX2Jhc2UuYwo+ID4gPiA+IEBAIC0xNSw2ICsx NSwzNiBAQCBzdHJ1Y3QgaWZjdmZfYWRhcHRlciAqdmZfdG9fYWRhcHRlcihzdHJ1Y3QgaWZjdmZf aHcgKmh3KQo+ID4gPiA+ICAgICByZXR1cm4gY29udGFpbmVyX29mKGh3LCBzdHJ1Y3QgaWZjdmZf YWRhcHRlciwgdmYpOwo+ID4gPiA+ICAgfQo+ID4gPiA+ICtpbnQgaWZjdmZfc2V0X3ZxX3ZlY3Rv cihzdHJ1Y3QgaWZjdmZfaHcgKmh3LCB1MTYgcWlkLCBpbnQgdmVjdG9yKQo+ID4gPiA+ICt7Cj4g PiA+ID4gKyAgIHN0cnVjdCB2aXJ0aW9fcGNpX2NvbW1vbl9jZmcgX19pb21lbSAqY2ZnID0gaHct PmNvbW1vbl9jZmc7Cj4gPiA+ID4gKyAgIHN0cnVjdCBpZmN2Zl9hZGFwdGVyICppZmN2ZiA9IHZm X3RvX2FkYXB0ZXIoaHcpOwo+ID4gPiA+ICsKPiA+ID4gPiArICAgaWZjX2lvd3JpdGUxNihxaWQs ICZjZmctPnF1ZXVlX3NlbGVjdCk7Cj4gPiA+ID4gKyAgIGlmY19pb3dyaXRlMTYodmVjdG9yLCAm Y2ZnLT5xdWV1ZV9tc2l4X3ZlY3Rvcik7Cj4gPiA+ID4gKyAgIGlmIChpZmNfaW9yZWFkMTYoJmNm Zy0+cXVldWVfbXNpeF92ZWN0b3IpID09IFZJUlRJT19NU0lfTk9fVkVDVE9SKSB7Cj4gPiA+ID4g KyAgICAgICAgICAgSUZDVkZfRVJSKGlmY3ZmLT5wZGV2LCAiTm8gbXNpeCB2ZWN0b3IgZm9yIHF1 ZXVlICV1XG4iLCBxaWQpOwo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgcmV0dXJuIC1FSU5W QUw7Cj4gPiA+ID4gKyAgIH0KPiA+ID4KPiA+ID4KPiA+ID4gTGV0J3MgbGVhdmUgdGhpcyBjaGVj ayBmb3IgdGhlIGNhbGxlciwgRS5nIGNhbiBjYWxsZXIgdHJ5IHRvIGFzc2lnbgo+ID4gPiBOT19W RUNUT1IgZHVyaW5nIHVuaS1uaXQ/Cj4gPgo+ID4KPiA+IEhtbSBJJ20gbm90IHN1cmUgSSBhZ3Jl ZS4gQ2FsbGVyIHdpbGwgaGF2ZSB0byB3cml0ZSBxdWV1ZSBzZWxlY3QKPiA+IGFnYWluLCBhbmQg dGhhdCdzIGFuIGV4dHJhIElPLCB3aGljaCBpcyBhIHdhc3RlLgo+ID4gQW5kIGhhdmluZyBmdW5j dGlvbiBjaGVja2luZyBpdHNlbGYganVzdCBzZWVtcyBiZXR0ZXIgY29udGFpbmVkLgo+IAo+IEl0 J3MgYXMgc2ltcGxlIGFzIGp1c3QgcmV0dXJuIHdoYXQgd2UgcmVhZCBoZXJlIGxpa2UgdmlydGlv X3BjaSBkaWQ6Cj4gCj4gdTE2IHZwX21vZGVybl9xdWV1ZV92ZWN0b3Ioc3RydWN0IHZpcnRpb19w Y2lfbW9kZXJuX2RldmljZSAqbWRldiwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICB1MTYg aW5kZXgsIHUxNiB2ZWN0b3IpCj4gewo+ICAgICAgICAgc3RydWN0IHZpcnRpb19wY2lfY29tbW9u X2NmZyBfX2lvbWVtICpjZmcgPSBtZGV2LT5jb21tb247Cj4gCj4gICAgICAgICB2cF9pb3dyaXRl MTYoaW5kZXgsICZjZmctPnF1ZXVlX3NlbGVjdCk7Cj4gICAgICAgICB2cF9pb3dyaXRlMTYodmVj dG9yLCAmY2ZnLT5xdWV1ZV9tc2l4X3ZlY3Rvcik7Cj4gICAgICAgICAvKiBGbHVzaCB0aGUgd3Jp dGUgb3V0IHRvIGRldmljZSAqLwo+ICAgICAgICAgcmV0dXJuIHZwX2lvcmVhZDE2KCZjZmctPnF1 ZXVlX21zaXhfdmVjdG9yKTsKPiB9Cj4gRVhQT1JUX1NZTUJPTF9HUEwodnBfbW9kZXJuX3F1ZXVl X3ZlY3Rvcik7CgoKVGhhdCB3b3VsZCBiZSBvay4KCj4gVGhlbiB0aGUgY2FsbGVyIGNhbiBkZWNp ZGUgdG8gY2hlY2sgaXQgd2l0aCBOT19WRUNUT1IgaWYgbmVlZGVkLgo+IEN1cnJlbnQgY29kZSB3 aWxsIGJyZWFrIHRoZSBjYWxsZXJzIHRoYXQgd2FudCB0byBzZXQgTk9fVkVDVE9SLgo+IAo+ID4K PiA+ID4KPiA+ID4gPiArCj4gPiA+ID4gKyAgIHJldHVybiAwOwo+ID4gPiA+ICt9Cj4gPiA+ID4g Kwo+ID4gPiA+ICtpbnQgaWZjdmZfc2V0X2NvbmZpZ192ZWN0b3Ioc3RydWN0IGlmY3ZmX2h3ICpo dywgaW50IHZlY3RvcikKPiA+ID4gPiArewo+ID4gPiA+ICsgICBzdHJ1Y3QgdmlydGlvX3BjaV9j b21tb25fY2ZnIF9faW9tZW0gKmNmZyA9IGh3LT5jb21tb25fY2ZnOwo+ID4gPiA+ICsgICBzdHJ1 Y3QgaWZjdmZfYWRhcHRlciAqaWZjdmYgPSB2Zl90b19hZGFwdGVyKGh3KTsKPiA+ID4gPiArCj4g PiA+ID4gKyAgIGNmZyA9IGh3LT5jb21tb25fY2ZnOwo+ID4gPiA+ICsgICBpZmNfaW93cml0ZTE2 KHZlY3RvciwgICZjZmctPm1zaXhfY29uZmlnKTsKPiA+ID4gPiArICAgaWYgKGlmY19pb3JlYWQx NigmY2ZnLT5tc2l4X2NvbmZpZykgPT0gVklSVElPX01TSV9OT19WRUNUT1IpIHsKPiA+ID4gPiAr ICAgICAgICAgICBJRkNWRl9FUlIoaWZjdmYtPnBkZXYsICJObyBtc2l4IHZlY3RvciBmb3IgZGV2 aWNlIGNvbmZpZ1xuIik7Cj4gPiA+ID4gKyAgICAgICAgICAgcmV0dXJuIC1FSU5WQUw7Cj4gPiA+ ID4gKyAgIH0KPiA+ID4KPiA+ID4KPiA+ID4gU2ltaWxhciBxdWVzdGlvbiBhcyBhYm92ZS4KPiA+ ID4KPiA+ID4KPiA+ID4gPiArCj4gPiA+ID4gKyAgIHJldHVybiAwOwo+ID4gPiA+ICt9Cj4gPiA+ ID4gKwo+ID4gPiA+ICAgc3RhdGljIHZvaWQgX19pb21lbSAqZ2V0X2NhcF9hZGRyKHN0cnVjdCBp ZmN2Zl9odyAqaHcsCj4gPiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgc3RydWN0 IHZpcnRpb19wY2lfY2FwICpjYXApCj4gPiA+ID4gICB7Cj4gPiA+ID4gQEAgLTE0MCw2ICsxNzAs OCBAQCBpbnQgaWZjdmZfaW5pdF9odyhzdHJ1Y3QgaWZjdmZfaHcgKmh3LCBzdHJ1Y3QgcGNpX2Rl diAqcGRldikKPiA+ID4gPiAgICAgICAgICAgICAgIGh3LT5jb21tb25fY2ZnLCBody0+bm90aWZ5 X2Jhc2UsIGh3LT5pc3IsCj4gPiA+ID4gICAgICAgICAgICAgICBody0+ZGV2X2NmZywgaHctPm5v dGlmeV9vZmZfbXVsdGlwbGllcik7Cj4gPiA+ID4gKyAgIGh3LT52cXNfc2hhcmVkX2lycSA9IC1F SU5WQUw7Cj4gPiA+ID4gKwo+ID4gPiA+ICAgICByZXR1cm4gMDsKPiA+ID4gPiAgIH0KPiA+ID4g PiBAQCAtMzIxLDEyICszNTMsNiBAQCBzdGF0aWMgaW50IGlmY3ZmX2h3X2VuYWJsZShzdHJ1Y3Qg aWZjdmZfaHcgKmh3KQo+ID4gPiA+ICAgICBpZmN2ZiA9IHZmX3RvX2FkYXB0ZXIoaHcpOwo+ID4g PiA+ICAgICBjZmcgPSBody0+Y29tbW9uX2NmZzsKPiA+ID4gPiAtICAgaWZjX2lvd3JpdGUxNihJ RkNWRl9NU0lfQ09ORklHX09GRiwgJmNmZy0+bXNpeF9jb25maWcpOwo+ID4gPiA+IC0KPiA+ID4g PiAtICAgaWYgKGlmY19pb3JlYWQxNigmY2ZnLT5tc2l4X2NvbmZpZykgPT0gVklSVElPX01TSV9O T19WRUNUT1IpIHsKPiA+ID4gPiAtICAgICAgICAgICBJRkNWRl9FUlIoaWZjdmYtPnBkZXYsICJO byBtc2l4IHZlY3RvciBmb3IgZGV2aWNlIGNvbmZpZ1xuIik7Cj4gPiA+ID4gLSAgICAgICAgICAg cmV0dXJuIC1FSU5WQUw7Cj4gPiA+ID4gLSAgIH0KPiA+ID4gPiAgICAgZm9yIChpID0gMDsgaSA8 IGh3LT5ucl92cmluZzsgaSsrKSB7Cj4gPiA+ID4gICAgICAgICAgICAgaWYgKCFody0+dnJpbmdb aV0ucmVhZHkpCj4gPiA+ID4gQEAgLTM0MCwxNSArMzY2LDYgQEAgc3RhdGljIGludCBpZmN2Zl9o d19lbmFibGUoc3RydWN0IGlmY3ZmX2h3ICpodykKPiA+ID4gPiAgICAgICAgICAgICBpZmNfaW93 cml0ZTY0X3R3b3BhcnQoaHctPnZyaW5nW2ldLnVzZWQsICZjZmctPnF1ZXVlX3VzZWRfbG8sCj4g PiA+ID4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJmNmZy0+cXVldWVfdXNlZF9o aSk7Cj4gPiA+ID4gICAgICAgICAgICAgaWZjX2lvd3JpdGUxNihody0+dnJpbmdbaV0uc2l6ZSwg JmNmZy0+cXVldWVfc2l6ZSk7Cj4gPiA+ID4gLSAgICAgICAgICAgaWZjX2lvd3JpdGUxNihpICsg SUZDVkZfTVNJX1FVRVVFX09GRiwgJmNmZy0+cXVldWVfbXNpeF92ZWN0b3IpOwo+ID4gPiA+IC0K PiA+ID4gPiAtICAgICAgICAgICBpZiAoaWZjX2lvcmVhZDE2KCZjZmctPnF1ZXVlX21zaXhfdmVj dG9yKSA9PQo+ID4gPiA+IC0gICAgICAgICAgICAgICBWSVJUSU9fTVNJX05PX1ZFQ1RPUikgewo+ ID4gPiA+IC0gICAgICAgICAgICAgICAgICAgSUZDVkZfRVJSKGlmY3ZmLT5wZGV2LAo+ID4gPiA+ IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICJObyBtc2l4IHZlY3RvciBmb3IgcXVldWUg JXVcbiIsIGkpOwo+ID4gPiA+IC0gICAgICAgICAgICAgICAgICAgcmV0dXJuIC1FSU5WQUw7Cj4g PiA+ID4gLSAgICAgICAgICAgfQo+ID4gPiA+IC0KPiA+ID4gPiAgICAgICAgICAgICBpZmN2Zl9z ZXRfdnFfc3RhdGUoaHcsIGksIGh3LT52cmluZ1tpXS5sYXN0X2F2YWlsX2lkeCk7Cj4gPiA+ID4g ICAgICAgICAgICAgaWZjX2lvd3JpdGUxNigxLCAmY2ZnLT5xdWV1ZV9lbmFibGUpOwo+ID4gPiA+ ICAgICB9Cj4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvdmRwYS9pZmN2Zi9pZmN2Zl9iYXNl LmggYi9kcml2ZXJzL3ZkcGEvaWZjdmYvaWZjdmZfYmFzZS5oCj4gPiA+ID4gaW5kZXggOTQ5YjRm YjlkNTU0Li45Y2ZlMDg4YzgyZTkgMTAwNjQ0Cj4gPiA+ID4gLS0tIGEvZHJpdmVycy92ZHBhL2lm Y3ZmL2lmY3ZmX2Jhc2UuaAo+ID4gPiA+ICsrKyBiL2RyaXZlcnMvdmRwYS9pZmN2Zi9pZmN2Zl9i YXNlLmgKPiA+ID4gPiBAQCAtMjcsOCArMjcsNiBAQAo+ID4gPiA+ICAgI2RlZmluZSBJRkNWRl9R VUVVRV9BTElHTk1FTlQgICAgIFBBR0VfU0laRQo+ID4gPiA+ICAgI2RlZmluZSBJRkNWRl9RVUVV RV9NQVggICAgICAgICAgIDMyNzY4Cj4gPiA+ID4gLSNkZWZpbmUgSUZDVkZfTVNJX0NPTkZJR19P RkYgICAgICAgMAo+ID4gPiA+IC0jZGVmaW5lIElGQ1ZGX01TSV9RVUVVRV9PRkYgICAgICAgIDEK PiA+ID4gPiAgICNkZWZpbmUgSUZDVkZfUENJX01BWF9SRVNPVVJDRSAgICA2Cj4gPiA+ID4gICAj ZGVmaW5lIElGQ1ZGX0xNX0NGR19TSVpFICAgICAgICAgMHg0MAo+ID4gPiA+IEBAIC00Miw2ICs0 MCwxMyBAQAo+ID4gPiA+ICAgI2RlZmluZSBpZmN2Zl9wcml2YXRlX3RvX3ZmKGFkYXB0ZXIpIFwK PiA+ID4gPiAgICAgKCYoKHN0cnVjdCBpZmN2Zl9hZGFwdGVyICopYWRhcHRlciktPnZmKQo+ID4g PiA+ICsvKiBhbGwgdnFzIGFuZCBjb25maWcgaW50ZXJydXB0IGhhcyBpdHMgb3duIHZlY3RvciAq Lwo+ID4gPiA+ICsjZGVmaW5lIE1TSVhfVkVDVE9SX1BFUl9WUV9BTkRfQ09ORklHICAgICAgICAg ICAgICAxCj4gPiA+ID4gKy8qIGFsbCB2cXMgc2hhcmUgYSB2ZWN0b3IsIGFuZCBjb25maWcgaW50 ZXJydXB0IGhhcyBhIHNlcGFyYXRlIHZlY3RvciAqLwo+ID4gPiA+ICsjZGVmaW5lIE1TSVhfVkVD VE9SX1NIQVJFRF9WUV9BTkRfQ09ORklHICAgMgo+ID4gPiA+ICsvKiBhbGwgdnFzIGFuZCBjb25m aWcgaW50ZXJydXB0IHNoYXJlIGEgdmVjdG9yICovCj4gPiA+ID4gKyNkZWZpbmUgTVNJWF9WRUNU T1JfREVWX1NIQVJFRCAgICAgICAgICAgICAgICAgICAgIDMKPiA+ID4KPiA+ID4KPiA+ID4gSSB0 aGluayB0aGVyZSdzIG5vIG11Y2ggdmFsdWUgdG8gZGlmZmVyIDIgZnJvbSAzIGNvbnNpZGVyIGNv bmZpZyBpbnRlcnJ1cHQKPiA+ID4gc2hvdWxkIGJlIHJhcmUuCj4gPgo+ID4KPiA+IFllcyBidXQg aWYgd2UgZG8gbm90IGhhdmUgYSBkZWRpY2F0ZWQgdmVjdG9yIHRoZW4gd2UgbmVlZCBhbgo+ID4g ZXh0cmEgZGV2aWNlIElPIChpbiBmYWN0LCBhIHJlYWQpIG9uIGVhY2ggaW50ZXJydXB0Lgo+IAo+ IE9rLCByaWdodC4KPiAKPiA+Cj4gPiA+Cj4gPiA+ID4gKwo+ID4gPiA+ICAgc3RhdGljIGlubGlu ZSB1OCBpZmNfaW9yZWFkOCh1OCBfX2lvbWVtICphZGRyKQo+ID4gPiA+ICAgewo+ID4gPiA+ICAg ICByZXR1cm4gaW9yZWFkOChhZGRyKTsKPiA+ID4gPiBAQCAtOTcsMjUgKzEwMiwyNyBAQCBzdHJ1 Y3QgaWZjdmZfaHcgewo+ID4gPiA+ICAgICB1OCBfX2lvbWVtICppc3I7Cj4gPiA+ID4gICAgIC8q IExpdmUgbWlncmF0aW9uICovCj4gPiA+ID4gICAgIHU4IF9faW9tZW0gKmxtX2NmZzsKPiA+ID4g PiAtICAgdTE2IG5yX3ZyaW5nOwo+ID4gPgo+ID4gPgo+ID4gPiBBbnkgcmVhc29uIGZvciBtb3Zp bmcgbnZfdnJpbmcsIGNvbmZpZ19zaXplLCBhbmQgb3RoZXIgc3R1ZmZzPwo+ID4gPgo+ID4gPgo+ ID4gPiA+ICAgICAvKiBOb3RpZmljYXRpb24gYmFyIG51bWJlciAqLwo+ID4gPiA+ICAgICB1OCBu b3RpZnlfYmFyOwo+ID4gPiA+ICsgICB1OCBtc2l4X3ZlY3Rvcl9zdGF0dXM7Cj4gPiA+ID4gKyAg IC8qIHZpcnRpby1uZXQgb3IgdmlydGlvLWJsayBkZXZpY2UgY29uZmlnIHNpemUgKi8KPiA+ID4g PiArICAgdTMyIGNvbmZpZ19zaXplOwo+ID4gPiA+ICAgICAvKiBOb3RpZmljYWl0b24gYmFyIGFk ZHJlc3MgKi8KPiA+ID4gPiAgICAgdm9pZCBfX2lvbWVtICpub3RpZnlfYmFzZTsKPiA+ID4gPiAg ICAgcGh5c19hZGRyX3Qgbm90aWZ5X2Jhc2VfcGE7Cj4gPiA+ID4gICAgIHUzMiBub3RpZnlfb2Zm X211bHRpcGxpZXI7Cj4gPiA+ID4gKyAgIHUzMiBkZXZfdHlwZTsKPiA+ID4gPiAgICAgdTY0IHJl cV9mZWF0dXJlczsKPiA+ID4gPiAgICAgdTY0IGh3X2ZlYXR1cmVzOwo+ID4gPiA+IC0gICB1MzIg ZGV2X3R5cGU7Cj4gPiA+ID4gICAgIHN0cnVjdCB2aXJ0aW9fcGNpX2NvbW1vbl9jZmcgX19pb21l bSAqY29tbW9uX2NmZzsKPiA+ID4gPiAgICAgdm9pZCBfX2lvbWVtICpkZXZfY2ZnOwo+ID4gPiA+ ICAgICBzdHJ1Y3QgdnJpbmdfaW5mbyB2cmluZ1tJRkNWRl9NQVhfUVVFVUVTXTsKPiA+ID4gPiAg ICAgdm9pZCBfX2lvbWVtICogY29uc3QgKmJhc2U7Cj4gPiA+ID4gICAgIGNoYXIgY29uZmlnX21z aXhfbmFtZVsyNTZdOwo+ID4gPiA+ICAgICBzdHJ1Y3QgdmRwYV9jYWxsYmFjayBjb25maWdfY2I7 Cj4gPiA+ID4gLSAgIHVuc2lnbmVkIGludCBjb25maWdfaXJxOwo+ID4gPiA+IC0gICAvKiB2aXJ0 aW8tbmV0IG9yIHZpcnRpby1ibGsgZGV2aWNlIGNvbmZpZyBzaXplICovCj4gPiA+ID4gLSAgIHUz MiBjb25maWdfc2l6ZTsKPiA+ID4gPiArICAgaW50IGNvbmZpZ19pcnE7Cj4gPiA+ID4gKyAgIGlu dCB2cXNfc2hhcmVkX2lycTsKPiA+ID4gPiArICAgdTE2IG5yX3ZyaW5nOwo+ID4gPiA+ICAgfTsK PiA+ID4gPiAgIHN0cnVjdCBpZmN2Zl9hZGFwdGVyIHsKPiA+ID4gPiBAQCAtMTYwLDQgKzE2Nyw2 IEBAIGludCBpZmN2Zl9zZXRfdnFfc3RhdGUoc3RydWN0IGlmY3ZmX2h3ICpodywgdTE2IHFpZCwg dTE2IG51bSk7Cj4gPiA+ID4gICBzdHJ1Y3QgaWZjdmZfYWRhcHRlciAqdmZfdG9fYWRhcHRlcihz dHJ1Y3QgaWZjdmZfaHcgKmh3KTsKPiA+ID4gPiAgIGludCBpZmN2Zl9wcm9iZWRfdmlydGlvX25l dChzdHJ1Y3QgaWZjdmZfaHcgKmh3KTsKPiA+ID4gPiAgIHUzMiBpZmN2Zl9nZXRfY29uZmlnX3Np emUoc3RydWN0IGlmY3ZmX2h3ICpodyk7Cj4gPiA+ID4gK2ludCBpZmN2Zl9zZXRfdnFfdmVjdG9y KHN0cnVjdCBpZmN2Zl9odyAqaHcsIHUxNiBxaWQsIGludCB2ZWN0b3IpOwo+ID4gPiA+ICtpbnQg aWZjdmZfc2V0X2NvbmZpZ192ZWN0b3Ioc3RydWN0IGlmY3ZmX2h3ICpodywgaW50IHZlY3Rvcik7 Cj4gPiA+ID4gICAjZW5kaWYgLyogX0lGQ1ZGX0hfICovCj4gPiA+ID4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvdmRwYS9pZmN2Zi9pZmN2Zl9tYWluLmMgYi9kcml2ZXJzL3ZkcGEvaWZjdmYvaWZjdmZf bWFpbi5jCj4gPiA+ID4gaW5kZXggNDRjODlhYjBiNmRhLi5jYTQxNDM5OWYwNDAgMTAwNjQ0Cj4g PiA+ID4gLS0tIGEvZHJpdmVycy92ZHBhL2lmY3ZmL2lmY3ZmX21haW4uYwo+ID4gPiA+ICsrKyBi L2RyaXZlcnMvdmRwYS9pZmN2Zi9pZmN2Zl9tYWluLmMKPiA+ID4gPiBAQCAtMTcsNiArMTcsNyBA QAo+ID4gPiA+ICAgI2RlZmluZSBEUklWRVJfQVVUSE9SICAgIkludGVsIENvcnBvcmF0aW9uIgo+ ID4gPiA+ICAgI2RlZmluZSBJRkNWRl9EUklWRVJfTkFNRSAgICAgICAiaWZjdmYiCj4gPiA+ID4g Ky8qIGhhbmRsZXMgY29uZmlnIGludGVycnVwdCAqLwo+ID4gPgo+ID4gPgo+ID4gPiBUaGlzIHNl ZW1zIHVucmVsYXRlZCB0byB0aGUgc2hhcmVkIElSUSBsb2dpYyBhbmQgaXQgbG9va3MgdXNlbGVz cyBzaW5jZSBpdCdzCj4gPiA+IGVhc2lseSB0byBkZWR1Y2UgaXQgZnJvbSB0aGUgZnVuY3Rpb24g bmFtZSBiZWxvdy4KPiA+ID4KPiA+ID4KPiA+ID4gPiAgIHN0YXRpYyBpcnFyZXR1cm5fdCBpZmN2 Zl9jb25maWdfY2hhbmdlZChpbnQgaXJxLCB2b2lkICphcmcpCj4gPiA+ID4gICB7Cj4gPiA+ID4g ICAgIHN0cnVjdCBpZmN2Zl9odyAqdmYgPSBhcmc7Cj4gPiA+ID4gQEAgLTI3LDYgKzI4LDcgQEAg c3RhdGljIGlycXJldHVybl90IGlmY3ZmX2NvbmZpZ19jaGFuZ2VkKGludCBpcnEsIHZvaWQgKmFy ZykKPiA+ID4gPiAgICAgcmV0dXJuIElSUV9IQU5ETEVEOwo+ID4gPiA+ICAgfQo+ID4gPiA+ICsv KiBoYW5kbGVzIHZxcyBpbnRlcnJ1cHQgKi8KPiA+ID4KPiA+ID4KPiA+ID4gU28gZGlkIHRoaXMu Cj4gPiA+Cj4gPiA+Cj4gPiA+ID4gICBzdGF0aWMgaXJxcmV0dXJuX3QgaWZjdmZfaW50cl9oYW5k bGVyKGludCBpcnEsIHZvaWQgKmFyZykKPiA+ID4gPiAgIHsKPiA+ID4gPiAgICAgc3RydWN0IHZy aW5nX2luZm8gKnZyaW5nID0gYXJnOwo+ID4gPiA+IEBAIC0zNywyNCArMzksNzggQEAgc3RhdGlj IGlycXJldHVybl90IGlmY3ZmX2ludHJfaGFuZGxlcihpbnQgaXJxLCB2b2lkICphcmcpCj4gPiA+ ID4gICAgIHJldHVybiBJUlFfSEFORExFRDsKPiA+ID4gPiAgIH0KPiA+ID4gPiArLyogaGFuZGxz IHZxcyBzaGFyZWQgaW50ZXJydXB0ICovCj4gPiA+ID4gK3N0YXRpYyBpcnFyZXR1cm5fdCBpZmN2 Zl92cV9zaGFyZWRfaW50cl9oYW5kbGVyKGludCBpcnEsIHZvaWQgKmFyZykKPiA+ID4gPiArewo+ ID4gPiA+ICsgICBzdHJ1Y3QgaWZjdmZfaHcgKnZmID0gYXJnOwo+ID4gPiA+ICsgICBzdHJ1Y3Qg dnJpbmdfaW5mbyAqdnJpbmc7Cj4gPiA+ID4gKyAgIGludCBpOwo+ID4gPiA+ICsKPiA+ID4gPiAr ICAgZm9yIChpID0gMDsgaSA8IHZmLT5ucl92cmluZzsgaSsrKSB7Cj4gPiA+ID4gKyAgICAgICAg ICAgdnJpbmcgPSAmdmYtPnZyaW5nW2ldOwo+ID4gPiA+ICsgICAgICAgICAgIGlmICh2cmluZy0+ Y2IuY2FsbGJhY2spCj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICB2Zi0+dnJpbmctPmNiLmNh bGxiYWNrKHZyaW5nLT5jYi5wcml2YXRlKTsKPiA+ID4gPiArICAgfQo+ID4gPiA+ICsKPiA+ID4g PiArICAgcmV0dXJuIElSUV9IQU5ETEVEOwo+ID4gPiA+ICt9Cj4gPiA+ID4gKwo+ID4gPiA+ICsv KiBoYW5kbGVzIGEgc2hhcmVkIGludGVycnVwdCBmb3IgdnFzIGFuZCBjb25maWcgKi8KPiA+ID4g PiArc3RhdGljIGlycXJldHVybl90IGlmY3ZmX2Rldl9zaGFyZWRfaW50cl9oYW5kbGVyKGludCBp cnEsIHZvaWQgKmFyZykKPiA+Cj4gPiBzaGFyZWQgaXMgbm90IGEgZ29vZCBuYW1lIGdpdmVuIElS UV9TSEFSRUQgaXMgbm90IHNldC4KPiA+IG1heWJlICJjb21tb24iPyAicmV1c2VkIj8KPiA+Cj4g PiA+ID4gK3sKPiA+ID4gPiArICAgc3RydWN0IGlmY3ZmX2h3ICp2ZiA9IGFyZzsKPiA+ID4gPiAr ICAgdTggaXNyOwo+ID4gPiA+ICsKPiA+ID4gPiArICAgaXNyID0gaWZjX2lvcmVhZDgodmYtPmlz cik7Cj4gPiA+Cj4gPiA+Cj4gPiA+IFdlIG5lZWQgdG8gZXhhY3RseSB3aGF0IHZwX2ludGVycnVw dCBkbyBoZXJlLiBDaGVja2luZyBhZ2FpbnN0IHZmLT5pc3IgZmlyc3QKPiA+ID4gYW5kIHJldHVy biBJUlFfTk9ORSBpZiBpdCBpcyBub3Qgc2V0Lgo+ID4KPiA+IG5vLCB2Zi0+aXNyIGlzIG5vdCBz ZXQgZm9yIFZRIGludGVycnVwdHMuCj4gCj4gSSBhY3R1YWxseSB3b25kZXIgd2hhdCdzIHRoZSBh Y3R1YWwgYmVoYXZpb3VyIG9mIElGQ1ZGLgo+IAo+ID4gSWYgbmVlZCB0byBhY3R1YWxseSBwb2tl Cj4gPiBhdCB0aGUgVlEgdG8ga25vdy4KPiA+Cj4gPiA+IEFsd2F5cyByZXR1cm4gSVJRX0hBTkRM RUQgd2lsbCBicmVhayB0aGUgZGV2aWNlIHdobyBzaGFyZXMgYW4gaXJxIHdpdGgKPiA+ID4gSUZD VkYuCj4gPgo+ID4KPiA+IEl0J3MgYSBNU0ksIG5vdCBJTlQjLiBTbyBpbnRlcnJ1cHQgaXMgbm90 IHNoYXJlZCBhcyBzdWNoIC0gaXQncyBvbmx5Cj4gPiBzaGFyaW5nIHZlY3RvciBiZXR3ZWVuIGNv bmZpZyBhbmQgdnEuCj4gCj4gUmlnaHQsIEkgdGhvdWdodCBpdCB3YXMgYSBzaGFyZWQgb25lIGFz IHZpcml0b19wY2kgZGlkLgo+IAo+ID4KPiA+Cj4gPiA+Cj4gPiA+ID4gKyAgIGlmIChpc3IgJiBW SVJUSU9fUENJX0lTUl9DT05GSUcpCj4gPiA+ID4gKyAgICAgICAgICAgaWZjdmZfY29uZmlnX2No YW5nZWQoaXJxLCBhcmcpOwo+ID4gPiA+ICsKPiA+ID4gPiArICAgcmV0dXJuIGlmY3ZmX3ZxX3No YXJlZF9pbnRyX2hhbmRsZXIoaXJxLCBhcmcpOwo+ID4gPiA+ICt9Cj4gPiA+ID4gKwo+ID4gPiA+ ICAgc3RhdGljIHZvaWQgaWZjdmZfZnJlZV9pcnFfdmVjdG9ycyh2b2lkICpkYXRhKQo+ID4gPiA+ ICAgewo+ID4gPiA+ICAgICBwY2lfZnJlZV9pcnFfdmVjdG9ycyhkYXRhKTsKPiA+ID4gPiAgIH0K PiA+ID4gPiAtc3RhdGljIHZvaWQgaWZjdmZfZnJlZV9pcnEoc3RydWN0IGlmY3ZmX2FkYXB0ZXIg KmFkYXB0ZXIsIGludCBxdWV1ZXMpCj4gPiA+ID4gK3N0YXRpYyB2b2lkIGlmY3ZmX2ZyZWVfdnFf aXJxKHN0cnVjdCBpZmN2Zl9hZGFwdGVyICphZGFwdGVyLCBpbnQgcXVldWVzKQo+ID4gPiA+ICAg ewo+ID4gPiA+ICAgICBzdHJ1Y3QgcGNpX2RldiAqcGRldiA9IGFkYXB0ZXItPnBkZXY7Cj4gPiA+ ID4gICAgIHN0cnVjdCBpZmN2Zl9odyAqdmYgPSAmYWRhcHRlci0+dmY7Cj4gPiA+ID4gICAgIGlu dCBpOwo+ID4gPiA+ICsgICBpZiAodmYtPm1zaXhfdmVjdG9yX3N0YXR1cyA9PSBNU0lYX1ZFQ1RP Ul9QRVJfVlFfQU5EX0NPTkZJRykgewo+ID4gPiA+ICsgICAgICAgICAgIGZvciAoaSA9IDA7IGkg PCBxdWV1ZXM7IGkrKykgewo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgZGV2bV9mcmVlX2ly cSgmcGRldi0+ZGV2LCB2Zi0+dnJpbmdbaV0uaXJxLCAmdmYtPnZyaW5nW2ldKTsKPiA+ID4gPiAr ICAgICAgICAgICAgICAgICAgIHZmLT52cmluZ1tpXS5pcnEgPSAtRUlOVkFMOwo+ID4gPiA+ICsg ICAgICAgICAgIH0KPiA+ID4gPiArICAgfSBlbHNlIHsKPiA+ID4gPiArICAgICAgICAgICBkZXZt X2ZyZWVfaXJxKCZwZGV2LT5kZXYsIHZmLT52cXNfc2hhcmVkX2lycSwgdmYpOwo+ID4gPiA+ICsg ICAgICAgICAgIHZmLT52cXNfc2hhcmVkX2lycSA9IC1FSU5WQUw7Cj4gPiA+ID4gKyAgIH0KPiA+ ID4gPiArfQo+ID4gPiA+IC0gICBmb3IgKGkgPSAwOyBpIDwgcXVldWVzOyBpKyspIHsKPiA+ID4g PiAtICAgICAgICAgICBkZXZtX2ZyZWVfaXJxKCZwZGV2LT5kZXYsIHZmLT52cmluZ1tpXS5pcnEs ICZ2Zi0+dnJpbmdbaV0pOwo+ID4gPiA+IC0gICAgICAgICAgIHZmLT52cmluZ1tpXS5pcnEgPSAt RUlOVkFMOwo+ID4gPiA+ICtzdGF0aWMgdm9pZCBpZmN2Zl9mcmVlX2NvbmZpZ19pcnEoc3RydWN0 IGlmY3ZmX2FkYXB0ZXIgKmFkYXB0ZXIpCj4gPiA+ID4gK3sKPiA+ID4gPiArICAgc3RydWN0IHBj aV9kZXYgKnBkZXYgPSBhZGFwdGVyLT5wZGV2Owo+ID4gPiA+ICsgICBzdHJ1Y3QgaWZjdmZfaHcg KnZmID0gJmFkYXB0ZXItPnZmOwo+ID4gPiA+ICsKPiA+ID4gPiArICAgLyogSWYgdGhlIGlycSBp cyBzaGFyZWQgYnkgYWxsIHZxcyBhbmQgdGhlIGNvbmZpZyBpbnRlcnJ1cHQsCj4gPiA+ID4gKyAg ICAqIGl0IGlzIGFscmVhZHkgZnJlZWQgaW4gaWZjdmZfZnJlZV92cV9pcnEsIHNvIGhlcmUgb25s eQo+ID4gPiA+ICsgICAgKiBuZWVkIHRvIGZyZWUgY29uZmlnIGlycSB3aGVuIG1zaXhfdmVjdG9y X3N0YXR1cyAhPSBNU0lYX1ZFQ1RPUl9ERVZfU0hBUkVECj4gPiA+ID4gKyAgICAqLwo+ID4gPiA+ ICsgICBpZiAodmYtPm1zaXhfdmVjdG9yX3N0YXR1cyAhPSBNU0lYX1ZFQ1RPUl9ERVZfU0hBUkVE KSB7Cj4gPiA+ID4gKyAgICAgICAgICAgZGV2bV9mcmVlX2lycSgmcGRldi0+ZGV2LCB2Zi0+Y29u ZmlnX2lycSwgdmYpOwo+ID4gPiA+ICsgICAgICAgICAgIHZmLT5jb25maWdfaXJxID0gLUVJTlZB TDsKPiA+ID4gPiAgICAgfQo+ID4gPiA+ICt9Cj4gPiA+ID4gKwo+ID4gPiA+ICtzdGF0aWMgdm9p ZCBpZmN2Zl9mcmVlX2lycShzdHJ1Y3QgaWZjdmZfYWRhcHRlciAqYWRhcHRlciwgaW50IHF1ZXVl cykKPiA+ID4gPiArewo+ID4gPiA+ICsgICBzdHJ1Y3QgcGNpX2RldiAqcGRldiA9IGFkYXB0ZXIt PnBkZXY7Cj4gPiA+ID4gLSAgIGRldm1fZnJlZV9pcnEoJnBkZXYtPmRldiwgdmYtPmNvbmZpZ19p cnEsIHZmKTsKPiA+ID4gPiArICAgaWZjdmZfZnJlZV92cV9pcnEoYWRhcHRlciwgcXVldWVzKTsK PiA+ID4gPiArICAgaWZjdmZfZnJlZV9jb25maWdfaXJxKGFkYXB0ZXIpOwo+ID4gPiA+ICAgICBp ZmN2Zl9mcmVlX2lycV92ZWN0b3JzKHBkZXYpOwo+ID4gPiA+ICAgfQo+ID4gPiA+IEBAIC04Niw1 OCArMTQyLDE3MiBAQCBzdGF0aWMgaW50IGlmY3ZmX2FsbG9jX3ZlY3RvcnMoc3RydWN0IGlmY3Zm X2FkYXB0ZXIgKmFkYXB0ZXIpCj4gPiA+ID4gICAgIHJldHVybiByZXQ7Cj4gPiA+ID4gICB9Cj4g PiA+ID4gLXN0YXRpYyBpbnQgaWZjdmZfcmVxdWVzdF9pcnEoc3RydWN0IGlmY3ZmX2FkYXB0ZXIg KmFkYXB0ZXIpCj4gPiA+ID4gK3N0YXRpYyBpbnQgaWZjdmZfcmVxdWVzdF9wZXJfdnFfaXJxKHN0 cnVjdCBpZmN2Zl9hZGFwdGVyICphZGFwdGVyKQo+ID4gPiA+ICAgewo+ID4gPiA+ICAgICBzdHJ1 Y3QgcGNpX2RldiAqcGRldiA9IGFkYXB0ZXItPnBkZXY7Cj4gPiA+ID4gICAgIHN0cnVjdCBpZmN2 Zl9odyAqdmYgPSAmYWRhcHRlci0+dmY7Cj4gPiA+ID4gLSAgIGludCB2ZWN0b3IsIG52ZWN0b3Jz LCBpLCByZXQsIGlycTsKPiA+ID4gPiAtICAgdTE2IG1heF9pbnRyOwo+ID4gPiA+ICsgICBpbnQg aSwgdmVjdG9yLCByZXQsIGlycTsKPiA+ID4gPiAtICAgbnZlY3RvcnMgPSBpZmN2Zl9hbGxvY192 ZWN0b3JzKGFkYXB0ZXIpOwo+ID4gPiA+IC0gICBpZiAoIShudmVjdG9ycyA+IDApKQo+ID4gPiA+ IC0gICAgICAgICAgIHJldHVybiBudmVjdG9yczsKPiA+ID4gPiArICAgZm9yIChpID0gMDsgaSA8 IHZmLT5ucl92cmluZzsgaSsrKSB7Cj4gPiA+ID4gKyAgICAgICAgICAgc25wcmludGYodmYtPnZy aW5nW2ldLm1zaXhfbmFtZSwgMjU2LCAiaWZjdmZbJXNdLSVkXG4iLCBwY2lfbmFtZShwZGV2KSwg aSk7Cj4gPiA+ID4gKyAgICAgICAgICAgdmVjdG9yID0gaTsKPiA+ID4gPiArICAgICAgICAgICBp cnEgPSBwY2lfaXJxX3ZlY3RvcihwZGV2LCB2ZWN0b3IpOwo+ID4gPiA+ICsgICAgICAgICAgIHJl dCA9IGRldm1fcmVxdWVzdF9pcnEoJnBkZXYtPmRldiwgaXJxLAo+ID4gPiA+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgaWZjdmZfaW50cl9oYW5kbGVyLCAwLAo+ID4gPiA+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdmYtPnZyaW5nW2ldLm1zaXhfbmFtZSwK PiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZ2Zi0+dnJpbmdbaV0p Owo+ID4gPiA+ICsgICAgICAgICAgIGlmIChyZXQpIHsKPiA+ID4gPiArICAgICAgICAgICAgICAg ICAgIElGQ1ZGX0VSUihwZGV2LCAiRmFpbGVkIHRvIHJlcXVlc3QgaXJxIGZvciB2cSAlZFxuIiwg aSk7Cj4gPiA+ID4gKyAgICAgICAgICAgICAgICAgICBpZmN2Zl9mcmVlX3ZxX2lycShhZGFwdGVy LCBpKTsKPiA+ID4gPiArICAgICAgICAgICB9IGVsc2Ugewo+ID4gPiA+ICsgICAgICAgICAgICAg ICAgICAgdmYtPnZyaW5nW2ldLmlycSA9IGlycTsKPiA+ID4gPiArICAgICAgICAgICAgICAgICAg IGlmY3ZmX3NldF92cV92ZWN0b3IodmYsIGksIHZlY3Rvcik7Cj4gPiA+ID4gKyAgICAgICAgICAg fQo+ID4gPiA+ICsgICB9Cj4gPiA+ID4gLSAgIG1heF9pbnRyID0gdmYtPm5yX3ZyaW5nICsgMTsK PiA+ID4gPiArICAgdmYtPnZxc19zaGFyZWRfaXJxID0gLUVJTlZBTDsKPiA+ID4gPiArCj4gPiA+ ID4gKyAgIHJldHVybiAwOwo+ID4gPiA+ICt9Cj4gPiA+ID4gKwo+ID4gPiA+ICtzdGF0aWMgaW50 IGlmY3ZmX3JlcXVlc3Rfc2hhcmVkX3ZxX2lycShzdHJ1Y3QgaWZjdmZfYWRhcHRlciAqYWRhcHRl cikKPiA+ID4gPiArewo+ID4gPiA+ICsgICBzdHJ1Y3QgcGNpX2RldiAqcGRldiA9IGFkYXB0ZXIt PnBkZXY7Cj4gPiA+ID4gKyAgIHN0cnVjdCBpZmN2Zl9odyAqdmYgPSAmYWRhcHRlci0+dmY7Cj4g PiA+ID4gKyAgIGludCBpLCB2ZWN0b3IsIHJldCwgaXJxOwo+ID4gPiA+ICsKPiA+ID4gPiArICAg dmVjdG9yID0gMDsKPiA+ID4gPiArICAgLyogcmV1c2UgbXNpeF9uYW1lWzI1Nl0gc3BhY2Ugb2Yg dnJpbmcwIHRvIHN0b3JlIHNoYXJlZCB2cXMgaW50ZXJydXB0IG5hbWUgKi8KPiA+ID4KPiA+ID4K PiA+ID4gSSB0aGluayB3ZSBjYW4gcmVtb3ZlIHRoaXMgY29tbWVudCBzaW5jZSB0aGUgY29kZSBp cyBzdHJhaWdodGZvcndhcmQuCj4gPiA+Cj4gPiA+Cj4gPiA+ID4gKyAgIHNucHJpbnRmKHZmLT52 cmluZ1swXS5tc2l4X25hbWUsIDI1NiwgImlmY3ZmWyVzXS12cXMtc2hhcmVkLWlycVxuIiwgcGNp X25hbWUocGRldikpOwo+ID4gPiA+ICsgICBpcnEgPSBwY2lfaXJxX3ZlY3RvcihwZGV2LCB2ZWN0 b3IpOwo+ID4gPiA+ICsgICByZXQgPSBkZXZtX3JlcXVlc3RfaXJxKCZwZGV2LT5kZXYsIGlycSwK PiA+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICAgICBpZmN2Zl92cV9zaGFyZWRfaW50cl9o YW5kbGVyLCAwLAo+ID4gPiA+ICsgICAgICAgICAgICAgICAgICAgICAgICAgIHZmLT52cmluZ1sw XS5tc2l4X25hbWUsIHZmKTsKPiA+ID4gPiArICAgaWYgKHJldCkgewo+ID4gPiA+ICsgICAgICAg ICAgIElGQ1ZGX0VSUihwZGV2LCAiRmFpbGVkIHRvIHJlcXVlc3Qgc2hhcmVkIGlycSBmb3IgdmZc biIpOwo+ID4gPiA+ICsKPiA+ID4gPiArICAgICAgICAgICByZXR1cm4gcmV0Owo+ID4gPiA+ICsg ICB9Cj4gPiA+ID4gKwo+ID4gPiA+ICsgICB2Zi0+dnFzX3NoYXJlZF9pcnEgPSBpcnE7Cj4gPiA+ ID4gKyAgIGZvciAoaSA9IDA7IGkgPCB2Zi0+bnJfdnJpbmc7IGkrKykgewo+ID4gPiA+ICsgICAg ICAgICAgIHZmLT52cmluZ1tpXS5pcnEgPSAtRUlOVkFMOwo+ID4gPiA+ICsgICAgICAgICAgIGlm Y3ZmX3NldF92cV92ZWN0b3IodmYsIGksIHZlY3Rvcik7Cj4gPiA+ID4gKyAgIH0KPiA+ID4gPiAr Cj4gPiA+ID4gKyAgIHJldHVybiAwOwo+ID4gPiA+ICsKPiA+ID4gPiArfQo+ID4gPiA+ICsKPiA+ ID4gPiArc3RhdGljIGludCBpZmN2Zl9yZXF1ZXN0X2Rldl9zaGFyZWRfaXJxKHN0cnVjdCBpZmN2 Zl9hZGFwdGVyICphZGFwdGVyKQo+ID4gPiA+ICt7Cj4gPiA+ID4gKyAgIHN0cnVjdCBwY2lfZGV2 ICpwZGV2ID0gYWRhcHRlci0+cGRldjsKPiA+ID4gPiArICAgc3RydWN0IGlmY3ZmX2h3ICp2ZiA9 ICZhZGFwdGVyLT52ZjsKPiA+ID4gPiArICAgaW50IGksIHZlY3RvciwgcmV0LCBpcnE7Cj4gPiA+ ID4gKwo+ID4gPiA+ICsgICB2ZWN0b3IgPSAwOwo+ID4gPiA+ICsgICAvKiByZXVzZSBtc2l4X25h bWVbMjU2XSBzcGFjZSBvZiB2cmluZzAgdG8gc3RvcmUgc2hhcmVkIGRldmljZSBpbnRlcnJ1cHQg bmFtZSAqLwo+ID4gPiA+ICsgICBzbnByaW50Zih2Zi0+dnJpbmdbMF0ubXNpeF9uYW1lLCAyNTYs ICJpZmN2Zlslc10tZGV2LXNoYXJlZC1pcnFcbiIsIHBjaV9uYW1lKHBkZXYpKTsKPiA+ID4gPiAr ICAgaXJxID0gcGNpX2lycV92ZWN0b3IocGRldiwgdmVjdG9yKTsKPiA+ID4gPiArICAgcmV0ID0g ZGV2bV9yZXF1ZXN0X2lycSgmcGRldi0+ZGV2LCBpcnEsCj4gPiA+ID4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgaWZjdmZfZGV2X3NoYXJlZF9pbnRyX2hhbmRsZXIsIDAsCj4gPiA+ID4gKyAg ICAgICAgICAgICAgICAgICAgICAgICAgdmYtPnZyaW5nWzBdLm1zaXhfbmFtZSwgdmYpOwo+ID4g PiA+ICsgICBpZiAocmV0KSB7Cj4gPiA+ID4gKyAgICAgICAgICAgSUZDVkZfRVJSKHBkZXYsICJG YWlsZWQgdG8gcmVxdWVzdCBzaGFyZWQgaXJxIGZvciB2ZlxuIik7Cj4gPiA+ID4gLSAgIHJldCA9 IHBjaV9hbGxvY19pcnFfdmVjdG9ycyhwZGV2LCBtYXhfaW50ciwKPiA+ID4gPiAtICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIG1heF9pbnRyLCBQQ0lfSVJRX01TSVgpOwo+ID4gPiA+IC0g ICBpZiAocmV0IDwgMCkgewo+ID4gPiA+IC0gICAgICAgICAgIElGQ1ZGX0VSUihwZGV2LCAiRmFp bGVkIHRvIGFsbG9jIElSUSB2ZWN0b3JzXG4iKTsKPiA+ID4gPiAgICAgICAgICAgICByZXR1cm4g cmV0Owo+ID4gPiA+ICAgICB9Cj4gPiA+ID4gKyAgIHZmLT52cXNfc2hhcmVkX2lycSA9IGlycTsK PiA+ID4gPiArICAgZm9yIChpID0gMDsgaSA8IHZmLT5ucl92cmluZzsgaSsrKSB7Cj4gPiA+ID4g KyAgICAgICAgICAgdmYtPnZyaW5nW2ldLmlycSA9IC1FSU5WQUw7Cj4gPiA+ID4gKyAgICAgICAg ICAgaWZjdmZfc2V0X3ZxX3ZlY3Rvcih2ZiwgaSwgdmVjdG9yKTsKPiA+ID4gPiArICAgfQo+ID4g PiA+ICsKPiA+ID4gPiArICAgdmYtPmNvbmZpZ19pcnEgPSBpcnE7Cj4gPiA+ID4gKyAgIGlmY3Zm X3NldF9jb25maWdfdmVjdG9yKHZmLCB2ZWN0b3IpOwo+ID4gPiA+ICsKPiA+ID4gPiArICAgcmV0 dXJuIDA7Cj4gPiA+ID4gKwo+ID4gPiA+ICt9Cj4gPiA+ID4gKwo+ID4gPiA+ICtzdGF0aWMgaW50 IGlmY3ZmX3JlcXVlc3RfdnFfaXJxKHN0cnVjdCBpZmN2Zl9hZGFwdGVyICphZGFwdGVyKQo+ID4g PiA+ICt7Cj4gPiA+ID4gKyAgIHN0cnVjdCBpZmN2Zl9odyAqdmYgPSAmYWRhcHRlci0+dmY7Cj4g PiA+ID4gKyAgIGludCByZXQ7Cj4gPiA+ID4gKwo+ID4gPiA+ICsgICBpZiAodmYtPm1zaXhfdmVj dG9yX3N0YXR1cyA9PSBNU0lYX1ZFQ1RPUl9QRVJfVlFfQU5EX0NPTkZJRykKPiA+ID4gPiArICAg ICAgICAgICByZXQgPSBpZmN2Zl9yZXF1ZXN0X3Blcl92cV9pcnEoYWRhcHRlcik7Cj4gPiA+ID4g KyAgIGVsc2UKPiA+ID4gPiArICAgICAgICAgICByZXQgPSBpZmN2Zl9yZXF1ZXN0X3NoYXJlZF92 cV9pcnEoYWRhcHRlcik7Cj4gPiA+ID4gKwo+ID4gPiA+ICsgICByZXR1cm4gcmV0Owo+ID4gPiA+ ICt9Cj4gPiA+ID4gKwo+ID4gPiA+ICtzdGF0aWMgaW50IGlmY3ZmX3JlcXVlc3RfY29uZmlnX2ly cShzdHJ1Y3QgaWZjdmZfYWRhcHRlciAqYWRhcHRlcikKPiA+ID4gPiArewo+ID4gPiA+ICsgICBz dHJ1Y3QgcGNpX2RldiAqcGRldiA9IGFkYXB0ZXItPnBkZXY7Cj4gPiA+ID4gKyAgIHN0cnVjdCBp ZmN2Zl9odyAqdmYgPSAmYWRhcHRlci0+dmY7Cj4gPiA+ID4gKyAgIGludCBjb25maWdfdmVjdG9y LCByZXQ7Cj4gPiA+ID4gKwo+ID4gPiA+ICsgICBpZiAodmYtPm1zaXhfdmVjdG9yX3N0YXR1cyA9 PSBNU0lYX1ZFQ1RPUl9ERVZfU0hBUkVEKQo+ID4gPiA+ICsgICAgICAgICAgIHJldHVybiAwOwo+ ID4gPiA+ICsKPiA+ID4gPiArICAgaWYgKHZmLT5tc2l4X3ZlY3Rvcl9zdGF0dXMgPT0gTVNJWF9W RUNUT1JfUEVSX1ZRX0FORF9DT05GSUcpCj4gPiA+ID4gKyAgICAgICAgICAgLyogdmVjdG9yIDAg fiB2Zi0+bnJfdnJpbmcgZm9yIHZxcywgbnVtIHZmLT5ucl92cmluZyB2ZWN0b3IgZm9yIGNvbmZp ZyBpbnRlcnJ1cHQgKi8KPiA+ID4gPiArICAgICAgICAgICBjb25maWdfdmVjdG9yID0gdmYtPm5y X3ZyaW5nOwo+ID4gPiA+ICsKPiA+ID4gPiArICAgaWYgKHZmLT5tc2l4X3ZlY3Rvcl9zdGF0dXMg PT0gIE1TSVhfVkVDVE9SX1NIQVJFRF9WUV9BTkRfQ09ORklHKQo+ID4gPiA+ICsgICAgICAgICAg IC8qIHZlY3RvciAwIGZvciB2cXMgYW5kIDEgZm9yIGNvbmZpZyBpbnRlcnJ1cHQgKi8KPiA+ID4g PiArICAgICAgICAgICBjb25maWdfdmVjdG9yID0gMTsKPiA+ID4gPiArCj4gPiA+ID4gICAgIHNu cHJpbnRmKHZmLT5jb25maWdfbXNpeF9uYW1lLCAyNTYsICJpZmN2Zlslc10tY29uZmlnXG4iLAo+ ID4gPiA+ICAgICAgICAgICAgICBwY2lfbmFtZShwZGV2KSk7Cj4gPiA+ID4gLSAgIHZlY3RvciA9 IDA7Cj4gPiA+ID4gLSAgIHZmLT5jb25maWdfaXJxID0gcGNpX2lycV92ZWN0b3IocGRldiwgdmVj dG9yKTsKPiA+ID4gPiArICAgdmYtPmNvbmZpZ19pcnEgPSBwY2lfaXJxX3ZlY3RvcihwZGV2LCBj b25maWdfdmVjdG9yKTsKPiA+ID4gPiAgICAgcmV0ID0gZGV2bV9yZXF1ZXN0X2lycSgmcGRldi0+ ZGV2LCB2Zi0+Y29uZmlnX2lycSwKPiA+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgICAgICBp ZmN2Zl9jb25maWdfY2hhbmdlZCwgMCwKPiA+ID4gPiAgICAgICAgICAgICAgICAgICAgICAgICAg ICB2Zi0+Y29uZmlnX21zaXhfbmFtZSwgdmYpOwo+ID4gPiA+ICAgICBpZiAocmV0KSB7Cj4gPiA+ ID4gICAgICAgICAgICAgSUZDVkZfRVJSKHBkZXYsICJGYWlsZWQgdG8gcmVxdWVzdCBjb25maWcg aXJxXG4iKTsKPiA+ID4gPiArICAgICAgICAgICBpZmN2Zl9mcmVlX3ZxX2lycShhZGFwdGVyLCB2 Zi0+bnJfdnJpbmcpOwo+ID4gPiA+ICAgICAgICAgICAgIHJldHVybiByZXQ7Cj4gPiA+ID4gICAg IH0KPiA+ID4gPiAtICAgZm9yIChpID0gMDsgaSA8IHZmLT5ucl92cmluZzsgaSsrKSB7Cj4gPiA+ ID4gLSAgICAgICAgICAgc25wcmludGYodmYtPnZyaW5nW2ldLm1zaXhfbmFtZSwgMjU2LCAiaWZj dmZbJXNdLSVkXG4iLAo+ID4gPiA+IC0gICAgICAgICAgICAgICAgICAgIHBjaV9uYW1lKHBkZXYp LCBpKTsKPiA+ID4gPiAtICAgICAgICAgICB2ZWN0b3IgPSBpICsgSUZDVkZfTVNJX1FVRVVFX09G RjsKPiA+ID4gPiAtICAgICAgICAgICBpcnEgPSBwY2lfaXJxX3ZlY3RvcihwZGV2LCB2ZWN0b3Ip Owo+ID4gPiA+IC0gICAgICAgICAgIHJldCA9IGRldm1fcmVxdWVzdF9pcnEoJnBkZXYtPmRldiwg aXJxLAo+ID4gPiA+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaWZjdmZfaW50 cl9oYW5kbGVyLCAwLAo+ID4gPiA+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg dmYtPnZyaW5nW2ldLm1zaXhfbmFtZSwKPiA+ID4gPiAtICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICZ2Zi0+dnJpbmdbaV0pOwo+ID4gPiA+IC0gICAgICAgICAgIGlmIChyZXQpIHsK PiA+ID4gPiAtICAgICAgICAgICAgICAgICAgIElGQ1ZGX0VSUihwZGV2LAo+ID4gPiA+IC0gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICJGYWlsZWQgdG8gcmVxdWVzdCBpcnEgZm9yIHZxICVk XG4iLCBpKTsKPiA+ID4gPiAtICAgICAgICAgICAgICAgICAgIGlmY3ZmX2ZyZWVfaXJxKGFkYXB0 ZXIsIGkpOwo+ID4gPiA+ICsgICBpZmN2Zl9zZXRfY29uZmlnX3ZlY3Rvcih2ZiwgY29uZmlnX3Zl Y3Rvcik7Cj4gPiA+ID4gLSAgICAgICAgICAgICAgICAgICByZXR1cm4gcmV0Owo+ID4gPiA+IC0g ICAgICAgICAgIH0KPiA+ID4gPiArICAgcmV0dXJuIDA7Cj4gPiA+ID4gK30KPiA+ID4gPiArCj4g PiA+ID4gK3N0YXRpYyBpbnQgaWZjdmZfcmVxdWVzdF9pcnEoc3RydWN0IGlmY3ZmX2FkYXB0ZXIg KmFkYXB0ZXIpCj4gPiA+ID4gK3sKPiA+ID4KPiA+ID4KPiA+ID4gQXMgcmVwbGllZCBhYm92ZSwg SSB0aGluayBoYXZpbmcgdHdvIG1vZGVzIHNob3VsZCBiZSBzdWZmaWNpZW50IGFuZCB0aGUgY29k ZQo+ID4gPiBjb3VsZCBiZSBncmVhdGx5IHNpbXBsaWZpZWQuCj4gPiA+Cj4gPiA+IFRoYW5rcwo+ ID4gPgo+ID4KPiA+IFdlbGwgaXQgaXMgY2xhaW1lZCB0aGVyZSBhcmUgcGxhdGZvcm1zIHdoZXJl IHdlIGFyZSBzaG9ydAo+ID4gb24gdmVjdG9ycy4gMyB2ZXJzdXMgMiBzZWVtcyBhIDUwJSBzYXZp bmcuIFlvdSBkaXNhZ3JlZT8KPiAKPiBJIHRoaW5rIHdlIGNhbiAyIHZlY3RvcnMgKGEgZGVkaWNh dGVkIGZvciBjb25maWcpLgo+IAo+IFRoYW5rcwo+IAo+ID4KPiA+ID4gPiArICAgc3RydWN0IGlm Y3ZmX2h3ICp2ZiA9ICZhZGFwdGVyLT52ZjsKPiA+ID4gPiArICAgaW50IG52ZWN0b3JzLCByZXQs IG1heF9pbnRyOwo+ID4gPiA+IC0gICAgICAgICAgIHZmLT52cmluZ1tpXS5pcnEgPSBpcnE7Cj4g PiA+ID4gKyAgIG52ZWN0b3JzID0gaWZjdmZfYWxsb2NfdmVjdG9ycyhhZGFwdGVyKTsKPiA+ID4g PiArICAgaWYgKCEobnZlY3RvcnMgPiAwKSkKPiA+ID4gPiArICAgICAgICAgICByZXR1cm4gbnZl Y3RvcnM7Cj4gPiA+ID4gKwo+ID4gPiA+ICsgICB2Zi0+bXNpeF92ZWN0b3Jfc3RhdHVzID0gTVNJ WF9WRUNUT1JfUEVSX1ZRX0FORF9DT05GSUc7Cj4gPiA+ID4gKyAgIG1heF9pbnRyID0gdmYtPm5y X3ZyaW5nICsgMTsKPiA+ID4gPiArICAgaWYgKG52ZWN0b3JzIDwgbWF4X2ludHIpCj4gPiA+ID4g KyAgICAgICAgICAgdmYtPm1zaXhfdmVjdG9yX3N0YXR1cyA9IE1TSVhfVkVDVE9SX1NIQVJFRF9W UV9BTkRfQ09ORklHOwo+ID4gPiA+ICsKPiA+ID4gPiArICAgaWYgKG52ZWN0b3JzID09IDEpIHsK PiA+ID4gPiArICAgICAgICAgICB2Zi0+bXNpeF92ZWN0b3Jfc3RhdHVzID0gTVNJWF9WRUNUT1Jf REVWX1NIQVJFRDsKPiA+ID4gPiArICAgICAgICAgICByZXQgPSBpZmN2Zl9yZXF1ZXN0X2Rldl9z aGFyZWRfaXJxKGFkYXB0ZXIpOwo+ID4gPiA+ICsKPiA+ID4gPiArICAgICAgICAgICByZXR1cm4g cmV0Owo+ID4gPiA+ICAgICB9Cj4gPiA+ID4gKyAgIHJldCA9IGlmY3ZmX3JlcXVlc3RfdnFfaXJx KGFkYXB0ZXIpOwo+ID4gPiA+ICsgICBpZiAocmV0KQo+ID4gPiA+ICsgICAgICAgICAgIHJldHVy biByZXQ7Cj4gPiA+ID4gKwo+ID4gPiA+ICsgICByZXQgPSBpZmN2Zl9yZXF1ZXN0X2NvbmZpZ19p cnEoYWRhcHRlcik7Cj4gPiA+ID4gKwo+ID4gPiA+ICsgICBpZiAocmV0KQo+ID4gPiA+ICsgICAg ICAgICAgIHJldHVybiByZXQ7Cj4gPiA+ID4gKwo+ID4gPiA+ICAgICByZXR1cm4gMDsKPiA+ID4g PiAgIH0KPiA+ID4gPiBAQCAtNDQxLDcgKzYxMSwxMCBAQCBzdGF0aWMgaW50IGlmY3ZmX3ZkcGFf Z2V0X3ZxX2lycShzdHJ1Y3QgdmRwYV9kZXZpY2UgKnZkcGFfZGV2LAo+ID4gPiA+ICAgewo+ID4g PiA+ICAgICBzdHJ1Y3QgaWZjdmZfaHcgKnZmID0gdmRwYV90b192Zih2ZHBhX2Rldik7Cj4gPiA+ ID4gLSAgIHJldHVybiB2Zi0+dnJpbmdbcWlkXS5pcnE7Cj4gPiA+ID4gKyAgIGlmICh2Zi0+dnFz X3NoYXJlZF9pcnEgPCAwKQo+ID4gPiA+ICsgICAgICAgICAgIHJldHVybiB2Zi0+dnJpbmdbcWlk XS5pcnE7Cj4gPiA+ID4gKyAgIGVsc2UKPiA+ID4gPiArICAgICAgICAgICByZXR1cm4gLUVJTlZB TDsKPiA+ID4gPiAgIH0KPiA+ID4gPiAgIHN0YXRpYyBzdHJ1Y3QgdmRwYV9ub3RpZmljYXRpb25f YXJlYSBpZmN2Zl9nZXRfdnFfbm90aWZpY2F0aW9uKHN0cnVjdCB2ZHBhX2RldmljZSAqdmRwYV9k ZXYsCj4gPgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K VmlydHVhbGl6YXRpb24gbWFpbGluZyBsaXN0ClZpcnR1YWxpemF0aW9uQGxpc3RzLmxpbnV4LWZv dW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xp c3RpbmZvL3ZpcnR1YWxpemF0aW9u From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1D7CDC433F5 for ; Tue, 15 Feb 2022 14:29:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235589AbiBOO30 (ORCPT ); Tue, 15 Feb 2022 09:29:26 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:47832 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232774AbiBOO3Z (ORCPT ); Tue, 15 Feb 2022 09:29:25 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 532FCCEA2D for ; Tue, 15 Feb 2022 06:29:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1644935353; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=aJaT7tTiIAUHk5Poe1JvEf9JYY6BY3ufsdneAooVC6s=; b=idp4/ihNXRHm3LgEJhL1itN/vP3HhKH/FQF1Evvt+gBF1XxLV1bIXFxUGxK4mmCt6gwq99 obGSbhjjSUWiYSOuS58Xmx9GODnSWb3qskLPfjOfiuRIGyuW014nu/Zh4vX8DlHJXkV5gL swFG35oyL1Gi8knizf50qJjCr4wN6jA= Received: from mail-ed1-f70.google.com (mail-ed1-f70.google.com [209.85.208.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-355-GK1d_Pn1Pr-X_F7_YkFM5A-1; Tue, 15 Feb 2022 09:29:12 -0500 X-MC-Unique: GK1d_Pn1Pr-X_F7_YkFM5A-1 Received: by mail-ed1-f70.google.com with SMTP id w3-20020a50c443000000b0040696821132so12438237edf.22 for ; Tue, 15 Feb 2022 06:29:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=aJaT7tTiIAUHk5Poe1JvEf9JYY6BY3ufsdneAooVC6s=; b=Xon+/qe/Dq+I7SMDuhWJgdv6rmLDgxdJFWQ6CxulD+ukukTAXH49w9alBmW+7Rp6Nz l93tUGlc51XwC2CEUxc4lAuUQVxJIoV/hqF8Qfw12o/UJx6f/2/uJNh+ujQCY0AYRolF xsS5AlKgJIxXfNcSsv1e0jTrlXJcixSMWIxmlaGPU/Xi6kC1dJHbW37kJg+dC0C1TdLI iY3MrDztDH6ABBbFyIJW32B8s2K9Mz+OVH/8PQgbWbN7/nWIZWROmgIdUhvwiWeO7O2K B85Ph82/gV3/j8v+hAz8sg8fRKmUCrbM+0e+J3PoiJSk2QHMFmOdr1rSrtN7aRruz9x4 FOjg== X-Gm-Message-State: AOAM532JWJ9N71EYmU+7RW9C1AtfNiOw7tiVJ4srb6mt+FT86xOAJrww /KdSh6bdTMBeREiyZpgQqJ0Sy+dyHjmJjBMy/AtPGl6o38RKbBgwtIM5jOsKMecYl7+3jd1emXR EgO1OodXbYWfOrV4x X-Received: by 2002:a17:906:135a:: with SMTP id x26mr1315254ejb.325.1644935350715; Tue, 15 Feb 2022 06:29:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJwo2EJpQoaVBkF0I4043ub23NV8B2eqRsSc+WMFLJ+57JIiIcdevZMu6B65nzRu2rLTKRWHQQ== X-Received: by 2002:a17:906:135a:: with SMTP id x26mr1315228ejb.325.1644935350315; Tue, 15 Feb 2022 06:29:10 -0800 (PST) Received: from redhat.com ([2a03:c5c0:207e:b00c:b5b3:fd4c:a2cd:10e5]) by smtp.gmail.com with ESMTPSA id e15sm2991485edz.104.2022.02.15.06.29.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 15 Feb 2022 06:29:08 -0800 (PST) Date: Tue, 15 Feb 2022 09:29:05 -0500 From: "Michael S. Tsirkin" To: Jason Wang Cc: Zhu Lingshan , netdev , virtualization Subject: Re: [PATCH V4 4/4] vDPA/ifcvf: implement shared IRQ feature Message-ID: <20220215092846-mutt-send-email-mst@kernel.org> References: <20220203072735.189716-1-lingshan.zhu@intel.com> <20220203072735.189716-5-lingshan.zhu@intel.com> <20220214091842-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Feb 15, 2022 at 11:34:31AM +0800, Jason Wang wrote: > On Mon, Feb 14, 2022 at 10:25 PM Michael S. Tsirkin wrote: > > > > On Mon, Feb 14, 2022 at 03:19:25PM +0800, Jason Wang wrote: > > > > > > 在 2022/2/3 下午3:27, Zhu Lingshan 写道: > > > > On some platforms/devices, there may not be enough MSI vector > > > > slots allocated for virtqueues and config changes. In such a case, > > > > the interrupt sources(virtqueues, config changes) must share > > > > an IRQ/vector, to avoid initialization failures, keep > > > > the device functional. > > > > > > > > This commit handles three cases: > > > > (1) number of the allocated vectors == the number of virtqueues + 1 > > > > (config changes), every virtqueue and the config interrupt has > > > > a separated vector/IRQ, the best and the most likely case. > > > > (2) number of the allocated vectors is less than the best case, but > > > > greater than 1. In this case, all virtqueues share a vector/IRQ, > > > > the config interrupt has a separated vector/IRQ > > > > (3) only one vector is allocated, in this case, the virtqueues and > > > > the config interrupt share a vector/IRQ. The worst and most > > > > unlikely case. > > > > > > > > Otherwise, it needs to fail. > > > > > > > > This commit introduces some helper functions: > > > > ifcvf_set_vq_vector() and ifcvf_set_config_vector() sets virtqueue > > > > vector and config vector in the device config space, so that > > > > the device can send interrupt DMA. > > > > > > > > This commit adds some fields in struct ifcvf_hw and re-placed > > > > the existed fields to be aligned with the cacheline. > > > > > > > > Signed-off-by: Zhu Lingshan > > > > --- > > > > drivers/vdpa/ifcvf/ifcvf_base.c | 47 ++++-- > > > > drivers/vdpa/ifcvf/ifcvf_base.h | 23 ++- > > > > drivers/vdpa/ifcvf/ifcvf_main.c | 243 +++++++++++++++++++++++++++----- > > > > 3 files changed, 256 insertions(+), 57 deletions(-) > > > > > > > > diff --git a/drivers/vdpa/ifcvf/ifcvf_base.c b/drivers/vdpa/ifcvf/ifcvf_base.c > > > > index 397692ae671c..18dcb63ab1e3 100644 > > > > --- a/drivers/vdpa/ifcvf/ifcvf_base.c > > > > +++ b/drivers/vdpa/ifcvf/ifcvf_base.c > > > > @@ -15,6 +15,36 @@ struct ifcvf_adapter *vf_to_adapter(struct ifcvf_hw *hw) > > > > return container_of(hw, struct ifcvf_adapter, vf); > > > > } > > > > +int ifcvf_set_vq_vector(struct ifcvf_hw *hw, u16 qid, int vector) > > > > +{ > > > > + struct virtio_pci_common_cfg __iomem *cfg = hw->common_cfg; > > > > + struct ifcvf_adapter *ifcvf = vf_to_adapter(hw); > > > > + > > > > + ifc_iowrite16(qid, &cfg->queue_select); > > > > + ifc_iowrite16(vector, &cfg->queue_msix_vector); > > > > + if (ifc_ioread16(&cfg->queue_msix_vector) == VIRTIO_MSI_NO_VECTOR) { > > > > + IFCVF_ERR(ifcvf->pdev, "No msix vector for queue %u\n", qid); > > > > + return -EINVAL; > > > > + } > > > > > > > > > Let's leave this check for the caller, E.g can caller try to assign > > > NO_VECTOR during uni-nit? > > > > > > Hmm I'm not sure I agree. Caller will have to write queue select > > again, and that's an extra IO, which is a waste. > > And having function checking itself just seems better contained. > > It's as simple as just return what we read here like virtio_pci did: > > u16 vp_modern_queue_vector(struct virtio_pci_modern_device *mdev, > u16 index, u16 vector) > { > struct virtio_pci_common_cfg __iomem *cfg = mdev->common; > > vp_iowrite16(index, &cfg->queue_select); > vp_iowrite16(vector, &cfg->queue_msix_vector); > /* Flush the write out to device */ > return vp_ioread16(&cfg->queue_msix_vector); > } > EXPORT_SYMBOL_GPL(vp_modern_queue_vector); That would be ok. > Then the caller can decide to check it with NO_VECTOR if needed. > Current code will break the callers that want to set NO_VECTOR. > > > > > > > > > > + > > > > + return 0; > > > > +} > > > > + > > > > +int ifcvf_set_config_vector(struct ifcvf_hw *hw, int vector) > > > > +{ > > > > + struct virtio_pci_common_cfg __iomem *cfg = hw->common_cfg; > > > > + struct ifcvf_adapter *ifcvf = vf_to_adapter(hw); > > > > + > > > > + cfg = hw->common_cfg; > > > > + ifc_iowrite16(vector, &cfg->msix_config); > > > > + if (ifc_ioread16(&cfg->msix_config) == VIRTIO_MSI_NO_VECTOR) { > > > > + IFCVF_ERR(ifcvf->pdev, "No msix vector for device config\n"); > > > > + return -EINVAL; > > > > + } > > > > > > > > > Similar question as above. > > > > > > > > > > + > > > > + return 0; > > > > +} > > > > + > > > > static void __iomem *get_cap_addr(struct ifcvf_hw *hw, > > > > struct virtio_pci_cap *cap) > > > > { > > > > @@ -140,6 +170,8 @@ int ifcvf_init_hw(struct ifcvf_hw *hw, struct pci_dev *pdev) > > > > hw->common_cfg, hw->notify_base, hw->isr, > > > > hw->dev_cfg, hw->notify_off_multiplier); > > > > + hw->vqs_shared_irq = -EINVAL; > > > > + > > > > return 0; > > > > } > > > > @@ -321,12 +353,6 @@ static int ifcvf_hw_enable(struct ifcvf_hw *hw) > > > > ifcvf = vf_to_adapter(hw); > > > > cfg = hw->common_cfg; > > > > - ifc_iowrite16(IFCVF_MSI_CONFIG_OFF, &cfg->msix_config); > > > > - > > > > - if (ifc_ioread16(&cfg->msix_config) == VIRTIO_MSI_NO_VECTOR) { > > > > - IFCVF_ERR(ifcvf->pdev, "No msix vector for device config\n"); > > > > - return -EINVAL; > > > > - } > > > > for (i = 0; i < hw->nr_vring; i++) { > > > > if (!hw->vring[i].ready) > > > > @@ -340,15 +366,6 @@ static int ifcvf_hw_enable(struct ifcvf_hw *hw) > > > > ifc_iowrite64_twopart(hw->vring[i].used, &cfg->queue_used_lo, > > > > &cfg->queue_used_hi); > > > > ifc_iowrite16(hw->vring[i].size, &cfg->queue_size); > > > > - ifc_iowrite16(i + IFCVF_MSI_QUEUE_OFF, &cfg->queue_msix_vector); > > > > - > > > > - if (ifc_ioread16(&cfg->queue_msix_vector) == > > > > - VIRTIO_MSI_NO_VECTOR) { > > > > - IFCVF_ERR(ifcvf->pdev, > > > > - "No msix vector for queue %u\n", i); > > > > - return -EINVAL; > > > > - } > > > > - > > > > ifcvf_set_vq_state(hw, i, hw->vring[i].last_avail_idx); > > > > ifc_iowrite16(1, &cfg->queue_enable); > > > > } > > > > diff --git a/drivers/vdpa/ifcvf/ifcvf_base.h b/drivers/vdpa/ifcvf/ifcvf_base.h > > > > index 949b4fb9d554..9cfe088c82e9 100644 > > > > --- a/drivers/vdpa/ifcvf/ifcvf_base.h > > > > +++ b/drivers/vdpa/ifcvf/ifcvf_base.h > > > > @@ -27,8 +27,6 @@ > > > > #define IFCVF_QUEUE_ALIGNMENT PAGE_SIZE > > > > #define IFCVF_QUEUE_MAX 32768 > > > > -#define IFCVF_MSI_CONFIG_OFF 0 > > > > -#define IFCVF_MSI_QUEUE_OFF 1 > > > > #define IFCVF_PCI_MAX_RESOURCE 6 > > > > #define IFCVF_LM_CFG_SIZE 0x40 > > > > @@ -42,6 +40,13 @@ > > > > #define ifcvf_private_to_vf(adapter) \ > > > > (&((struct ifcvf_adapter *)adapter)->vf) > > > > +/* all vqs and config interrupt has its own vector */ > > > > +#define MSIX_VECTOR_PER_VQ_AND_CONFIG 1 > > > > +/* all vqs share a vector, and config interrupt has a separate vector */ > > > > +#define MSIX_VECTOR_SHARED_VQ_AND_CONFIG 2 > > > > +/* all vqs and config interrupt share a vector */ > > > > +#define MSIX_VECTOR_DEV_SHARED 3 > > > > > > > > > I think there's no much value to differ 2 from 3 consider config interrupt > > > should be rare. > > > > > > Yes but if we do not have a dedicated vector then we need an > > extra device IO (in fact, a read) on each interrupt. > > Ok, right. > > > > > > > > > > + > > > > static inline u8 ifc_ioread8(u8 __iomem *addr) > > > > { > > > > return ioread8(addr); > > > > @@ -97,25 +102,27 @@ struct ifcvf_hw { > > > > u8 __iomem *isr; > > > > /* Live migration */ > > > > u8 __iomem *lm_cfg; > > > > - u16 nr_vring; > > > > > > > > > Any reason for moving nv_vring, config_size, and other stuffs? > > > > > > > > > > /* Notification bar number */ > > > > u8 notify_bar; > > > > + u8 msix_vector_status; > > > > + /* virtio-net or virtio-blk device config size */ > > > > + u32 config_size; > > > > /* Notificaiton bar address */ > > > > void __iomem *notify_base; > > > > phys_addr_t notify_base_pa; > > > > u32 notify_off_multiplier; > > > > + u32 dev_type; > > > > u64 req_features; > > > > u64 hw_features; > > > > - u32 dev_type; > > > > struct virtio_pci_common_cfg __iomem *common_cfg; > > > > void __iomem *dev_cfg; > > > > struct vring_info vring[IFCVF_MAX_QUEUES]; > > > > void __iomem * const *base; > > > > char config_msix_name[256]; > > > > struct vdpa_callback config_cb; > > > > - unsigned int config_irq; > > > > - /* virtio-net or virtio-blk device config size */ > > > > - u32 config_size; > > > > + int config_irq; > > > > + int vqs_shared_irq; > > > > + u16 nr_vring; > > > > }; > > > > struct ifcvf_adapter { > > > > @@ -160,4 +167,6 @@ int ifcvf_set_vq_state(struct ifcvf_hw *hw, u16 qid, u16 num); > > > > struct ifcvf_adapter *vf_to_adapter(struct ifcvf_hw *hw); > > > > int ifcvf_probed_virtio_net(struct ifcvf_hw *hw); > > > > u32 ifcvf_get_config_size(struct ifcvf_hw *hw); > > > > +int ifcvf_set_vq_vector(struct ifcvf_hw *hw, u16 qid, int vector); > > > > +int ifcvf_set_config_vector(struct ifcvf_hw *hw, int vector); > > > > #endif /* _IFCVF_H_ */ > > > > diff --git a/drivers/vdpa/ifcvf/ifcvf_main.c b/drivers/vdpa/ifcvf/ifcvf_main.c > > > > index 44c89ab0b6da..ca414399f040 100644 > > > > --- a/drivers/vdpa/ifcvf/ifcvf_main.c > > > > +++ b/drivers/vdpa/ifcvf/ifcvf_main.c > > > > @@ -17,6 +17,7 @@ > > > > #define DRIVER_AUTHOR "Intel Corporation" > > > > #define IFCVF_DRIVER_NAME "ifcvf" > > > > +/* handles config interrupt */ > > > > > > > > > This seems unrelated to the shared IRQ logic and it looks useless since it's > > > easily to deduce it from the function name below. > > > > > > > > > > static irqreturn_t ifcvf_config_changed(int irq, void *arg) > > > > { > > > > struct ifcvf_hw *vf = arg; > > > > @@ -27,6 +28,7 @@ static irqreturn_t ifcvf_config_changed(int irq, void *arg) > > > > return IRQ_HANDLED; > > > > } > > > > +/* handles vqs interrupt */ > > > > > > > > > So did this. > > > > > > > > > > static irqreturn_t ifcvf_intr_handler(int irq, void *arg) > > > > { > > > > struct vring_info *vring = arg; > > > > @@ -37,24 +39,78 @@ static irqreturn_t ifcvf_intr_handler(int irq, void *arg) > > > > return IRQ_HANDLED; > > > > } > > > > +/* handls vqs shared interrupt */ > > > > +static irqreturn_t ifcvf_vq_shared_intr_handler(int irq, void *arg) > > > > +{ > > > > + struct ifcvf_hw *vf = arg; > > > > + struct vring_info *vring; > > > > + int i; > > > > + > > > > + for (i = 0; i < vf->nr_vring; i++) { > > > > + vring = &vf->vring[i]; > > > > + if (vring->cb.callback) > > > > + vf->vring->cb.callback(vring->cb.private); > > > > + } > > > > + > > > > + return IRQ_HANDLED; > > > > +} > > > > + > > > > +/* handles a shared interrupt for vqs and config */ > > > > +static irqreturn_t ifcvf_dev_shared_intr_handler(int irq, void *arg) > > > > shared is not a good name given IRQ_SHARED is not set. > > maybe "common"? "reused"? > > > > > > +{ > > > > + struct ifcvf_hw *vf = arg; > > > > + u8 isr; > > > > + > > > > + isr = ifc_ioread8(vf->isr); > > > > > > > > > We need to exactly what vp_interrupt do here. Checking against vf->isr first > > > and return IRQ_NONE if it is not set. > > > > no, vf->isr is not set for VQ interrupts. > > I actually wonder what's the actual behaviour of IFCVF. > > > If need to actually poke > > at the VQ to know. > > > > > Always return IRQ_HANDLED will break the device who shares an irq with > > > IFCVF. > > > > > > It's a MSI, not INT#. So interrupt is not shared as such - it's only > > sharing vector between config and vq. > > Right, I thought it was a shared one as virito_pci did. > > > > > > > > > > > > + if (isr & VIRTIO_PCI_ISR_CONFIG) > > > > + ifcvf_config_changed(irq, arg); > > > > + > > > > + return ifcvf_vq_shared_intr_handler(irq, arg); > > > > +} > > > > + > > > > static void ifcvf_free_irq_vectors(void *data) > > > > { > > > > pci_free_irq_vectors(data); > > > > } > > > > -static void ifcvf_free_irq(struct ifcvf_adapter *adapter, int queues) > > > > +static void ifcvf_free_vq_irq(struct ifcvf_adapter *adapter, int queues) > > > > { > > > > struct pci_dev *pdev = adapter->pdev; > > > > struct ifcvf_hw *vf = &adapter->vf; > > > > int i; > > > > + if (vf->msix_vector_status == MSIX_VECTOR_PER_VQ_AND_CONFIG) { > > > > + for (i = 0; i < queues; i++) { > > > > + devm_free_irq(&pdev->dev, vf->vring[i].irq, &vf->vring[i]); > > > > + vf->vring[i].irq = -EINVAL; > > > > + } > > > > + } else { > > > > + devm_free_irq(&pdev->dev, vf->vqs_shared_irq, vf); > > > > + vf->vqs_shared_irq = -EINVAL; > > > > + } > > > > +} > > > > - for (i = 0; i < queues; i++) { > > > > - devm_free_irq(&pdev->dev, vf->vring[i].irq, &vf->vring[i]); > > > > - vf->vring[i].irq = -EINVAL; > > > > +static void ifcvf_free_config_irq(struct ifcvf_adapter *adapter) > > > > +{ > > > > + struct pci_dev *pdev = adapter->pdev; > > > > + struct ifcvf_hw *vf = &adapter->vf; > > > > + > > > > + /* If the irq is shared by all vqs and the config interrupt, > > > > + * it is already freed in ifcvf_free_vq_irq, so here only > > > > + * need to free config irq when msix_vector_status != MSIX_VECTOR_DEV_SHARED > > > > + */ > > > > + if (vf->msix_vector_status != MSIX_VECTOR_DEV_SHARED) { > > > > + devm_free_irq(&pdev->dev, vf->config_irq, vf); > > > > + vf->config_irq = -EINVAL; > > > > } > > > > +} > > > > + > > > > +static void ifcvf_free_irq(struct ifcvf_adapter *adapter, int queues) > > > > +{ > > > > + struct pci_dev *pdev = adapter->pdev; > > > > - devm_free_irq(&pdev->dev, vf->config_irq, vf); > > > > + ifcvf_free_vq_irq(adapter, queues); > > > > + ifcvf_free_config_irq(adapter); > > > > ifcvf_free_irq_vectors(pdev); > > > > } > > > > @@ -86,58 +142,172 @@ static int ifcvf_alloc_vectors(struct ifcvf_adapter *adapter) > > > > return ret; > > > > } > > > > -static int ifcvf_request_irq(struct ifcvf_adapter *adapter) > > > > +static int ifcvf_request_per_vq_irq(struct ifcvf_adapter *adapter) > > > > { > > > > struct pci_dev *pdev = adapter->pdev; > > > > struct ifcvf_hw *vf = &adapter->vf; > > > > - int vector, nvectors, i, ret, irq; > > > > - u16 max_intr; > > > > + int i, vector, ret, irq; > > > > - nvectors = ifcvf_alloc_vectors(adapter); > > > > - if (!(nvectors > 0)) > > > > - return nvectors; > > > > + for (i = 0; i < vf->nr_vring; i++) { > > > > + snprintf(vf->vring[i].msix_name, 256, "ifcvf[%s]-%d\n", pci_name(pdev), i); > > > > + vector = i; > > > > + irq = pci_irq_vector(pdev, vector); > > > > + ret = devm_request_irq(&pdev->dev, irq, > > > > + ifcvf_intr_handler, 0, > > > > + vf->vring[i].msix_name, > > > > + &vf->vring[i]); > > > > + if (ret) { > > > > + IFCVF_ERR(pdev, "Failed to request irq for vq %d\n", i); > > > > + ifcvf_free_vq_irq(adapter, i); > > > > + } else { > > > > + vf->vring[i].irq = irq; > > > > + ifcvf_set_vq_vector(vf, i, vector); > > > > + } > > > > + } > > > > - max_intr = vf->nr_vring + 1; > > > > + vf->vqs_shared_irq = -EINVAL; > > > > + > > > > + return 0; > > > > +} > > > > + > > > > +static int ifcvf_request_shared_vq_irq(struct ifcvf_adapter *adapter) > > > > +{ > > > > + struct pci_dev *pdev = adapter->pdev; > > > > + struct ifcvf_hw *vf = &adapter->vf; > > > > + int i, vector, ret, irq; > > > > + > > > > + vector = 0; > > > > + /* reuse msix_name[256] space of vring0 to store shared vqs interrupt name */ > > > > > > > > > I think we can remove this comment since the code is straightforward. > > > > > > > > > > + snprintf(vf->vring[0].msix_name, 256, "ifcvf[%s]-vqs-shared-irq\n", pci_name(pdev)); > > > > + irq = pci_irq_vector(pdev, vector); > > > > + ret = devm_request_irq(&pdev->dev, irq, > > > > + ifcvf_vq_shared_intr_handler, 0, > > > > + vf->vring[0].msix_name, vf); > > > > + if (ret) { > > > > + IFCVF_ERR(pdev, "Failed to request shared irq for vf\n"); > > > > + > > > > + return ret; > > > > + } > > > > + > > > > + vf->vqs_shared_irq = irq; > > > > + for (i = 0; i < vf->nr_vring; i++) { > > > > + vf->vring[i].irq = -EINVAL; > > > > + ifcvf_set_vq_vector(vf, i, vector); > > > > + } > > > > + > > > > + return 0; > > > > + > > > > +} > > > > + > > > > +static int ifcvf_request_dev_shared_irq(struct ifcvf_adapter *adapter) > > > > +{ > > > > + struct pci_dev *pdev = adapter->pdev; > > > > + struct ifcvf_hw *vf = &adapter->vf; > > > > + int i, vector, ret, irq; > > > > + > > > > + vector = 0; > > > > + /* reuse msix_name[256] space of vring0 to store shared device interrupt name */ > > > > + snprintf(vf->vring[0].msix_name, 256, "ifcvf[%s]-dev-shared-irq\n", pci_name(pdev)); > > > > + irq = pci_irq_vector(pdev, vector); > > > > + ret = devm_request_irq(&pdev->dev, irq, > > > > + ifcvf_dev_shared_intr_handler, 0, > > > > + vf->vring[0].msix_name, vf); > > > > + if (ret) { > > > > + IFCVF_ERR(pdev, "Failed to request shared irq for vf\n"); > > > > - ret = pci_alloc_irq_vectors(pdev, max_intr, > > > > - max_intr, PCI_IRQ_MSIX); > > > > - if (ret < 0) { > > > > - IFCVF_ERR(pdev, "Failed to alloc IRQ vectors\n"); > > > > return ret; > > > > } > > > > + vf->vqs_shared_irq = irq; > > > > + for (i = 0; i < vf->nr_vring; i++) { > > > > + vf->vring[i].irq = -EINVAL; > > > > + ifcvf_set_vq_vector(vf, i, vector); > > > > + } > > > > + > > > > + vf->config_irq = irq; > > > > + ifcvf_set_config_vector(vf, vector); > > > > + > > > > + return 0; > > > > + > > > > +} > > > > + > > > > +static int ifcvf_request_vq_irq(struct ifcvf_adapter *adapter) > > > > +{ > > > > + struct ifcvf_hw *vf = &adapter->vf; > > > > + int ret; > > > > + > > > > + if (vf->msix_vector_status == MSIX_VECTOR_PER_VQ_AND_CONFIG) > > > > + ret = ifcvf_request_per_vq_irq(adapter); > > > > + else > > > > + ret = ifcvf_request_shared_vq_irq(adapter); > > > > + > > > > + return ret; > > > > +} > > > > + > > > > +static int ifcvf_request_config_irq(struct ifcvf_adapter *adapter) > > > > +{ > > > > + struct pci_dev *pdev = adapter->pdev; > > > > + struct ifcvf_hw *vf = &adapter->vf; > > > > + int config_vector, ret; > > > > + > > > > + if (vf->msix_vector_status == MSIX_VECTOR_DEV_SHARED) > > > > + return 0; > > > > + > > > > + if (vf->msix_vector_status == MSIX_VECTOR_PER_VQ_AND_CONFIG) > > > > + /* vector 0 ~ vf->nr_vring for vqs, num vf->nr_vring vector for config interrupt */ > > > > + config_vector = vf->nr_vring; > > > > + > > > > + if (vf->msix_vector_status == MSIX_VECTOR_SHARED_VQ_AND_CONFIG) > > > > + /* vector 0 for vqs and 1 for config interrupt */ > > > > + config_vector = 1; > > > > + > > > > snprintf(vf->config_msix_name, 256, "ifcvf[%s]-config\n", > > > > pci_name(pdev)); > > > > - vector = 0; > > > > - vf->config_irq = pci_irq_vector(pdev, vector); > > > > + vf->config_irq = pci_irq_vector(pdev, config_vector); > > > > ret = devm_request_irq(&pdev->dev, vf->config_irq, > > > > ifcvf_config_changed, 0, > > > > vf->config_msix_name, vf); > > > > if (ret) { > > > > IFCVF_ERR(pdev, "Failed to request config irq\n"); > > > > + ifcvf_free_vq_irq(adapter, vf->nr_vring); > > > > return ret; > > > > } > > > > - for (i = 0; i < vf->nr_vring; i++) { > > > > - snprintf(vf->vring[i].msix_name, 256, "ifcvf[%s]-%d\n", > > > > - pci_name(pdev), i); > > > > - vector = i + IFCVF_MSI_QUEUE_OFF; > > > > - irq = pci_irq_vector(pdev, vector); > > > > - ret = devm_request_irq(&pdev->dev, irq, > > > > - ifcvf_intr_handler, 0, > > > > - vf->vring[i].msix_name, > > > > - &vf->vring[i]); > > > > - if (ret) { > > > > - IFCVF_ERR(pdev, > > > > - "Failed to request irq for vq %d\n", i); > > > > - ifcvf_free_irq(adapter, i); > > > > + ifcvf_set_config_vector(vf, config_vector); > > > > - return ret; > > > > - } > > > > + return 0; > > > > +} > > > > + > > > > +static int ifcvf_request_irq(struct ifcvf_adapter *adapter) > > > > +{ > > > > > > > > > As replied above, I think having two modes should be sufficient and the code > > > could be greatly simplified. > > > > > > Thanks > > > > > > > Well it is claimed there are platforms where we are short > > on vectors. 3 versus 2 seems a 50% saving. You disagree? > > I think we can 2 vectors (a dedicated for config). > > Thanks > > > > > > > + struct ifcvf_hw *vf = &adapter->vf; > > > > + int nvectors, ret, max_intr; > > > > - vf->vring[i].irq = irq; > > > > + nvectors = ifcvf_alloc_vectors(adapter); > > > > + if (!(nvectors > 0)) > > > > + return nvectors; > > > > + > > > > + vf->msix_vector_status = MSIX_VECTOR_PER_VQ_AND_CONFIG; > > > > + max_intr = vf->nr_vring + 1; > > > > + if (nvectors < max_intr) > > > > + vf->msix_vector_status = MSIX_VECTOR_SHARED_VQ_AND_CONFIG; > > > > + > > > > + if (nvectors == 1) { > > > > + vf->msix_vector_status = MSIX_VECTOR_DEV_SHARED; > > > > + ret = ifcvf_request_dev_shared_irq(adapter); > > > > + > > > > + return ret; > > > > } > > > > + ret = ifcvf_request_vq_irq(adapter); > > > > + if (ret) > > > > + return ret; > > > > + > > > > + ret = ifcvf_request_config_irq(adapter); > > > > + > > > > + if (ret) > > > > + return ret; > > > > + > > > > return 0; > > > > } > > > > @@ -441,7 +611,10 @@ static int ifcvf_vdpa_get_vq_irq(struct vdpa_device *vdpa_dev, > > > > { > > > > struct ifcvf_hw *vf = vdpa_to_vf(vdpa_dev); > > > > - return vf->vring[qid].irq; > > > > + if (vf->vqs_shared_irq < 0) > > > > + return vf->vring[qid].irq; > > > > + else > > > > + return -EINVAL; > > > > } > > > > static struct vdpa_notification_area ifcvf_get_vq_notification(struct vdpa_device *vdpa_dev, > >