From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0981CC433EF for ; Tue, 15 Feb 2022 09:45:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233386AbiBOJpN (ORCPT ); Tue, 15 Feb 2022 04:45:13 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:48764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232267AbiBOJpN (ORCPT ); Tue, 15 Feb 2022 04:45:13 -0500 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2B382E61E1; Tue, 15 Feb 2022 01:45:03 -0800 (PST) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D2EAF1F38A; Tue, 15 Feb 2022 09:45:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1644918301; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=30j1t+BysVNM2M5YkR9BOryVBI0lVA+UTPwiJwtZ/ck=; b=l2uC+Y5I+VaWIvIauDW98b9US/LXnMopiuG50JFdVDqlHW7fx+TVxgVrlcpdAtEh3YTZ4y 4KRWReMNSjqaFxO+1v2RRrdxF3YFVBuygZL4wrr8ms1EXO/A8mGmKqxlZEe1qVY8MSLoBA +cGa8ByBW2GntE0h8IKSXvbn9HKfTSk= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9ADCD13C36; Tue, 15 Feb 2022 09:45:01 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id YKqyJB12C2IVCAAAMHmgww (envelope-from ); Tue, 15 Feb 2022 09:45:01 +0000 Date: Tue, 15 Feb 2022 10:45:00 +0100 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: Shuah Khan Cc: Eric Biederman , Alexey Gladkov , Kees Cook , Shuah Khan , Christian Brauner , Solar Designer , Ran Xiaokai , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, Linux Containers Subject: Re: [RFC PATCH 5/6] selftests: Challenge RLIMIT_NPROC in user namespaces Message-ID: <20220215094459.GC21589@blackbody.suse.cz> References: <20220207121800.5079-1-mkoutny@suse.com> <20220207121800.5079-6-mkoutny@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kselftest@vger.kernel.org On Wed, Feb 09, 2022 at 06:22:18PM -0700, Shuah Khan wrote: > Please see comments below. A bit of a concern with how long this test > will run. Did you time it? It runs around 1 s, I didn't measure it and I used it manually only. > How long does this test now run for with this loop? I kept this sleep to space output from individual tasks for better readability of output. It's not necessary for the sake of the test. I'll remove it in next version. > > - for (i = 0; i < NR_CHILDS; i++) { > > + for (i = 0; i < NR_CHILDREN; i++) { > > if (WIFEXITED(wstatus[i])) > > warnx("(pid=%d): pid %d exited, status=%d", > > pid, -child[i], WEXITSTATUS(wstatus[i])); > > > > Please a add few more comments in the code path. Hehe, this is inherited from the original version. (True, it's not overly clear on its own.) Michal