From: "hch@lst.de" <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Chaitanya Kulkarni <chaitanyak@nvidia.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"hch@lst.de" <hch@lst.de>, "sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: [PATCH] nvme: remove nssa from struct nvme_ctrl
Date: Tue, 15 Feb 2022 19:38:53 +0100 [thread overview]
Message-ID: <20220215183853.GA24529@lst.de> (raw)
In-Reply-To: <20220215183736.GA1934598@dhcp-10-100-145-180.wdc.com>
On Tue, Feb 15, 2022 at 10:37:36AM -0800, Keith Busch wrote:
> > > Looks good, can we make this feature configurable from KConfig ?
> > >
> >
> > right question is should we make optional features configurable ?
>
> I don't see why. What benefit does the driver stand to gain from
> conditionally compiling such capabilities?
I could see the benefit for a really big feature that is not required
on typical embedded setups. But multipathing is the only feature
anywhere that threshold.
next prev parent reply other threads:[~2022-02-15 18:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 15:37 [PATCH] nvme: remove nssa from struct nvme_ctrl Keith Busch
2022-02-15 17:03 ` Chaitanya Kulkarni
2022-02-15 17:09 ` Chaitanya Kulkarni
2022-02-15 18:37 ` Keith Busch
2022-02-15 18:38 ` hch [this message]
2022-02-15 19:19 ` Chaitanya Kulkarni
2022-02-16 8:05 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220215183853.GA24529@lst.de \
--to=hch@lst.de \
--cc=chaitanyak@nvidia.com \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.