From: Jeevan B <jeevan.b@intel.com>
To: igt-dev@lists.freedesktop.org
Cc: juha-pekka.heikkila@intel.com
Subject: [igt-dev] [PATCH i-g-t v3 15/15] tests/kms_plane_scaling: Use tiling 4 if platform has support for it
Date: Wed, 16 Feb 2022 15:56:33 +0530 [thread overview]
Message-ID: <20220216102633.26949-16-jeevan.b@intel.com> (raw)
In-Reply-To: <20220216102633.26949-1-jeevan.b@intel.com>
From: Mika Kahola <mika.kahola@intel.com>
Switch using tiling 4 if a platform has support for it. For DG2 tiling 4
is superseeds Y tiling.
Signed-off-by: Mika Kahola <mika.kahola@intel.com>
Signed-off-by: Jeevan B <jeevan.b@intel.com>
---
tests/kms_plane_scaling.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/tests/kms_plane_scaling.c b/tests/kms_plane_scaling.c
index 1ab7e5ce..4baa8855 100644
--- a/tests/kms_plane_scaling.c
+++ b/tests/kms_plane_scaling.c
@@ -45,6 +45,7 @@ typedef struct {
igt_plane_t *plane3;
igt_plane_t *plane4;
bool extended;
+ bool has_4tile;
} data_t;
static int get_num_scalers(data_t* d, enum pipe pipe)
@@ -250,6 +251,9 @@ static void test_scaler_with_rotation_pipe(data_t *d, enum pipe pipe,
uint64_t modifier = is_i915_device(d->drm_fd) ?
I915_FORMAT_MOD_Y_TILED : DRM_FORMAT_MOD_LINEAR;
+ if (d->has_4tile)
+ modifier = I915_FORMAT_MOD_4_TILED;
+
igt_require(get_num_scalers(d, pipe) > 0);
igt_output_set_pipe(output, pipe);
@@ -285,7 +289,8 @@ static const uint64_t modifiers[] = {
DRM_FORMAT_MOD_LINEAR,
I915_FORMAT_MOD_X_TILED,
I915_FORMAT_MOD_Y_TILED,
- I915_FORMAT_MOD_Yf_TILED
+ I915_FORMAT_MOD_Yf_TILED,
+ I915_FORMAT_MOD_4_TILED
};
static void test_scaler_with_pixel_format_pipe(data_t *d, enum pipe pipe, igt_output_t *output)
@@ -531,6 +536,7 @@ test_scaler_with_clipping_clamping_scenario(data_t *d, enum pipe pipe, igt_outpu
igt_pipe_t *pipe_obj = &d->display.pipes[pipe];
drmModeModeInfo *mode;
struct igt_vec tested_formats1;
+ uint64_t modifier = d->has_4tile ? I915_FORMAT_MOD_4_TILED : I915_FORMAT_MOD_Y_TILED;
igt_require(get_num_scalers(d, pipe) >= 2);
@@ -567,7 +573,7 @@ test_scaler_with_clipping_clamping_scenario(data_t *d, enum pipe pipe, igt_outpu
igt_create_pattern_fb(d->drm_fd,
mode->hdisplay, mode->vdisplay, f2,
- I915_FORMAT_MOD_Y_TILED,
+ modifier,
&d->fb[2]);
__test_scaler_with_clipping_clamping_scenario(d, mode);
@@ -613,10 +619,9 @@ static void test_scaler_with_multi_pipe_plane(data_t *d)
igt_output_t *output1, *output2;
drmModeModeInfo *mode1, *mode2;
enum pipe pipe1, pipe2;
- bool has_4tile = intel_get_device_info(intel_get_drm_devid(d->drm_fd))->has_4tile;
uint64_t modifier;
- if (is_i915_device(display->drm_fd) && has_4tile)
+ if (is_i915_device(display->drm_fd) && d->has_4tile)
modifier = I915_FORMAT_MOD_4_TILED;
else if (is_i915_device(display->drm_fd))
modifier = I915_FORMAT_MOD_Y_TILED;
@@ -721,6 +726,8 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
data.devid = is_i915_device(data.drm_fd) ?
intel_get_drm_devid(data.drm_fd) : 0;
igt_require(data.display.is_atomic);
+ data.has_4tile = is_i915_device(data.drm_fd) &&
+ intel_get_device_info(intel_get_drm_devid(data.drm_fd))->has_4tile;
}
igt_subtest_group {
--
2.17.1
next prev parent reply other threads:[~2022-02-16 10:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 10:26 [igt-dev] [PATCH i-g-t v3 00/15] DG2 platform definition and Tile 4 plane format support Jeevan B
2022-02-16 10:26 ` [igt-dev] [PATCH i-g-t v3 01/15] lib/intel_device_info: Add a flag to indicate tiling 4 support Jeevan B
2022-02-16 10:26 ` [igt-dev] [PATCH i-g-t v3 02/15] igt/lib: Add tile 4(F-tile) format support Jeevan B
2022-02-16 10:46 ` Petri Latvala
2022-02-16 10:56 ` B, Jeevan
2022-02-16 10:26 ` [igt-dev] [PATCH i-g-t v3 03/15] lib/igt_draw: Add pixel math for tile-4 Jeevan B
2022-02-16 10:26 ` [igt-dev] [PATCH i-g-t v3 04/15] igt/tests: Add support for Tile4(TileF) format to kms_draw_crc Jeevan B
2022-02-17 12:51 ` Lisovskiy, Stanislav
2022-02-18 8:15 ` B, Jeevan
2022-02-18 10:16 ` Lisovskiy, Stanislav
2022-02-18 10:23 ` B, Jeevan
2022-02-16 10:26 ` [igt-dev] [PATCH i-g-t v3 05/15] igt/tests: Add support for Tile4(TileF) format to kms_rotation_crc Jeevan B
2022-02-16 10:26 ` [igt-dev] [PATCH i-g-t v3 06/15] igt/tests: Add support for Tile4(TileF) format to tests/kms_plane_multiple Jeevan B
2022-02-16 10:26 ` [igt-dev] [PATCH i-g-t v3 07/15] igt/tests: Add support for Tile4(TileF) format to tests/kms_plane_lowres Jeevan B
2022-02-16 10:26 ` [igt-dev] [PATCH i-g-t v3 08/15] igt/tests: Add support for Tile4(TileF) format to tests/kms_big_fb Jeevan B
2022-02-16 10:26 ` [igt-dev] [PATCH i-g-t v3 09/15] igt/tests: Add support for Tile4(TileF) format to testdisplay Jeevan B
2022-02-16 10:26 ` [igt-dev] [PATCH i-g-t v3 10/15] lib/igt_draw: Use XY_FAST_COLOR_BLT on DG2 Jeevan B
2022-02-16 10:26 ` [igt-dev] [PATCH i-g-t v3 11/15] igt/tests: Add support for Tile4(TileF) format to tests/kms_addfb_basic Jeevan B
2022-02-16 10:26 ` [igt-dev] [PATCH i-g-t v3 12/15] tests/kms_frontbuffer_tracking: Add support for 4 tiling Jeevan B
2022-02-16 10:26 ` [igt-dev] [PATCH i-g-t v3 13/15] tests/kms_draw_crc: Use 4 tiling when filling framebuffer Jeevan B
2022-02-16 10:26 ` [igt-dev] [PATCH i-g-t v3 14/15] tests/kms_plane_scaling: Adding Tile-4 support Jeevan B
2022-02-16 10:26 ` Jeevan B [this message]
2022-02-16 13:05 ` [igt-dev] ✗ Fi.CI.BAT: failure for DG2 platform definition and Tile 4 plane format support (rev3) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220216102633.26949-16-jeevan.b@intel.com \
--to=jeevan.b@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=juha-pekka.heikkila@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.