From: Jason Gunthorpe <jgg@nvidia.com>
To: Bob Pearson <rpearsonhpe@gmail.com>
Cc: linux-rdma@vger.kernel.org, zyjzyj2000@gmail.com,
guoqing.jiang@linux.dev, bvanassche@acm.org
Subject: Re: [PATCH for-next] RDMA/rxe: Revert changes from irqsave to bh locks
Date: Wed, 16 Feb 2022 13:44:51 -0400 [thread overview]
Message-ID: <20220216174451.GA1265489@nvidia.com> (raw)
In-Reply-To: <20220215194448.44369-1-rpearsonhpe@gmail.com>
On Tue, Feb 15, 2022 at 01:44:49PM -0600, Bob Pearson wrote:
> A previous patch replaced all irqsave locks in rxe with bh locks.
> This ran into problems because rdmacm has a bad habit of
> calling rdma verbs APIs while disabling irqs. This is not allowed
> during spin_unlock_bh() causing programs that use rdmacm to fail.
> This patch reverts the changes to locks that had this problem or
> got dragged into the same mess. After this patch blktests/check -q srp
> now runs correctly.
>
> This patch applies cleanly to current for-next
>
> commit: 2f1b2820b546 ("Merge branch 'irdma_dscp' into rdma.git for-next")
>
> Reported-by: Guoqing Jiang <guoqing.jiang@linux.dev>
> Reported-by: Bart Van Assche <bvanassche@acm.org>
> Fixes: 21adfa7a3c4e ("RDMA/rxe: Replace irqsave locks with bh locks")
> Signed-off-by: Bob Pearson <rpearsonhpe@gmail.com>
> ---
> drivers/infiniband/sw/rxe/rxe_cq.c | 20 +++++++++++-------
> drivers/infiniband/sw/rxe/rxe_mcast.c | 19 ++++++++++-------
> drivers/infiniband/sw/rxe/rxe_pool.c | 30 ++++++++++++++++-----------
> drivers/infiniband/sw/rxe/rxe_queue.c | 10 +++++----
> drivers/infiniband/sw/rxe/rxe_resp.c | 11 +++++-----
> drivers/infiniband/sw/rxe/rxe_verbs.c | 27 ++++++++++++++----------
> 6 files changed, 69 insertions(+), 48 deletions(-)
Applied to for-next, thanks
I also rebased the other patches I took on top of this, you should
probably check the wip branch
Jason
next prev parent reply other threads:[~2022-02-16 17:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-15 19:44 [PATCH for-next] RDMA/rxe: Revert changes from irqsave to bh locks Bob Pearson
2022-02-15 21:02 ` Bart Van Assche
2022-02-16 1:09 ` Zhu Yanjun
2022-02-16 7:07 ` Leon Romanovsky
2022-02-16 17:44 ` Jason Gunthorpe [this message]
2022-02-17 2:03 ` Guoqing Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220216174451.GA1265489@nvidia.com \
--to=jgg@nvidia.com \
--cc=bvanassche@acm.org \
--cc=guoqing.jiang@linux.dev \
--cc=linux-rdma@vger.kernel.org \
--cc=rpearsonhpe@gmail.com \
--cc=zyjzyj2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.