From: David Ahern <dsahern@kernel.org>
To: netdev@vger.kernel.org
Cc: stephen@networkplumber.org, parav@nvidia.com, jiri@nvidia.com,
David Ahern <dsahern@kernel.org>
Subject: [PATCH iproute2-next 1/4] devlink: Remove strtouint64_t in favor of get_u64
Date: Wed, 16 Feb 2022 19:57:08 -0700 [thread overview]
Message-ID: <20220217025711.9369-2-dsahern@kernel.org> (raw)
In-Reply-To: <20220217025711.9369-1-dsahern@kernel.org>
strtouint64_t duplicates get_u64; remove it.
Signed-off-by: David Ahern <dsahern@kernel.org>
---
devlink/devlink.c | 30 ++++++++----------------------
1 file changed, 8 insertions(+), 22 deletions(-)
diff --git a/devlink/devlink.c b/devlink/devlink.c
index d39792ec9212..4e2dc6e09682 100644
--- a/devlink/devlink.c
+++ b/devlink/devlink.c
@@ -315,7 +315,7 @@ struct dl_opts {
bool dpipe_counters_enabled;
enum devlink_eswitch_encap_mode eswitch_encap_mode;
const char *resource_path;
- uint64_t resource_size;
+ __u64 resource_size;
uint32_t resource_id;
bool resource_id_valid;
const char *param_name;
@@ -323,12 +323,12 @@ struct dl_opts {
enum devlink_param_cmode cmode;
char *region_name;
uint32_t region_snapshot_id;
- uint64_t region_address;
- uint64_t region_length;
+ __u64 region_address;
+ __u64 region_length;
const char *flash_file_name;
const char *flash_component;
const char *reporter_name;
- uint64_t reporter_graceful_period;
+ __u64 reporter_graceful_period;
bool reporter_auto_recover;
bool reporter_auto_dump;
const char *trap_name;
@@ -337,8 +337,8 @@ struct dl_opts {
bool netns_is_pid;
uint32_t netns;
uint32_t trap_policer_id;
- uint64_t trap_policer_rate;
- uint64_t trap_policer_burst;
+ __u64 trap_policer_rate;
+ __u64 trap_policer_burst;
char port_function_hw_addr[MAX_ADDR_LEN];
uint32_t port_function_hw_addr_len;
uint32_t overwrite_mask;
@@ -857,20 +857,6 @@ static int ifname_map_rev_lookup(struct dl *dl, const char *bus_name,
return -ENOENT;
}
-static int strtouint64_t(const char *str, uint64_t *p_val)
-{
- char *endptr;
- unsigned long long int val;
-
- val = strtoull(str, &endptr, 10);
- if (endptr == str || *endptr != '\0')
- return -EINVAL;
- if (val > ULONG_MAX)
- return -ERANGE;
- *p_val = val;
- return 0;
-}
-
static int strtouint32_t(const char *str, uint32_t *p_val)
{
char *endptr;
@@ -1173,7 +1159,7 @@ static int dl_argv_handle_rate(struct dl *dl, char **p_bus_name,
return 0;
}
-static int dl_argv_uint64_t(struct dl *dl, uint64_t *p_val)
+static int dl_argv_uint64_t(struct dl *dl, __u64 *p_val)
{
char *str = dl_argv_next(dl);
int err;
@@ -1183,7 +1169,7 @@ static int dl_argv_uint64_t(struct dl *dl, uint64_t *p_val)
return -EINVAL;
}
- err = strtouint64_t(str, p_val);
+ err = get_u64(p_val, str, 10);
if (err) {
pr_err("\"%s\" is not a number or not within range\n", str);
return err;
--
2.24.3 (Apple Git-128)
next prev parent reply other threads:[~2022-02-17 2:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 2:57 [PATCH iproute2-next 0/4] devlink: Remove custom string conversions David Ahern
2022-02-17 2:57 ` David Ahern [this message]
2022-02-17 2:57 ` [PATCH iproute2-next 2/4] devlink: Remove strtouint32_t in favor of get_u32 David Ahern
2022-02-17 2:57 ` [PATCH iproute2-next 3/4] devlink: Remove strtouint16_t in favor of get_u16 David Ahern
2022-02-17 2:57 ` [PATCH iproute2-next 4/4] devlink: Remove strtouint8_t in favor of get_u8 David Ahern
2022-02-21 16:40 ` [PATCH iproute2-next 0/4] devlink: Remove custom string conversions patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220217025711.9369-2-dsahern@kernel.org \
--to=dsahern@kernel.org \
--cc=jiri@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=parav@nvidia.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.