From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 29460C433EF for ; Thu, 17 Feb 2022 06:48:29 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-16-6N9RhuMGMIOIXlAGmmuqQA-1; Thu, 17 Feb 2022 01:48:24 -0500 X-MC-Unique: 6N9RhuMGMIOIXlAGmmuqQA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C1206180FD60; Thu, 17 Feb 2022 06:48:19 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1F6026C18B; Thu, 17 Feb 2022 06:48:18 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 4EAD01809CB8; Thu, 17 Feb 2022 06:48:15 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 21H6i1l6002739 for ; Thu, 17 Feb 2022 01:44:01 -0500 Received: by smtp.corp.redhat.com (Postfix) id 1A3771120AA8; Thu, 17 Feb 2022 06:44:01 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast08.extmail.prod.ext.rdu2.redhat.com [10.11.55.24]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1552B112132C for ; Thu, 17 Feb 2022 06:43:56 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C96473804508 for ; Thu, 17 Feb 2022 06:43:56 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-1-CdCWwVsuORyeR_003sORIA-1; Thu, 17 Feb 2022 01:43:53 -0500 X-MC-Unique: CdCWwVsuORyeR_003sORIA-1 Received: by verein.lst.de (Postfix, from userid 2407) id AD69868B05; Thu, 17 Feb 2022 07:43:49 +0100 (CET) Date: Thu, 17 Feb 2022 07:43:49 +0100 From: Christoph Hellwig To: Jens Axboe Message-ID: <20220217064349.GA374@lst.de> References: <20220209082828.2629273-1-hch@lst.de> <20220210055151.GA3491@lst.de> <2f3f1c98-e013-ee03-2ffb-3a14730b13b9@kernel.dk> MIME-Version: 1.0 In-Reply-To: <2f3f1c98-e013-ee03-2ffb-3a14730b13b9@kernel.dk> User-Agent: Mutt/1.5.17 (2007-11-01) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: dm-devel@redhat.com Cc: manoj@linux.ibm.com, linux-scsi@vger.kernel.org, "Martin K. Petersen" , philipp.reisner@linbit.com, linux-block@vger.kernel.org, dm-devel@redhat.com, target-devel@vger.kernel.org, haris.iqbal@ionos.com, ukrishn@linux.ibm.com, lars.ellenberg@linbit.com, drbd-dev@lists.linbit.com, jinpu.wang@ionos.com, Christoph Hellwig , mrochs@linux.ibm.com Subject: Re: [dm-devel] remove REQ_OP_WRITE_SAME v2 X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Feb 16, 2022 at 08:07:56PM -0700, Jens Axboe wrote: > Let's just use the SCSI tree - I didn't check if it throws any conflicts > right now, so probably something to check upfront... There is a minor conflict because the __blkdev_issue_write_same function removed by this series is affected by the blk_next_bio calling convention change in the block tree, but the fixup is trivial. Martin: do you want to fix that up when applying, or do you want me to resend? If you have your discard rework ready you can also send that now and I'll rebase on top of that. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62325C433FE for ; Thu, 17 Feb 2022 06:43:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235603AbiBQGoJ (ORCPT ); Thu, 17 Feb 2022 01:44:09 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:45308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbiBQGoI (ORCPT ); Thu, 17 Feb 2022 01:44:08 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA4D2178386; Wed, 16 Feb 2022 22:43:54 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id AD69868B05; Thu, 17 Feb 2022 07:43:49 +0100 (CET) Date: Thu, 17 Feb 2022 07:43:49 +0100 From: Christoph Hellwig To: Jens Axboe Cc: Christoph Hellwig , "Martin K. Petersen" , philipp.reisner@linbit.com, lars.ellenberg@linbit.com, target-devel@vger.kernel.org, haris.iqbal@ionos.com, jinpu.wang@ionos.com, manoj@linux.ibm.com, mrochs@linux.ibm.com, ukrishn@linux.ibm.com, linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, drbd-dev@lists.linbit.com, dm-devel@redhat.com Subject: Re: remove REQ_OP_WRITE_SAME v2 Message-ID: <20220217064349.GA374@lst.de> References: <20220209082828.2629273-1-hch@lst.de> <20220210055151.GA3491@lst.de> <2f3f1c98-e013-ee03-2ffb-3a14730b13b9@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2f3f1c98-e013-ee03-2ffb-3a14730b13b9@kernel.dk> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Feb 16, 2022 at 08:07:56PM -0700, Jens Axboe wrote: > Let's just use the SCSI tree - I didn't check if it throws any conflicts > right now, so probably something to check upfront... There is a minor conflict because the __blkdev_issue_write_same function removed by this series is affected by the blk_next_bio calling convention change in the block tree, but the fixup is trivial. Martin: do you want to fix that up when applying, or do you want me to resend? If you have your discard rework ready you can also send that now and I'll rebase on top of that. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id BD31D4202E4 for ; Thu, 17 Feb 2022 07:43:52 +0100 (CET) Date: Thu, 17 Feb 2022 07:43:49 +0100 From: Christoph Hellwig To: Jens Axboe Message-ID: <20220217064349.GA374@lst.de> References: <20220209082828.2629273-1-hch@lst.de> <20220210055151.GA3491@lst.de> <2f3f1c98-e013-ee03-2ffb-3a14730b13b9@kernel.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2f3f1c98-e013-ee03-2ffb-3a14730b13b9@kernel.dk> Cc: manoj@linux.ibm.com, linux-scsi@vger.kernel.org, "Martin K. Petersen" , philipp.reisner@linbit.com, linux-block@vger.kernel.org, dm-devel@redhat.com, target-devel@vger.kernel.org, haris.iqbal@ionos.com, ukrishn@linux.ibm.com, lars.ellenberg@linbit.com, drbd-dev@lists.linbit.com, jinpu.wang@ionos.com, Christoph Hellwig , mrochs@linux.ibm.com Subject: Re: [Drbd-dev] remove REQ_OP_WRITE_SAME v2 List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Feb 16, 2022 at 08:07:56PM -0700, Jens Axboe wrote: > Let's just use the SCSI tree - I didn't check if it throws any conflicts > right now, so probably something to check upfront... There is a minor conflict because the __blkdev_issue_write_same function removed by this series is affected by the blk_next_bio calling convention change in the block tree, but the fixup is trivial. Martin: do you want to fix that up when applying, or do you want me to resend? If you have your discard rework ready you can also send that now and I'll rebase on top of that.