From: Dan Carpenter <dan.carpenter@oracle.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Dongliang Mu <mudongliangabcd@gmail.com>,
Salah Triki <salah.triki@gmail.com>,
benjamin.tissoires@redhat.com, jikos@kernel.org,
linux-input@vger.kernel.org, linux-usb@vger.kernel.org,
noralf@tronnes.org,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
tzimmermann@suse.de
Subject: Re: [PATCH] HID: elo: Fix refcount leak in elo_probe()
Date: Thu, 17 Feb 2022 11:19:25 +0300 [thread overview]
Message-ID: <20220217081925.GA2467@kadam> (raw)
In-Reply-To: <20220217080459.GB2407@kadam>
On Thu, Feb 17, 2022 at 11:04:59AM +0300, Dan Carpenter wrote:
>
> Salah sent a bunch of these. The reasoning was explained in this email.
>
> https://www.spinics.net/lists/kernel/msg4026672.html
>
> When he resent the patch, Greg said that taking the reference wasn't
> needed so the patch wasn't applied. (Also it had the same reference
> leak so that's a second reason it wasn't applied).
>
> https://lkml.org/lkml/2021/8/4/324
>
> So someone should go through and revert all of Salah's bogus usb_get_dev()
> patches.
Never mind, this is the only usb_get_dev() which was merged.
regards,
dan carpenter
next prev parent reply other threads:[~2022-02-17 8:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 20:17 [syzbot] memory leak in hub_event (3) syzbot
2022-02-11 21:23 ` Alan Stern
2022-02-11 21:36 ` syzbot
2022-02-12 1:50 ` [PATCH] HID: elo: Fix refcount leak in elo_probe() Alan Stern
2022-02-14 7:34 ` Dongliang Mu
2022-02-14 14:41 ` Alan Stern
2022-02-17 8:04 ` Dan Carpenter
2022-02-17 8:19 ` Dan Carpenter [this message]
2022-02-17 13:21 ` Jiri Kosina
2022-02-17 15:25 ` Alan Stern
2022-02-25 9:15 ` Greg KH
2022-02-25 14:38 ` [PATCH] USB: core: Update kerneldoc for usb_get_dev() and usb_get_intf() Alan Stern
2022-03-12 9:39 ` [PATCH] HID: elo: Fix refcount leak in elo_probe() Dongliang Mu
2022-03-12 14:59 ` Alan Stern
2022-02-17 7:54 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220217081925.GA2467@kadam \
--to=dan.carpenter@oracle.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mudongliangabcd@gmail.com \
--cc=noralf@tronnes.org \
--cc=salah.triki@gmail.com \
--cc=stern@rowland.harvard.edu \
--cc=syzkaller-bugs@googlegroups.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.