From: Stephen Hemminger <stephen@networkplumber.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: dsahern@gmail.com, gnault@redhat.com, netdev@vger.kernel.org
Subject: Re: [RFC iproute2] tos: interpret ToS in natural numeral system
Date: Thu, 17 Feb 2022 11:14:10 -0800 [thread overview]
Message-ID: <20220217111410.70e4dba3@hermes.local> (raw)
In-Reply-To: <20220216194205.3780848-1-kuba@kernel.org>
On Wed, 16 Feb 2022 11:42:05 -0800
Jakub Kicinski <kuba@kernel.org> wrote:
> Silently forcing a base numeral system is very painful for users.
> ip currently interprets tos 10 as 0x10. Imagine user's bash script
> does:
>
> .. tos $((TOS * 2)) ..
>
> or any numerical operation on the ToS.
>
> This patch breaks existing scripts if they expect 10 to be 0x10.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Maybe a warning?? but no one will see it.
prev parent reply other threads:[~2022-02-17 19:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-16 19:42 [RFC iproute2] tos: interpret ToS in natural numeral system Jakub Kicinski
2022-02-16 22:23 ` Guillaume Nault
2022-02-16 22:44 ` David Laight
2022-02-17 11:18 ` Guillaume Nault
2022-02-17 1:52 ` David Ahern
2022-02-17 2:40 ` Jakub Kicinski
2022-02-17 19:12 ` Stephen Hemminger
2022-02-17 19:14 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220217111410.70e4dba3@hermes.local \
--to=stephen@networkplumber.org \
--cc=dsahern@gmail.com \
--cc=gnault@redhat.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.