From: "Yann E. MORIN" <yann.morin.1998@free.fr>
To: Marcus Hoffmann <marcus.hoffmann@othermo.de>
Cc: Suniel Mahesh <sunil@amarulasolutions.com>, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 2/2] board/orangepi/orangepi-rk3399/genimage: fix partition types for gpt
Date: Thu, 17 Feb 2022 22:44:43 +0100 [thread overview]
Message-ID: <20220217214443.GN522310@scaer> (raw)
In-Reply-To: <20220217155549.1084829-3-marcus.hoffmann@othermo.de>
Marcus, All,
On 2022-02-17 16:55 +0100, Marcus Hoffmann spake thusly:
> Fixes the following error during image generation:
> ERROR: hdimage(sdcard.img): part boot: 'partition-type' is only valid
> for mbr and hybrid partition-table-type
>
> Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/2103784375
>
> Signed-off-by: Marcus Hoffmann <marcus.hoffmann@othermo.de>
> ---
> board/orangepi/orangepi-rk3399/genimage.cfg | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/board/orangepi/orangepi-rk3399/genimage.cfg b/board/orangepi/orangepi-rk3399/genimage.cfg
> index c94e0bc7cc..a02166172f 100644
> --- a/board/orangepi/orangepi-rk3399/genimage.cfg
> +++ b/board/orangepi/orangepi-rk3399/genimage.cfg
> @@ -26,14 +26,13 @@ image sdcard.img {
> }
>
> partition boot {
> - partition-type = 0xC
> + partition-type-uuid = F
> bootable = "true"
> image = "boot.vfat"
> offset = 16M
> }
>
> partition rootfs {
> - partition-type = 0x83
Why don't you also switch this one to partition-type-uuid?
Regards,
Yann E. MORIN.
> image = "rootfs.ext4"
> }
> }
> --
> 2.25.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-02-17 21:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 15:55 [Buildroot] [PATCH v2 0/2] defconfig fixes Marcus Hoffmann
2022-02-17 15:55 ` [Buildroot] [PATCH v2 1/2] configs/friendlyarm_nanopi_r2s_defconfig: uboot needs openssl Marcus Hoffmann
2022-02-17 15:58 ` Giulio Benetti
2022-02-17 21:43 ` Yann E. MORIN
2022-02-17 15:55 ` [Buildroot] [PATCH v2 2/2] board/orangepi/orangepi-rk3399/genimage: fix partition types for gpt Marcus Hoffmann
2022-02-17 15:58 ` Giulio Benetti
2022-02-17 21:44 ` Yann E. MORIN [this message]
2022-02-17 21:47 ` Marcus Hoffmann
2022-02-17 21:50 ` Giulio Benetti
2022-03-05 15:01 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220217214443.GN522310@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@buildroot.org \
--cc=marcus.hoffmann@othermo.de \
--cc=sunil@amarulasolutions.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.