From: Stephen Boyd <sboyd@kernel.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Taniya Das <tdas@codeaurora.org>,
Michael Turquette <mturquette@baylibre.com>,
Rajendra Nayak <rnayak@codeaurora.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [v1 1/2] clk: qcom: gdsc: Use the default transition delay for GDSCs
Date: Thu, 17 Feb 2022 15:19:15 -0800 [thread overview]
Message-ID: <20220217231916.E944BC340E8@smtp.kernel.org> (raw)
In-Reply-To: <YgVoM2QZTJAbu6WR@builder.lan>
Quoting Bjorn Andersson (2022-02-10 11:32:03)
> On Thu 10 Feb 01:28 CST 2022, Stephen Boyd wrote:
>
> > I'd prefer we invert the logic so that we don't need to litter this flag
> > all over the place. I recall that the wait values were incorrect a long
> > time ago on early gdsc using designs but hopefully they've been fixed
> > now and we can simply use the default power on reset (POR) values.
>
> Are you suggesting that we make it the default to not update the values
> and then provide means to specify it where needed?
Sure!
>
> I like that suggestion.
>
> But as mentioned in my reply yesterday, GPU_CX on several platforms
> needs a different CLK_DIS_WAIT_VAL - and not the same value.
>
> Are these values ever 0? Or could we simply add the three numbers to
> struct gdsc and have 0 denote "use hw default"?
I don't think they're ever set to zero. That would most likely just
break things because they need a few clk cycles to wait between
transitioning states. Otherwise the GDSC gets stuck and the clks don't
work.
next prev parent reply other threads:[~2022-02-17 23:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 17:25 [v1 1/2] clk: qcom: gdsc: Use the default transition delay for GDSCs Taniya Das
2022-02-09 17:25 ` [v1 2/2] clk: qcom: dispcc: Update gdsc flag for display GDSC Taniya Das
2022-02-09 19:14 ` Steev Klimaszewski
2022-02-09 18:19 ` [v1 1/2] clk: qcom: gdsc: Use the default transition delay for GDSCs Bjorn Andersson
2022-02-09 22:35 ` Bjorn Andersson
2022-02-10 7:28 ` Stephen Boyd
2022-02-10 19:32 ` Bjorn Andersson
2022-02-17 23:19 ` Stephen Boyd [this message]
2022-02-21 16:55 ` Taniya Das
2022-02-21 20:42 ` Bjorn Andersson
2022-02-22 11:23 ` Taniya Das
2022-02-10 7:26 ` Stephen Boyd
2022-02-10 19:28 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220217231916.E944BC340E8@smtp.kernel.org \
--to=sboyd@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=rnayak@codeaurora.org \
--cc=tdas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.