From: Florian Westphal <fw@strlen.de>
To: Paolo Abeni <pabeni@redhat.com>
Cc: Florian Westphal <fw@strlen.de>, mptcp@lists.linux.dev
Subject: Re: [PATCH mptcp-next v2 3/5] tcp: add mptcp join demultiplex hooks
Date: Fri, 18 Feb 2022 08:29:30 +0100 [thread overview]
Message-ID: <20220218072930.GB30383@breakpoint.cc> (raw)
In-Reply-To: <f99582a630cdb54490462277f06dfaac204e9f86.camel@redhat.com>
Paolo Abeni <pabeni@redhat.com> wrote:
> If I read correctly, subflow_syn_recv_sock() will filter the incoming
> packets vs the annonced list, but only if the incoming packet's
> destination port is different from the listener port.
Same as today, if it hit listener port then no issue...?
The listener port isn't in the announced list, so the check would fail.
> - incoming request targeting a bad address and/or port will reach the
> syn-ack before being rejected.
Yes.
> - incoming request targeting port 0 will likely be always accepted.
No, port 0 is illegal, there is an explicit check that prevents
such port from being wired up to the magic listener.
> What about moving the anno_list check in __mptcp_handle_join()? Should
> address the 2 above points and keep the anno_list traversals to the
> bare minimum.
I can have a look.
next prev parent reply other threads:[~2022-02-18 7:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-17 14:25 [PATCH mptcp-next v2 0/5] mptcp: replace per-addr listener sockets Florian Westphal
2022-02-17 14:25 ` [PATCH mptcp-next v2 1/5] mptcp: check netns in mptcp_token_exists Florian Westphal
2022-02-17 14:25 ` [PATCH mptcp-next v2 2/5] mptcp: prefer ip address in syn skb instead of listen sk bound address Florian Westphal
2022-02-17 14:25 ` [PATCH mptcp-next v2 3/5] tcp: add mptcp join demultiplex hooks Florian Westphal
2022-02-17 21:58 ` Paolo Abeni
2022-02-18 7:29 ` Florian Westphal [this message]
2022-02-18 8:49 ` Paolo Abeni
2022-02-17 14:25 ` [PATCH mptcp-next v2 4/5] mptcp: handle join requests via pernet listen socket Florian Westphal
2022-02-17 19:46 ` kernel test robot
2022-02-17 19:46 ` kernel test robot
2022-02-17 19:47 ` kernel test robot
2022-02-17 19:47 ` kernel test robot
2022-02-17 23:52 ` Mat Martineau
2022-02-20 22:01 ` Florian Westphal
2022-02-23 18:07 ` Kishen Maloor
2022-02-17 14:25 ` [PATCH mptcp-next v2 5/5] mptcp: remove per-address listening sockets Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220218072930.GB30383@breakpoint.cc \
--to=fw@strlen.de \
--cc=mptcp@lists.linux.dev \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.