From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7E4EFC433F5 for ; Fri, 18 Feb 2022 12:16:21 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4K0VzR4QCxz3ck6 for ; Fri, 18 Feb 2022 23:16:19 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=kernel.crashing.org (client-ip=63.228.1.57; helo=gate.crashing.org; envelope-from=segher@kernel.crashing.org; receiver=) Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by lists.ozlabs.org (Postfix) with ESMTP id 4K0Vyv4Sj4z3bbT for ; Fri, 18 Feb 2022 23:15:50 +1100 (AEDT) Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 21ICCdAd007386; Fri, 18 Feb 2022 06:12:39 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 21ICCbi7007385; Fri, 18 Feb 2022 06:12:37 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Fri, 18 Feb 2022 06:12:37 -0600 From: Segher Boessenkool To: Masahiro Yamada Subject: Re: [PATCH net v3] net: Force inlining of checksum functions in net/checksum.h Message-ID: <20220218121237.GQ614@gate.crashing.org> References: <978951d76d8cb84bab347c7623bc163e9a038452.1645100305.git.christophe.leroy@csgroup.eu> <35bcd5df0fb546008ff4043dbea68836@AcuMS.aculab.com> <9b8ef186-c7fe-822c-35df-342c9e86cc88@csgroup.eu> <3c2b682a7d804b5e8749428b50342c82@AcuMS.aculab.com> <2e38265880db45afa96cfb51223f7418@AcuMS.aculab.com> <20220217180735.GM614@gate.crashing.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "netdev@vger.kernel.org" , Nick Desaulniers , "linux-kernel@vger.kernel.org" , "David S. Miller" , David Laight , Jakub Kicinski , Andrew Morton , "linuxppc-dev@lists.ozlabs.org" , Ingo Molnar Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Feb 18, 2022 at 10:35:48AM +0900, Masahiro Yamada wrote: > On Fri, Feb 18, 2022 at 3:10 AM Segher Boessenkool > wrote: > > On Fri, Feb 18, 2022 at 02:27:16AM +0900, Masahiro Yamada wrote: > > > On Fri, Feb 18, 2022 at 1:49 AM David Laight wrote: > > > > That description is largely fine. > > > > > > > > Inappropriate 'inline' ought to be removed. > > > > Then 'inline' means - 'really do inline this'. > > > > > > You cannot change "static inline" to "static" > > > in header files. > > > > Why not? Those two have identical semantics! > > e.g.) > > > [1] Open include/linux/device.h with your favorite editor, > then edit > > static inline void *devm_kcalloc(struct device *dev, > > to > > static void *devm_kcalloc(struct device *dev, > > > [2] Build the kernel You get some "defined but not used" warnings that are shushed for inlines. Do you see something else? The semantics are the same. Warnings are just warnings. It builds fine. Segher From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 390D1C433F5 for ; Fri, 18 Feb 2022 12:17:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235096AbiBRMRR (ORCPT ); Fri, 18 Feb 2022 07:17:17 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:58890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234997AbiBRMRO (ORCPT ); Fri, 18 Feb 2022 07:17:14 -0500 Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3551428BF4C; Fri, 18 Feb 2022 04:16:55 -0800 (PST) Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 21ICCdAd007386; Fri, 18 Feb 2022 06:12:39 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 21ICCbi7007385; Fri, 18 Feb 2022 06:12:37 -0600 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Fri, 18 Feb 2022 06:12:37 -0600 From: Segher Boessenkool To: Masahiro Yamada Cc: David Laight , "netdev@vger.kernel.org" , Nick Desaulniers , "linux-kernel@vger.kernel.org" , Ingo Molnar , Jakub Kicinski , Andrew Morton , "linuxppc-dev@lists.ozlabs.org" , "David S. Miller" Subject: Re: [PATCH net v3] net: Force inlining of checksum functions in net/checksum.h Message-ID: <20220218121237.GQ614@gate.crashing.org> References: <978951d76d8cb84bab347c7623bc163e9a038452.1645100305.git.christophe.leroy@csgroup.eu> <35bcd5df0fb546008ff4043dbea68836@AcuMS.aculab.com> <9b8ef186-c7fe-822c-35df-342c9e86cc88@csgroup.eu> <3c2b682a7d804b5e8749428b50342c82@AcuMS.aculab.com> <2e38265880db45afa96cfb51223f7418@AcuMS.aculab.com> <20220217180735.GM614@gate.crashing.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 18, 2022 at 10:35:48AM +0900, Masahiro Yamada wrote: > On Fri, Feb 18, 2022 at 3:10 AM Segher Boessenkool > wrote: > > On Fri, Feb 18, 2022 at 02:27:16AM +0900, Masahiro Yamada wrote: > > > On Fri, Feb 18, 2022 at 1:49 AM David Laight wrote: > > > > That description is largely fine. > > > > > > > > Inappropriate 'inline' ought to be removed. > > > > Then 'inline' means - 'really do inline this'. > > > > > > You cannot change "static inline" to "static" > > > in header files. > > > > Why not? Those two have identical semantics! > > e.g.) > > > [1] Open include/linux/device.h with your favorite editor, > then edit > > static inline void *devm_kcalloc(struct device *dev, > > to > > static void *devm_kcalloc(struct device *dev, > > > [2] Build the kernel You get some "defined but not used" warnings that are shushed for inlines. Do you see something else? The semantics are the same. Warnings are just warnings. It builds fine. Segher