From: Dan Carpenter <dan.carpenter@oracle.com>
To: Marcelo Aloisio da Silva <marcelo.as@aol.com>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
Phillip Potter <phil@philpotter.co.uk>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove unnecessary braces in if statements
Date: Fri, 18 Feb 2022 15:50:58 +0300 [thread overview]
Message-ID: <20220218125058.GE2467@kadam> (raw)
In-Reply-To: <20220218114455.GG2407@kadam>
On Fri, Feb 18, 2022 at 02:44:55PM +0300, Dan Carpenter wrote:
> On Fri, Feb 18, 2022 at 01:37:05AM -0300, Marcelo Aloisio da Silva wrote:
> > Braces are not necessary for single statement blocks.
> >
> > Signed-off-by: Marcelo Aloisio da Silva <marcelo.as@aol.com>
> > ---
> > drivers/staging/r8188eu/core/rtw_mlme.c | 8 ++------
> > 1 file changed, 2 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r8188eu/core/rtw_mlme.c
> > index 45eff3018d73..ad1d73a27548 100644
> > --- a/drivers/staging/r8188eu/core/rtw_mlme.c
> > +++ b/drivers/staging/r8188eu/core/rtw_mlme.c
> > @@ -1379,10 +1379,8 @@ void rtw_dynamic_check_timer_handlder(struct adapter *adapter)
> > if (pregistrypriv->wifi_spec == 1) {
> > struct wifidirect_info *pwdinfo = &adapter->wdinfo;
> > if (rtw_p2p_chk_state(pwdinfo, P2P_STATE_NONE))
> > - {
> > /* auto site survey */
> > rtw_auto_scan_handler(adapter);
> > - }
>
> Generally we prefer if statements around multi-line indents. It helps
I meant "prefer curly braces around multi-line indents".
regards,
dan carpenter
next prev parent reply other threads:[~2022-02-18 12:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20220218043705.GA23783.ref@snoopy>
2022-02-18 4:37 ` [PATCH] staging: r8188eu: remove unnecessary braces in if statements Marcelo Aloisio da Silva
2022-02-18 11:44 ` Dan Carpenter
2022-02-18 12:50 ` Dan Carpenter [this message]
2022-02-20 17:31 ` Marcelo Aloisio da Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220218125058.GE2467@kadam \
--to=dan.carpenter@oracle.com \
--cc=Larry.Finger@lwfinger.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=marcelo.as@aol.com \
--cc=phil@philpotter.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.