From: David Sterba <dsterba@suse.cz>
To: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Cc: clm@fb.com, josef@toxicpanda.com, dsterba@suse.com,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Abaci Robot <abaci@linux.alibaba.com>
Subject: Re: [PATCH] btrfs: Fix non-kernel-doc comment
Date: Fri, 18 Feb 2022 14:06:28 +0100 [thread overview]
Message-ID: <20220218130628.GS12643@suse.cz> (raw)
In-Reply-To: <20220218101345.125518-1-jiapeng.chong@linux.alibaba.com>
On Fri, Feb 18, 2022 at 06:13:45PM +0800, Jiapeng Chong wrote:
> Fixes the following W=1 kernel build warning:
>
> fs/btrfs/ioctl.c:1789: warning: This comment starts with '/**', but
> isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> * Entry point to file defragmentation.
>
> fs/btrfs/extent_map.c:390: warning: This comment starts with '/**', but
> isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> * Add new extent map to the extent tree.
>
> fs/btrfs/block-group.c:1743: warning: This comment starts with '/**',
> but isn't a kernel-doc comment. Refer
> Documentation/doc-guide/kernel-doc.rst
> * Map a physical disk address to a list of logical addresses.
>
> fs/btrfs/extent_io.c:4923: warning: This comment starts with '/**', but
> isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> * Walk the list of dirty pages of the given address space and write all
> * of them.
>
> fs/btrfs/file-item.c:625: warning: This comment starts with '/**', but
> isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> * Calculate checksums of the data contained inside a bio.
>
> fs/btrfs/inode.c:3430: warning: This comment starts with '/**', but
> isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst
> * Wait for flushing all delayed iputs
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
> fs/btrfs/block-group.c | 2 +-
> fs/btrfs/extent_io.c | 2 +-
> fs/btrfs/extent_map.c | 2 +-
> fs/btrfs/file-item.c | 2 +-
> fs/btrfs/inode.c | 2 +-
> fs/btrfs/ioctl.c | 2 +-
> 6 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/fs/btrfs/block-group.c b/fs/btrfs/block-group.c
> index c22d287e020b..884002e510ec 100644
> --- a/fs/btrfs/block-group.c
> +++ b/fs/btrfs/block-group.c
> @@ -1739,7 +1739,7 @@ static void set_avail_alloc_bits(struct btrfs_fs_info *fs_info, u64 flags)
> write_sequnlock(&fs_info->profiles_lock);
> }
>
> -/**
> +/*
> * Map a physical disk address to a list of logical addresses
> *
> * @fs_info: the filesystem
We'd actually like the kdoc script to check the argument list.
next prev parent reply other threads:[~2022-02-18 13:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 10:13 [PATCH] btrfs: Fix non-kernel-doc comment Jiapeng Chong
2022-02-18 13:06 ` David Sterba [this message]
-- strict thread matches above, loose matches on Subject: below --
2022-03-07 0:42 Jiapeng Chong
2022-02-15 3:34 Jiapeng Chong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220218130628.GS12643@suse.cz \
--to=dsterba@suse.cz \
--cc=abaci@linux.alibaba.com \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=josef@toxicpanda.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.