From: Hans Schultz <schultz.hans@gmail.com>
To: davem@davemloft.net, kuba@kernel.org
Cc: Petr Machata <petrm@nvidia.com>, Andrew Lunn <andrew@lunn.ch>,
Baowen Zheng <baowen.zheng@corigine.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Amit Cohen <amcohen@nvidia.com>,
netdev@vger.kernel.org, David Ahern <dsahern@kernel.org>,
bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Ido Schimmel <idosch@nvidia.com>,
Stephen Suryaputra <ssuryaextr@gmail.com>,
Hans Schultz <schultz.hans+netdev@gmail.com>,
Po-Hsu Lin <po-hsu.lin@canonical.com>,
Nikolay Aleksandrov <nikolay@nvidia.com>,
linux-kselftest@vger.kernel.org, Roopa Prabhu <roopa@nvidia.com>,
Vladimir Oltean <olteanv@gmail.com>,
Shuah Khan <shuah@kernel.org>,
Vivien Didelot <vivien.didelot@gmail.com>
Subject: [Bridge] [PATCH net-next v3 5/5] selftests: forwarding: tests of locked port feature
Date: Fri, 18 Feb 2022 16:51:48 +0100 [thread overview]
Message-ID: <20220218155148.2329797-6-schultz.hans+netdev@gmail.com> (raw)
In-Reply-To: <20220218155148.2329797-1-schultz.hans+netdev@gmail.com>
These tests check that the basic locked port feature works, so that no 'host'
can communicate (ping) through a locked port unless the MAC address of the
'host' interface is in the forwarding database of the bridge.
Signed-off-by: Hans Schultz <schultz.hans+netdev@gmail.com>
---
.../testing/selftests/net/forwarding/Makefile | 1 +
.../net/forwarding/bridge_locked_port.sh | 174 ++++++++++++++++++
tools/testing/selftests/net/forwarding/lib.sh | 16 ++
3 files changed, 191 insertions(+)
create mode 100755 tools/testing/selftests/net/forwarding/bridge_locked_port.sh
diff --git a/tools/testing/selftests/net/forwarding/Makefile b/tools/testing/selftests/net/forwarding/Makefile
index 72ee644d47bf..8fa97ae9af9e 100644
--- a/tools/testing/selftests/net/forwarding/Makefile
+++ b/tools/testing/selftests/net/forwarding/Makefile
@@ -1,6 +1,7 @@
# SPDX-License-Identifier: GPL-2.0+ OR MIT
TEST_PROGS = bridge_igmp.sh \
+ bridge_locked_port.sh \
bridge_port_isolation.sh \
bridge_sticky_fdb.sh \
bridge_vlan_aware.sh \
diff --git a/tools/testing/selftests/net/forwarding/bridge_locked_port.sh b/tools/testing/selftests/net/forwarding/bridge_locked_port.sh
new file mode 100755
index 000000000000..d2805441b325
--- /dev/null
+++ b/tools/testing/selftests/net/forwarding/bridge_locked_port.sh
@@ -0,0 +1,174 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-2.0
+
+ALL_TESTS="locked_port_ipv4 locked_port_ipv6 locked_port_vlan"
+NUM_NETIFS=4
+CHECK_TC="no"
+source lib.sh
+
+h1_create()
+{
+ simple_if_init $h1 192.0.2.1/24 2001:db8:1::1/64
+ vrf_create "vrf-vlan-h1"
+ ip link set dev vrf-vlan-h1 up
+ vlan_create $h1 100 vrf-vlan-h1 192.0.3.1/24 2001:db8:3::1/64
+}
+
+h1_destroy()
+{
+ vlan_destroy $h1 100
+ simple_if_fini $h1 192.0.2.1/24 2001:db8:1::1/64
+}
+
+h2_create()
+{
+ simple_if_init $h2 192.0.2.2/24 2001:db8:1::2/64
+ vrf_create "vrf-vlan-h2"
+ ip link set dev vrf-vlan-h2 up
+ vlan_create $h2 100 vrf-vlan-h2 192.0.3.2/24 2001:db8:3::2/64
+}
+
+h2_destroy()
+{
+ vlan_destroy $h2 100
+ simple_if_fini $h2 192.0.2.2/24 2001:db8:1::2/64
+}
+
+switch_create()
+{
+ ip link add dev br0 type bridge vlan_filtering 1
+
+ ip link set dev $swp1 master br0
+ ip link set dev $swp2 master br0
+
+ ip link set dev br0 up
+ ip link set dev $swp1 up
+ ip link set dev $swp2 up
+
+ bridge link set dev $swp1 learning off
+}
+
+switch_destroy()
+{
+ ip link set dev $swp2 down
+ ip link set dev $swp1 down
+
+ ip link del dev br0
+}
+
+setup_prepare()
+{
+ h1=${NETIFS[p1]}
+ swp1=${NETIFS[p2]}
+
+ swp2=${NETIFS[p3]}
+ h2=${NETIFS[p4]}
+
+ vrf_prepare
+
+ h1_create
+ h2_create
+
+ switch_create
+}
+
+cleanup()
+{
+ pre_cleanup
+
+ switch_destroy
+
+ h2_destroy
+ h1_destroy
+
+ vrf_cleanup
+}
+
+ifaddr()
+{
+ ip -br link show dev "$1" | awk '{ print($3); }'
+}
+
+locked_port_ipv4()
+{
+ RET=0
+
+ check_locked_port_support || return 0
+
+ ping_do $h1 192.0.2.2
+ check_err $? "Ping didn't work when it should have"
+
+ bridge link set dev $swp1 locked on
+
+ ping_do $h1 192.0.2.2
+ check_fail $? "Ping worked when it should not have"
+
+ bridge fdb add `ifaddr $h1` dev $swp1 master static
+
+ ping_do $h1 192.0.2.2
+ check_err $? "Ping didn't work when it should have"
+
+ bridge link set dev $swp1 locked off
+ bridge fdb del `ifaddr $h1` dev $swp1 master static
+ log_test "Locked port ipv4"
+}
+
+locked_port_vlan()
+{
+ RET=0
+
+ check_locked_port_support || return 0
+ check_vlan_filtering_support || return 0
+
+ bridge vlan add vid 100 dev $swp1 tagged
+ bridge vlan add vid 100 dev $swp2 tagged
+
+ ping_do $h1.100 192.0.3.2
+ check_err $? "Ping didn't work when it should have"
+
+ bridge link set dev $swp1 locked on
+ ping_do $h1.100 192.0.3.2
+ check_fail $? "Ping worked when it should not have"
+
+ bridge fdb add `ifaddr $h1` dev $swp1 vlan 100 master static
+
+ ping_do $h1.100 192.0.3.2
+ check_err $? "Ping didn't work when it should have"
+
+ bridge link set dev $swp1 locked off
+ bridge vlan del vid 100 dev $swp1
+ bridge vlan del vid 100 dev $swp2
+ bridge fdb del `ifaddr $h1` dev $swp1 vlan 100 master static
+ log_test "Locked port vlan"
+}
+
+locked_port_ipv6()
+{
+ RET=0
+ check_locked_port_support || return 0
+
+ ping6_do $h1 2001:db8:1::2
+ check_err $? "Ping6 didn't work when it should have"
+
+ bridge link set dev $swp1 locked on
+
+ ping6_do $h1 2001:db8:1::2
+ check_fail $? "Ping worked when it should not have"
+
+ bridge fdb add `ifaddr $h1` dev $swp1 master static
+ ping6_do $h1 2001:db8:1::2
+ check_err $? "Ping didn't work when it should have"
+
+ bridge link set dev $swp1 locked off
+ bridge fdb del `ifaddr $h1` dev $swp1 master static
+ log_test "Locked port ipv6"
+}
+
+trap cleanup EXIT
+
+setup_prepare
+setup_wait
+
+tests_run
+
+exit $EXIT_STATUS
diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh
index 7da783d6f453..9ded90f17ead 100644
--- a/tools/testing/selftests/net/forwarding/lib.sh
+++ b/tools/testing/selftests/net/forwarding/lib.sh
@@ -125,6 +125,22 @@ check_ethtool_lanes_support()
fi
}
+check_locked_port_support()
+{
+ if ! bridge -d link show | grep -q " locked"; then
+ echo "SKIP: iproute2 too old; Locked port feature not supported."
+ return $ksft_skip
+ fi
+}
+
+check_vlan_filtering_support()
+{
+ if ! bridge -d vlan show | grep -q "state forwarding"; then
+ echo "SKIP: vlan filtering not supported."
+ return $ksft_skip
+ fi
+}
+
if [[ "$(id -u)" -ne 0 ]]; then
echo "SKIP: need root privileges"
exit $ksft_skip
--
2.30.2
WARNING: multiple messages have this Message-ID (diff)
From: Hans Schultz <schultz.hans@gmail.com>
To: davem@davemloft.net, kuba@kernel.org
Cc: netdev@vger.kernel.org,
Hans Schultz <schultz.hans+netdev@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
Roopa Prabhu <roopa@nvidia.com>,
Nikolay Aleksandrov <nikolay@nvidia.com>,
Shuah Khan <shuah@kernel.org>,
Stephen Suryaputra <ssuryaextr@gmail.com>,
David Ahern <dsahern@kernel.org>,
Ido Schimmel <idosch@nvidia.com>, Petr Machata <petrm@nvidia.com>,
Amit Cohen <amcohen@nvidia.com>,
Po-Hsu Lin <po-hsu.lin@canonical.com>,
Baowen Zheng <baowen.zheng@corigine.com>,
linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org,
linux-kselftest@vger.kernel.org
Subject: [PATCH net-next v3 5/5] selftests: forwarding: tests of locked port feature
Date: Fri, 18 Feb 2022 16:51:48 +0100 [thread overview]
Message-ID: <20220218155148.2329797-6-schultz.hans+netdev@gmail.com> (raw)
In-Reply-To: <20220218155148.2329797-1-schultz.hans+netdev@gmail.com>
These tests check that the basic locked port feature works, so that no 'host'
can communicate (ping) through a locked port unless the MAC address of the
'host' interface is in the forwarding database of the bridge.
Signed-off-by: Hans Schultz <schultz.hans+netdev@gmail.com>
---
.../testing/selftests/net/forwarding/Makefile | 1 +
.../net/forwarding/bridge_locked_port.sh | 174 ++++++++++++++++++
tools/testing/selftests/net/forwarding/lib.sh | 16 ++
3 files changed, 191 insertions(+)
create mode 100755 tools/testing/selftests/net/forwarding/bridge_locked_port.sh
diff --git a/tools/testing/selftests/net/forwarding/Makefile b/tools/testing/selftests/net/forwarding/Makefile
index 72ee644d47bf..8fa97ae9af9e 100644
--- a/tools/testing/selftests/net/forwarding/Makefile
+++ b/tools/testing/selftests/net/forwarding/Makefile
@@ -1,6 +1,7 @@
# SPDX-License-Identifier: GPL-2.0+ OR MIT
TEST_PROGS = bridge_igmp.sh \
+ bridge_locked_port.sh \
bridge_port_isolation.sh \
bridge_sticky_fdb.sh \
bridge_vlan_aware.sh \
diff --git a/tools/testing/selftests/net/forwarding/bridge_locked_port.sh b/tools/testing/selftests/net/forwarding/bridge_locked_port.sh
new file mode 100755
index 000000000000..d2805441b325
--- /dev/null
+++ b/tools/testing/selftests/net/forwarding/bridge_locked_port.sh
@@ -0,0 +1,174 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-2.0
+
+ALL_TESTS="locked_port_ipv4 locked_port_ipv6 locked_port_vlan"
+NUM_NETIFS=4
+CHECK_TC="no"
+source lib.sh
+
+h1_create()
+{
+ simple_if_init $h1 192.0.2.1/24 2001:db8:1::1/64
+ vrf_create "vrf-vlan-h1"
+ ip link set dev vrf-vlan-h1 up
+ vlan_create $h1 100 vrf-vlan-h1 192.0.3.1/24 2001:db8:3::1/64
+}
+
+h1_destroy()
+{
+ vlan_destroy $h1 100
+ simple_if_fini $h1 192.0.2.1/24 2001:db8:1::1/64
+}
+
+h2_create()
+{
+ simple_if_init $h2 192.0.2.2/24 2001:db8:1::2/64
+ vrf_create "vrf-vlan-h2"
+ ip link set dev vrf-vlan-h2 up
+ vlan_create $h2 100 vrf-vlan-h2 192.0.3.2/24 2001:db8:3::2/64
+}
+
+h2_destroy()
+{
+ vlan_destroy $h2 100
+ simple_if_fini $h2 192.0.2.2/24 2001:db8:1::2/64
+}
+
+switch_create()
+{
+ ip link add dev br0 type bridge vlan_filtering 1
+
+ ip link set dev $swp1 master br0
+ ip link set dev $swp2 master br0
+
+ ip link set dev br0 up
+ ip link set dev $swp1 up
+ ip link set dev $swp2 up
+
+ bridge link set dev $swp1 learning off
+}
+
+switch_destroy()
+{
+ ip link set dev $swp2 down
+ ip link set dev $swp1 down
+
+ ip link del dev br0
+}
+
+setup_prepare()
+{
+ h1=${NETIFS[p1]}
+ swp1=${NETIFS[p2]}
+
+ swp2=${NETIFS[p3]}
+ h2=${NETIFS[p4]}
+
+ vrf_prepare
+
+ h1_create
+ h2_create
+
+ switch_create
+}
+
+cleanup()
+{
+ pre_cleanup
+
+ switch_destroy
+
+ h2_destroy
+ h1_destroy
+
+ vrf_cleanup
+}
+
+ifaddr()
+{
+ ip -br link show dev "$1" | awk '{ print($3); }'
+}
+
+locked_port_ipv4()
+{
+ RET=0
+
+ check_locked_port_support || return 0
+
+ ping_do $h1 192.0.2.2
+ check_err $? "Ping didn't work when it should have"
+
+ bridge link set dev $swp1 locked on
+
+ ping_do $h1 192.0.2.2
+ check_fail $? "Ping worked when it should not have"
+
+ bridge fdb add `ifaddr $h1` dev $swp1 master static
+
+ ping_do $h1 192.0.2.2
+ check_err $? "Ping didn't work when it should have"
+
+ bridge link set dev $swp1 locked off
+ bridge fdb del `ifaddr $h1` dev $swp1 master static
+ log_test "Locked port ipv4"
+}
+
+locked_port_vlan()
+{
+ RET=0
+
+ check_locked_port_support || return 0
+ check_vlan_filtering_support || return 0
+
+ bridge vlan add vid 100 dev $swp1 tagged
+ bridge vlan add vid 100 dev $swp2 tagged
+
+ ping_do $h1.100 192.0.3.2
+ check_err $? "Ping didn't work when it should have"
+
+ bridge link set dev $swp1 locked on
+ ping_do $h1.100 192.0.3.2
+ check_fail $? "Ping worked when it should not have"
+
+ bridge fdb add `ifaddr $h1` dev $swp1 vlan 100 master static
+
+ ping_do $h1.100 192.0.3.2
+ check_err $? "Ping didn't work when it should have"
+
+ bridge link set dev $swp1 locked off
+ bridge vlan del vid 100 dev $swp1
+ bridge vlan del vid 100 dev $swp2
+ bridge fdb del `ifaddr $h1` dev $swp1 vlan 100 master static
+ log_test "Locked port vlan"
+}
+
+locked_port_ipv6()
+{
+ RET=0
+ check_locked_port_support || return 0
+
+ ping6_do $h1 2001:db8:1::2
+ check_err $? "Ping6 didn't work when it should have"
+
+ bridge link set dev $swp1 locked on
+
+ ping6_do $h1 2001:db8:1::2
+ check_fail $? "Ping worked when it should not have"
+
+ bridge fdb add `ifaddr $h1` dev $swp1 master static
+ ping6_do $h1 2001:db8:1::2
+ check_err $? "Ping didn't work when it should have"
+
+ bridge link set dev $swp1 locked off
+ bridge fdb del `ifaddr $h1` dev $swp1 master static
+ log_test "Locked port ipv6"
+}
+
+trap cleanup EXIT
+
+setup_prepare
+setup_wait
+
+tests_run
+
+exit $EXIT_STATUS
diff --git a/tools/testing/selftests/net/forwarding/lib.sh b/tools/testing/selftests/net/forwarding/lib.sh
index 7da783d6f453..9ded90f17ead 100644
--- a/tools/testing/selftests/net/forwarding/lib.sh
+++ b/tools/testing/selftests/net/forwarding/lib.sh
@@ -125,6 +125,22 @@ check_ethtool_lanes_support()
fi
}
+check_locked_port_support()
+{
+ if ! bridge -d link show | grep -q " locked"; then
+ echo "SKIP: iproute2 too old; Locked port feature not supported."
+ return $ksft_skip
+ fi
+}
+
+check_vlan_filtering_support()
+{
+ if ! bridge -d vlan show | grep -q "state forwarding"; then
+ echo "SKIP: vlan filtering not supported."
+ return $ksft_skip
+ fi
+}
+
if [[ "$(id -u)" -ne 0 ]]; then
echo "SKIP: need root privileges"
exit $ksft_skip
--
2.30.2
next prev parent reply other threads:[~2022-02-18 15:51 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 15:51 [Bridge] [PATCH net-next v3 0/5] Add support for locked bridge ports (for 802.1X) Hans Schultz
2022-02-18 15:51 ` Hans Schultz
2022-02-18 15:51 ` [Bridge] [PATCH net-next v3 1/5] net: bridge: Add support for bridge port in locked mode Hans Schultz
2022-02-18 15:51 ` Hans Schultz
2022-02-19 9:46 ` [Bridge] " Nikolay Aleksandrov
2022-02-19 9:46 ` Nikolay Aleksandrov
2022-02-20 9:18 ` [Bridge] " Ido Schimmel
2022-02-20 9:18 ` Ido Schimmel
2022-02-18 15:51 ` [Bridge] [PATCH net-next v3 2/5] net: bridge: Add support for offloading of locked port flag Hans Schultz
2022-02-18 15:51 ` Hans Schultz
2022-02-19 9:47 ` [Bridge] " Nikolay Aleksandrov
2022-02-19 9:47 ` Nikolay Aleksandrov
2022-02-20 9:19 ` [Bridge] " Ido Schimmel
2022-02-20 9:19 ` Ido Schimmel
2022-02-18 15:51 ` [Bridge] [PATCH net-next v3 3/5] net: dsa: Add support for offloaded " Hans Schultz
2022-02-18 15:51 ` Hans Schultz
2022-02-19 9:56 ` [Bridge] " Vladimir Oltean
2022-02-19 9:56 ` Vladimir Oltean
2022-02-18 15:51 ` [Bridge] [PATCH net-next v3 4/5] net: dsa: mv88e6xxx: Add support for bridge port locked mode Hans Schultz
2022-02-18 15:51 ` Hans Schultz
2022-02-19 10:00 ` [Bridge] " Vladimir Oltean
2022-02-19 10:00 ` Vladimir Oltean
2022-02-20 9:21 ` [Bridge] " Ido Schimmel
2022-02-20 9:21 ` Ido Schimmel
2022-02-21 14:05 ` [Bridge] " Hans Schultz
2022-02-21 14:05 ` Hans Schultz
2022-02-18 15:51 ` Hans Schultz [this message]
2022-02-18 15:51 ` [PATCH net-next v3 5/5] selftests: forwarding: tests of locked port feature Hans Schultz
2022-02-18 21:02 ` [Bridge] " Shuah Khan
2022-02-18 21:02 ` Shuah Khan
2022-02-19 9:48 ` [Bridge] " Nikolay Aleksandrov
2022-02-19 9:48 ` Nikolay Aleksandrov
2022-02-20 9:12 ` [Bridge] " Ido Schimmel
2022-02-20 9:12 ` Ido Schimmel
2022-02-21 9:20 ` [Bridge] " Hans Schultz
2022-02-21 9:20 ` Hans Schultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220218155148.2329797-6-schultz.hans+netdev@gmail.com \
--to=schultz.hans@gmail.com \
--cc=amcohen@nvidia.com \
--cc=andrew@lunn.ch \
--cc=baowen.zheng@corigine.com \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=f.fainelli@gmail.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nikolay@nvidia.com \
--cc=olteanv@gmail.com \
--cc=petrm@nvidia.com \
--cc=po-hsu.lin@canonical.com \
--cc=roopa@nvidia.com \
--cc=schultz.hans+netdev@gmail.com \
--cc=shuah@kernel.org \
--cc=ssuryaextr@gmail.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.