From: menglong8.dong@gmail.com
To: kuba@kernel.org
Cc: rostedt@goodmis.org, mingo@redhat.com, davem@davemloft.net,
yoshfuji@linux-ipv6.org, dsahern@kernel.org,
imagedong@tencent.com, edumazet@google.com, alobakin@pm.me,
cong.wang@bytedance.com, paulb@nvidia.com, talalahmad@google.com,
keescook@chromium.org, ilias.apalodimas@linaro.org,
memxor@gmail.com, flyingpeng@tencent.com, mengensun@tencent.com,
daniel@iogearbox.net, yajun.deng@linux.dev, roopa@nvidia.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH net-next 3/3] net: neigh: add skb drop reasons to arp_error_report()
Date: Sun, 20 Feb 2022 23:57:05 +0800 [thread overview]
Message-ID: <20220220155705.194266-4-imagedong@tencent.com> (raw)
In-Reply-To: <20220220155705.194266-1-imagedong@tencent.com>
From: Menglong Dong <imagedong@tencent.com>
When neighbour become invalid or destroyed, neigh_invalidate() will be
called. neigh->ops->error_report() will be called if the neighbour's
state is NUD_FAILED, and seems here is the only use of error_report().
So we can tell that the reason of skb drops in arp_error_report() is
SKB_DROP_REASON_NEIGH_FAILED.
Replace kfree_skb() used in arp_error_report() with kfree_skb_reason().
Reviewed-by: Mengen Sun <mengensun@tencent.com>
Reviewed-by: Hao Peng <flyingpeng@tencent.com>
Signed-off-by: Menglong Dong <imagedong@tencent.com>
---
net/ipv4/arp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/ipv4/arp.c b/net/ipv4/arp.c
index 4db0325f6e1a..8e4ca4738c43 100644
--- a/net/ipv4/arp.c
+++ b/net/ipv4/arp.c
@@ -293,7 +293,7 @@ static int arp_constructor(struct neighbour *neigh)
static void arp_error_report(struct neighbour *neigh, struct sk_buff *skb)
{
dst_link_failure(skb);
- kfree_skb(skb);
+ kfree_skb_reason(skb, SKB_DROP_REASON_NEIGH_FAILED);
}
/* Create and send an arp packet. */
--
2.35.1
next prev parent reply other threads:[~2022-02-20 15:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-20 15:57 [PATCH net-next 0/3] net: use kfree_skb_reason() for ip/neighbour menglong8.dong
2022-02-20 15:57 ` [PATCH net-next 1/3] net: ip: add skb drop reasons for ip egress path menglong8.dong
2022-02-22 3:13 ` David Ahern
2022-02-22 3:44 ` Menglong Dong
2022-02-25 6:05 ` Menglong Dong
2022-02-25 13:41 ` Roman Mashak
2022-02-25 13:53 ` Menglong Dong
2022-02-20 15:57 ` [PATCH net-next 2/3] net: neigh: use kfree_skb_reason() for __neigh_event_send() menglong8.dong
2022-02-22 3:17 ` David Ahern
2022-02-22 3:47 ` Menglong Dong
2022-02-20 15:57 ` menglong8.dong [this message]
2022-02-22 3:19 ` [PATCH net-next 3/3] net: neigh: add skb drop reasons to arp_error_report() David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220220155705.194266-4-imagedong@tencent.com \
--to=menglong8.dong@gmail.com \
--cc=alobakin@pm.me \
--cc=cong.wang@bytedance.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=flyingpeng@tencent.com \
--cc=ilias.apalodimas@linaro.org \
--cc=imagedong@tencent.com \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=memxor@gmail.com \
--cc=mengensun@tencent.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=paulb@nvidia.com \
--cc=roopa@nvidia.com \
--cc=rostedt@goodmis.org \
--cc=talalahmad@google.com \
--cc=yajun.deng@linux.dev \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.