From: Dan Carpenter <dan.carpenter@oracle.com>
To: Hangyu Hua <hbh25y@gmail.com>
Cc: manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com,
coiby.xu@gmail.com, gregkh@linuxfoundation.org,
netdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] staging: qlge: add unregister_netdev in qlge_probe
Date: Mon, 21 Feb 2022 12:56:23 +0300 [thread overview]
Message-ID: <20220221095623.GB3965@kadam> (raw)
In-Reply-To: <20220221022312.9101-1-hbh25y@gmail.com>
On Mon, Feb 21, 2022 at 10:23:12AM +0800, Hangyu Hua wrote:
> unregister_netdev need to be called when register_netdev succeeds
> qlge_health_create_reporters fails.
>
> Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
> ---
>
> v2: use goto to fix this bug
Hey Greg,
Don't take this one. Take v3 instead with the Fixes tag.
regards,
dan carpenter
prev parent reply other threads:[~2022-02-21 9:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 2:23 [PATCH v2] staging: qlge: add unregister_netdev in qlge_probe Hangyu Hua
2022-02-21 9:48 ` Dan Carpenter
2022-02-21 9:56 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220221095623.GB3965@kadam \
--to=dan.carpenter@oracle.com \
--cc=GR-Linux-NIC-Dev@marvell.com \
--cc=coiby.xu@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hbh25y@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.