diff for duplicates of <202202211208.RSlRUGsa-lkp@intel.com> diff --git a/a/1.txt b/N1/1.txt index 00b250a..adc31c6 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,14 +1,6 @@ -CC: kbuild-all(a)lists.01.org -CC: linux-kernel(a)vger.kernel.org -TO: Maciej Fijalkowski <maciej.fijalkowski@intel.com> -CC: Tony Nguyen <anthony.l.nguyen@intel.com> - tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: cfb92440ee71adcc2105b0890bb01ac3cddb8507 commit: e72bba21355dbb67512a0d666fec9f4b56dbfc2f ice: split ice_ring onto Tx/Rx separate structs -date: 4 months ago -:::::: branch date: 7 hours ago -:::::: commit date: 4 months ago config: ia64-randconfig-m031-20220220 (https://download.01.org/0day-ci/archive/20220221/202202211208.RSlRUGsa-lkp(a)intel.com/config) compiler: ia64-linux-gcc (GCC) 11.2.0 @@ -21,13 +13,6 @@ drivers/net/ethernet/intel/ice/ice_main.c:5677 ice_update_vsi_tx_ring_stats() er vim +/ring +5677 drivers/net/ethernet/intel/ice/ice_main.c -fcea6f3da546b9 Anirudh Venkataramanan 2018-03-20 5654 -49d358e0e746dc Marta Plantykow 2020-05-15 5655 /** -49d358e0e746dc Marta Plantykow 2020-05-15 5656 * ice_update_vsi_tx_ring_stats - Update VSI Tx ring stats counters -49d358e0e746dc Marta Plantykow 2020-05-15 5657 * @vsi: the VSI to be updated -49d358e0e746dc Marta Plantykow 2020-05-15 5658 * @rings: rings to work on -49d358e0e746dc Marta Plantykow 2020-05-15 5659 * @count: number of rings -49d358e0e746dc Marta Plantykow 2020-05-15 5660 */ 49d358e0e746dc Marta Plantykow 2020-05-15 5661 static void e72bba21355dbb Maciej Fijalkowski 2021-08-19 5662 ice_update_vsi_tx_ring_stats(struct ice_vsi *vsi, struct ice_tx_ring **rings, 49d358e0e746dc Marta Plantykow 2020-05-15 5663 u16 count) @@ -41,21 +26,20 @@ e72bba21355dbb Maciej Fijalkowski 2021-08-19 5670 u64 pkts = 0, bytes = 49d358e0e746dc Marta Plantykow 2020-05-15 5671 49d358e0e746dc Marta Plantykow 2020-05-15 5672 ring = READ_ONCE(rings[i]); e72bba21355dbb Maciej Fijalkowski 2021-08-19 @5673 if (ring) + ^^^^ +Check for NULL + e72bba21355dbb Maciej Fijalkowski 2021-08-19 5674 ice_fetch_u64_stats_per_ring(&ring->syncp, ring->stats, &pkts, &bytes); 49d358e0e746dc Marta Plantykow 2020-05-15 5675 vsi_stats->tx_packets += pkts; 49d358e0e746dc Marta Plantykow 2020-05-15 5676 vsi_stats->tx_bytes += bytes; 49d358e0e746dc Marta Plantykow 2020-05-15 @5677 vsi->tx_restart += ring->tx_stats.restart_q; + +Unchecked dereferences on the following lines + 49d358e0e746dc Marta Plantykow 2020-05-15 5678 vsi->tx_busy += ring->tx_stats.tx_busy; 49d358e0e746dc Marta Plantykow 2020-05-15 5679 vsi->tx_linearize += ring->tx_stats.tx_linearize; 49d358e0e746dc Marta Plantykow 2020-05-15 5680 } 49d358e0e746dc Marta Plantykow 2020-05-15 5681 } -49d358e0e746dc Marta Plantykow 2020-05-15 5682 - -:::::: The code at line 5677 was first introduced by commit -:::::: 49d358e0e746dc24bfb1b1cf98c17064e5177424 ice: Add XDP Tx to VSI ring stats - -:::::: TO: Marta Plantykow <marta.a.plantykow@intel.com> -:::::: CC: Jeff Kirsher <jeffrey.t.kirsher@intel.com> --- 0-DAY CI Kernel Test Service, Intel Corporation diff --git a/a/content_digest b/N1/content_digest index baf611b..63fb6ed 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,20 +1,12 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0drivers/net/ethernet/intel/ice/ice_main.c:5677 ice_update_vsi_tx_ring_stats() error: we previously assumed 'ring' could be null (see line 5673)\0" - "Date\0Mon, 21 Feb 2022 12:05:03 +0800\0" - "To\0kbuild@lists.01.org\0" + "Date\0Mon, 21 Feb 2022 16:09:14 +0300\0" + "To\0kbuild-all@lists.01.org\0" "\01:1\0" "b\0" - "CC: kbuild-all(a)lists.01.org\n" - "CC: linux-kernel(a)vger.kernel.org\n" - "TO: Maciej Fijalkowski <maciej.fijalkowski@intel.com>\n" - "CC: Tony Nguyen <anthony.l.nguyen@intel.com>\n" - "\n" "tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master\n" "head: cfb92440ee71adcc2105b0890bb01ac3cddb8507\n" "commit: e72bba21355dbb67512a0d666fec9f4b56dbfc2f ice: split ice_ring onto Tx/Rx separate structs\n" - "date: 4 months ago\n" - ":::::: branch date: 7 hours ago\n" - ":::::: commit date: 4 months ago\n" "config: ia64-randconfig-m031-20220220 (https://download.01.org/0day-ci/archive/20220221/202202211208.RSlRUGsa-lkp(a)intel.com/config)\n" "compiler: ia64-linux-gcc (GCC) 11.2.0\n" "\n" @@ -27,13 +19,6 @@ "\n" "vim +/ring +5677 drivers/net/ethernet/intel/ice/ice_main.c\n" "\n" - "fcea6f3da546b9 Anirudh Venkataramanan 2018-03-20 5654 \n" - "49d358e0e746dc Marta Plantykow 2020-05-15 5655 /**\n" - "49d358e0e746dc Marta Plantykow 2020-05-15 5656 * ice_update_vsi_tx_ring_stats - Update VSI Tx ring stats counters\n" - "49d358e0e746dc Marta Plantykow 2020-05-15 5657 * @vsi: the VSI to be updated\n" - "49d358e0e746dc Marta Plantykow 2020-05-15 5658 * @rings: rings to work on\n" - "49d358e0e746dc Marta Plantykow 2020-05-15 5659 * @count: number of rings\n" - "49d358e0e746dc Marta Plantykow 2020-05-15 5660 */\n" "49d358e0e746dc Marta Plantykow 2020-05-15 5661 static void\n" "e72bba21355dbb Maciej Fijalkowski 2021-08-19 5662 ice_update_vsi_tx_ring_stats(struct ice_vsi *vsi, struct ice_tx_ring **rings,\n" "49d358e0e746dc Marta Plantykow 2020-05-15 5663 \t\t\t u16 count)\n" @@ -47,24 +32,23 @@ "49d358e0e746dc Marta Plantykow 2020-05-15 5671 \n" "49d358e0e746dc Marta Plantykow 2020-05-15 5672 \t\tring = READ_ONCE(rings[i]);\n" "e72bba21355dbb Maciej Fijalkowski 2021-08-19 @5673 \t\tif (ring)\n" + " ^^^^\n" + "Check for NULL\n" + "\n" "e72bba21355dbb Maciej Fijalkowski 2021-08-19 5674 \t\t\tice_fetch_u64_stats_per_ring(&ring->syncp, ring->stats, &pkts, &bytes);\n" "49d358e0e746dc Marta Plantykow 2020-05-15 5675 \t\tvsi_stats->tx_packets += pkts;\n" "49d358e0e746dc Marta Plantykow 2020-05-15 5676 \t\tvsi_stats->tx_bytes += bytes;\n" "49d358e0e746dc Marta Plantykow 2020-05-15 @5677 \t\tvsi->tx_restart += ring->tx_stats.restart_q;\n" + "\n" + "Unchecked dereferences on the following lines\n" + "\n" "49d358e0e746dc Marta Plantykow 2020-05-15 5678 \t\tvsi->tx_busy += ring->tx_stats.tx_busy;\n" "49d358e0e746dc Marta Plantykow 2020-05-15 5679 \t\tvsi->tx_linearize += ring->tx_stats.tx_linearize;\n" "49d358e0e746dc Marta Plantykow 2020-05-15 5680 \t}\n" "49d358e0e746dc Marta Plantykow 2020-05-15 5681 }\n" - "49d358e0e746dc Marta Plantykow 2020-05-15 5682 \n" - "\n" - ":::::: The code at line 5677 was first introduced by commit\n" - ":::::: 49d358e0e746dc24bfb1b1cf98c17064e5177424 ice: Add XDP Tx to VSI ring stats\n" - "\n" - ":::::: TO: Marta Plantykow <marta.a.plantykow@intel.com>\n" - ":::::: CC: Jeff Kirsher <jeffrey.t.kirsher@intel.com>\n" "\n" "---\n" "0-DAY CI Kernel Test Service, Intel Corporation\n" https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org -023d6fed7eb4714035658237031d23c51938474c1c6ef7be8c75d42934da5c7e +a73c67e3de3a8fb4e5959a7ab77f3b156bdbf7738641ae79dbdb994acdb57319
diff --git a/a/1.txt b/N2/1.txt index 00b250a..49908cb 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,15 +1,7 @@ -CC: kbuild-all(a)lists.01.org -CC: linux-kernel(a)vger.kernel.org -TO: Maciej Fijalkowski <maciej.fijalkowski@intel.com> -CC: Tony Nguyen <anthony.l.nguyen@intel.com> - tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: cfb92440ee71adcc2105b0890bb01ac3cddb8507 commit: e72bba21355dbb67512a0d666fec9f4b56dbfc2f ice: split ice_ring onto Tx/Rx separate structs -date: 4 months ago -:::::: branch date: 7 hours ago -:::::: commit date: 4 months ago -config: ia64-randconfig-m031-20220220 (https://download.01.org/0day-ci/archive/20220221/202202211208.RSlRUGsa-lkp(a)intel.com/config) +config: ia64-randconfig-m031-20220220 (https://download.01.org/0day-ci/archive/20220221/202202211208.RSlRUGsa-lkp@intel.com/config) compiler: ia64-linux-gcc (GCC) 11.2.0 If you fix the issue, kindly add following tag as appropriate @@ -21,13 +13,6 @@ drivers/net/ethernet/intel/ice/ice_main.c:5677 ice_update_vsi_tx_ring_stats() er vim +/ring +5677 drivers/net/ethernet/intel/ice/ice_main.c -fcea6f3da546b9 Anirudh Venkataramanan 2018-03-20 5654 -49d358e0e746dc Marta Plantykow 2020-05-15 5655 /** -49d358e0e746dc Marta Plantykow 2020-05-15 5656 * ice_update_vsi_tx_ring_stats - Update VSI Tx ring stats counters -49d358e0e746dc Marta Plantykow 2020-05-15 5657 * @vsi: the VSI to be updated -49d358e0e746dc Marta Plantykow 2020-05-15 5658 * @rings: rings to work on -49d358e0e746dc Marta Plantykow 2020-05-15 5659 * @count: number of rings -49d358e0e746dc Marta Plantykow 2020-05-15 5660 */ 49d358e0e746dc Marta Plantykow 2020-05-15 5661 static void e72bba21355dbb Maciej Fijalkowski 2021-08-19 5662 ice_update_vsi_tx_ring_stats(struct ice_vsi *vsi, struct ice_tx_ring **rings, 49d358e0e746dc Marta Plantykow 2020-05-15 5663 u16 count) @@ -41,22 +26,21 @@ e72bba21355dbb Maciej Fijalkowski 2021-08-19 5670 u64 pkts = 0, bytes = 49d358e0e746dc Marta Plantykow 2020-05-15 5671 49d358e0e746dc Marta Plantykow 2020-05-15 5672 ring = READ_ONCE(rings[i]); e72bba21355dbb Maciej Fijalkowski 2021-08-19 @5673 if (ring) + ^^^^ +Check for NULL + e72bba21355dbb Maciej Fijalkowski 2021-08-19 5674 ice_fetch_u64_stats_per_ring(&ring->syncp, ring->stats, &pkts, &bytes); 49d358e0e746dc Marta Plantykow 2020-05-15 5675 vsi_stats->tx_packets += pkts; 49d358e0e746dc Marta Plantykow 2020-05-15 5676 vsi_stats->tx_bytes += bytes; 49d358e0e746dc Marta Plantykow 2020-05-15 @5677 vsi->tx_restart += ring->tx_stats.restart_q; + +Unchecked dereferences on the following lines + 49d358e0e746dc Marta Plantykow 2020-05-15 5678 vsi->tx_busy += ring->tx_stats.tx_busy; 49d358e0e746dc Marta Plantykow 2020-05-15 5679 vsi->tx_linearize += ring->tx_stats.tx_linearize; 49d358e0e746dc Marta Plantykow 2020-05-15 5680 } 49d358e0e746dc Marta Plantykow 2020-05-15 5681 } -49d358e0e746dc Marta Plantykow 2020-05-15 5682 - -:::::: The code at line 5677 was first introduced by commit -:::::: 49d358e0e746dc24bfb1b1cf98c17064e5177424 ice: Add XDP Tx to VSI ring stats - -:::::: TO: Marta Plantykow <marta.a.plantykow@intel.com> -:::::: CC: Jeff Kirsher <jeffrey.t.kirsher@intel.com> --- 0-DAY CI Kernel Test Service, Intel Corporation -https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org +https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org diff --git a/a/content_digest b/N2/content_digest index baf611b..e19a48b 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,21 +1,18 @@ - "From\0kernel test robot <lkp@intel.com>\0" + "From\0Dan Carpenter <dan.carpenter@oracle.com>\0" "Subject\0drivers/net/ethernet/intel/ice/ice_main.c:5677 ice_update_vsi_tx_ring_stats() error: we previously assumed 'ring' could be null (see line 5673)\0" - "Date\0Mon, 21 Feb 2022 12:05:03 +0800\0" - "To\0kbuild@lists.01.org\0" - "\01:1\0" + "Date\0Mon, 21 Feb 2022 16:09:14 +0300\0" + "To\0kbuild@lists.01.org" + " Maciej Fijalkowski <maciej.fijalkowski@intel.com>\0" + "Cc\0lkp@intel.com" + kbuild-all@lists.01.org + linux-kernel@vger.kernel.org + " Tony Nguyen <anthony.l.nguyen@intel.com>\0" + "\00:1\0" "b\0" - "CC: kbuild-all(a)lists.01.org\n" - "CC: linux-kernel(a)vger.kernel.org\n" - "TO: Maciej Fijalkowski <maciej.fijalkowski@intel.com>\n" - "CC: Tony Nguyen <anthony.l.nguyen@intel.com>\n" - "\n" "tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master\n" "head: cfb92440ee71adcc2105b0890bb01ac3cddb8507\n" "commit: e72bba21355dbb67512a0d666fec9f4b56dbfc2f ice: split ice_ring onto Tx/Rx separate structs\n" - "date: 4 months ago\n" - ":::::: branch date: 7 hours ago\n" - ":::::: commit date: 4 months ago\n" - "config: ia64-randconfig-m031-20220220 (https://download.01.org/0day-ci/archive/20220221/202202211208.RSlRUGsa-lkp(a)intel.com/config)\n" + "config: ia64-randconfig-m031-20220220 (https://download.01.org/0day-ci/archive/20220221/202202211208.RSlRUGsa-lkp@intel.com/config)\n" "compiler: ia64-linux-gcc (GCC) 11.2.0\n" "\n" "If you fix the issue, kindly add following tag as appropriate\n" @@ -27,13 +24,6 @@ "\n" "vim +/ring +5677 drivers/net/ethernet/intel/ice/ice_main.c\n" "\n" - "fcea6f3da546b9 Anirudh Venkataramanan 2018-03-20 5654 \n" - "49d358e0e746dc Marta Plantykow 2020-05-15 5655 /**\n" - "49d358e0e746dc Marta Plantykow 2020-05-15 5656 * ice_update_vsi_tx_ring_stats - Update VSI Tx ring stats counters\n" - "49d358e0e746dc Marta Plantykow 2020-05-15 5657 * @vsi: the VSI to be updated\n" - "49d358e0e746dc Marta Plantykow 2020-05-15 5658 * @rings: rings to work on\n" - "49d358e0e746dc Marta Plantykow 2020-05-15 5659 * @count: number of rings\n" - "49d358e0e746dc Marta Plantykow 2020-05-15 5660 */\n" "49d358e0e746dc Marta Plantykow 2020-05-15 5661 static void\n" "e72bba21355dbb Maciej Fijalkowski 2021-08-19 5662 ice_update_vsi_tx_ring_stats(struct ice_vsi *vsi, struct ice_tx_ring **rings,\n" "49d358e0e746dc Marta Plantykow 2020-05-15 5663 \t\t\t u16 count)\n" @@ -47,24 +37,23 @@ "49d358e0e746dc Marta Plantykow 2020-05-15 5671 \n" "49d358e0e746dc Marta Plantykow 2020-05-15 5672 \t\tring = READ_ONCE(rings[i]);\n" "e72bba21355dbb Maciej Fijalkowski 2021-08-19 @5673 \t\tif (ring)\n" + " ^^^^\n" + "Check for NULL\n" + "\n" "e72bba21355dbb Maciej Fijalkowski 2021-08-19 5674 \t\t\tice_fetch_u64_stats_per_ring(&ring->syncp, ring->stats, &pkts, &bytes);\n" "49d358e0e746dc Marta Plantykow 2020-05-15 5675 \t\tvsi_stats->tx_packets += pkts;\n" "49d358e0e746dc Marta Plantykow 2020-05-15 5676 \t\tvsi_stats->tx_bytes += bytes;\n" "49d358e0e746dc Marta Plantykow 2020-05-15 @5677 \t\tvsi->tx_restart += ring->tx_stats.restart_q;\n" + "\n" + "Unchecked dereferences on the following lines\n" + "\n" "49d358e0e746dc Marta Plantykow 2020-05-15 5678 \t\tvsi->tx_busy += ring->tx_stats.tx_busy;\n" "49d358e0e746dc Marta Plantykow 2020-05-15 5679 \t\tvsi->tx_linearize += ring->tx_stats.tx_linearize;\n" "49d358e0e746dc Marta Plantykow 2020-05-15 5680 \t}\n" "49d358e0e746dc Marta Plantykow 2020-05-15 5681 }\n" - "49d358e0e746dc Marta Plantykow 2020-05-15 5682 \n" - "\n" - ":::::: The code at line 5677 was first introduced by commit\n" - ":::::: 49d358e0e746dc24bfb1b1cf98c17064e5177424 ice: Add XDP Tx to VSI ring stats\n" - "\n" - ":::::: TO: Marta Plantykow <marta.a.plantykow@intel.com>\n" - ":::::: CC: Jeff Kirsher <jeffrey.t.kirsher@intel.com>\n" "\n" "---\n" "0-DAY CI Kernel Test Service, Intel Corporation\n" - https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org + https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org -023d6fed7eb4714035658237031d23c51938474c1c6ef7be8c75d42934da5c7e +005f172700a0510a67326ab396372a2ef0a29bc36b28034f42f5a56d79b5ccf8
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.