From: Dan Carpenter <dan.carpenter@oracle.com>
To: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc: Forest Bond <forest@alittletooquiet.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] staging: vt6656: Fix CamelCase warnings in mac.h and mac.c
Date: Mon, 21 Feb 2022 15:27:52 +0300 [thread overview]
Message-ID: <20220221122751.GG3965@kadam> (raw)
In-Reply-To: <505ae2999ea93318e3745c69d8e36e2c108d9fd0.1645386791.git.philipp.g.hortmann@gmail.com>
On Sun, Feb 20, 2022 at 09:30:29PM +0100, Philipp Hortmann wrote:
> /* Bits in the EnhanceCFG_2 register */
> -#define EnCFG_NXTBTTCFPSTR BIT(0)
> -#define EnCFG_BarkerPream BIT(1)
> -#define EnCFG_PktBurstMode BIT(2)
> +#define EN_CFG_NXTBTTCFPSTR BIT(0)
> +#define EN_CFG_BARKER_PREAM BIT(1)
> +#define EN_CFG_PKT_BURST_MO BIT(2)
Presumably you mean "_MD" for mode instead "_MO"?
regards,
dan carpenter
next prev parent reply other threads:[~2022-02-21 12:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-20 20:30 [PATCH 0/3] staging: vt6656: Fix CamelCase, add comments, change macro to function Philipp Hortmann
2022-02-20 20:30 ` [PATCH 1/3] staging: vt6656: Fix CamelCase warnings in mac.h and mac.c Philipp Hortmann
2022-02-21 12:27 ` Dan Carpenter [this message]
2022-02-20 20:30 ` [PATCH 2/3] staging: vt6656: Add comment and change macro to function Philipp Hortmann
2022-02-21 12:33 ` Dan Carpenter
2022-02-21 17:15 ` Greg Kroah-Hartman
2022-02-20 20:30 ` [PATCH 3/3] staging: vt6656: Remove ftrace-like logging and unnecessary line breaks Philipp Hortmann
2022-02-21 12:35 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220221122751.GG3965@kadam \
--to=dan.carpenter@oracle.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=philipp.g.hortmann@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.