From: David Teigland <teigland@redhat.com>
To: Konstantin Kharlamov <hi-angel@yandex.ru>
Cc: linux-lvm@redhat.com
Subject: Re: [linux-lvm] Frequent crashes when accessing dev_name(dev) on an empty list
Date: Mon, 21 Feb 2022 10:49:47 -0600 [thread overview]
Message-ID: <20220221164947.GA18428@redhat.com> (raw)
In-Reply-To: <3e96860d112e86ee55fba0e5fffbf1ee433905e6.camel@yandex.ru>
On Mon, Feb 21, 2022 at 04:45:51PM +0300, Konstantin Kharlamov wrote:
> So, what happened was that dev_name(dev) was extracting a `dev->aliases` element
> , however `dev->aliases` was empty, thus the extracted element was a junk.
>
> Although we encountered these crashes on an older 2.03.07 version, however the
> patch applies to latest master as well, thus the bugs are still relevant, which
> is odd. This makes me wondering, is this a known problem, could I possibly
> overlooked something, for example that dev->aliases should never be empty, and
> thus the fix just works around another problem? Any thoughts?
It's familiar, but I thought it was fixed. I don't remember the details,
so we'll have to look at it again. It's related to a device being removed
from the system while the command is running, which we need to add tests
for.
Dave
_______________________________________________
linux-lvm mailing list
linux-lvm@redhat.com
https://listman.redhat.com/mailman/listinfo/linux-lvm
read the LVM HOW-TO at http://tldp.org/HOWTO/LVM-HOWTO/
next prev parent reply other threads:[~2022-02-21 16:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 13:45 [linux-lvm] Frequent crashes when accessing dev_name(dev) on an empty list Konstantin Kharlamov
2022-02-21 16:49 ` David Teigland [this message]
2022-02-21 17:35 ` Konstantin Kharlamov
2022-04-01 14:48 ` Konstantin Kharlamov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220221164947.GA18428@redhat.com \
--to=teigland@redhat.com \
--cc=hi-angel@yandex.ru \
--cc=linux-lvm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.