From: Vladimir Oltean <olteanv@gmail.com>
To: "Alvin Šipraga" <ALSI@bang-olufsen.dk>
Cc: "Alvin Šipraga" <alvin@pqrs.dk>, "Andrew Lunn" <andrew@lunn.ch>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Jakub Kicinski" <kuba@kernel.org>,
"Vladimir Oltean" <vladimir.oltean@nxp.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net] net: dsa: fix panic when removing unoffloaded port from bridge
Date: Mon, 21 Feb 2022 22:45:56 +0200 [thread overview]
Message-ID: <20220221204556.ymlwsrm4rfllp54y@skbuf> (raw)
In-Reply-To: <87ilt8hs5e.fsf@bang-olufsen.dk>
On Mon, Feb 21, 2022 at 08:38:21PM +0000, Alvin Šipraga wrote:
> >> + info.bridge = *dp->bridge,
> >
> > By the way, does this patch compile, with the comma and not the
> > semicolon, like that?
>
> Yikes, sorry about that. Sent a corrected v2 now.
>
> It does actually compile though.
Yes, I see, I think it probably works too:
info.bridge = *dp->bridge, dsa_port_bridge_destroy(dp, br);
although I would never write code like that.
prev parent reply other threads:[~2022-02-21 20:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-21 20:19 [PATCH net] net: dsa: fix panic when removing unoffloaded port from bridge Alvin Šipraga
2022-02-21 20:26 ` Vladimir Oltean
2022-02-21 20:38 ` Alvin Šipraga
2022-02-21 20:45 ` Vladimir Oltean [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220221204556.ymlwsrm4rfllp54y@skbuf \
--to=olteanv@gmail.com \
--cc=ALSI@bang-olufsen.dk \
--cc=alvin@pqrs.dk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.