Re: [meta-arago][dunfell][PATCH] external-arm-toolchain: Remove EAT_TOOL_CHAIN symlinks

["Denys Dmytriyenko" <denis@denix.org>]

NAK.

On Tue, Feb 22, 2022 at 11:50:27AM +0530, Devarsh Thakkar via lists.yoctoproject.org wrote:
> As per below commit in https://git.yoctoproject.org/meta-arm/log/?h=dunfell,
> 
> "1644922 external-arm-toolchain: Align glibc packaging to OE TARGET_SYS"
> 
> the upstream recipe external-arm-toolchain.bb doesn't use EAT_TARGET_SYS for
> installing toolchain anymore and the recipe is directly using TARGET_SYS
> for copying.
> 
> So remove EAT_TARGET_SYS symlinks as they are not required anymore and instead
> copy directly to ORIG_TARGET_SYS.
> 
> Signed-off-by: Devarsh Thakkar <devarsht@ti.com>
> ---
>  .../recipes-core/meta/external-arm-toolchain.bbappend     | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/meta-arago-extras/recipes-core/meta/external-arm-toolchain.bbappend b/meta-arago-extras/recipes-core/meta/external-arm-toolchain.bbappend
> index 5a51aaa0..ea4df2ff 100644
> --- a/meta-arago-extras/recipes-core/meta/external-arm-toolchain.bbappend
> +++ b/meta-arago-extras/recipes-core/meta/external-arm-toolchain.bbappend
> @@ -6,12 +6,6 @@ do_install_append() {
>  	install -d ${D}${sysconfdir}
>  	echo -e "/lib\n/usr/lib" >> ${D}${sysconfdir}/ld.so.conf
>  
> -	if [ ${EAT_TARGET_SYS} != ${ORIG_TARGET_SYS} ]; then
> -		ln -sf ${EAT_TARGET_SYS} ${D}${libdir}/${ORIG_TARGET_SYS}
> -		ln -sf ${EAT_TARGET_SYS} ${D}${includedir}/c++/${EAT_VER_GCC}/${ORIG_TARGET_SYS}
> -		mv ${D}${libdir}/gcc/${EAT_TARGET_SYS} ${D}${libdir}/gcc/${ORIG_TARGET_SYS}
> -		ln -sf ${ORIG_TARGET_SYS} ${D}${libdir}/gcc/${EAT_TARGET_SYS}
> -	fi
>  
>  	ln -sf libatomic.so.1 ${D}${libdir}/libatomic.so
>  	ln -sf libgomp.so.1 ${D}${libdir}/libgomp.so
> @@ -22,7 +16,7 @@ do_install_append() {
>  	ln -sf libasan.so.5 ${D}${libdir}/libasan.so
>  	ln -sf libgfortran.so.5 ${D}${libdir}/libgfortran.so
>  
> -	cp ${CP_ARGS} ${EXTERNAL_TOOLCHAIN}/lib/gcc/${EAT_TARGET_SYS}/${EAT_VER_GCC}/libgcc* ${D}${libdir}/${EAT_TARGET_SYS}/${EAT_VER_GCC}/
> +	cp ${CP_ARGS} ${EXTERNAL_TOOLCHAIN}/lib/gcc/${EAT_TARGET_SYS}/${EAT_VER_GCC}/libgcc* ${D}${libdir}/${ORIG_TARGET_SYS}/${EAT_VER_GCC}/
>  }
>  
>  # Below FILES_* overrides are due to TARGET_SYS -> ORIG_TARGET_SYS move in ${libdir}/gcc
> -- 
> 2.17.1