From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF6D6C433F5 for ; Tue, 22 Feb 2022 08:47:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229958AbiBVIsP (ORCPT ); Tue, 22 Feb 2022 03:48:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229785AbiBVIsN (ORCPT ); Tue, 22 Feb 2022 03:48:13 -0500 Received: from elvis.franken.de (elvis.franken.de [193.175.24.41]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 288D4A2F3C; Tue, 22 Feb 2022 00:47:48 -0800 (PST) Received: from uucp (helo=alpha) by elvis.franken.de with local-bsmtp (Exim 3.36 #1) id 1nMQpn-0001CP-00; Tue, 22 Feb 2022 09:47:47 +0100 Received: by alpha.franken.de (Postfix, from userid 1000) id 54F15C25FC; Tue, 22 Feb 2022 09:43:31 +0100 (CET) Date: Tue, 22 Feb 2022 09:43:31 +0100 From: Thomas Bogendoerfer To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Christoph Hellwig , linux-mips@vger.kernel.org Subject: Re: [PATCH] mips: setup: fix setnocoherentio() boolean setting Message-ID: <20220222084331.GA7049@alpha.franken.de> References: <20220221175029.6046-1-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220221175029.6046-1-rdunlap@infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org On Mon, Feb 21, 2022 at 09:50:29AM -0800, Randy Dunlap wrote: > Correct a typo/pasto: setnocoherentio() should set > dma_default_coherent to false, not true. > > Fixes: 14ac09a65e19 ("MIPS: refactor the runtime coherent vs noncoherent DMA indicators") > Signed-off-by: Randy Dunlap > Cc: Christoph Hellwig > Cc: Thomas Bogendoerfer > Cc: linux-mips@vger.kernel.org > --- > arch/mips/kernel/setup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- linux-next-20220217.orig/arch/mips/kernel/setup.c > +++ linux-next-20220217/arch/mips/kernel/setup.c > @@ -803,7 +803,7 @@ early_param("coherentio", setcoherentio) > > static int __init setnocoherentio(char *str) > { > - dma_default_coherent = true; > + dma_default_coherent = false; > pr_info("Software DMA cache coherency (command line)\n"); > return 0; > } applied to mips-fixes. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]