From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============4763635882558589280==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: misc: fix minmax.cocci warnings Date: Wed, 23 Feb 2022 03:51:51 +0800 Message-ID: <20220222195151.GA174427@086b3271c347> In-Reply-To: <202202230332.kEB4LBR9-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============4763635882558589280== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Denis Efremov CC: Julia Lawall CC: David Airlie CC: Daniel Vetter CC: dri-devel(a)lists.freedesktop.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/gpu/drm/savage/savage_state.c:267:26-27: WARNING opportunity for mi= n() Check for opencoded min(), max() implementations. Generated patches sometimes require adding a cast to fix compile warning. Warnings/patches scope intentionally limited to a function body. Generated by: scripts/coccinelle/misc/minmax.cocci CC: Denis Efremov Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: 917bbdb107f8767cb78f24e7d6725a2f93b9effe commit: 5f66f73b9ff4dcabd4e2405ba9c32e80e02f9408 coccinelle: misc: add minm= ax script :::::: branch date: 80 minutes ago :::::: commit date: 10 months ago Please take the patch only if it's a positive warning. Thanks! drivers/gpu/drm/savage/savage_state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpu/drm/savage/savage_state.c +++ b/drivers/gpu/drm/savage/savage_state.c @@ -264,7 +264,7 @@ static int savage_dispatch_state(drm_sav = do { while (count > 0) { - unsigned int n =3D count < 255 ? count : 255; + unsigned int n =3D min(count, 255); DMA_SET_REGISTERS(start, n); DMA_COPY(regs, n); count -=3D n; --===============4763635882558589280==--