From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7FF6C433FE for ; Wed, 23 Feb 2022 06:42:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238480AbiBWGnB (ORCPT ); Wed, 23 Feb 2022 01:43:01 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238463AbiBWGnA (ORCPT ); Wed, 23 Feb 2022 01:43:00 -0500 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DC146D870; Tue, 22 Feb 2022 22:42:30 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id A272A68B05; Wed, 23 Feb 2022 07:42:26 +0100 (CET) Date: Wed, 23 Feb 2022 07:42:26 +0100 From: Christoph Hellwig To: Ming Lei Cc: Christoph Hellwig , Jens Axboe , "Martin K. Petersen" , linux-block@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH 01/12] blk-mq: do not include passthrough requests in I/O accounting Message-ID: <20220223064226.GA31307@lst.de> References: <20220222141450.591193-1-hch@lst.de> <20220222141450.591193-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org On Wed, Feb 23, 2022 at 10:08:20AM +0800, Ming Lei wrote: > > - return (rq->rq_flags & RQF_IO_STAT) && rq->q->disk; > > + return (rq->rq_flags & RQF_IO_STAT) && !blk_rq_is_passthrough(rq); > > I guess this way may cause regression for workloads with lots of userspace IO > from user viewpoint? I'd say it fixes it as the accounting right now is completely bogus.