From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] reiserfs: get rid of AOP_FLAG_CONT_EXPAND flag
Date: Wed, 23 Feb 2022 13:17:37 +0100
Message-ID: <20220223121737.bsyoih6rt63pev54@quack3.lan>
References: <fbc744c9-e22f-138c-2da3-f76c3edfcc3d@gmail.com>
 <20220220232219.1235-1-edward.shishkin@gmail.com>
 <20220222102727.2sqf4wfdtjaxrqat@quack3.lan>
 <YhTnSwmHVRe5AzJQ@casper.infradead.org>
Mime-Version: 1.0
Return-path: <reiserfs-devel-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa;
        t=1645618663; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=z25zmfa1BH9FbZAkPcAjAOIvBZxhio/HEtOcbGxkK2s=;
        b=iBLlmwQKBfdGXCAAeg3wvlnrV4J7/udoMQQsDdu2Cee3a60Gai9m9bpGPUSAITEkoMaU8s
        1//GkQuJVdkXZW2F3rLTgCANQjuKMwtQWqcfgugd/zWATYwJ3OL5tTae/rSTpI2MgrUQn2
        85bOgy9hMuJpJjjUpIHA/9zHbWWnRZ4=
DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz;
        s=susede2_ed25519; t=1645618663;
        h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc:
         mime-version:mime-version:content-type:content-type:
         in-reply-to:in-reply-to:references:references;
        bh=z25zmfa1BH9FbZAkPcAjAOIvBZxhio/HEtOcbGxkK2s=;
        b=XIUgtLKy3brznIghNde4scldLLjKyFNVYfgKgSPS1OgKLfn3fJyCKSDJsMuABr1N7A2HJi
        gggIq5wSLuuz1jCw==
Content-Disposition: inline
In-Reply-To: <YhTnSwmHVRe5AzJQ@casper.infradead.org>
List-ID: <reiserfs-devel.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Matthew Wilcox <willy@infradead.org>
Cc: Jan Kara <jack@suse.cz>, Edward Shishkin <edward.shishkin@gmail.com>, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, reiserfs-devel@vger.kernel.org

On Tue 22-02-22 13:38:19, Matthew Wilcox wrote:
> On Tue, Feb 22, 2022 at 11:27:27AM +0100, Jan Kara wrote:
> > On Mon 21-02-22 00:22:19, Edward Shishkin wrote:
> > > Signed-off-by: Edward Shishkin <edward.shishkin@gmail.com>
> > > ---
> > >  fs/reiserfs/inode.c | 16 +++++-----------
> > >  1 file changed, 5 insertions(+), 11 deletions(-)
> > 
> > Thanks! I have queued this patch into my tree.
> 
> I added the following commit message to it for my tree:
> 
> Author: Edward Shishkin <edward.shishkin@gmail.com>
> Date:   Mon Feb 21 00:22:19 2022 +0100
> 
>     reiserfs: Stop using AOP_FLAG_CONT_EXPAND flag
> 
>     We can simplify write_begin() and write_end() by handling the
>     cont_expand case in reiserfs_setattr().
> 
>     Signed-off-by: Edward Shishkin <edward.shishkin@gmail.com>
>     Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>

Yeah, I have written some changelog as well :) Something like:

    reiserfs: get rid of AOP_FLAG_CONT_EXPAND flag
    
    Remove usage of AOP_FLAG_CONT_EXPAND flag. Reiserfs is the only user of
    it and it is easy to avoid.
    
    Link: https://lore.kernel.org/r/20220220232219.1235-1-edward.shishkin@gmail.com
    Signed-off-by: Edward Shishkin <edward.shishkin@gmail.com>
    Signed-off-by: Jan Kara <jack@suse.cz>

> I don't object if it goes via your tree; I doubt I'll get the AOP_FLAG
> removal finished in time for the next merge window.

OK, I'll keep it in my tree then and push it to Linus for the merge window.

								Honza
-- 
Jan Kara <jack@suse.com>
SUSE Labs, CR