From: Christoph Hellwig <hch@lst.de>
To: John Garry <john.garry@huawei.com>
Cc: Christoph Hellwig <hch@lst.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org
Subject: Re: [PATCH 3/8] scsi: don't memset the entire scsi_cmnd in scsi_init_command
Date: Wed, 23 Feb 2022 13:58:55 +0100 [thread overview]
Message-ID: <20220223125855.GA4489@lst.de> (raw)
In-Reply-To: <75ccb490-3c77-b7d9-815a-8bf1698f0848@huawei.com>
On Wed, Feb 23, 2022 at 12:56:32PM +0000, John Garry wrote:
> For the record, advantages now could include:
> - prob more efficient
> - somewhat safer coding practice
> - more condense C code
>
> But, for sure, it's not so pretty to have this sub-struct.
>
> Anyway, I don't feel too strongly about it and it was just a suggestion.
In general most of the zeroing here should go away entirely. Right
now that code is a bit convolute due to the fake EH scsi command that
also uses scsi_init_command. Once that is sorted out (I've just pinged
Hannes for his series) scsi_init_command can be folded into
scsi_prepare_cmd and a lot more of this can be cleaned up.
next prev parent reply other threads:[~2022-02-23 12:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-22 14:04 remove struct scsi_request Christoph Hellwig
2022-02-22 14:04 ` [PATCH 1/8] bsg: don't include scsi_request.h in bsg-lib.h Christoph Hellwig
2022-02-22 18:33 ` Bart Van Assche
2022-02-22 14:04 ` [PATCH 2/8] target/pscsi: remove struct pscsi_plugin_task Christoph Hellwig
2022-02-22 14:04 ` [PATCH 3/8] scsi: don't memset the entire scsi_cmnd in scsi_init_command Christoph Hellwig
2022-02-23 12:21 ` John Garry
2022-02-23 12:39 ` Christoph Hellwig
2022-02-23 12:56 ` John Garry
2022-02-23 12:58 ` Christoph Hellwig [this message]
2022-02-23 20:16 ` Bart Van Assche
2022-02-24 6:52 ` Christoph Hellwig
2022-02-23 23:03 ` Bart Van Assche
2022-02-24 8:28 ` John Garry
2022-02-24 16:27 ` Christoph Hellwig
2022-02-24 16:38 ` John Garry
2022-02-22 14:04 ` [PATCH 4/8] scsi: remove the cmd field from struct scsi_request Christoph Hellwig
2022-02-23 3:31 ` Martin K. Petersen
2022-02-23 23:36 ` Bart Van Assche
2022-02-22 14:04 ` [PATCH 5/8] scsi: remove the sense and sense_len fields " Christoph Hellwig
2022-02-23 23:39 ` Bart Van Assche
2022-02-24 6:53 ` Christoph Hellwig
2022-02-22 14:04 ` [PATCH 6/8] scsi: move the resid_len field from struct scsi_request to struct scsi_cmnd Christoph Hellwig
2022-02-23 23:41 ` Bart Van Assche
2022-02-22 14:04 ` [PATCH 7/8] scsi: move the result " Christoph Hellwig
2022-02-23 23:43 ` Bart Van Assche
2022-02-22 14:04 ` [PATCH 8/8] scsi: remove struct scsi_request Christoph Hellwig
2022-02-23 23:48 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220223125855.GA4489@lst.de \
--to=hch@lst.de \
--cc=john.garry@huawei.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.