Re: [Buildroot] [RFC PATCH] package/libiberty: use the same version as binutils

["Yann E. MORIN" <yann.morin.1998@free.fr>]

John, All,

On 2022-02-23 11:55 +0000, John Keeping spake thusly:
> libiberty is built from the binutils source but this package has
> languished on version 2.32 while the binutils package now uses 2.36.1 by
> default.
> 
> Even between the 2.32 version and GDB 10.2 which is the default (and
> where host-libiberty is used instead of a version bundled in the GDB
> source) there are memory leak fixes and several improvements to
> demangling.
> 
> Update the libiberty package to simply use the same version as binutils
> so that there is no need to remember to update this package in the
> future.  Replace the .hash file with a symlink so that the binutils
> hashes are used automatically.
> 
> Signed-off-by: John Keeping <john@metanate.com>
> ---
> I'm not sure if this is this is the best way to improve the situation
> here - it's the smallest change to get something a bit more modern (in
> most circumstances), but I wonder if libiberty should use the GDB source
> instead as that's the one package we know both bundles libiberty source
> and will use host-libiberty in preference.
> 
>  package/libiberty/libiberty.hash | 6 +-----
>  package/libiberty/libiberty.mk   | 4 ++--
>  2 files changed, 3 insertions(+), 7 deletions(-)
>  mode change 100644 => 120000 package/libiberty/libiberty.hash
> 
> diff --git a/package/libiberty/libiberty.hash b/package/libiberty/libiberty.hash
> deleted file mode 100644
> index 0dafcea520..0000000000
> --- a/package/libiberty/libiberty.hash
> +++ /dev/null
> @@ -1,5 +0,0 @@
> -# From ftp://gcc.gnu.org/pub/binutils/releases/sha512.sum
> -sha512  d326408f12a03d9a61a9de56584c2af12f81c2e50d2d7e835d51565df8314df01575724afa1e43bd0db45cfc9916b41519b67dfce03232aa4978704492a6994a  binutils-2.32.tar.xz
> -
> -# Locally computed, same as binutils.hash
> -sha256  56bdea73b6145ef6ac5259b3da390b981d840c24cb03b8e1cbc678de7ecfa18d  COPYING.LIB
> diff --git a/package/libiberty/libiberty.hash b/package/libiberty/libiberty.hash
> new file mode 120000
> index 0000000000..e0655d3af3
> --- /dev/null
> +++ b/package/libiberty/libiberty.hash
> @@ -0,0 +1 @@
> +../binutils/binutils.hash
> \ No newline at end of file
> diff --git a/package/libiberty/libiberty.mk b/package/libiberty/libiberty.mk
> index 6235a8b956..d0847bf298 100644
> --- a/package/libiberty/libiberty.mk
> +++ b/package/libiberty/libiberty.mk
> @@ -4,8 +4,8 @@
>  #
>  ################################################################################
>  
> -LIBIBERTY_VERSION = 2.32
> -LIBIBERTY_SOURCE = binutils-$(LIBIBERTY_VERSION).tar.xz
> +LIBIBERTY_VERSION = $(BINUTILS_VERSION)
> +LIBIBERTY_SOURCE = $(BINUTILS_SOURCE)

Although this works, this is by pure chance: binutils is included before
libiberty, so BINUTILS_VERSION is defined. But we try and avoid such a
situation, unless we explicitly guarantee the include ordering (eg. gcc,
fftw, util-linux, or previously, qt5).

Instead, in such a case, we prefer that the version strin is duplicated,
and a comment added above to note that both shoujld be updated in sync.
See for example bluez5_utils and bluez5_utils-headers, mesa3d and
mesa3d-headers.

Regards,
Yann E. MORIN.

>  LIBIBERTY_SITE = $(BR2_GNU_MIRROR)/binutils
>  HOST_LIBIBERTY_DL_SUBDIR = binutils
>  
> -- 
> 2.35.1
> 

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot