From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F323C433EF for ; Wed, 23 Feb 2022 15:17:44 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id C9F9C82846; Wed, 23 Feb 2022 15:17:43 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Zk5WsCvkz7Rl; Wed, 23 Feb 2022 15:17:43 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp1.osuosl.org (Postfix) with ESMTP id 10DF78282C; Wed, 23 Feb 2022 15:17:42 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 1064D1BF83B for ; Wed, 23 Feb 2022 15:17:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 0C6958282C for ; Wed, 23 Feb 2022 15:17:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id P0i1w9MsJK-q for ; Wed, 23 Feb 2022 15:17:39 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from smtp1-g21.free.fr (smtp1-g21.free.fr [IPv6:2a01:e0c:1:1599::10]) by smtp1.osuosl.org (Postfix) with ESMTPS id DC5408281A for ; Wed, 23 Feb 2022 15:17:38 +0000 (UTC) Received: from ymorin.is-a-geek.org (unknown [IPv6:2a01:cb19:8b51:cb00:f0be:eb0a:9f13:7f4d]) (Authenticated sender: yann.morin.1998@free.fr) by smtp1-g21.free.fr (Postfix) with ESMTPSA id 56944B00579; Wed, 23 Feb 2022 16:17:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=free.fr; s=smtp-20201208; t=1645629455; bh=Ajx6mCG2XFy1WgKUdDWW99rukRR6Z6Cd/vGEKVfm6Lo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=KDRzM4tgFi+jd90K1jnR3QCZWYSyOYSeUfJrv71+HdIFB86j1nhWktM6Ovlc86HS7 t/euCTr+vszCoHlyBdSiz9wlmURdwMQhFRm6RuDeoKhYYwBPEkCtCfRPx4c1rjzsJd T1mfbz0aP5eIjEp4RCm5ilmjTWxCYJk8GJ8FnMHlbL40hUFCm98RIrKluJccZax3bt 5+s6TpzMfGRVi0TrwIqUb4m1ERnA0O0HJWP+SOsZFV4GkMIwZb8Z7zFvTX5UKcM1j8 xVHfUkSOTwhc6x7eQeAX705gtQ39MgLyBu2KBFNO2lDBsmyDYMxcFGIgxROfWIXfdh 1wwSdz+44yZ5A== Received: by ymorin.is-a-geek.org (sSMTP sendmail emulation); Wed, 23 Feb 2022 16:17:32 +0100 Date: Wed, 23 Feb 2022 16:17:32 +0100 From: "Yann E. MORIN" To: Thomas Petazzoni Message-ID: <20220223151732.GB189337@scaer> References: <20220223115506.1191031-1-john@metanate.com> <20220223142731.GA189337@scaer> <20220223155141.0223462b@windsurf> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20220223155141.0223462b@windsurf> User-Agent: Mutt/1.5.22 (2013-10-16) Subject: Re: [Buildroot] [RFC PATCH] package/libiberty: use the same version as binutils X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John Keeping , buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" Thomas, All, On 2022-02-23 15:51 +0100, Thomas Petazzoni spake thusly: > On Wed, 23 Feb 2022 15:27:31 +0100 > "Yann E. MORIN" wrote: > > Although this works, this is by pure chance: binutils is included before > > libiberty, so BINUTILS_VERSION is defined. But we try and avoid such a > > situation, unless we explicitly guarantee the include ordering (eg. gcc, > > fftw, util-linux, or previously, qt5). > > Instead, in such a case, we prefer that the version strin is duplicated, > > and a comment added above to note that both shoujld be updated in sync. > > See for example bluez5_utils and bluez5_utils-headers, mesa3d and > > mesa3d-headers. > libiberty/binutils is different than mesa3d or bluez5_utils, as the > version is user-selectable, or even different depending on the selected > CPU architecture. Right, I forgot about that... But still, I don't like that we rely on the implied include order here, as we try and avoid that elsewhere... > So we would have to replicate all the version selection logic (like we > admittedly do for linux vs. linux-headers). That would not be very convenient and maintainable in the long run, as we update binutils to newer versions with various arch support changes: indeed, as we can see here, we'd eventually forget to update libibert in sync. Unless we move libiberty as a sub-directory in pacage/binutils/libiberty/ (like for util-linux-libs) to make it obvious that we need to share the version... That'd be my favourite option. Regards, Yann E. MORIN. -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot