From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FCF7C433FE for ; Wed, 23 Feb 2022 17:05:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243147AbiBWRFb (ORCPT ); Wed, 23 Feb 2022 12:05:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243145AbiBWRFU (ORCPT ); Wed, 23 Feb 2022 12:05:20 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E3D96527D0 for ; Wed, 23 Feb 2022 09:04:44 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 81F3D60FC9 for ; Wed, 23 Feb 2022 17:04:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93CD6C340F0; Wed, 23 Feb 2022 17:04:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1645635884; bh=NZeQ+wwrCQZ8vfRNFi38OmhFvr6Kq3fkbb92bPDrZVA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f+Eu7HTY0Mf3T+k6+83nLIQQSviBj5gm8yk8erPoQqf1tfEVyABR77rjmh278p1sM 0nik5F4TAbQJzY4zgD+Z5XIv4WdKJwmpydu7PUIQWcsEaKswbcUf9uAKk1SYUODvQ5 4TYHm6f/cNRvnRYt7pyZpxKeOvHIvFo4ucSUOjlt03g4qzn2hjR81aJYmqDaGQPrHZ sjo7zg7N299pavgHpS1i+5j3GDPlB76TtzfuU3gLp/hBDRdhZEhtrm5l4voSDPaPv7 CKp/Dy1K3yy1xE2OSLgIvJjnEPYk+XiYNPnKyN13oM8aI3PZmSwLLLfsQDJJncfxNj R0qGOL86cHcVA== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, Roi Dayan , Oz Shlomo , Saeed Mahameed Subject: [net 13/19] net/mlx5e: TC, Reject rules with forward and drop actions Date: Wed, 23 Feb 2022 09:04:24 -0800 Message-Id: <20220223170430.295595-14-saeed@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20220223170430.295595-1-saeed@kernel.org> References: <20220223170430.295595-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Roi Dayan Such rules are redundant but allowed and passed to the driver. The driver does not support offloading such rules so return an error. Fixes: 03a9d11e6eeb ("net/mlx5e: Add TC drop and mirred/redirect action parsing for SRIOV offloads") Signed-off-by: Roi Dayan Reviewed-by: Oz Shlomo Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c index 34700cf1285e..b27532a9301e 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c @@ -3204,6 +3204,12 @@ actions_match_supported(struct mlx5e_priv *priv, return false; } + if (!(~actions & + (MLX5_FLOW_CONTEXT_ACTION_FWD_DEST | MLX5_FLOW_CONTEXT_ACTION_DROP))) { + NL_SET_ERR_MSG_MOD(extack, "Rule cannot support forward+drop action"); + return false; + } + if (actions & MLX5_FLOW_CONTEXT_ACTION_MOD_HDR && actions & MLX5_FLOW_CONTEXT_ACTION_DROP) { NL_SET_ERR_MSG_MOD(extack, "Drop with modify header action is not supported"); -- 2.35.1