Re: [PATCH mptcp-next] mptcp: add fullmesh flag check for adding address

[Geliang Tang <geliang.tang@suse.com>]

On Tue, Feb 22, 2022 at 04:52:40PM -0800, Mat Martineau wrote:
> On Mon, 21 Feb 2022, Geliang Tang wrote:
> 
> > The fullmesh flag mustn't be used with the signal flag when adding an
> > address. This patch added the necessary flags check for this case.
> > 
> 
> Hi Geliang -
> 
> What happens if FULLMESH and SIGNAL are used together with the existing
> code? Is this a patch that should go to -net with a Fixes: tag?

Hi Mat,

If 'fullmesh' is used with 'signal', 'fullmesh' will not take effect.
Since there's no address signal mechanism to send the fullmesh flag to
the peer. We only deal the fullmesh flag with local addresses.

Thanks,
-Geliang

> 
> -Mat
> 
> 
> > Signed-off-by: Geliang Tang <geliang.tang@suse.com>
> > ---
> > net/mptcp/pm_netlink.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> > 
> > diff --git a/net/mptcp/pm_netlink.c b/net/mptcp/pm_netlink.c
> > index a0e7d5b7e22f..e3b0384ff79a 100644
> > --- a/net/mptcp/pm_netlink.c
> > +++ b/net/mptcp/pm_netlink.c
> > @@ -1253,6 +1253,12 @@ static int mptcp_nl_cmd_add_addr(struct sk_buff *skb, struct genl_info *info)
> > 		return -EINVAL;
> > 	}
> > 
> > +	if (addr.flags & MPTCP_PM_ADDR_FLAG_SIGNAL &&
> > +	    addr.flags & MPTCP_PM_ADDR_FLAG_FULLMESH) {
> > +		GENL_SET_ERR_MSG(info, "flags mustn't have both signal and fullmesh");
> > +		return -EINVAL;
> > +	}
> > +
> > 	if (addr.flags & MPTCP_PM_ADDR_FLAG_IMPLICIT) {
> > 		GENL_SET_ERR_MSG(info, "can't create IMPLICIT endpoint");
> > 		return -EINVAL;
> > -- 
> > 2.34.1
> > 
> > 
> > 
> 
> --
> Mat Martineau
> Intel
>