From: Wei Yang <richard.weiyang@gmail.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Wei Yang <richard.weiyang@gmail.com>,
Matthew Wilcox <willy@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
peterz@infradead.org, will@kernel.org, linyunsheng@huawei.com,
aarcange@redhat.com, feng.tang@intel.com, ebiederm@xmission.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: remove offset check on page->compound_head and folio->lru
Date: Thu, 24 Feb 2022 01:03:58 +0000 [thread overview]
Message-ID: <20220224010358.ttc2mgdevfqddvea@master> (raw)
In-Reply-To: <93c48e68-2266-72ee-0763-65805b94c968@suse.cz>
On Mon, Jan 24, 2022 at 11:30:10AM +0100, Vlastimil Babka wrote:
[...]
>> Hi, Matthew
>>
>> Are you back from vocation? If you could give more insight on this check, I
>> would be appreciated.
>
>I can offer my insight (which might be of course wrong). Ideally one day
>page.lru will be gone and only folio will be used for LRU pages. Then there
>won't be a FOLIO_MATCH(lru, lru); and FOLIO_MATCH(compound_head, lru);
>won't appear to be redundant anymore. lru is list_head so two pointers and
>thus valid pointers are aligned in such a way they can't accidentaly set the
>bit 0.
>
Hmm... I see your change on struct slab. I guess I got your point.
Seems we would shrink struct page...
--
Wei Yang
Help you, Help me
next prev parent reply other threads:[~2022-02-24 1:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-06 23:52 [PATCH] mm: remove offset check on page->compound_head and folio->lru Wei Yang
2022-01-07 3:59 ` Matthew Wilcox
2022-01-07 13:40 ` Wei Yang
2022-01-07 22:11 ` Matthew Wilcox
2022-01-08 0:08 ` Andrew Morton
2022-01-08 0:49 ` Matthew Wilcox
2022-01-08 2:41 ` Andrew Morton
2022-01-08 8:13 ` Wei Yang
2022-01-23 1:38 ` Wei Yang
2022-01-24 10:30 ` Vlastimil Babka
2022-01-24 22:55 ` Wei Yang
2022-01-25 10:11 ` Vlastimil Babka
2022-01-27 1:10 ` Wei Yang
2022-01-27 15:42 ` Vlastimil Babka
2022-01-29 0:47 ` Wei Yang
2022-02-24 1:03 ` Wei Yang [this message]
2022-02-17 0:34 ` Wei Yang
2022-01-08 0:27 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220224010358.ttc2mgdevfqddvea@master \
--to=richard.weiyang@gmail.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=feng.tang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linyunsheng@huawei.com \
--cc=peterz@infradead.org \
--cc=vbabka@suse.cz \
--cc=will@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.