From: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
To: igt-dev@lists.freedesktop.org, manasi.d.navare@intel.com
Subject: [igt-dev] [i-g-t 1/5] tests/kms_vrr: Create dynamic subtests
Date: Thu, 24 Feb 2022 10:46:44 +0530 [thread overview]
Message-ID: <20220224051648.91470-2-bhanuprakash.modem@intel.com> (raw)
In-Reply-To: <20220224051648.91470-1-bhanuprakash.modem@intel.com>
Create dynamic subtests with crtc/connector combinations
Cc: Manasi Navare <manasi.d.navare@intel.com>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem@intel.com>
---
tests/kms_vrr.c | 24 +++++++++++-------------
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/tests/kms_vrr.c b/tests/kms_vrr.c
index 55de7cb989..8976d4a6c3 100644
--- a/tests/kms_vrr.c
+++ b/tests/kms_vrr.c
@@ -364,7 +364,7 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
igt_info("VRR Test execution on %s, PIPE_%s with VRR range: (%u-%u) Hz\n",
output->name, kmstest_pipe_name(pipe), range.min, range.max);
- set_vrr_on_pipe(data, pipe, 1);
+ set_vrr_on_pipe(data, pipe, true);
/*
* Do a short run with VRR, but don't check the result.
@@ -414,7 +414,7 @@ test_basic(data_t *data, enum pipe pipe, igt_output_t *output, uint32_t flags)
"Refresh rate (%u Hz) %"PRIu64"ns: Target VRR on threshold not reached, result was %u%%\n",
((range.max + range.min) / 2), rate, result);
- set_vrr_on_pipe(data, pipe, 0);
+ set_vrr_on_pipe(data, pipe, false);
result = flip_and_measure(data, output, pipe, rate, TEST_DURATION_NS);
igt_assert_f(result < 10,
"Refresh rate (%u Hz) %"PRIu64"ns: Target VRR off threshold exceeded, result was %u%%\n",
@@ -435,7 +435,6 @@ static void
run_vrr_test(data_t *data, test_t test, uint32_t flags)
{
igt_output_t *output;
- bool found = false;
for_each_connected_output(&data->display, output) {
enum pipe pipe;
@@ -443,16 +442,15 @@ run_vrr_test(data_t *data, test_t test, uint32_t flags)
if (!has_vrr(output))
continue;
- for_each_pipe(&data->display, pipe)
+ for_each_pipe(&data->display, pipe) {
if (igt_pipe_connector_valid(pipe, output)) {
- test(data, pipe, output, flags);
- found = true;
+ igt_dynamic_f("pipe-%s-%s",
+ kmstest_pipe_name(pipe), output->name)
+ test(data, pipe, output, flags);
break;
}
+ }
}
-
- if (!found)
- igt_skip("No vrr capable outputs found.\n");
}
igt_main
@@ -471,21 +469,21 @@ igt_main
igt_describe("Tests that VRR is enabled and that the difference between flip "
"timestamps converges to the requested rate");
- igt_subtest("flip-basic")
+ igt_subtest_with_dynamic("flip-basic")
run_vrr_test(&data, test_basic, 0);
igt_describe("Tests with DPMS that VRR is enabled and that the difference between flip "
"timestamps converges to the requested rate.");
- igt_subtest("flip-dpms")
+ igt_subtest_with_dynamic("flip-dpms")
run_vrr_test(&data, test_basic, TEST_DPMS);
igt_describe("Tests that VRR is enabled and that the difference between flip "
"timestamps converges to the requested rate in a suspend test");
- igt_subtest("flip-suspend")
+ igt_subtest_with_dynamic("flip-suspend")
run_vrr_test(&data, test_basic, TEST_SUSPEND);
igt_describe("Make sure that flips happen at flipline decision boundary.");
- igt_subtest("flipline")
+ igt_subtest_with_dynamic("flipline")
run_vrr_test(&data, test_basic, TEST_FLIPLINE);
igt_fixture {
--
2.35.0
next prev parent reply other threads:[~2022-02-24 5:17 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 5:16 [igt-dev] [i-g-t 0/5] Add Negative tests to VRR Bhanuprakash Modem
2022-02-24 5:16 ` Bhanuprakash Modem [this message]
2022-03-04 1:01 ` [igt-dev] [i-g-t 1/5] tests/kms_vrr: Create dynamic subtests Navare, Manasi
2022-02-24 5:16 ` [igt-dev] [i-g-t 2/5] lib/igt_edid: Helper to read monitor range from EDID Bhanuprakash Modem
2022-02-24 8:32 ` [igt-dev] [v2 i-g-t " Bhanuprakash Modem
2022-03-04 1:07 ` [igt-dev] [i-g-t " Navare, Manasi
2022-03-04 3:12 ` Modem, Bhanuprakash
2022-02-24 5:16 ` [igt-dev] [i-g-t 3/5] tests/kms_vrr: Add Negative tests to validate VRR Bhanuprakash Modem
2022-03-04 1:20 ` Navare, Manasi
2022-03-04 4:02 ` Modem, Bhanuprakash
2022-03-07 4:57 ` Modem, Bhanuprakash
2022-03-07 20:06 ` Navare, Manasi
2022-03-08 4:13 ` Modem, Bhanuprakash
2022-02-24 5:16 ` [igt-dev] [i-g-t 4/5] tests/kms_vrr: Add a test for VRR range capability Bhanuprakash Modem
2022-02-24 5:16 ` [igt-dev] [i-g-t 5/5] HAX: Add VRR negative tests to BAT Bhanuprakash Modem
2022-02-24 6:53 ` [igt-dev] ✓ Fi.CI.BAT: success for Add Negative tests to VRR (rev3) Patchwork
2022-02-24 8:59 ` [igt-dev] ✗ GitLab.Pipeline: warning for Add Negative tests to VRR (rev4) Patchwork
2022-02-24 9:27 ` [igt-dev] ✓ Fi.CI.BAT: success " Patchwork
2022-02-24 18:53 ` [igt-dev] ✓ Fi.CI.IGT: success for Add Negative tests to VRR (rev3) Patchwork
2022-02-24 22:01 ` [igt-dev] ✗ Fi.CI.IGT: failure for Add Negative tests to VRR (rev4) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220224051648.91470-2-bhanuprakash.modem@intel.com \
--to=bhanuprakash.modem@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=manasi.d.navare@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.