From: Dan Carpenter <dan.carpenter@oracle.com>
To: Tong Zhang <ztong0001@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kees Cook <keescook@chromium.org>,
Jakub Kicinski <kuba@kernel.org>,
Colin Ian King <colin.i.king@googlemail.com>,
Lee Jones <lee.jones@linaro.org>,
Saurav Girepunje <saurav.girepunje@gmail.com>,
Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
Johan Hovold <johan@kernel.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/3] staging: rtl8192u: rework init and exit function
Date: Thu, 24 Feb 2022 10:27:17 +0300 [thread overview]
Message-ID: <20220224072717.GJ3943@kadam> (raw)
In-Reply-To: <20220224064033.1530924-3-ztong0001@gmail.com>
On Wed, Feb 23, 2022 at 10:40:31PM -0800, Tong Zhang wrote:
> The init and exit functions are not releasing resource properly. An error
> can be observed when we load/unload/load r8192u_usb module due to this
> issue. This patch rework init and exit functions to do proper resource
> release on init error and module unload.
> The __exit attribute is stripped from some functions since they are now
> being used by module init functions.
>
> [ 493.068012] proc_dir_entry 'net/ieee80211' already registered
> [ 493.271973] proc_mkdir+0x18/0x20
> [ 493.272136] ieee80211_debug_init+0x28/0xde8 [r8192u_usb]
> [ 493.272404] rtl8192_usb_module_init+0x10/0x161 [r8192u_usb]
>
> [ 13.910616] proc_dir_entry 'net/rtl819xU' already registered
> [ 13.918931] proc_mkdir+0x18/0x20
> [ 13.919098] rtl8192_usb_module_init+0x142/0x16d [r8192u_usb]
>
> Signed-off-by: Tong Zhang <ztong0001@gmail.com>
Good! Thanks!
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
regards,
dan carpenter
prev parent reply other threads:[~2022-02-24 7:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-20 23:15 [PATCH] staging: rtl8192u: cleanup proc fs entries upon exit Tong Zhang
2022-02-21 13:00 ` Dan Carpenter
2022-02-21 13:05 ` Dan Carpenter
2022-02-21 17:16 ` Greg Kroah-Hartman
2022-02-23 5:43 ` Tong Zhang
2022-02-24 6:40 ` [PATCH v2 1/3] staging: rtl8192u: fix broken debug macro Tong Zhang
2022-02-24 6:40 ` [PATCH v2 2/3] staging: rtl8192u: add empty debug functions Tong Zhang
2022-02-24 6:40 ` [PATCH v2 3/3] staging: rtl8192u: rework init and exit function Tong Zhang
2022-02-24 7:27 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220224072717.GJ3943@kadam \
--to=dan.carpenter@oracle.com \
--cc=colin.i.king@googlemail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=johan@kernel.org \
--cc=keescook@chromium.org \
--cc=kuba@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=saurav.girepunje@gmail.com \
--cc=ztong0001@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.