From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A10E9C433F5 for ; Thu, 24 Feb 2022 08:19:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ba2xOxw2VW28YD5AY5PNU75PXQ4gh9wwPRl4LRSNwCs=; b=unf4CdcKk8S8T5 YRiEBH1/U5T8feS8D5Z2ABHYM2zKG7MCwKThWvaOTwzgUhYSPnbMMDhDd7Ew0urxp6X0hYGxuoPku Usq1VgZcRVvZZQmar/0SUWGOXMrkZjqIOCCtqKOARmD/6quh5DjQ39RIb0eq+7ldAxlc29Sl8GjUy ljia52NcSk0So/AHzpbWASdYzJLB0qwpQ/b4vbGEe2JdjnG/447bNJSo1+uaHD58BeweJlIZvQZN2 e3DwMBdx1bRNpwOcwgfcILyAu0N9//Uj3Vk3TtMtyEhwIW2KgpEuDydh+m4xoFnrfv9ytu7LmtTsq s8kHLtQqcaVWHhNqm5Mw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nN9LU-00HGn5-NL; Thu, 24 Feb 2022 08:19:28 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nN9LJ-00HGkm-17 for linux-rockchip@lists.infradead.org; Thu, 24 Feb 2022 08:19:18 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nN9LE-0002PW-7K; Thu, 24 Feb 2022 09:19:12 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nN9LB-0008OP-Fk; Thu, 24 Feb 2022 09:19:09 +0100 Date: Thu, 24 Feb 2022 09:19:09 +0100 From: Sascha Hauer To: Andy Yan Cc: Heiko =?iso-8859-15?Q?St=FCbner?= , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , Peter Geis Subject: Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver Message-ID: <20220224081909.GS9136@pengutronix.de> References: <20220217082954.2967889-1-s.hauer@pengutronix.de> <20220217135823.GR18637@pengutronix.de> <6072461.kR79ftKOrO@diego> <8c0b1d1e-6787-8edc-c1fd-e1b68b92e60e@rock-chips.com> <20220218080024.GU18637@pengutronix.de> <8a386dbf-645b-8054-368b-535ded778d71@rock-chips.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8a386dbf-645b-8054-368b-535ded778d71@rock-chips.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:12:47 up 75 days, 16:58, 82 users, load average: 0.12, 0.25, 0.28 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-rockchip@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220224_001917_081577_ABD86E10 X-CRM114-Status: GOOD ( 46.86 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Sat, Feb 19, 2022 at 03:35:12PM +0800, Andy Yan wrote: > Hi Sascha: > = > On 2/18/22 16:00, Sascha Hauer wrote: > > On Fri, Feb 18, 2022 at 11:50:32AM +0800, Andy Yan wrote: > > > Hi Sascha: > > > = > > > On 2/17/22 22:06, Heiko St=FCbner wrote: > > > > Am Donnerstag, 17. Februar 2022, 14:58:23 CET schrieb Sascha Hauer: > > > > > Hi Andy, > > > > > = > > > > > Please trim the context in your answers to the relevant parts, it= makes > > > > > it easier to find the things you said. > > > > > = > > > > > On Thu, Feb 17, 2022 at 08:00:11PM +0800, Andy Yan wrote: > > > > > > Hi Sascha: > > > > > > = > > > > > > > + > > > > > > > + drm_for_each_encoder_mask(encoder, crtc->dev, crtc_state->e= ncoder_mask) { > > > > > > > + struct rockchip_encoder *rkencoder =3D to_rockchip_encoder= (encoder); > > > > > > > + struct device_node *node, *parent; > > > > > > > + > > > > > > > + parent =3D of_get_parent(rkencoder->port); > > > > > > > + > > > > > > > + for_each_endpoint_of_node(parent, node) { > > > > > > Is there any hurt directly use our downstream vendor kernel met= hod here: use > > > > > > vcstate->output_if set by encoder driver to get which interface= we should > > > > > > enable here? > > > > > There is no vcstate->output_if in mainline currently. Ok, we coul= d add > > > > > that. The other thing is that there are multiple HDMI interfaces = and > > > > > the id of the HDMI encoder is encoded into output_if. Downstream = kernel > > > > > adds OF aliases to the HDMI ports. I didn't want to go that route > > > > > because it doesn't seem to be very elegant to me. > > > aliases is a very comm strategy in device tree world. > > Yes, but not for retrieving bit offsets into registers. Normally aliases > > can be changed at board level without confusing drivers. > > = > > > And your method also > > > add need additional dt binds to define RK3568_VOP2_EP_xxx > > > > > > You method is ok with device tree, but it tied up this driver = to device > > > > > > tree, we are now tring to extend vop2 driver work with ACPI, so= we hope this > > > > > > driver can be much more flexible. > > > > > The current rockchip drm driver seems to be pretty much tied to d= evice > > > > > tree. There are probably many other places that need parallel pat= hs for > > > > > ACPI support, I think we can delay this particular part until we = see the > > > > > whole picture. In the end we can still retrieve the output_if > > > > > information differently with ACPI while still retrieving the info= rmation > > > > > from the device tree the way we are doing currently. > > > The current driver only reference device thee at driver initial, we n= ot wrap > > > = > > > device tree related things in other parts, so if we extend it to supp= ort > > > ACPI, > > > = > > > we just need modify the initial code, this make things easier. > > The device tree parsing could be moved out of vop2_crtc_atomic_enable() > > into some initialisation path. In the end it's static information, > > there's no need to do it repeatedly in atomic_enable. > = > This could be one solution, the repeatedly parsing device tree in > atomic_enable is also my concern. > = > In addition, there are 2 HDMI, 2 eDP, 2 MIPI on the coming rk3588, so it's > better to consider give position > = > for HDMI1, EDP1, in=A0 include/dt-bindings/soc/rockchip,vop2.h The defines are rk3568 specific. rk3588 would use a set of rk3588 specific defines along with a rk3588_set_intf_mux(). Sascha -- = Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9A43C433EF for ; Thu, 24 Feb 2022 08:20:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6Y2Gp6qS76ztYbwQGzWuJkK1jZji2WOby7hcRBIAIq0=; b=Op1dcP+qYebmh5 VloOdcwEjN7eMDeTjHlbRonVub3iEsi7c2W2E7+N0cSFPewPI5wrOK1vjEtFLubQ/Byi0G9eC+YXb SxM3sFy6N0Sh6egU/kN5J9i0qp1Al/eNSeIT1ISHJ3LYCZnDPaRMRvEpTRYum0sQQPgJcogwQK2mi 27NwXRrmEk/Ob/0uDc7DHlPXersbfBiNIbvI/3Qux37elSI72eoEmX44SJ2ihDD8B1hSnmDLpTyzY sjgaSgkrkuszcKBiq3Pg8LMuHXxTzHriZPJZE74grIsMGXFJtWsyNk2pZ7Hvf9aWOhSu0UXfWgeeu IIjLv6sWN+aIQOkB9RhA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nN9LM-00HGm6-2q; Thu, 24 Feb 2022 08:19:20 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nN9LH-00HGkZ-Tx for linux-arm-kernel@lists.infradead.org; Thu, 24 Feb 2022 08:19:17 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nN9LE-0002PW-7K; Thu, 24 Feb 2022 09:19:12 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nN9LB-0008OP-Fk; Thu, 24 Feb 2022 09:19:09 +0100 Date: Thu, 24 Feb 2022 09:19:09 +0100 From: Sascha Hauer To: Andy Yan Cc: Heiko =?iso-8859-15?Q?St=FCbner?= , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , Peter Geis Subject: Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver Message-ID: <20220224081909.GS9136@pengutronix.de> References: <20220217082954.2967889-1-s.hauer@pengutronix.de> <20220217135823.GR18637@pengutronix.de> <6072461.kR79ftKOrO@diego> <8c0b1d1e-6787-8edc-c1fd-e1b68b92e60e@rock-chips.com> <20220218080024.GU18637@pengutronix.de> <8a386dbf-645b-8054-368b-535ded778d71@rock-chips.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <8a386dbf-645b-8054-368b-535ded778d71@rock-chips.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:12:47 up 75 days, 16:58, 82 users, load average: 0.12, 0.25, 0.28 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220224_001915_993010_DAB78C68 X-CRM114-Status: GOOD ( 47.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Feb 19, 2022 at 03:35:12PM +0800, Andy Yan wrote: > Hi Sascha: > = > On 2/18/22 16:00, Sascha Hauer wrote: > > On Fri, Feb 18, 2022 at 11:50:32AM +0800, Andy Yan wrote: > > > Hi Sascha: > > > = > > > On 2/17/22 22:06, Heiko St=FCbner wrote: > > > > Am Donnerstag, 17. Februar 2022, 14:58:23 CET schrieb Sascha Hauer: > > > > > Hi Andy, > > > > > = > > > > > Please trim the context in your answers to the relevant parts, it= makes > > > > > it easier to find the things you said. > > > > > = > > > > > On Thu, Feb 17, 2022 at 08:00:11PM +0800, Andy Yan wrote: > > > > > > Hi Sascha: > > > > > > = > > > > > > > + > > > > > > > + drm_for_each_encoder_mask(encoder, crtc->dev, crtc_state->e= ncoder_mask) { > > > > > > > + struct rockchip_encoder *rkencoder =3D to_rockchip_encoder= (encoder); > > > > > > > + struct device_node *node, *parent; > > > > > > > + > > > > > > > + parent =3D of_get_parent(rkencoder->port); > > > > > > > + > > > > > > > + for_each_endpoint_of_node(parent, node) { > > > > > > Is there any hurt directly use our downstream vendor kernel met= hod here: use > > > > > > vcstate->output_if set by encoder driver to get which interface= we should > > > > > > enable here? > > > > > There is no vcstate->output_if in mainline currently. Ok, we coul= d add > > > > > that. The other thing is that there are multiple HDMI interfaces = and > > > > > the id of the HDMI encoder is encoded into output_if. Downstream = kernel > > > > > adds OF aliases to the HDMI ports. I didn't want to go that route > > > > > because it doesn't seem to be very elegant to me. > > > aliases is a very comm strategy in device tree world. > > Yes, but not for retrieving bit offsets into registers. Normally aliases > > can be changed at board level without confusing drivers. > > = > > > And your method also > > > add need additional dt binds to define RK3568_VOP2_EP_xxx > > > > > > You method is ok with device tree, but it tied up this driver = to device > > > > > > tree, we are now tring to extend vop2 driver work with ACPI, so= we hope this > > > > > > driver can be much more flexible. > > > > > The current rockchip drm driver seems to be pretty much tied to d= evice > > > > > tree. There are probably many other places that need parallel pat= hs for > > > > > ACPI support, I think we can delay this particular part until we = see the > > > > > whole picture. In the end we can still retrieve the output_if > > > > > information differently with ACPI while still retrieving the info= rmation > > > > > from the device tree the way we are doing currently. > > > The current driver only reference device thee at driver initial, we n= ot wrap > > > = > > > device tree related things in other parts, so if we extend it to supp= ort > > > ACPI, > > > = > > > we just need modify the initial code, this make things easier. > > The device tree parsing could be moved out of vop2_crtc_atomic_enable() > > into some initialisation path. In the end it's static information, > > there's no need to do it repeatedly in atomic_enable. > = > This could be one solution, the repeatedly parsing device tree in > atomic_enable is also my concern. > = > In addition, there are 2 HDMI, 2 eDP, 2 MIPI on the coming rk3588, so it's > better to consider give position > = > for HDMI1, EDP1, in=A0 include/dt-bindings/soc/rockchip,vop2.h The defines are rk3568 specific. rk3588 would use a set of rk3588 specific defines along with a rk3588_set_intf_mux(). Sascha -- = Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86BADC433EF for ; Thu, 24 Feb 2022 08:19:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229653AbiBXITt (ORCPT ); Thu, 24 Feb 2022 03:19:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45858 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229631AbiBXITt (ORCPT ); Thu, 24 Feb 2022 03:19:49 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61709251E79 for ; Thu, 24 Feb 2022 00:19:19 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nN9LE-0002PW-7K; Thu, 24 Feb 2022 09:19:12 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nN9LB-0008OP-Fk; Thu, 24 Feb 2022 09:19:09 +0100 Date: Thu, 24 Feb 2022 09:19:09 +0100 From: Sascha Hauer To: Andy Yan Cc: Heiko =?iso-8859-15?Q?St=FCbner?= , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, kernel@pengutronix.de, Benjamin Gaignard , Michael Riesch , Sandy Huang , Peter Geis Subject: Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver Message-ID: <20220224081909.GS9136@pengutronix.de> References: <20220217082954.2967889-1-s.hauer@pengutronix.de> <20220217135823.GR18637@pengutronix.de> <6072461.kR79ftKOrO@diego> <8c0b1d1e-6787-8edc-c1fd-e1b68b92e60e@rock-chips.com> <20220218080024.GU18637@pengutronix.de> <8a386dbf-645b-8054-368b-535ded778d71@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8a386dbf-645b-8054-368b-535ded778d71@rock-chips.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:12:47 up 75 days, 16:58, 82 users, load average: 0.12, 0.25, 0.28 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, Feb 19, 2022 at 03:35:12PM +0800, Andy Yan wrote: > Hi Sascha: > > On 2/18/22 16:00, Sascha Hauer wrote: > > On Fri, Feb 18, 2022 at 11:50:32AM +0800, Andy Yan wrote: > > > Hi Sascha: > > > > > > On 2/17/22 22:06, Heiko Stübner wrote: > > > > Am Donnerstag, 17. Februar 2022, 14:58:23 CET schrieb Sascha Hauer: > > > > > Hi Andy, > > > > > > > > > > Please trim the context in your answers to the relevant parts, it makes > > > > > it easier to find the things you said. > > > > > > > > > > On Thu, Feb 17, 2022 at 08:00:11PM +0800, Andy Yan wrote: > > > > > > Hi Sascha: > > > > > > > > > > > > > + > > > > > > > + drm_for_each_encoder_mask(encoder, crtc->dev, crtc_state->encoder_mask) { > > > > > > > + struct rockchip_encoder *rkencoder = to_rockchip_encoder(encoder); > > > > > > > + struct device_node *node, *parent; > > > > > > > + > > > > > > > + parent = of_get_parent(rkencoder->port); > > > > > > > + > > > > > > > + for_each_endpoint_of_node(parent, node) { > > > > > > Is there any hurt directly use our downstream vendor kernel method here: use > > > > > > vcstate->output_if set by encoder driver to get which interface we should > > > > > > enable here? > > > > > There is no vcstate->output_if in mainline currently. Ok, we could add > > > > > that. The other thing is that there are multiple HDMI interfaces and > > > > > the id of the HDMI encoder is encoded into output_if. Downstream kernel > > > > > adds OF aliases to the HDMI ports. I didn't want to go that route > > > > > because it doesn't seem to be very elegant to me. > > > aliases is a very comm strategy in device tree world. > > Yes, but not for retrieving bit offsets into registers. Normally aliases > > can be changed at board level without confusing drivers. > > > > > And your method also > > > add need additional dt binds to define RK3568_VOP2_EP_xxx > > > > > > You method is ok with device tree, but it tied up this driver to device > > > > > > tree, we are now tring to extend vop2 driver work with ACPI, so we hope this > > > > > > driver can be much more flexible. > > > > > The current rockchip drm driver seems to be pretty much tied to device > > > > > tree. There are probably many other places that need parallel paths for > > > > > ACPI support, I think we can delay this particular part until we see the > > > > > whole picture. In the end we can still retrieve the output_if > > > > > information differently with ACPI while still retrieving the information > > > > > from the device tree the way we are doing currently. > > > The current driver only reference device thee at driver initial, we not wrap > > > > > > device tree related things in other parts, so if we extend it to support > > > ACPI, > > > > > > we just need modify the initial code, this make things easier. > > The device tree parsing could be moved out of vop2_crtc_atomic_enable() > > into some initialisation path. In the end it's static information, > > there's no need to do it repeatedly in atomic_enable. > > This could be one solution, the repeatedly parsing device tree in > atomic_enable is also my concern. > > In addition, there are 2 HDMI, 2 eDP, 2 MIPI on the coming rk3588, so it's > better to consider give position > > for HDMI1, EDP1, in  include/dt-bindings/soc/rockchip,vop2.h The defines are rk3568 specific. rk3588 would use a set of rk3588 specific defines along with a rk3588_set_intf_mux(). Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0084C433F5 for ; Thu, 24 Feb 2022 08:19:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EB4E110E1ED; Thu, 24 Feb 2022 08:19:15 +0000 (UTC) Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id E97B610E1ED for ; Thu, 24 Feb 2022 08:19:13 +0000 (UTC) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nN9LE-0002PW-7K; Thu, 24 Feb 2022 09:19:12 +0100 Received: from sha by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1nN9LB-0008OP-Fk; Thu, 24 Feb 2022 09:19:09 +0100 Date: Thu, 24 Feb 2022 09:19:09 +0100 From: Sascha Hauer To: Andy Yan Subject: Re: [PATCH v6 21/23] drm: rockchip: Add VOP2 driver Message-ID: <20220224081909.GS9136@pengutronix.de> References: <20220217082954.2967889-1-s.hauer@pengutronix.de> <20220217135823.GR18637@pengutronix.de> <6072461.kR79ftKOrO@diego> <8c0b1d1e-6787-8edc-c1fd-e1b68b92e60e@rock-chips.com> <20220218080024.GU18637@pengutronix.de> <8a386dbf-645b-8054-368b-535ded778d71@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <8a386dbf-645b-8054-368b-535ded778d71@rock-chips.com> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 09:12:47 up 75 days, 16:58, 82 users, load average: 0.12, 0.25, 0.28 User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Benjamin Gaignard , Sandy Huang , dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Michael Riesch , kernel@pengutronix.de, Peter Geis , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, Feb 19, 2022 at 03:35:12PM +0800, Andy Yan wrote: > Hi Sascha: > > On 2/18/22 16:00, Sascha Hauer wrote: > > On Fri, Feb 18, 2022 at 11:50:32AM +0800, Andy Yan wrote: > > > Hi Sascha: > > > > > > On 2/17/22 22:06, Heiko Stübner wrote: > > > > Am Donnerstag, 17. Februar 2022, 14:58:23 CET schrieb Sascha Hauer: > > > > > Hi Andy, > > > > > > > > > > Please trim the context in your answers to the relevant parts, it makes > > > > > it easier to find the things you said. > > > > > > > > > > On Thu, Feb 17, 2022 at 08:00:11PM +0800, Andy Yan wrote: > > > > > > Hi Sascha: > > > > > > > > > > > > > + > > > > > > > + drm_for_each_encoder_mask(encoder, crtc->dev, crtc_state->encoder_mask) { > > > > > > > + struct rockchip_encoder *rkencoder = to_rockchip_encoder(encoder); > > > > > > > + struct device_node *node, *parent; > > > > > > > + > > > > > > > + parent = of_get_parent(rkencoder->port); > > > > > > > + > > > > > > > + for_each_endpoint_of_node(parent, node) { > > > > > > Is there any hurt directly use our downstream vendor kernel method here: use > > > > > > vcstate->output_if set by encoder driver to get which interface we should > > > > > > enable here? > > > > > There is no vcstate->output_if in mainline currently. Ok, we could add > > > > > that. The other thing is that there are multiple HDMI interfaces and > > > > > the id of the HDMI encoder is encoded into output_if. Downstream kernel > > > > > adds OF aliases to the HDMI ports. I didn't want to go that route > > > > > because it doesn't seem to be very elegant to me. > > > aliases is a very comm strategy in device tree world. > > Yes, but not for retrieving bit offsets into registers. Normally aliases > > can be changed at board level without confusing drivers. > > > > > And your method also > > > add need additional dt binds to define RK3568_VOP2_EP_xxx > > > > > > You method is ok with device tree, but it tied up this driver to device > > > > > > tree, we are now tring to extend vop2 driver work with ACPI, so we hope this > > > > > > driver can be much more flexible. > > > > > The current rockchip drm driver seems to be pretty much tied to device > > > > > tree. There are probably many other places that need parallel paths for > > > > > ACPI support, I think we can delay this particular part until we see the > > > > > whole picture. In the end we can still retrieve the output_if > > > > > information differently with ACPI while still retrieving the information > > > > > from the device tree the way we are doing currently. > > > The current driver only reference device thee at driver initial, we not wrap > > > > > > device tree related things in other parts, so if we extend it to support > > > ACPI, > > > > > > we just need modify the initial code, this make things easier. > > The device tree parsing could be moved out of vop2_crtc_atomic_enable() > > into some initialisation path. In the end it's static information, > > there's no need to do it repeatedly in atomic_enable. > > This could be one solution, the repeatedly parsing device tree in > atomic_enable is also my concern. > > In addition, there are 2 HDMI, 2 eDP, 2 MIPI on the coming rk3588, so it's > better to consider give position > > for HDMI1, EDP1, in  include/dt-bindings/soc/rockchip,vop2.h The defines are rk3568 specific. rk3588 would use a set of rk3588 specific defines along with a rk3588_set_intf_mux(). Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |