From: Christoph Hellwig <hch@lst.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH 3/3] nvme: check that EUI/GUID/UUID are globally unique
Date: Thu, 24 Feb 2022 17:51:38 +0100 [thread overview]
Message-ID: <20220224165138.GA32261@lst.de> (raw)
In-Reply-To: <20220224154304.GB2976831@dhcp-10-100-145-180.wdc.com>
On Thu, Feb 24, 2022 at 07:43:04AM -0800, Keith Busch wrote:
> It looks like a race condition exists here such that two namespaces with
> duplicate IDs in different subsystems being concurrently added may not
> see the duplicate.
Yes. But do we care? This is a sanity check. The alternative would be
to hold nvme_subsystems_lock for the whole ns_head probing, which is
a little annoying.
next prev parent reply other threads:[~2022-02-24 16:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 10:58 properly validate the nvme uniqueue identifiers are unique Christoph Hellwig
2022-02-24 10:58 ` [PATCH 1/3] nvme: cleanup __nvme_check_ids Christoph Hellwig
2022-02-24 13:31 ` Kanchan Joshi
2022-02-24 15:29 ` Keith Busch
2022-02-24 10:58 ` [PATCH 2/3] nvme: fix the IDs equality check Christoph Hellwig
2022-02-24 14:12 ` Kanchan Joshi
2022-02-24 10:58 ` [PATCH 3/3] nvme: check that EUI/GUID/UUID are globally unique Christoph Hellwig
2022-02-24 15:43 ` Keith Busch
2022-02-24 16:51 ` Christoph Hellwig [this message]
2022-02-24 17:12 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220224165138.GA32261@lst.de \
--to=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.