From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16C6CC433EF for ; Fri, 25 Feb 2022 02:31:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236747AbiBYCcH (ORCPT ); Thu, 24 Feb 2022 21:32:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231263AbiBYCcE (ORCPT ); Thu, 24 Feb 2022 21:32:04 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DEDE2DC9 for ; Thu, 24 Feb 2022 18:31:32 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BC30F61591 for ; Fri, 25 Feb 2022 02:31:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1DDCEC340EB; Fri, 25 Feb 2022 02:31:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1645756291; bh=uXAsTddlNLcxWEuMsgTsAALK50TvuzsGvZyAONAF2Dk=; h=Date:To:From:Subject:From; b=aS5WW2vG55gPB0Lg/mH+5Y7zTPeqLzOGr8CezQ5Y0DgUWBLnwmzh0OIGesEuJL9nA laqp3M5y0UG8dScfAvDM2VSOh67fsFU8LT7+Q/uLNTM+E95vXDk6fwOOiEe9XGMOlM jhxCIb30ohcNi09pgkU42JnbHP0GOROIHBD7P4Ro= Date: Thu, 24 Feb 2022 18:31:30 -0800 To: mm-commits@vger.kernel.org, shakeelb@google.com, roman.gushchin@linux.dev, mhocko@suse.com, hannes@cmpxchg.org, richard.weiyang@gmail.com, akpm@linux-foundation.org From: Andrew Morton Subject: + mm-memcg-set-memcg-after-css-verified-and-got-reference.patch added to -mm tree Message-Id: <20220225023131.1DDCEC340EB@smtp.kernel.org> Precedence: bulk Reply-To: linux-kernel@vger.kernel.org List-ID: X-Mailing-List: mm-commits@vger.kernel.org The patch titled Subject: mm/memcg: set memcg after css verified and got reference has been added to the -mm tree. Its filename is mm-memcg-set-memcg-after-css-verified-and-got-reference.patch This patch should soon appear at https://ozlabs.org/~akpm/mmots/broken-out/mm-memcg-set-memcg-after-css-verified-and-got-reference.patch and later at https://ozlabs.org/~akpm/mmotm/broken-out/mm-memcg-set-memcg-after-css-verified-and-got-reference.patch Before you just go and hit "reply", please: a) Consider who else should be cc'ed b) Prefer to cc a suitable mailing list as well c) Ideally: find the original patch on the mailing list and do a reply-to-all to that, adding suitable additional cc's *** Remember to use Documentation/process/submit-checklist.rst when testing your code *** The -mm tree is included into linux-next and is updated there every 3-4 working days ------------------------------------------------------ From: Wei Yang Subject: mm/memcg: set memcg after css verified and got reference Patch series "mm/memcg: some cleanup for mem_cgroup_iter()". This patch (of 3): Instead of resetting memcg when css is either not verified or has no reference, we can set it after these are processed. No functional change, just simplified the code a little. Link: https://lkml.kernel.org/r/20220225003437.12620-2-richard.weiyang@gmail.com Signed-off-by: Wei Yang Cc: Michal Hocko Cc: Roman Gushchin Cc: Johannes Weiner Cc: Shakeel Butt Signed-off-by: Andrew Morton --- mm/memcontrol.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) --- a/mm/memcontrol.c~mm-memcg-set-memcg-after-css-verified-and-got-reference +++ a/mm/memcontrol.c @@ -1089,15 +1089,10 @@ struct mem_cgroup *mem_cgroup_iter(struc * is provided by the caller, so we know it's alive * and kicking, and don't take an extra reference. */ - memcg = mem_cgroup_from_css(css); - - if (css == &root->css) - break; - - if (css_tryget(css)) + if (css == &root->css || css_tryget(css)) { + memcg = mem_cgroup_from_css(css); break; - - memcg = NULL; + } } if (reclaim) { _ Patches currently in -mm which might be from richard.weiyang@gmail.com are mm-memcg-mem_cgroup_per_node-is-already-set-to-0-on-allocation.patch mm-memcg-retrieve-parent-memcg-from-cssparent.patch mm-memcg-set-memcg-after-css-verified-and-got-reference.patch mm-memcg-set-pos-to-prev-unconditionally.patch mm-memcg-move-generation-assignment-and-comparison-together.patch mm-page_alloc-add-same-penalty-is-enough-to-get-round-robin-order.patch mm-page_alloc-add-penalty-to-local_node.patch memcg-do-not-tweak-node-in-alloc_mem_cgroup_per_node_info.patch