From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2E6DC433EF for ; Fri, 25 Feb 2022 17:32:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243736AbiBYRdR (ORCPT ); Fri, 25 Feb 2022 12:33:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52656 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233650AbiBYRdP (ORCPT ); Fri, 25 Feb 2022 12:33:15 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E11B03BFA1 for ; Fri, 25 Feb 2022 09:32:42 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 690DD61CB9 for ; Fri, 25 Feb 2022 17:32:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27703C340E7; Fri, 25 Feb 2022 17:32:40 +0000 (UTC) Date: Fri, 25 Feb 2022 12:32:38 -0500 From: Steven Rostedt To: Josh Poimboeuf Cc: Peter Zijlstra , x86@kernel.org, joao@overdrivepizza.com, hjl.tools@gmail.com, andrew.cooper3@citrix.com, linux-kernel@vger.kernel.org, ndesaulniers@google.com, keescook@chromium.org, samitolvanen@google.com, mark.rutland@arm.com, alyssa.milburn@intel.com, mbenes@suse.cz, mhiramat@kernel.org, alexei.starovoitov@gmail.com Subject: Re: [PATCH v2 00/39] x86: Kernel IBT Message-ID: <20220225123238.5ceeaae1@gandalf.local.home> In-Reply-To: <20220225172644.76fyxjximjrcdbzt@treble> References: <20220224145138.952963315@infradead.org> <20220224202602.3gvz5tnxvwb4maod@treble> <20220225172644.76fyxjximjrcdbzt@treble> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 25 Feb 2022 09:26:44 -0800 Josh Poimboeuf wrote: > > Damn, I just realized this makes KERNEL_IBT hard depend on KALLSYMS :-( > > Why should the jump label patching code even care whether there's an > ENDBR at the jump target? It should never jump to the beginning of a > function anyway, right? And objtool presumably doesn't patch out ENDBRs > in the middle of a function. Perhaps Peter confused jump labels with static calls? -- Steve