[linusw-nomadik:ux500-href-charging-v5.17-rc1 28/30] drivers/power/supply/samsung-sdi-battery.c:29:35: sparse: sparse: symbol 'samsung_vbat2res_discharging_eb_l1m7flu' was not declared. Should it be static?

[linusw-nomadik:ux500-href-charging-v5.17-rc1 28/30] drivers/power/supply/samsung-sdi-battery.c:29:35: sparse: sparse: symbol 'samsung_vbat2res_discharging_eb_l1m7flu' was not declared. Should it be static?

[kernel test robot]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-nomadik.git ux500-href-charging-v5.17-rc1
head:   ff2a9483749f5860407c6fb4798202b774978a81
commit: 77f450def23a94bcdea9a60f4df683461899158e [28/30] power: supply: Static data for Samsung batteries
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20220226/202202260125.d751ECgs-lkp@intel.com/config)
compiler: gcc-9 (Debian 9.3.0-22) 9.3.0
reproduce:
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-nomadik.git/commit/?id=77f450def23a94bcdea9a60f4df683461899158e
        git remote add linusw-nomadik https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-nomadik.git
        git fetch --no-tags linusw-nomadik ux500-href-charging-v5.17-rc1
        git checkout 77f450def23a94bcdea9a60f4df683461899158e
        # save the config file to linux build tree
        mkdir build_dir
        make W=1 C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/power/supply/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> drivers/power/supply/samsung-sdi-battery.c:29:35: sparse: sparse: symbol 'samsung_vbat2res_discharging_eb_l1m7flu' was not declared. Should it be static?
>> drivers/power/supply/samsung-sdi-battery.c:57:35: sparse: sparse: symbol 'samsung_vbat2res_charging_eb_l1m7flu' was not declared. Should it be static?
>> drivers/power/supply/samsung-sdi-battery.c:77:35: sparse: sparse: symbol 'samsung_vbat2res_discharging_eb425161la' was not declared. Should it be static?
>> drivers/power/supply/samsung-sdi-battery.c:109:35: sparse: sparse: symbol 'samsung_vbat2res_charging_eb425161la' was not declared. Should it be static?
>> drivers/power/supply/samsung-sdi-battery.c:186:35: sparse: sparse: symbol 'samsung_vbat2res_discharging_eb425161lu' was not declared. Should it be static?
>> drivers/power/supply/samsung-sdi-battery.c:218:35: sparse: sparse: symbol 'samsung_vbat2res_charging_eb425161lu' was not declared. Should it be static?
>> drivers/power/supply/samsung-sdi-battery.c:248:35: sparse: sparse: symbol 'samsung_vbat2res_discharging_eb485159lu' was not declared. Should it be static?
>> drivers/power/supply/samsung-sdi-battery.c:275:35: sparse: sparse: symbol 'samsung_vbat2res_charging_eb485159lu' was not declared. Should it be static?
>> drivers/power/supply/samsung-sdi-battery.c:295:35: sparse: sparse: symbol 'samsung_vbat2res_discharging_eb535151vu' was not declared. Should it be static?
>> drivers/power/supply/samsung-sdi-battery.c:315:35: sparse: sparse: symbol 'samsung_vbat2res_charging_eb535151vu' was not declared. Should it be static?
   drivers/power/supply/samsung-sdi-battery.c:335:35: sparse: sparse: symbol 'samsung_vbat2res_discharging_eb585157lu' was not declared. Should it be static?
   drivers/power/supply/samsung-sdi-battery.c:405:35: sparse: sparse: symbol 'samsung_vbat2res_charging_eb585157lu' was not declared. Should it be static?
   drivers/power/supply/samsung-sdi-battery.c:617:46: sparse: sparse: symbol 'samsung_maint_charge_table' was not declared. Should it be static?
   drivers/power/supply/samsung-sdi-battery.c:632:28: sparse: sparse: symbol 'samsung_sdi_batteries' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[RFC PATCH linusw-nomadik] power: supply: samsung_vbat2res_discharging_eb_l1m7flu[] can be static

[kernel test robot]

drivers/power/supply/samsung-sdi-battery.c:29:35: warning: symbol 'samsung_vbat2res_discharging_eb_l1m7flu' was not declared. Should it be static?
drivers/power/supply/samsung-sdi-battery.c:57:35: warning: symbol 'samsung_vbat2res_charging_eb_l1m7flu' was not declared. Should it be static?
drivers/power/supply/samsung-sdi-battery.c:77:35: warning: symbol 'samsung_vbat2res_discharging_eb425161la' was not declared. Should it be static?
drivers/power/supply/samsung-sdi-battery.c:109:35: warning: symbol 'samsung_vbat2res_charging_eb425161la' was not declared. Should it be static?
drivers/power/supply/samsung-sdi-battery.c:186:35: warning: symbol 'samsung_vbat2res_discharging_eb425161lu' was not declared. Should it be static?
drivers/power/supply/samsung-sdi-battery.c:218:35: warning: symbol 'samsung_vbat2res_charging_eb425161lu' was not declared. Should it be static?
drivers/power/supply/samsung-sdi-battery.c:248:35: warning: symbol 'samsung_vbat2res_discharging_eb485159lu' was not declared. Should it be static?
drivers/power/supply/samsung-sdi-battery.c:275:35: warning: symbol 'samsung_vbat2res_charging_eb485159lu' was not declared. Should it be static?
drivers/power/supply/samsung-sdi-battery.c:295:35: warning: symbol 'samsung_vbat2res_discharging_eb535151vu' was not declared. Should it be static?
drivers/power/supply/samsung-sdi-battery.c:315:35: warning: symbol 'samsung_vbat2res_charging_eb535151vu' was not declared. Should it be static?

Fixes: 77f450def23a ("power: supply: Static data for Samsung batteries")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: kernel test robot <lkp@intel.com>
---
 drivers/power/supply/samsung-sdi-battery.c |   20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/power/supply/samsung-sdi-battery.c b/drivers/power/supply/samsung-sdi-battery.c
index 8e718f0fc2b5b..3dbc05bc2e576 100644
--- a/drivers/power/supply/samsung-sdi-battery.c
+++ b/drivers/power/supply/samsung-sdi-battery.c
@@ -26,7 +26,7 @@ struct samsung_sdi_battery {
  * tables apply depending on whether we are charging or not.
  */
 
-struct power_supply_vbat_ri_table samsung_vbat2res_discharging_eb_l1m7flu[] = {
+static struct power_supply_vbat_ri_table samsung_vbat2res_discharging_eb_l1m7flu[] = {
 	{ .vbat_uv = 4240000, .ri_uohm = 160000 },
 	{ .vbat_uv = 4210000, .ri_uohm = 179000 },
 	{ .vbat_uv = 4180000, .ri_uohm = 183000 },
@@ -54,7 +54,7 @@ struct power_supply_vbat_ri_table samsung_vbat2res_discharging_eb_l1m7flu[] = {
 	{ .vbat_uv = 3300000, .ri_uohm = 339000 },
 };
 
-struct power_supply_vbat_ri_table samsung_vbat2res_charging_eb_l1m7flu[] = {
+static struct power_supply_vbat_ri_table samsung_vbat2res_charging_eb_l1m7flu[] = {
 	{ .vbat_uv = 4302000, .ri_uohm = 230000 },
 	{ .vbat_uv = 4276000, .ri_uohm = 345000 },
 	{ .vbat_uv = 4227000, .ri_uohm = 345000 },
@@ -74,7 +74,7 @@ struct power_supply_vbat_ri_table samsung_vbat2res_charging_eb_l1m7flu[] = {
 	{ .vbat_uv = 3590000, .ri_uohm = 164000 },
 };
 
-struct power_supply_vbat_ri_table samsung_vbat2res_discharging_eb425161la[] = {
+static struct power_supply_vbat_ri_table samsung_vbat2res_discharging_eb425161la[] = {
 	{ .vbat_uv = 4240000, .ri_uohm = 160000 },
 	{ .vbat_uv = 4210000, .ri_uohm = 179000 },
 	{ .vbat_uv = 4180000, .ri_uohm = 183000 },
@@ -106,7 +106,7 @@ struct power_supply_vbat_ri_table samsung_vbat2res_discharging_eb425161la[] = {
 	{ .vbat_uv = 3300000, .ri_uohm = 339000 },
 };
 
-struct power_supply_vbat_ri_table samsung_vbat2res_charging_eb425161la[] = {
+static struct power_supply_vbat_ri_table samsung_vbat2res_charging_eb425161la[] = {
 	{ .vbat_uv = 4345000, .ri_uohm = 230000 },
 	{ .vbat_uv = 4329000, .ri_uohm = 238000 },
 	{ .vbat_uv = 4314000, .ri_uohm = 225000 },
@@ -183,7 +183,7 @@ struct power_supply_vbat_ri_table samsung_vbat2res_charging_eb425161la[] = {
 	{ .vbat_uv = 3590000, .ri_uohm = 164000 },
 };
 
-struct power_supply_vbat_ri_table samsung_vbat2res_discharging_eb425161lu[] = {
+static struct power_supply_vbat_ri_table samsung_vbat2res_discharging_eb425161lu[] = {
 	{ .vbat_uv = 4240000, .ri_uohm = 160000 },
 	{ .vbat_uv = 4210000, .ri_uohm = 179000 },
 	{ .vbat_uv = 4180000, .ri_uohm = 183000 },
@@ -215,7 +215,7 @@ struct power_supply_vbat_ri_table samsung_vbat2res_discharging_eb425161lu[] = {
 	{ .vbat_uv = 3300000, .ri_uohm = 339000 },
 };
 
-struct power_supply_vbat_ri_table samsung_vbat2res_charging_eb425161lu[] = {
+static struct power_supply_vbat_ri_table samsung_vbat2res_charging_eb425161lu[] = {
 	{ .vbat_uv = 4346000, .ri_uohm = 293000 },
 	{ .vbat_uv = 4336000, .ri_uohm = 290000 },
 	{ .vbat_uv = 4315000, .ri_uohm = 274000 },
@@ -245,7 +245,7 @@ struct power_supply_vbat_ri_table samsung_vbat2res_charging_eb425161lu[] = {
 	{ .vbat_uv = 3590000, .ri_uohm = 164000 },
 };
 
-struct power_supply_vbat_ri_table samsung_vbat2res_discharging_eb485159lu[] = {
+static struct power_supply_vbat_ri_table samsung_vbat2res_discharging_eb485159lu[] = {
 	{ .vbat_uv = 4240000, .ri_uohm = 160000 },
 	{ .vbat_uv = 4210000, .ri_uohm = 179000 },
 	{ .vbat_uv = 4180000, .ri_uohm = 183000 },
@@ -272,7 +272,7 @@ struct power_supply_vbat_ri_table samsung_vbat2res_discharging_eb485159lu[] = {
 	{ .vbat_uv = 3300000, .ri_uohm = 339000 },
 };
 
-struct power_supply_vbat_ri_table samsung_vbat2res_charging_eb485159lu[] = {
+static struct power_supply_vbat_ri_table samsung_vbat2res_charging_eb485159lu[] = {
 	{ .vbat_uv = 4302000, .ri_uohm = 200000 },
 	{ .vbat_uv = 4258000, .ri_uohm = 206000 },
 	{ .vbat_uv = 4200000, .ri_uohm = 231000 },
@@ -292,7 +292,7 @@ struct power_supply_vbat_ri_table samsung_vbat2res_charging_eb485159lu[] = {
 	{ .vbat_uv = 3590000, .ri_uohm = 164000 },
 };
 
-struct power_supply_vbat_ri_table samsung_vbat2res_discharging_eb535151vu[] = {
+static struct power_supply_vbat_ri_table samsung_vbat2res_discharging_eb535151vu[] = {
 	{ .vbat_uv = 4071000, .ri_uohm = 158000 },
 	{ .vbat_uv = 4019000, .ri_uohm = 187000 },
 	{ .vbat_uv = 3951000, .ri_uohm = 191000 },
@@ -312,7 +312,7 @@ struct power_supply_vbat_ri_table samsung_vbat2res_discharging_eb535151vu[] = {
 	{ .vbat_uv = 3280000, .ri_uohm = 250000 },
 };
 
-struct power_supply_vbat_ri_table samsung_vbat2res_charging_eb535151vu[] = {
+static struct power_supply_vbat_ri_table samsung_vbat2res_charging_eb535151vu[] = {
 	{ .vbat_uv = 4190000, .ri_uohm = 214000 },
 	{ .vbat_uv = 4159000, .ri_uohm = 252000 },
 	{ .vbat_uv = 4121000, .ri_uohm = 245000 },

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel