From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 89837C433EF for ; Tue, 1 Mar 2022 08:52:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v5pEeYllAadR0g2l0xIQQmQiXaGkM4h9KXxsi9gpeOU=; b=BFX1Z0Yq20Iyv+ /tMtLpVY0nuv2VV/HEf7p+KnPvUMZK6McmokgXR7P1DkMWTt/mrRecM3CGy5Nytkd1wX0g8Ygc8Z/ ybu1SpdY3xkP0DevSEb1gtt86K0vW+2Yj3vPM5IXTB40jHMlPD01K5O1qhpSlPIAjPG/OV9i9zdwI sBLGnOtifEtk9ecpmJw9ePV8kFmzAlFm5H/JX1YH4EUoTmneVHGNHOOnWuSF3vvLCSSE1yNklbBeZ O5bOWIAOC6EGVIY8X0Byf5iPdP7NeyN8bEfUzvcAt7HDnVBIx/3hIrbWlRmA0pwEYAYDf8Sl7EwU0 U7b60Oo5TUdE/IYjBDCA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOyE2-00FhIW-K2; Tue, 01 Mar 2022 08:51:18 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOyDX-00Fh1r-S6; Tue, 01 Mar 2022 08:50:49 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id AA7871F43F9D; Tue, 1 Mar 2022 08:50:43 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1646124644; bh=0ZrsARjiH24wsElmcwQCEqvABOocHSYJJ1IUet5VHj0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VkssrVfGYwFWa86K5JP4dvVJi6C+6lIuwJgIlWE43OPqM0Jkp6M9+FhyeHzetVEl+ GHv/S5dgJcAckf4Rz8kTvMI3l2e5f8DT3pWg6E9FH0/dMdwYbVh3DloQHKlmplgNrl /OS4LXT69IGzmAt7ExHejLoZJgKgThPU/lkUtaI3B1X8gsNlxdIrX/2m3NQApgnQ9s O7VmwhqHFJ0gpWAB6+nSGvaOOTp/YOQwllykSHbIkN/HgNEHhmUQyObYJGUj+vP1Ua w61pUvqu9bVvZlIXtQ7a3Nw/3CJkFwNzfWJj0KB7IwvU14dF5AExlse8rU/ajiY6Zm YPGpFHL9UWlOQ== Date: Tue, 1 Mar 2022 09:50:37 +0100 From: Boris Brezillon To: Xin Xiong Cc: Tudor Ambarus , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Boris Brezillon , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, yuanxzhang@fudan.edu.cn, Xiyu Yang , Xin Tan Subject: Re: [PATCH v2] mtd: rawnand: atmel: fix refcount issue in atmel_nand_controller_init Message-ID: <20220301095037.1763e051@collabora.com> In-Reply-To: <20220301044556.36162-1-xiongx18@fudan.edu.cn> References: <20220301044556.36162-1-xiongx18@fudan.edu.cn> Organization: Collabora X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220301_005048_170085_DEC0C360 X-CRM114-Status: GOOD ( 20.79 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Tue, 1 Mar 2022 12:45:56 +0800 Xin Xiong wrote: > The reference counting issue happens in several error handling paths > on a refcounted object "nc->dmac". In these paths, the function simply > returns the error code, forgetting to balance the reference count of > "nc->dmac", increased earlier by dma_request_channel(), which may > cause refcount leaks. > > Fix it by decrementing the refcount of specific object in those error > paths. > > Fixes: f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver") > Co-developed-by: Xiyu Yang > Signed-off-by: Xiyu Yang > Co-developed-by: Xin Tan > Signed-off-by: Xin Tan > Signed-off-by: Xin Xiong > --- > V1 -> V2: Rewrited the error handling block > --- > drivers/mtd/nand/raw/atmel/nand-controller.c | 18 +++++++++++++++--- > 1 file changed, 15 insertions(+), 3 deletions(-) > > diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c > index f3276ee9e4fe..0efeb5d77be0 100644 > --- a/drivers/mtd/nand/raw/atmel/nand-controller.c > +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c > @@ -2060,13 +2060,15 @@ static int atmel_nand_controller_init(struct atmel_nand_controller *nc, > nc->mck = of_clk_get(dev->parent->of_node, 0); > if (IS_ERR(nc->mck)) { > dev_err(dev, "Failed to retrieve MCK clk\n"); > - return PTR_ERR(nc->mck); > + ret = PTR_ERR(nc->mck); > + goto out_release_dma; > } > > np = of_parse_phandle(dev->parent->of_node, "atmel,smc", 0); > if (!np) { > dev_err(dev, "Missing or invalid atmel,smc property\n"); > - return -EINVAL; > + ret = -EINVAL; > + goto out_release_dma; > } > > nc->smc = syscon_node_to_regmap(np); > @@ -2074,10 +2076,20 @@ static int atmel_nand_controller_init(struct atmel_nand_controller *nc, > if (IS_ERR(nc->smc)) { > ret = PTR_ERR(nc->smc); > dev_err(dev, "Could not get SMC regmap (err = %d)\n", ret); > - return ret; > + goto out_release_dma; > } > > return 0; > + > +out_release_dma: > + if (nc->caps->has_dma && !atmel_nand_avoid_dma) { > + if (nc->dmac) { > + dma_release_channel(nc->dmac); > + nc->dmac = NULL; > + } > + } Nit: if (nc->dmac) dma_release_channel(nc->dmac); should work just fine. > + > + return ret; > } > > static int ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9EDB2C433EF for ; Tue, 1 Mar 2022 08:52:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jX0T9Y5G0zptCyW9S/k+/WZY/Fbcs3Lv7Fn9IbjI/58=; b=wFSEgQ55OS2lZW qg/ISr7KidaY56Kfle7NOYpDpALPqTdZ3p0cuzWDPHT9pQFwLC16qLr8oN0hy53UPgHjt6jOqvAwU eYMAl0LMd5TtVWyIfgcddTHjZHqcqmxCd0nv9r+PFy2UlqqcTuuQr1t7yRecmZYwD1BzEMUjItdok Xd0nXVmYgH1tntfHY75QdMTpAefF8rkGK7yEYGcQ9+Y00lN2P6/ZIZnfdNlV8pNTYAo7gZaz2AI4p Y1ZKHFb0jpIHobBguYmm8EB+7CsPRiBebpFiIhXIH/y87fZkSj20LbVPYZ0TX6gtd8eSdO94Q63Du pmrM0QP7NMjWXqKv47Rg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOyDl-00Fh8K-6G; Tue, 01 Mar 2022 08:51:01 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nOyDX-00Fh1r-S6; Tue, 01 Mar 2022 08:50:49 +0000 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id AA7871F43F9D; Tue, 1 Mar 2022 08:50:43 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1646124644; bh=0ZrsARjiH24wsElmcwQCEqvABOocHSYJJ1IUet5VHj0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VkssrVfGYwFWa86K5JP4dvVJi6C+6lIuwJgIlWE43OPqM0Jkp6M9+FhyeHzetVEl+ GHv/S5dgJcAckf4Rz8kTvMI3l2e5f8DT3pWg6E9FH0/dMdwYbVh3DloQHKlmplgNrl /OS4LXT69IGzmAt7ExHejLoZJgKgThPU/lkUtaI3B1X8gsNlxdIrX/2m3NQApgnQ9s O7VmwhqHFJ0gpWAB6+nSGvaOOTp/YOQwllykSHbIkN/HgNEHhmUQyObYJGUj+vP1Ua w61pUvqu9bVvZlIXtQ7a3Nw/3CJkFwNzfWJj0KB7IwvU14dF5AExlse8rU/ajiY6Zm YPGpFHL9UWlOQ== Date: Tue, 1 Mar 2022 09:50:37 +0100 From: Boris Brezillon To: Xin Xiong Subject: Re: [PATCH v2] mtd: rawnand: atmel: fix refcount issue in atmel_nand_controller_init Message-ID: <20220301095037.1763e051@collabora.com> In-Reply-To: <20220301044556.36162-1-xiongx18@fudan.edu.cn> References: <20220301044556.36162-1-xiongx18@fudan.edu.cn> Organization: Collabora X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220301_005048_170085_DEC0C360 X-CRM114-Status: GOOD ( 20.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Belloni , yuanxzhang@fudan.edu.cn, Vignesh Raghavendra , Xiyu Yang , Tudor Ambarus , Richard Weinberger , Boris Brezillon , linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, Xin Tan , Miquel Raynal , Claudiu Beznea , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 1 Mar 2022 12:45:56 +0800 Xin Xiong wrote: > The reference counting issue happens in several error handling paths > on a refcounted object "nc->dmac". In these paths, the function simply > returns the error code, forgetting to balance the reference count of > "nc->dmac", increased earlier by dma_request_channel(), which may > cause refcount leaks. > > Fix it by decrementing the refcount of specific object in those error > paths. > > Fixes: f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver") > Co-developed-by: Xiyu Yang > Signed-off-by: Xiyu Yang > Co-developed-by: Xin Tan > Signed-off-by: Xin Tan > Signed-off-by: Xin Xiong > --- > V1 -> V2: Rewrited the error handling block > --- > drivers/mtd/nand/raw/atmel/nand-controller.c | 18 +++++++++++++++--- > 1 file changed, 15 insertions(+), 3 deletions(-) > > diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c > index f3276ee9e4fe..0efeb5d77be0 100644 > --- a/drivers/mtd/nand/raw/atmel/nand-controller.c > +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c > @@ -2060,13 +2060,15 @@ static int atmel_nand_controller_init(struct atmel_nand_controller *nc, > nc->mck = of_clk_get(dev->parent->of_node, 0); > if (IS_ERR(nc->mck)) { > dev_err(dev, "Failed to retrieve MCK clk\n"); > - return PTR_ERR(nc->mck); > + ret = PTR_ERR(nc->mck); > + goto out_release_dma; > } > > np = of_parse_phandle(dev->parent->of_node, "atmel,smc", 0); > if (!np) { > dev_err(dev, "Missing or invalid atmel,smc property\n"); > - return -EINVAL; > + ret = -EINVAL; > + goto out_release_dma; > } > > nc->smc = syscon_node_to_regmap(np); > @@ -2074,10 +2076,20 @@ static int atmel_nand_controller_init(struct atmel_nand_controller *nc, > if (IS_ERR(nc->smc)) { > ret = PTR_ERR(nc->smc); > dev_err(dev, "Could not get SMC regmap (err = %d)\n", ret); > - return ret; > + goto out_release_dma; > } > > return 0; > + > +out_release_dma: > + if (nc->caps->has_dma && !atmel_nand_avoid_dma) { > + if (nc->dmac) { > + dma_release_channel(nc->dmac); > + nc->dmac = NULL; > + } > + } Nit: if (nc->dmac) dma_release_channel(nc->dmac); should work just fine. > + > + return ret; > } > > static int _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 896ECC433F5 for ; Tue, 1 Mar 2022 08:50:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233605AbiCAIv3 (ORCPT ); Tue, 1 Mar 2022 03:51:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233585AbiCAIv1 (ORCPT ); Tue, 1 Mar 2022 03:51:27 -0500 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A35558931F for ; Tue, 1 Mar 2022 00:50:46 -0800 (PST) Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id AA7871F43F9D; Tue, 1 Mar 2022 08:50:43 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1646124644; bh=0ZrsARjiH24wsElmcwQCEqvABOocHSYJJ1IUet5VHj0=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VkssrVfGYwFWa86K5JP4dvVJi6C+6lIuwJgIlWE43OPqM0Jkp6M9+FhyeHzetVEl+ GHv/S5dgJcAckf4Rz8kTvMI3l2e5f8DT3pWg6E9FH0/dMdwYbVh3DloQHKlmplgNrl /OS4LXT69IGzmAt7ExHejLoZJgKgThPU/lkUtaI3B1X8gsNlxdIrX/2m3NQApgnQ9s O7VmwhqHFJ0gpWAB6+nSGvaOOTp/YOQwllykSHbIkN/HgNEHhmUQyObYJGUj+vP1Ua w61pUvqu9bVvZlIXtQ7a3Nw/3CJkFwNzfWJj0KB7IwvU14dF5AExlse8rU/ajiY6Zm YPGpFHL9UWlOQ== Date: Tue, 1 Mar 2022 09:50:37 +0100 From: Boris Brezillon To: Xin Xiong Cc: Tudor Ambarus , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Nicolas Ferre , Alexandre Belloni , Claudiu Beznea , Boris Brezillon , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, yuanxzhang@fudan.edu.cn, Xiyu Yang , Xin Tan Subject: Re: [PATCH v2] mtd: rawnand: atmel: fix refcount issue in atmel_nand_controller_init Message-ID: <20220301095037.1763e051@collabora.com> In-Reply-To: <20220301044556.36162-1-xiongx18@fudan.edu.cn> References: <20220301044556.36162-1-xiongx18@fudan.edu.cn> Organization: Collabora X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.31; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 1 Mar 2022 12:45:56 +0800 Xin Xiong wrote: > The reference counting issue happens in several error handling paths > on a refcounted object "nc->dmac". In these paths, the function simply > returns the error code, forgetting to balance the reference count of > "nc->dmac", increased earlier by dma_request_channel(), which may > cause refcount leaks. > > Fix it by decrementing the refcount of specific object in those error > paths. > > Fixes: f88fc122cc34 ("mtd: nand: Cleanup/rework the atmel_nand driver") > Co-developed-by: Xiyu Yang > Signed-off-by: Xiyu Yang > Co-developed-by: Xin Tan > Signed-off-by: Xin Tan > Signed-off-by: Xin Xiong > --- > V1 -> V2: Rewrited the error handling block > --- > drivers/mtd/nand/raw/atmel/nand-controller.c | 18 +++++++++++++++--- > 1 file changed, 15 insertions(+), 3 deletions(-) > > diff --git a/drivers/mtd/nand/raw/atmel/nand-controller.c b/drivers/mtd/nand/raw/atmel/nand-controller.c > index f3276ee9e4fe..0efeb5d77be0 100644 > --- a/drivers/mtd/nand/raw/atmel/nand-controller.c > +++ b/drivers/mtd/nand/raw/atmel/nand-controller.c > @@ -2060,13 +2060,15 @@ static int atmel_nand_controller_init(struct atmel_nand_controller *nc, > nc->mck = of_clk_get(dev->parent->of_node, 0); > if (IS_ERR(nc->mck)) { > dev_err(dev, "Failed to retrieve MCK clk\n"); > - return PTR_ERR(nc->mck); > + ret = PTR_ERR(nc->mck); > + goto out_release_dma; > } > > np = of_parse_phandle(dev->parent->of_node, "atmel,smc", 0); > if (!np) { > dev_err(dev, "Missing or invalid atmel,smc property\n"); > - return -EINVAL; > + ret = -EINVAL; > + goto out_release_dma; > } > > nc->smc = syscon_node_to_regmap(np); > @@ -2074,10 +2076,20 @@ static int atmel_nand_controller_init(struct atmel_nand_controller *nc, > if (IS_ERR(nc->smc)) { > ret = PTR_ERR(nc->smc); > dev_err(dev, "Could not get SMC regmap (err = %d)\n", ret); > - return ret; > + goto out_release_dma; > } > > return 0; > + > +out_release_dma: > + if (nc->caps->has_dma && !atmel_nand_avoid_dma) { > + if (nc->dmac) { > + dma_release_channel(nc->dmac); > + nc->dmac = NULL; > + } > + } Nit: if (nc->dmac) dma_release_channel(nc->dmac); should work just fine. > + > + return ret; > } > > static int