From: Stephen Hemminger <stephen@networkplumber.org>
To: daniel@braunwarth.dev
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2-next 1/2] lib: add profinet and ethercat as link layer protocol names
Date: Tue, 1 Mar 2022 11:58:55 -0800 [thread overview]
Message-ID: <20220301115855.53fe4e51@hermes.local> (raw)
In-Reply-To: <d928314fccec204c36979e253b8fc4ae@braunwarth.dev>
On Tue, 01 Mar 2022 18:26:10 +0000
daniel@braunwarth.dev wrote:
> February 28, 2022 6:21 PM, "Stephen Hemminger" <stephen@networkplumber.org> wrote:
> > This is legacy table. Original author did choose to use stanard
> > file /etc/ethertypes. Not sure why??
>
> I tried to extend /etc/ethertypes with the following line:
> ETHERCAT 88A4 ethercat
>
> I would expect the following command to successfully run:
> tc filter add dev eno1 protocol ethercat matchall action drop
>
> Unfortunately all I get is:
> Error: argument "ethercat" is wrong: invalid protocol
>
> With my patches applied, the command runs without any error.
>
>
> I wasn't able to find any hint in the code, where /etc/ethertypes is supposed to be parsed. Could you give me a hint?
>
>
> Thanks
>
> Daniel
Right, iproute2 has its own built in table.
There is nothing that parses and loads ethertypes.
I am suggesting that there ought to read and cache the file; assuming it doesn't slow things down too much.
next prev parent reply other threads:[~2022-03-01 19:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-28 13:45 [PATCH iproute2-next 0/2] lib: add profinet and ethercat as link layer protocol Daniel Braunwarth
2022-02-28 13:45 ` [PATCH iproute2-next 1/2] lib: add profinet and ethercat as link layer protocol names Daniel Braunwarth
2022-02-28 17:21 ` Stephen Hemminger
2022-03-01 18:26 ` daniel
2022-03-01 19:58 ` Stephen Hemminger [this message]
2022-02-28 13:45 ` [PATCH iproute2-next 2/2] tc: bash-completion: Add profinet and ethercat to procotol completion list Daniel Braunwarth
2022-03-04 16:30 ` [PATCH iproute2-next 0/2] lib: add profinet and ethercat as link layer protocol patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220301115855.53fe4e51@hermes.local \
--to=stephen@networkplumber.org \
--cc=daniel@braunwarth.dev \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.