From: Amir Goldstein <amir73il@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Dave Chinner <david@fromorbit.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [PATCH v3 5/6] ovl: opt-in for per-sb io stats
Date: Tue, 1 Mar 2022 20:42:20 +0200 [thread overview]
Message-ID: <20220301184221.371853-6-amir73il@gmail.com> (raw)
In-Reply-To: <20220301184221.371853-1-amir73il@gmail.com>
Traditionally, system administrators have used the iostat utility
to track the amount of io performed to a local disk filesystem.
Similar functionality is provided for NFS mounts via the nfsstat
utility that reads the NFS client's stats from /proc/pid/mountstats.
There is currently no good way for a system administrator or a
monitoring application inside a container to track the amount of io
performed via overlayfs.
Opt-in for generic io stats via /proc/pid/mountstats to provide
that functionality.
This feature depends on CONFIG_FS_IOSTATS.
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
fs/overlayfs/super.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/fs/overlayfs/super.c b/fs/overlayfs/super.c
index 7bb0a47cb615..94ab6adebe07 100644
--- a/fs/overlayfs/super.c
+++ b/fs/overlayfs/super.c
@@ -6,6 +6,7 @@
#include <uapi/linux/magic.h>
#include <linux/fs.h>
+#include <linux/fs_iostats.h>
#include <linux/namei.h>
#include <linux/xattr.h>
#include <linux/mount.h>
@@ -1979,6 +1980,10 @@ static int ovl_fill_super(struct super_block *sb, void *data, int silent)
sb->s_d_op = &ovl_dentry_operations;
+ err = sb_iostats_init(sb);
+ if (err && err != -EOPNOTSUPP)
+ goto out;
+
err = -ENOMEM;
ofs = kzalloc(sizeof(struct ovl_fs), GFP_KERNEL);
if (!ofs)
--
2.25.1
next prev parent reply other threads:[~2022-03-01 18:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 18:42 [PATCH v3 0/6] Generic per-sb io stats Amir Goldstein
2022-03-01 18:42 ` [PATCH v3 1/6] lib/percpu_counter: add helpers for arrays of counters Amir Goldstein
2022-03-01 18:42 ` [PATCH v3 2/6] fs: add optional iostats counters to struct super_block Amir Goldstein
2022-03-01 18:42 ` [PATCH v3 3/6] fs: collect per-sb io stats Amir Goldstein
2022-03-01 18:42 ` [PATCH v3 4/6] fs: report " Amir Goldstein
2022-03-01 18:42 ` Amir Goldstein [this message]
2022-03-01 18:42 ` [PATCH v3 6/6] fuse: opt-in for " Amir Goldstein
2022-03-02 6:59 ` [PATCH v3 0/6] Generic " Dave Chinner
2022-03-02 7:43 ` Amir Goldstein
2022-03-02 8:26 ` Dave Chinner
2022-03-02 8:34 ` Amir Goldstein
2022-03-02 16:59 ` Amir Goldstein
2022-03-02 21:12 ` Dave Chinner
2022-03-02 22:04 ` nfs generic/373 failure after "fs: allow cross-vfsmount reflink/dedupe" J. Bruce Fields
2022-03-02 22:26 ` Josef Bacik
2022-03-02 22:42 ` J. Bruce Fields
2022-03-02 23:45 ` Josef Bacik
2022-03-03 0:07 ` J. Bruce Fields
2022-03-03 0:29 ` Josef Bacik
2022-03-03 0:50 ` J. Bruce Fields
2022-03-04 20:03 ` J. Bruce Fields
2022-03-03 6:50 ` [PATCH v3 0/6] Generic per-sb io stats Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220301184221.371853-6-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=david@fromorbit.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.