From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 991A5C433F5 for ; Wed, 2 Mar 2022 08:36:40 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id E6EC9193E; Wed, 2 Mar 2022 09:35:48 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz E6EC9193E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1646210199; bh=4qKWs5h/jJHZkRn4zMPfWqRwLoCfLxIL/zCqnzdFEfg=; h=Date:From:To:Subject:References:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=FKDr64yqfoPPdB6AHFNtbnrX3QamE7JfYA53gRcYCA/IFyvowEqhGmvC6pZCh2XrA P1JIxB/TvWlo6Xxs22mvQZbe4+LqvuD+Ek7ghxdNZxNycCMQ24lGR0YXJnNPGCUWyK 8onAAGL6WErV4R1vfLepwhuysxO902mZO3JRsku8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 50C76F8052E; Wed, 2 Mar 2022 09:33:41 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 5FA9FF801D5; Wed, 2 Mar 2022 08:30:26 +0100 (CET) Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B4EA3F80054 for ; Wed, 2 Mar 2022 08:30:19 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B4EA3F80054 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id B8E6F1C0B81; Wed, 2 Mar 2022 08:30:18 +0100 (CET) Date: Wed, 2 Mar 2022 08:30:16 +0100 From: Pavel Machek To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH 5/5] spi: make remove callback a void function Message-ID: <20220302073016.GB32222@amd> References: <20220123175201.34839-1-u.kleine-koenig@pengutronix.de> <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xXmbgvnjoT4axfJE" Content-Disposition: inline In-Reply-To: <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> User-Agent: Mutt/1.5.23 (2014-03-12) X-Mailman-Approved-At: Wed, 02 Mar 2022 09:33:33 +0100 Cc: Andrew Lunn , Gwendal Grignou , Yasunari Takiguchi , Claudius Heine , Geert Uytterhoeven , Nanyong Sun , Linus Walleij , dri-devel@lists.freedesktop.org, Frieder Schrempf , Miquel Raynal , Christian Lamparter , Ajay Singh , linux-clk@vger.kernel.org, Stefan Schmidt , Sidong Yang , libertas-dev@lists.infradead.org, linux-omap@vger.kernel.org, Antti Palosaari , Guenter Roeck , Jean Delvare , linux-serial@vger.kernel.org, =?utf-8?Q?=C5=81ukasz?= Stelmach , Mark Tomlinson , James Schulman , Kamlesh Gurudasani , Jingoo Han , Zhang Qilong , Randy Dunlap , linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Michael Walle , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , kernel@pengutronix.de, Greg Kroah-Hartman , linux-mtd@lists.infradead.org, Andrew Morton , Vladimir Oltean , linux-wpan@vger.kernel.org, Claudiu Beznea , Alexandre Belloni , Dan Robertson , Markuss Broks , Lucas Tanure , David Airlie , linux-wireless@vger.kernel.org, Marco Felsch , David Rhodes , Thierry Reding , Solomon Peachy , Marek =?iso-8859-1?Q?Beh=FAn?= , Lars-Peter Clausen , Krzysztof Kozlowski , Emmanuel Gil Peyrot , Jiri Slaby , Helge Deller , Tudor Ambarus , Minghao Chi , Jon Hunter , dingsenjie , Heiko Schocher , Wolfgang Grandegger , Matt Kline , Woojung Huh , Charles Keepax , Michael Hennerich , Mike Looijmans , Ronald =?iso-8859-1?Q?Tschal=E4r?= , Daniel Thompson , Maxime Ripard , linux-can@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Hans de Goede , Stephen Boyd , Davidlohr Bueso , UNGLinuxDriver@microchip.com, Jarkko Sakkinen , linux-usb@vger.kernel.org, Maxime Coquelin , linux-integrity@vger.kernel.org, Jonathan Cameron , Heiner Kallweit , Ulf Hansson , linux-staging@lists.linux.dev, linux-iio@vger.kernel.org, Michael Turquette , alsa-devel@alsa-project.org, Nuno =?iso-8859-1?Q?S=E1?= , netdev@vger.kernel.org, Wei Yongjun , Sam Ravnborg , =?iso-8859-1?B?Suly9G1l?= Pouiller , linux-rtc@vger.kernel.org, Marcus Folkesson , Florian Fainelli , Aditya Srivastava , Varka Bhadram , wengjianfeng , linux-input@vger.kernel.org, linux-media@vger.kernel.org, Arnd Bergmann , Jonathan =?iso-8859-1?Q?Neusch=E4fer?= , Mark Greer , Mark Gross , Richard Fitzgerald , Mark Brown , linux-fbdev@vger.kernel.org, Mauro Carvalho Chehab , Benson Leung , Stefan =?iso-8859-1?Q?M=E4tje?= , linux-hwmon@vger.kernel.org, Felipe Balbi , Paulo Miguel Almeida , Support Opensource , Dmitry Torokhov , linux-mmc@vger.kernel.org, Liam Girdwood , Julia Lawall , Yang Li , Dan Carpenter , patches@opensource.cirrus.com, Kent Gustavsson , "David S. Miller" , Charles-Antoine Couret , Alexander Aring , Jiri Prchal , Vignesh Raghavendra , Emma Anholt , Peter Zijlstra , Alexandre Torgue , Alexandru Ardelean , Antoniu Miclaus , Peter Huewe , Torin Cooper-Bennun , Lee Jones , linux-leds@vger.kernel.org, Eric Piel , Stephan Gerhold , Richard Weinberger , Russell King , Jason Gunthorpe , Thomas Kopp , Jakub Kicinski , Vivien Didelot , platform-driver-x86@vger.kernel.org, Stefan Wahren , Xue Liu , David Lechner , Will Deacon , Manivannan Sadhasivam , Kalle Valo , Rui Miguel Silva , Marc Kleine-Budde , Fabio Estevam , Harry Morris , Andy Shevchenko , Vincent Mailhol , Alessandro Zummo , Yang Shen , Thomas Zimmermann , Takashi Iwai , Cai Huoqing , Daniel Mack , Daniel Vetter , Colin Ian King , Bartosz Golaszewski , Alan Ott X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" --xXmbgvnjoT4axfJE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > The value returned by an spi driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) >=20 > So change the prototype of the remove function to return no value. This > way driver authors are not tempted to assume that passing an error to > the upper layer is a good idea. All drivers are adapted accordingly. > There is no intended change of behaviour, all callbacks were prepared to > return 0 before. Acked-by: Pavel Machek Pavel --=20 http://www.livejournal.com/~pavelmachek --xXmbgvnjoT4axfJE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmIfHQgACgkQMOfwapXb+vLxcgCghFIMSLkgbmU4bCcL4+4sOBXY b1QAoKETSRxn6hbtUUF5RsaX43sun2ct =6C0C -----END PGP SIGNATURE----- --xXmbgvnjoT4axfJE-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97C7BC433FE for ; Wed, 2 Mar 2022 07:30:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234255AbiCBHbE (ORCPT ); Wed, 2 Mar 2022 02:31:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231681AbiCBHbD (ORCPT ); Wed, 2 Mar 2022 02:31:03 -0500 Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2C7EE51E51; Tue, 1 Mar 2022 23:30:21 -0800 (PST) Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id B8E6F1C0B81; Wed, 2 Mar 2022 08:30:18 +0100 (CET) Date: Wed, 2 Mar 2022 08:30:16 +0100 From: Pavel Machek To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Mark Brown , Marek =?iso-8859-1?Q?Beh=FAn?= , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Michael Turquette , Stephen Boyd , Linus Walleij , Bartosz Golaszewski , Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Markuss Broks , Emma Anholt , David Lechner , Kamlesh Gurudasani , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Jean Delvare , Guenter Roeck , Dan Robertson , Jonathan Cameron , Lars-Peter Clausen , Michael Hennerich , Marcus Folkesson , Kent Gustavsson , Rui Miguel Silva , Dmitry Torokhov , Yasunari Takiguchi , Mauro Carvalho Chehab , Charles-Antoine Couret , Antti Palosaari , Lee Jones , Support Opensource , Charles Keepax , Richard Fitzgerald , Maxime Coquelin , Alexandre Torgue , Arnd Bergmann , Greg Kroah-Hartman , Eric Piel , Ulf Hansson , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Jakub Kicinski , Manivannan Sadhasivam , Thomas Kopp , Florian Fainelli , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Woojung Huh , UNGLinuxDriver@microchip.com, =?utf-8?Q?=C5=81ukasz?= Stelmach , Alexander Aring , Stefan Schmidt , Harry Morris , Varka Bhadram , Xue Liu , Alan Ott , Heiner Kallweit , Russell King , Christian Lamparter , Kalle Valo , Ajay Singh , Claudiu Beznea , Solomon Peachy , Krzysztof Kozlowski , Mark Greer , Benson Leung , Hans de Goede , Mark Gross , Alessandro Zummo , Alexandre Belloni , =?iso-8859-1?B?Suly9G1l?= Pouiller , Jiri Slaby , Felipe Balbi , Daniel Thompson , Jingoo Han , Helge Deller , James Schulman , David Rhodes , Lucas Tanure , Jaroslav Kysela , Takashi Iwai , Nuno =?iso-8859-1?Q?S=E1?= , Liam Girdwood , Daniel Mack , Thomas Zimmermann , Maxime Ripard , Andy Shevchenko , Stephan Gerhold , Alexandru Ardelean , Mike Looijmans , Gwendal Grignou , Cai Huoqing , Minghao Chi , Antoniu Miclaus , Julia Lawall , Ronald =?iso-8859-1?Q?Tschal=E4r?= , Marco Felsch , Jonathan =?iso-8859-1?Q?Neusch=E4fer?= , Emmanuel Gil Peyrot , Jon Hunter , Andrew Morton , Heiko Schocher , Fabio Estevam , Colin Ian King , Dan Carpenter , Tudor Ambarus , Matt Kline , Torin Cooper-Bennun , Vincent Mailhol , Stefan =?iso-8859-1?Q?M=E4tje?= , Frieder Schrempf , Wei Yongjun , Randy Dunlap , Nanyong Sun , Yang Shen , dingsenjie , Aditya Srivastava , Stefan Wahren , Peter Zijlstra , Michael Walle , Yang Li , Geert Uytterhoeven , wengjianfeng , Sidong Yang , Paulo Miguel Almeida , Zhang Qilong , Will Deacon , Mark Tomlinson , Davidlohr Bueso , Claudius Heine , Jiri Prchal , linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-wpan@vger.kernel.org, linux-wireless@vger.kernel.org, libertas-dev@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-rtc@vger.kernel.org, linux-spi@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 5/5] spi: make remove callback a void function Message-ID: <20220302073016.GB32222@amd> References: <20220123175201.34839-1-u.kleine-koenig@pengutronix.de> <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xXmbgvnjoT4axfJE" Content-Disposition: inline In-Reply-To: <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> User-Agent: Mutt/1.5.23 (2014-03-12) Precedence: bulk List-ID: X-Mailing-List: linux-can@vger.kernel.org --xXmbgvnjoT4axfJE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > The value returned by an spi driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) >=20 > So change the prototype of the remove function to return no value. This > way driver authors are not tempted to assume that passing an error to > the upper layer is a good idea. All drivers are adapted accordingly. > There is no intended change of behaviour, all callbacks were prepared to > return 0 before. Acked-by: Pavel Machek Pavel --=20 http://www.livejournal.com/~pavelmachek --xXmbgvnjoT4axfJE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmIfHQgACgkQMOfwapXb+vLxcgCghFIMSLkgbmU4bCcL4+4sOBXY b1QAoKETSRxn6hbtUUF5RsaX43sun2ct =6C0C -----END PGP SIGNATURE----- --xXmbgvnjoT4axfJE-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B65CC433F5 for ; Wed, 2 Mar 2022 07:31:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ux2aAYlTujttHTWZ1fTCcyaEwf/WajxVFSMMUV+VtLU=; b=y2ZYCXWc9ncQH11Hkz9IJikumd Fhr4adYdR561WHFXQKOxBtc9pkwtj9gp5l+ceEdg3b/4LOhH72TIj+P0qYgEIKRdPbXCUnjvTA7HN xT0jlxrnh0QjPv5MCB1va5qRI4zmWXk+bt9EvLJ8lmf8l+RJAzC/SI5+iQt85btxl7TCSqkHcqwSk fOrWwDOa2+lWrnKdMYzzFBy+2o13o+MOUgVM6vWhMdejbqaaXY7+y9FqfYmUS35uBB5puqrMAqD6d 5rp4+yPFtJYlpxWFVNqJcO7eX6+MJOKGmbusJM38N7ytR6VVy2Z5rP6vTS+cjBMeCghm+DAwwAUpZ R8+RaD0A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPJRN-001joC-Uf; Wed, 02 Mar 2022 07:30:30 +0000 Received: from jabberwock.ucw.cz ([46.255.230.98]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nPJRI-001jla-Ub; Wed, 02 Mar 2022 07:30:26 +0000 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id B8E6F1C0B81; Wed, 2 Mar 2022 08:30:18 +0100 (CET) Date: Wed, 2 Mar 2022 08:30:16 +0100 From: Pavel Machek To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Mark Brown , Marek =?iso-8859-1?Q?Beh=FAn?= , Peter Huewe , Jarkko Sakkinen , Jason Gunthorpe , Michael Turquette , Stephen Boyd , Linus Walleij , Bartosz Golaszewski , Thierry Reding , Sam Ravnborg , David Airlie , Daniel Vetter , Markuss Broks , Emma Anholt , David Lechner , Kamlesh Gurudasani , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , Jean Delvare , Guenter Roeck , Dan Robertson , Jonathan Cameron , Lars-Peter Clausen , Michael Hennerich , Marcus Folkesson , Kent Gustavsson , Rui Miguel Silva , Dmitry Torokhov , Yasunari Takiguchi , Mauro Carvalho Chehab , Charles-Antoine Couret , Antti Palosaari , Lee Jones , Support Opensource , Charles Keepax , Richard Fitzgerald , Maxime Coquelin , Alexandre Torgue , Arnd Bergmann , Greg Kroah-Hartman , Eric Piel , Ulf Hansson , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Wolfgang Grandegger , Marc Kleine-Budde , "David S. Miller" , Jakub Kicinski , Manivannan Sadhasivam , Thomas Kopp , Florian Fainelli , Andrew Lunn , Vivien Didelot , Vladimir Oltean , Woojung Huh , UNGLinuxDriver@microchip.com, =?utf-8?Q?=C5=81ukasz?= Stelmach , Alexander Aring , Stefan Schmidt , Harry Morris , Varka Bhadram , Xue Liu , Alan Ott , Heiner Kallweit , Russell King , Christian Lamparter , Kalle Valo , Ajay Singh , Claudiu Beznea , Solomon Peachy , Krzysztof Kozlowski , Mark Greer , Benson Leung , Hans de Goede , Mark Gross , Alessandro Zummo , Alexandre Belloni , =?iso-8859-1?B?Suly9G1l?= Pouiller , Jiri Slaby , Felipe Balbi , Daniel Thompson , Jingoo Han , Helge Deller , James Schulman , David Rhodes , Lucas Tanure , Jaroslav Kysela , Takashi Iwai , Nuno =?iso-8859-1?Q?S=E1?= , Liam Girdwood , Daniel Mack , Thomas Zimmermann , Maxime Ripard , Andy Shevchenko , Stephan Gerhold , Alexandru Ardelean , Mike Looijmans , Gwendal Grignou , Cai Huoqing , Minghao Chi , Antoniu Miclaus , Julia Lawall , Ronald =?iso-8859-1?Q?Tschal=E4r?= , Marco Felsch , Jonathan =?iso-8859-1?Q?Neusch=E4fer?= , Emmanuel Gil Peyrot , Jon Hunter , Andrew Morton , Heiko Schocher , Fabio Estevam , Colin Ian King , Dan Carpenter , Tudor Ambarus , Matt Kline , Torin Cooper-Bennun , Vincent Mailhol , Stefan =?iso-8859-1?Q?M=E4tje?= , Frieder Schrempf , Wei Yongjun , Randy Dunlap , Nanyong Sun , Yang Shen , dingsenjie , Aditya Srivastava , Stefan Wahren , Peter Zijlstra , Michael Walle , Yang Li , Geert Uytterhoeven , wengjianfeng , Sidong Yang , Paulo Miguel Almeida , Zhang Qilong , Will Deacon , Mark Tomlinson , Davidlohr Bueso , Claudius Heine , Jiri Prchal , linux-kernel@vger.kernel.org, linux-integrity@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-hwmon@vger.kernel.org, linux-iio@vger.kernel.org, linux-input@vger.kernel.org, linux-leds@vger.kernel.org, linux-media@vger.kernel.org, patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-can@vger.kernel.org, netdev@vger.kernel.org, linux-wpan@vger.kernel.org, linux-wireless@vger.kernel.org, libertas-dev@lists.infradead.org, platform-driver-x86@vger.kernel.org, linux-rtc@vger.kernel.org, linux-spi@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, linux-omap@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH 5/5] spi: make remove callback a void function Message-ID: <20220302073016.GB32222@amd> References: <20220123175201.34839-1-u.kleine-koenig@pengutronix.de> <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 In-Reply-To: <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> User-Agent: Mutt/1.5.23 (2014-03-12) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220301_233025_320340_78592CEA X-CRM114-Status: GOOD ( 19.92 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2222688525629615989==" Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org --===============2222688525629615989== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xXmbgvnjoT4axfJE" Content-Disposition: inline --xXmbgvnjoT4axfJE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > The value returned by an spi driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) >=20 > So change the prototype of the remove function to return no value. This > way driver authors are not tempted to assume that passing an error to > the upper layer is a good idea. All drivers are adapted accordingly. > There is no intended change of behaviour, all callbacks were prepared to > return 0 before. Acked-by: Pavel Machek Pavel --=20 http://www.livejournal.com/~pavelmachek --xXmbgvnjoT4axfJE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmIfHQgACgkQMOfwapXb+vLxcgCghFIMSLkgbmU4bCcL4+4sOBXY b1QAoKETSRxn6hbtUUF5RsaX43sun2ct =6C0C -----END PGP SIGNATURE----- --xXmbgvnjoT4axfJE-- --===============2222688525629615989== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ --===============2222688525629615989==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 91F1FC433EF for ; Wed, 2 Mar 2022 08:54:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E0DCD10EE74; Wed, 2 Mar 2022 08:54:44 +0000 (UTC) X-Greylist: delayed 589 seconds by postgrey-1.36 at gabe; Wed, 02 Mar 2022 07:40:12 UTC Received: from jabberwock.ucw.cz (jabberwock.ucw.cz [46.255.230.98]) by gabe.freedesktop.org (Postfix) with ESMTPS id D888F10EF26 for ; Wed, 2 Mar 2022 07:40:12 +0000 (UTC) Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id B8E6F1C0B81; Wed, 2 Mar 2022 08:30:18 +0100 (CET) Date: Wed, 2 Mar 2022 08:30:16 +0100 From: Pavel Machek To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH 5/5] spi: make remove callback a void function Message-ID: <20220302073016.GB32222@amd> References: <20220123175201.34839-1-u.kleine-koenig@pengutronix.de> <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="xXmbgvnjoT4axfJE" Content-Disposition: inline In-Reply-To: <20220123175201.34839-6-u.kleine-koenig@pengutronix.de> User-Agent: Mutt/1.5.23 (2014-03-12) X-Mailman-Approved-At: Wed, 02 Mar 2022 08:54:41 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Gwendal Grignou , Yasunari Takiguchi , Claudius Heine , Geert Uytterhoeven , Nanyong Sun , dri-devel@lists.freedesktop.org, Jaroslav Kysela , Frieder Schrempf , Miquel Raynal , Christian Lamparter , Ajay Singh , linux-clk@vger.kernel.org, Stefan Schmidt , Sidong Yang , libertas-dev@lists.infradead.org, linux-omap@vger.kernel.org, Guenter Roeck , Jean Delvare , linux-serial@vger.kernel.org, =?utf-8?Q?=C5=81ukasz?= Stelmach , Mark Tomlinson , James Schulman , Kamlesh Gurudasani , Jingoo Han , Zhang Qilong , Randy Dunlap , linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, Michael Walle , Noralf =?iso-8859-1?Q?Tr=F8nnes?= , kernel@pengutronix.de, Greg Kroah-Hartman , linux-mtd@lists.infradead.org, Andrew Morton , Vladimir Oltean , linux-wpan@vger.kernel.org, Claudiu Beznea , Alexandre Belloni , Dan Robertson , Markuss Broks , Lucas Tanure , David Airlie , linux-wireless@vger.kernel.org, Marco Felsch , David Rhodes , Thierry Reding , Solomon Peachy , Marek =?iso-8859-1?Q?Beh=FAn?= , Krzysztof Kozlowski , Emmanuel Gil Peyrot , Jiri Slaby , Bartosz Golaszewski , Tudor Ambarus , Minghao Chi , Jon Hunter , dingsenjie , Heiko Schocher , Wolfgang Grandegger , Matt Kline , Woojung Huh , Charles Keepax , Michael Hennerich , Mike Looijmans , Ronald =?iso-8859-1?Q?Tschal=E4r?= , Daniel Thompson , linux-can@vger.kernel.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Hans de Goede , Stephen Boyd , Davidlohr Bueso , UNGLinuxDriver@microchip.com, Jarkko Sakkinen , linux-usb@vger.kernel.org, Maxime Coquelin , linux-integrity@vger.kernel.org, Jonathan Cameron , Heiner Kallweit , Ulf Hansson , linux-staging@lists.linux.dev, linux-iio@vger.kernel.org, Michael Turquette , alsa-devel@alsa-project.org, Nuno =?iso-8859-1?Q?S=E1?= , netdev@vger.kernel.org, Wei Yongjun , Sam Ravnborg , =?iso-8859-1?B?Suly9G1l?= Pouiller , linux-rtc@vger.kernel.org, Marcus Folkesson , Florian Fainelli , Aditya Srivastava , Varka Bhadram , wengjianfeng , linux-input@vger.kernel.org, linux-media@vger.kernel.org, Arnd Bergmann , Jonathan =?iso-8859-1?Q?Neusch=E4fer?= , Mark Greer , Mark Gross , Richard Fitzgerald , Mark Brown , linux-fbdev@vger.kernel.org, Mauro Carvalho Chehab , Stefan =?iso-8859-1?Q?M=E4tje?= , linux-hwmon@vger.kernel.org, Felipe Balbi , Paulo Miguel Almeida , Support Opensource , Dmitry Torokhov , linux-mmc@vger.kernel.org, Liam Girdwood , Julia Lawall , Yang Li , Dan Carpenter , patches@opensource.cirrus.com, Kent Gustavsson , "David S. Miller" , Charles-Antoine Couret , Alexander Aring , Jiri Prchal , Vignesh Raghavendra , Emma Anholt , Peter Zijlstra , Alexandre Torgue , Alexandru Ardelean , Antoniu Miclaus , Peter Huewe , Torin Cooper-Bennun , Lee Jones , linux-leds@vger.kernel.org, Eric Piel , Stephan Gerhold , Richard Weinberger , Russell King , Jason Gunthorpe , Thomas Kopp , Jakub Kicinski , Vivien Didelot , platform-driver-x86@vger.kernel.org, Stefan Wahren , Xue Liu , David Lechner , Will Deacon , Manivannan Sadhasivam , Kalle Valo , Rui Miguel Silva , Marc Kleine-Budde , Harry Morris , Andy Shevchenko , Vincent Mailhol , Alessandro Zummo , Yang Shen , Thomas Zimmermann , Takashi Iwai , Cai Huoqing , Daniel Mack , Colin Ian King , Helge Deller , Alan Ott Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --xXmbgvnjoT4axfJE Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > The value returned by an spi driver's remove function is mostly ignored. > (Only an error message is printed if the value is non-zero that the > error is ignored.) >=20 > So change the prototype of the remove function to return no value. This > way driver authors are not tempted to assume that passing an error to > the upper layer is a good idea. All drivers are adapted accordingly. > There is no intended change of behaviour, all callbacks were prepared to > return 0 before. Acked-by: Pavel Machek Pavel --=20 http://www.livejournal.com/~pavelmachek --xXmbgvnjoT4axfJE Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAmIfHQgACgkQMOfwapXb+vLxcgCghFIMSLkgbmU4bCcL4+4sOBXY b1QAoKETSRxn6hbtUUF5RsaX43sun2ct =6C0C -----END PGP SIGNATURE----- --xXmbgvnjoT4axfJE--